On 22.09.16 20:21, Sergey Bylokhov wrote:
Looks fine.
Can you please check the "thumb" in the scroll bar in text area as
well(it is invisible in the current screenshots)
I also suggest as a separate task check how this code will be printed,
when the dpi will be much bigger.
On 20.09.16
Looks fine.
Can you please check the "thumb" in the scroll bar in text area as
well(it is invisible in the current screenshots)
On 20.09.16 19:35, Alexandr Scherbatiy wrote:
Thank you for the suggested code.
Could you review the updated fix:
Looks good.
--Semyon
On 9/20/2016 7:35 PM, Alexandr Scherbatiy wrote:
Thank you for the suggested code.
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165594/webrev.04
- the provided method is used to draw triangles in BasicArrowButton
class
- shift to
Thank you for the suggested code.
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165594/webrev.04
- the provided method is used to draw triangles in BasicArrowButton class
- shift to one pixel right is added for the triangles drawing
- AA rendering hint is
On 20.09.16 15:04, Alexandr Scherbatiy wrote:
On 9/20/2016 2:56 PM, Alexandr Scherbatiy wrote:
[2]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x_01.png
[3]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x_01.png
Not
On 9/20/2016 3:04 PM, Alexandr Scherbatiy wrote:
On 9/20/2016 2:56 PM, Alexandr Scherbatiy wrote:
[2]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x_01.png
[3]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x_01.png
I would rewrite the method that draws triangle to simplify it:
private void paintScaledTriangle(Graphics g, double x, double y,
double size,
int direction, boolean isEnabled) {
size = Math.max(size , 2);
Path2D.Double path = new
On 9/20/2016 2:56 PM, Alexandr Scherbatiy wrote:
[2]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x_01.png
[3]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x_01.png
Radio buttons are still not ideal. Have you
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165594/webrev.02
The code formatting issues are updated.
On 9/14/2016 8:02 PM, Semyon Sadetsky wrote:
Hi Alexander,
When I press the arrow button (for example in the "111" combo) several
times I can see
On 9/16/2016 11:22 AM, Andrej Golovnin wrote:
Hi Alexandr,
thanks! It looks much better now.
http://cr.openjdk.java.net/~alexsch/8165594/webrev.01
src/java.desktop/share/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java
490 if(isScaledGraphics){
Spaces are
Hi Alexandr,
thanks! It looks much better now.
> http://cr.openjdk.java.net/~alexsch/8165594/webrev.01
src/java.desktop/share/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java
490 if(isScaledGraphics){
Spaces are missed between 'if' and '(' and between ')' and
Hi Alexander,
When I press the arrow button (for example in the "111" combo) several
times I can see artifacts. They are well seen in scale x4.
--Semyon
On 9/14/2016 5:39 PM, Alexandr Scherbatiy wrote:
Hello,
Could you review the updated fix:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165594/webrev.01
- HiDPI icons are only drawn for scaled graphics.
The screenshots [1], [2], and [3] show difference between icons
drawing before and after the fix for scales 1x, 2x, and 4x.
[1]
Hi Alexandr,
> [1]
> http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-1x.png
The icons do not look right to me. Take look at the top-left part of
the radio button. There is a white pixel between the shadow lines. And
in the selected state there should be a black
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8165594
webrev: http://cr.openjdk.java.net/~alexsch/8165594/webrev.00
The icons drawing is changed to use ovals and polygons for
JRadioButton, JCheckBox, JComboBox, and JScrollBar.
The screenshots [1],
15 matches
Mail list logo
