Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

2016-06-02 Thread Alexandr Scherbatiy
e try with resources. Regards, Rajeev Chamyal *From:*Alexandr Scherbatiy *Sent:* 01 June 2016 19:30 *To:* Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net *Subject:* Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock On 6/1/2016 12:21 PM,

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

2016-06-02 Thread Rajeev Chamyal
@openjdk.java.net Subject: Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock On 6/1/2016 12:21 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-8146319 Webrev : HYPERLINK "

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

2016-06-01 Thread Alexandr Scherbatiy
On 6/1/2016 12:21 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-8146319 Webrev : http://cr.openjdk.java.net/~rchamyal/8146319/webrev.00/ Issue:

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

2016-06-01 Thread Semyon Sadetsky
to use File.createTempFile() for creating temp file. Regards, Rajeev Chamyal *From:*Semyon Sadetsky *Sent:* 01 June 2016 15:01 *To:* Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net *Subject:* Re: [9] Review request for JDK-8146319 JEditorPane function setPage

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

2016-06-01 Thread Rajeev Chamyal
To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock Hi, The fix looks good. In the test you could use File.createTempFile() or better Files.createTempFile() --Semyon

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

2016-06-01 Thread Semyon Sadetsky
Hi, The fix looks good. In the test you could use File.createTempFile() or better Files.createTempFile() --Semyon On 6/1/2016 12:21 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-8146319 Webrev :

[9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

2016-06-01 Thread Rajeev Chamyal
Hello All, Please review the following webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-8146319 Webrev : http://cr.openjdk.java.net/~rchamyal/8146319/webrev.00/ Issue: JEditorPane::read method is not closing the InputStreamReader. Fix: closing the InputStreamReader in finally