Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-11-04 Thread Phil Race
I've been testing this by re-enabling deprecation so On 11/02/2016 10:50 PM, Prasanta Sadhukhan wrote: Do we need the suppression in JavaSoundAudioClip.java as I could not find any mention of Applet in that class? In AppletViewer.java shouldn't we need to add "deprecation" to 45

Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-11-02 Thread Prasanta Sadhukhan
Do we need the suppression in JavaSoundAudioClip.java as I could not find any mention of Applet in that class? In AppletViewer.java shouldn't we need to add "deprecation" to 45 @SuppressWarnings("serial") // JDK implementation class Do we still need this 160

Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-11-02 Thread Sergey Bylokhov
On 20.10.16 1:14, Philip Race wrote: Well maybe but this isn't about adding deprecations it is just about of getting rid of warnings for uses of APIs that are already deprecated. ok. You are welcome to file a separate bug on that ... -phil. On 10/19/16, 2:59 PM, Sergey Bylokhov wrote: On

Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-10-20 Thread Sergey Bylokhov
On 20.10.16 1:14, Philip Race wrote: Well maybe but this isn't about adding deprecations it is just about of getting rid of warnings for uses of APIs that are already deprecated. I though that if the code marked as deprecated is used inside deprecated method then this warning is not occurred,

Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-10-19 Thread Philip Race
Well maybe but this isn't about adding deprecations it is just about of getting rid of warnings for uses of APIs that are already deprecated. You are welcome to file a separate bug on that ... -phil. On 10/19/16, 2:59 PM, Sergey Bylokhov wrote: On 19.10.16 23:14, Philip Race wrote: This

Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-10-19 Thread Sergey Bylokhov
On 19.10.16 23:14, Philip Race wrote: This resolves the applet ones .. as a precursor to fixing up the other issues that cause this global supression. Probably some of related code can be deprecated as well?(like AppletAudioClip, AppletPanel,AppletViewer ,RepaintManager.addDirtyRegion(),

RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-10-19 Thread Philip Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8168316 Webrev: http://cr.openjdk.java.net/~prr/8168316/ When applets were deprecated it seems that due to all deprecated warning being suppressed in java.desktop many places that should have been updated weren't This resolves the applet ones .. as