: JDK9 Review Request for JDK-7104635 HTMLEditorKit
fails to write down some html files
Hello Sergey,
Thanks for the review.
indentLevel is decremented in AbstractWriter :: incrIndent method as well.
Here also we have a check before decrementing indentLevel.
Regards,
Rajeev Chamyal
Fix looks good to me.
Regards
Prasanta
On 11/26/2015 2:06 PM, Rajeev Chamyal wrote:
Hello All,
Please review the following fix for Jdk9:
Bug: https://bugs.openjdk.java.net/browse/JDK-7104635
Webrev: http://cr.openjdk.java.net/~rchamyal/7104635/webrev.00/
2015 01:49
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net; Prasanta
Sadhukhan
Subject: Re: JDK9 Review Request for JDK-7104635 HTMLEditorKit
fails to write down some html files
Hi, Rajeev.
Did you check another place where it is decremented?
Also it seems this change
; Alexander Scherbatiy; swing-dev@openjdk.java.net; Prasanta
Sadhukhan
Subject: Re: JDK9 Review Request for JDK-7104635 HTMLEditorKit
fails to write down some html files
Hi, Rajeev.
Did you check another place where it is decremented?
Also it seems this change in some way contradicts
Hi, Rajeev.
Did you check another place where it is decremented?
Also it seems this change in some way contradicts the specification of
getIndentLevel() method, because it is quite general:
/**
* Returns the current indentation level. That is, the number of times
* incrIndent has
Hello All,
Please review the following fix for Jdk9:
Bug: https://bugs.openjdk.java.net/browse/JDK-7104635
Webrev: http://cr.openjdk.java.net/~rchamyal/7104635/webrev.00/
Issue: If the minimized HTML has spaces the writing is failing with index out
of bounds exception.
Cause: The
