The fix looks good to me.
Regards,
Rajeev Chamyal
Subject:
Re: RFR: [9] [JDK-8081491] The case print incomplete.
Date:
Fri, 16 Oct 2015 13:19:37 +0300
From:
Alexander Scherbatiy HYPERLINK
"mailto:alexandr.scherba...@oracle.com";
To:
prasanta sadhukhan
The fix looks good to me.
Thanks,
Alexandr.
On 10/14/2015 2:26 PM, prasanta sadhukhan wrote:
On 10/9/2015 3:00 PM, Alexander Scherbatiy wrote:
On 10/7/2015 3:10 PM, prasanta sadhukhan wrote:
Hi All,
@Sergey,Phil,Alexander Z
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.10/
On 10/9/2015 3:00 PM, Alexander Scherbatiy wrote:
On 10/7/2015 3:10 PM, prasanta sadhukhan wrote:
Hi All,
@Sergey,Phil,Alexander Z
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.10/
Have you checked the corner cases like printing a table which has
only one row (with and without
On 10/7/2015 3:10 PM, prasanta sadhukhan wrote:
Hi All,
@Sergey,Phil,Alexander Z
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.10/
Have you checked the corner cases like printing a table which has
only one row (with and without a scroll pane)?
Could you add these scenarios to
Hi All,
@Sergey,Phil,Alexander Z
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.10/
Any more comments/feedback? Can I get a +1 for this?
Regards
Prasanta
On 09/25/2015 04:47 AM, prasanta sadhukhan wrote:
Thanks Alexander. Can I get a +1 for this?
Regards
Prasanta
On 9/25/2015 2:43 P
Can I get a +1 for this?
Regards
Prasanta
On 9/30/2015 2:44 PM, prasanta sadhukhan wrote:
ok. I changed it initially to see if it helps in printing same number
of rows as displayed but forgot to change it back after adding the
rMax decrement in SwingUtilities.getUnwrappedParent(table) check.
P
ok. I changed it initially to see if it helps in printing same number of
rows as displayed but forgot to change it back after adding the rMax
decrement in SwingUtilities.getUnwrappedParent(table) check.
Please find the updated webrev:
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.10/
R
On 09/28/2015 11:53 PM, prasanta sadhukhan wrote:
Have updated the webrev to cater to this empty lines
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.09/
The below code was there initially and I have not added it. It was
there because
table.rowAtPoint() can return -1 when y/getRowHeight(
Have updated the webrev to cater to this empty lines
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.09/
The below code was there initially and I have not added it. It was there
because
table.rowAtPoint() can return -1 when y/getRowHeight() >= getRowCount()
so that rMax points to last row
Sorry to be nit-picky but TablePrintable.java seems to have
gained some new empty lines and lost other lines that make
the 'diff' look much larger than it really is.
Also a couple in BasicTableUI have the same.
I also see this comment seems to be invalidated by the change
in some cases and it al
Thanks Alexander. Can I get a +1 for this?
Regards
Prasanta
On 9/25/2015 2:43 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 9/25/2015 9:26 AM, prasanta sadhukhan wrote:
Added null check for SwingUtilities.getUnwrappedParent(table).
Please review the upd
The fix looks good to me.
Thanks,
Alexandr.
On 9/25/2015 9:26 AM, prasanta sadhukhan wrote:
Added null check for SwingUtilities.getUnwrappedParent(table).
Please review the updated webrev
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.08/
Regards
Prasanta
On 9/24/2015 5:19 PM, Al
Added null check for SwingUtilities.getUnwrappedParent(table).
Please review the updated webrev
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.08/
Regards
Prasanta
On 9/24/2015 5:19 PM, Alexander Scherbatiy wrote:
On 9/23/2015 12:26 PM, prasanta sadhukhan wrote:
On 9/23/2015 2:46 PM, A
On 9/23/2015 12:26 PM, prasanta sadhukhan wrote:
On 9/23/2015 2:46 PM, Alexander Scherbatiy wrote:
On 9/23/2015 9:42 AM, prasanta sadhukhan wrote:
I have updated the code as per your comment.
Please review this webrev
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.07/
- Is it poss
On 9/23/2015 2:46 PM, Alexander Scherbatiy wrote:
On 9/23/2015 9:42 AM, prasanta sadhukhan wrote:
I have updated the code as per your comment.
Please review this webrev
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.07/
- Is it possible that SwingUtilities.getUnwrappedParent(table)
On 9/23/2015 9:42 AM, prasanta sadhukhan wrote:
I have updated the code as per your comment.
Please review this webrev
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.07/
- Is it possible that SwingUtilities.getUnwrappedParent(table)
returns null?
- Does the fix work correctly for
I have updated the code as per your comment.
Please review this webrev
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.07/
Regards
Prasanta
On 9/22/2015 7:01 PM, Alexander Scherbatiy wrote:
On 9/21/2015 12:05 PM, prasanta sadhukhan wrote:
On 9/21/2015 2:20 PM, Alexandr Scherbatiy wrote:
On 9/21/2015 12:05 PM, prasanta sadhukhan wrote:
On 9/21/2015 2:20 PM, Alexandr Scherbatiy wrote:
18.09.2015 10:16, prasanta sadhukhan пишет:
On 9/17/2015 8:18 PM, Alexander Scherbatiy wrote:
On 9/16/2015 2:04 PM, prasanta sadhukhan wrote:
Hi Alexander, Sergey,
Waiting for your review on
On 9/21/2015 2:20 PM, Alexandr Scherbatiy wrote:
18.09.2015 10:16, prasanta sadhukhan пишет:
On 9/17/2015 8:18 PM, Alexander Scherbatiy wrote:
On 9/16/2015 2:04 PM, prasanta sadhukhan wrote:
Hi Alexander, Sergey,
Waiting for your review on this.
http://cr.openjdk.java.net/~psadhukhan/8081
18.09.2015 10:16, prasanta sadhukhan пишет:
On 9/17/2015 8:18 PM, Alexander Scherbatiy wrote:
On 9/16/2015 2:04 PM, prasanta sadhukhan wrote:
Hi Alexander, Sergey,
Waiting for your review on this.
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.06/
Could you describe why the paint
On 9/17/2015 8:18 PM, Alexander Scherbatiy wrote:
On 9/16/2015 2:04 PM, prasanta sadhukhan wrote:
Hi Alexander, Sergey,
Waiting for your review on this.
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.06/
Could you describe why the paint artifacts are drawn when a scroll
pane is p
On 9/16/2015 2:04 PM, prasanta sadhukhan wrote:
Hi Alexander, Sergey,
Waiting for your review on this.
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.06/
Could you describe why the paint artifacts are drawn when a scroll
pane is present?
Thanks,
Alexandr.
Regards
Prasanta
Hi Alexander, Sergey,
Waiting for your review on this.
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.06/
Regards
Prasanta
On 9/15/2015 10:55 AM, prasanta sadhukhan wrote:
On 9/14/2015 12:48 PM, prasanta sadhukhan wrote:
On 9/11/2015 2:20 PM, prasanta sadhukhan wrote:
On 9/10/201
On 9/14/2015 12:48 PM, prasanta sadhukhan wrote:
On 9/11/2015 2:20 PM, prasanta sadhukhan wrote:
On 9/10/2015 4:48 PM, Sergey Bylokhov wrote:
On 10.09.15 13:35, prasanta sadhukhan wrote:
On 9/10/2015 3:42 PM, Sergey Bylokhov wrote:
On 10.09.15 9:36, prasanta sadhukhan wrote:
Please r
On 9/11/2015 2:20 PM, prasanta sadhukhan wrote:
On 9/10/2015 4:48 PM, Sergey Bylokhov wrote:
On 10.09.15 13:35, prasanta sadhukhan wrote:
On 9/10/2015 3:42 PM, Sergey Bylokhov wrote:
On 10.09.15 9:36, prasanta sadhukhan wrote:
Please review the modified webrev which solves this artifact
On 9/10/2015 4:48 PM, Sergey Bylokhov wrote:
On 10.09.15 13:35, prasanta sadhukhan wrote:
On 9/10/2015 3:42 PM, Sergey Bylokhov wrote:
On 10.09.15 9:36, prasanta sadhukhan wrote:
Please review the modified webrev which solves this artifacts.
http://cr.openjdk.java.net/~psadhukhan/8081491/w
On 10.09.15 13:35, prasanta sadhukhan wrote:
On 9/10/2015 3:42 PM, Sergey Bylokhov wrote:
On 10.09.15 9:36, prasanta sadhukhan wrote:
Please review the modified webrev which solves this artifacts.
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.05/
What will happen if the table will b
On 9/10/2015 3:42 PM, Sergey Bylokhov wrote:
On 10.09.15 9:36, prasanta sadhukhan wrote:
Please review the modified webrev which solves this artifacts.
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.05/
What will happen if the table will be added to the jpanel and the
jpanel will be
On 10.09.15 9:36, prasanta sadhukhan wrote:
Please review the modified webrev which solves this artifacts.
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.05/
What will happen if the table will be added to the jpanel and the jpanel
will be added to JScrollPane? Will this configuration wo
Please review the modified webrev which solves this artifacts.
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.05/
I also added a reg test for this regression but I am not able to create
a automated testcase to deal with the scrolling artifacts, so I added a
manual test.
Regards
Prasant
On 08.09.15 13:57, Sergey Bylokhov wrote:
Hi, Prasanta.
Just before the push of this fix I made small pit, and found a
regression. Please run the SwingSet2, open JTable demo, and scroll the
table. You will see some artifacts.
When you will update the fix, please also add a new automated test,
Hi, Prasanta.
Just before the push of this fix I made small pit, and found a
regression. Please run the SwingSet2, open JTable demo, and scroll the
table. You will see some artifacts.
On 08.09.15 13:13, prasanta sadhukhan wrote:
Thanks Sergey for pointing this.
I have taken care of this plus
The fix looks good to me.
Thanks,
Alexandr.
On 9/8/2015 1:26 PM, Sergey Bylokhov wrote:
The fix looks good to me.
On 08.09.15 13:13, prasanta sadhukhan wrote:
Thanks Sergey for pointing this.
I have taken care of this plus formatting in for loop.
Please have a look
http://cr.openjdk.j
The fix looks good to me.
On 08.09.15 13:13, prasanta sadhukhan wrote:
Thanks Sergey for pointing this.
I have taken care of this plus formatting in for loop.
Please have a look
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.04/
Regards
Prasanta
On 9/8/2015 3:32 PM, Sergey Bylokhov wrot
Thanks Sergey for pointing this.
I have taken care of this plus formatting in for loop.
Please have a look
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.04/
Regards
Prasanta
On 9/8/2015 3:32 PM, Sergey Bylokhov wrote:
Hi, Prasanta.
A few small notes:
- BasicTableUI: typo "1850 // other
Hi, Prasanta.
A few small notes:
- BasicTableUI: typo "1850 // otherwise 1 extra rows are ptinted"
- ImageableAreaTest: the test instructions have copy pasted numbers
1/2/2/2 etc.
On 08.09.15 12:43, prasanta sadhukhan wrote:
Thanks for your review.
I need +1 for this. Alexander Z/Sergey,
Thanks for your review.
I need +1 for this. Alexander Z/Sergey, can you please approve this fix?
Regards
Prasanta
On 9/8/2015 3:02 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
But you need to properly format spaces in the 'for' loop on line
TablePrintable:410 before the push
The fix looks good to me.
But you need to properly format spaces in the 'for' loop on line
TablePrintable:410 before the push.
Thanks,
Alexandr.
On 9/8/2015 12:26 PM, prasanta sadhukhan wrote:
On 9/7/2015 5:50 PM, Alexander Scherbatiy wrote:
On 9/7/2015 9:23 AM, prasanta sadhukha
On 9/7/2015 5:50 PM, Alexander Scherbatiy wrote:
On 9/7/2015 9:23 AM, prasanta sadhukhan wrote:
I guess it will be same but anyways have modified to use
visibleBounds.getLocation() to be on safeside as we are dealing with
visible region for this fix.
Please review the updated webrev
http://c
On 9/7/2015 9:23 AM, prasanta sadhukhan wrote:
I guess it will be same but anyways have modified to use
visibleBounds.getLocation() to be on safeside as we are dealing with
visible region for this fix.
Please review the updated webrev
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.02/
I guess it will be same but anyways have modified to use
visibleBounds.getLocation() to be on safeside as we are dealing with
visible region for this fix.
Please review the updated webrev
http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.02/
Regards
Prasanta
On 9/4/2015 8:57 PM, Alexander S
Could the clip.getLocation() be differ from them
visibleBounds.getLocation()?
Thanks,
Alexandr.
On 9/4/2015 3:32 PM, prasanta sadhukhan wrote:
Any reviewers for this please?
On 9/2/2015 5:06 PM, prasanta sadhukhan wrote:
Hi,
Can this fix be reviewed?
Regards
Prasanta
On 8/28/2015 4:48
Any reviewers for this please?
On 9/2/2015 5:06 PM, prasanta sadhukhan wrote:
Hi,
Can this fix be reviewed?
Regards
Prasanta
On 8/28/2015 4:48 PM, prasanta sadhukhan wrote:
On 8/26/2015 6:24 PM, Alexander Scherbatiy wrote:
On 8/25/2015 1:51 PM, prasanta sadhukhan wrote:
On 8/25/2015 3:5
Hi,
Can this fix be reviewed?
Regards
Prasanta
On 8/28/2015 4:48 PM, prasanta sadhukhan wrote:
On 8/26/2015 6:24 PM, Alexander Scherbatiy wrote:
On 8/25/2015 1:51 PM, prasanta sadhukhan wrote:
On 8/25/2015 3:53 PM, Alexander Scherbatiy wrote:
On 8/24/2015 2:23 PM, prasanta sadhukhan wrot
On 8/26/2015 6:24 PM, Alexander Scherbatiy wrote:
On 8/25/2015 1:51 PM, prasanta sadhukhan wrote:
On 8/25/2015 3:53 PM, Alexander Scherbatiy wrote:
On 8/24/2015 2:23 PM, prasanta sadhukhan wrote:
Hi All,
Bug: https://bugs.openjdk.java.net/browse/JDK-8081491
webrev: http://cr.openjdk.java.
On 8/25/2015 1:51 PM, prasanta sadhukhan wrote:
On 8/25/2015 3:53 PM, Alexander Scherbatiy wrote:
On 8/24/2015 2:23 PM, prasanta sadhukhan wrote:
Hi All,
Bug: https://bugs.openjdk.java.net/browse/JDK-8081491
webrev: http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.00/
This seems to be
On 8/25/2015 3:53 PM, Alexander Scherbatiy wrote:
On 8/24/2015 2:23 PM, prasanta sadhukhan wrote:
Hi All,
Bug: https://bugs.openjdk.java.net/browse/JDK-8081491
webrev: http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.00/
This seems to be a hidden JTable bug in which if the user does not
47 matches
Mail list logo
