Re: RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-10 Thread Prasanta Sadhukhan
On 11-Mar-20 11:41 AM, Sergey Bylokhov wrote: On 3/10/20 11:00 pm, Prasanta Sadhukhan wrote: On 11-Mar-20 11:24 AM, Sergey Bylokhov wrote: On 3/10/20 10:23 pm, Prasanta Sadhukhan wrote: Yes, it was part of MetalFileChooseUI and WindowsFileChooserUI too but it was removed explicitly in uni

Re: RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-10 Thread Sergey Bylokhov
On 3/10/20 11:00 pm, Prasanta Sadhukhan wrote: On 11-Mar-20 11:24 AM, Sergey Bylokhov wrote: On 3/10/20 10:23 pm, Prasanta Sadhukhan wrote: Yes, it was part of MetalFileChooseUI and WindowsFileChooserUI too but it was removed explicitly in uninstallUI. The MetalFileChooseUI and WindowsFil

Re: RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-10 Thread Prasanta Sadhukhan
On 11-Mar-20 11:24 AM, Sergey Bylokhov wrote: On 3/10/20 10:23 pm, Prasanta Sadhukhan wrote: Yes, it was part of MetalFileChooseUI and WindowsFileChooserUI too but it was removed explicitly in uninstallUI. The MetalFileChooseUI and WindowsFileChooserUI use non-local(we could say public) l

Re: RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-10 Thread Sergey Bylokhov
On 3/10/20 10:23 pm, Prasanta Sadhukhan wrote: Yes, it was part of MetalFileChooseUI and WindowsFileChooserUI too but it was removed explicitly in uninstallUI. The MetalFileChooseUI and WindowsFileChooserUI use non-local(we could say public) listeners for example BasicFileChooserUI.getCance

Re: RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-10 Thread Prasanta Sadhukhan
On 11-Mar-20 6:10 AM, Sergey Bylokhov wrote: On 3/10/20 12:01 am, Prasanta Sadhukhan wrote: Hi Sergey, There are some ActionListeners that we add, namely for fileNameTextField, directoryComboBox, filterComboBox, approveButton, cancelButton. Shouldn't we remove those as has been done in Met

Re: RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-10 Thread Sergey Bylokhov
On 3/10/20 12:01 am, Prasanta Sadhukhan wrote: Hi Sergey, There are some ActionListeners that we add, namely for fileNameTextField, directoryComboBox, filterComboBox, approveButton, cancelButton. Shouldn't we remove those as has been done in Metal/Windows L&F uninstallUI? These components ar

Re: RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-10 Thread Prasanta Sadhukhan
Hi Sergey, There are some ActionListeners that we add, namely for fileNameTextField, directoryComboBox, filterComboBox, approveButton, cancelButton. Shouldn't we remove those as has been done in Metal/Windows L&F uninstallUI? I see uninstallUI does not do removeActionListener, or else proaba

Re: RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-09 Thread Pankaj Bansal
Hello Sergey, The changes look fine. Regards, Pankaj On 08/03/20 3:50 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8240633 Fix: http://cr.openjdk.java.net/~serb/8240633/webrev.00 Our tests in mach5 for JFileChooser so

RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-07 Thread Sergey Bylokhov
Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8240633 Fix: http://cr.openjdk.java.net/~serb/8240633/webrev.00 Our tests in mach5 for JFileChooser sometime fails with different suspicious exceptions. The root cause is that the Aqua UI delegates add var