Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v2]

2021-09-07 Thread Prasanta Sadhukhan
On Sat, 4 Sep 2021 11:06:14 GMT, Prasanta Sadhukhan wrote: >> You need to override the paintIcon method in the InvertableImageIcon >> returned by the AquaImageFactory.getMenuArrowIcon() or you can create `class >> MenuArrowIcon extends InvertableImageIcon,` and override it there. >> >> Also

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v2]

2021-09-04 Thread Prasanta Sadhukhan
On Fri, 3 Sep 2021 05:54:45 GMT, Sergey Bylokhov wrote: >> I will like to know how because as it is pointed out, paintArrow delegates >> drawing to ImageIcon#paintIcon which is in shared code and this is mac >> specific issue so it needs to be handled before we call ImageIcon#paintIcon > > You

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v2]

2021-09-02 Thread Sergey Bylokhov
On Fri, 3 Sep 2021 04:13:46 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/macosx/classes/com/apple/laf/AquaMenuPainter.java line 419: >> >>> 417: } else { >>> 418: arrowIcon.paintIcon(c, g, arrowIconRect.x, >>> arrowIconRect.y); >>> 419: } >> >>

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v2]

2021-09-02 Thread Prasanta Sadhukhan
On Thu, 2 Sep 2021 18:10:55 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Cache icon > > src/java.desktop/macosx/classes/com/apple/laf/AquaMenuPainter.java line 419: > >> 417:

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v2]

2021-09-02 Thread Sergey Bylokhov
On Thu, 2 Sep 2021 12:41:58 GMT, Prasanta Sadhukhan wrote: >> It is seen in macos disabled JMenuItem arrow is not disabled even though >> JMenuItem itself is disabled. >> In native app, same menuitem arrow is disabled for disabled menuitem. >> >> Issue is when AquaMenuPainter#paintMenuItem()

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v2]

2021-09-02 Thread Prasanta Sadhukhan
> It is seen in macos disabled JMenuItem arrow is not disabled even though > JMenuItem itself is disabled. > In native app, same menuitem arrow is disabled for disabled menuitem. > > Issue is when AquaMenuPainter#paintMenuItem() is called, it tries to draw a > ImageIcon image of the arrow via