Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-25 Thread Sergey Bylokhov
On 3/25/20 7:09 am, Prasanta Sadhukhan wrote: It seems there is a difference of 1 in all the color components ok +1 x 0 y 1 img1.getRGB(x,y) ff9e9e9e img2.getRGB(x,y) ff9f9f9f  x 0 y 2 img1.getRGB(x,y) ffa2a2a2 img2.getRGB(x,y) ffa1a1a1  x 1 y 0 img1.getRGB(x,y) fff8f8f8 img2.getRGB(x,y)

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-25 Thread Prasanta Sadhukhan
> On 25-Mar-2020, at 5:22 AM, Sergey Bylokhov > wrote: > > On 3/23/20 10:04 pm, Prasanta Sadhukhan wrote: >> On 24-Mar-20 10:17 AM, Sergey Bylokhov wrote: >>> On 3/23/20 9:36 pm, Prasanta Sadhukhan wrote: I did not get this point. "apple.awt.brushMetalLook" and "window.style" both s

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-24 Thread Sergey Bylokhov
On 3/23/20 10:04 pm, Prasanta Sadhukhan wrote: On 24-Mar-20 10:17 AM, Sergey Bylokhov wrote: On 3/23/20 9:36 pm, Prasanta Sadhukhan wrote: I did not get this point. "apple.awt.brushMetalLook" and "window.style" both set TEXTURED property of NSWindow so it's gradient should be the same, no? S

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-24 Thread Philip Race
we configure it NOT to run on osx 10.14 onwards? *From:*Pankaj Bansal *Sent:*Monday, March 23, 2020 10:55 AM *To:*Prasanta Sadhukhan;swing-dev@openjdk.java.net *Subject:*Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java Ok, looks good to me. -Pankaj *From

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Prasanta Sadhukhan
On 24-Mar-20 10:17 AM, Sergey Bylokhov wrote: On 3/23/20 9:36 pm, Prasanta Sadhukhan wrote: I did not get this point. "apple.awt.brushMetalLook" and "window.style" both set TEXTURED property of NSWindow so it's gradient should be the same, no? So, at what time do you think they will not be

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Sergey Bylokhov
On 3/23/20 9:36 pm, Prasanta Sadhukhan wrote: I did not get this point. "apple.awt.brushMetalLook" and "window.style" both set TEXTURED property of NSWindow so it's gradient should be the same, no? So, at what time do you think they will not be same? It seems every time the window becomes vis

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Prasanta Sadhukhan
On 23-Mar-20 11:44 PM, Sergey Bylokhov wrote: On 3/23/20 2:52 am, Prasanta Sadhukhan wrote: On 23-Mar-20 2:52 PM, Sergey Bylokhov wrote: On 3/22/20 11:51 pm, Ajit Ghaisas wrote: Instead of ignoring it on all versions of osx, can we configure it NOT to run on osx 10.14 onwards? I think tha

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Sergey Bylokhov
On 3/23/20 2:52 am, Prasanta Sadhukhan wrote: On 23-Mar-20 2:52 PM, Sergey Bylokhov wrote: On 3/22/20 11:51 pm, Ajit Ghaisas wrote: Instead of ignoring it on all versions of osx, can we configure it NOT to run on osx 10.14 onwards? I think that the problem is not directly related to the OS

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Prasanta Sadhukhan
> On 23-Mar-2020, at 3:33 PM, Sergey Bylokhov > wrote: > > On 3/23/20 2:52 am, Prasanta Sadhukhan wrote: >> On 23-Mar-20 2:52 PM, Sergey Bylokhov wrote: >>> On 3/22/20 11:51 pm, Ajit Ghaisas wrote: Instead of ignoring it on all versions of osx, can we configure it NOT to run on osx

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Sergey Bylokhov
On 3/23/20 2:52 am, Prasanta Sadhukhan wrote: On 23-Mar-20 2:52 PM, Sergey Bylokhov wrote: On 3/22/20 11:51 pm, Ajit Ghaisas wrote: Instead of ignoring it on all versions of osx, can we configure it NOT to run on osx 10.14 onwards? I think that the problem is not directly related to the OS

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Prasanta Sadhukhan
Prasanta Sadhukhan;swing-dev@openjdk.java.net *Subject:*Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java Ok, looks good to me. -Pankaj *From:*Prasanta Sadhukhan *Sent:*Monday, March 23, 2020 10:54 AM *To:*Pankaj Bansal <mailto:pankaj.b.ban...@oracle.

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Prasanta Sadhukhan
March 22, 2020 12:20 PM     *To:* swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net>     *Subject:* RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java     Hi All,     Since Textured JFrame property is not supported anymore by Apple, the test

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Sergey Bylokhov
fine on 10.13? *From:*Pankaj Bansal *Sent:* Monday, March 23, 2020 10:55 AM *To:* Prasanta Sadhukhan ; swing-dev@openjdk.java.net *Subject:* Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java Ok, looks good to me. -Pankaj *From:*Prasanta Sadhukhan *Sent

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Ajit Ghaisas
NOT to >> run on osx 10.14 onwards? >> >> From: Pankaj Bansal >> Sent: Monday, March 23, 2020 10:55 AM >> To: Prasanta Sadhukhan >> <mailto:prasanta.sadhuk...@oracle.com>; swing-dev@openjdk.java.net >> <mailto:swing-dev@openjdk.java.net> >> Sub

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-23 Thread Prasanta Sadhukhan
, 2020 12:20 PM *To:* swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> *Subject:* RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java Hi All, Since Textured JFrame property is not supported anymore by Apple, the test which is

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-22 Thread Ajit Ghaisas
khan Sent: Sunday, March 22, 2020 12:20 PM To: HYPERLINK "mailto:swing-dev@openjdk.java.net"swing-dev@openjdk.java.net Subject: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java   Hi All,   Since Textured JFrame property is not supported anymore by Apple

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-22 Thread Pankaj Bansal
Ok, looks good to me.   -Pankaj   From: Prasanta Sadhukhan Sent: Monday, March 23, 2020 10:54 AM To: Pankaj Bansal ; swing-dev@openjdk.java.net Subject: Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java   I prefer it not to be deleted as we can still

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-22 Thread Prasanta Sadhukhan
[macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java Hi All, Since Textured JFrame property is not supported anymore by Apple, the test which is failing from osx10.14 onwards should be ignored from now onwards diff -r 20374b37dd01 test/jdk/javax/swing/JFrame/NSTexturedJFrame

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-22 Thread Pankaj Bansal
PM To: swing-dev@openjdk.java.net Subject: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java   Hi All,   Since Textured JFrame property is not supported anymore by Apple, the test which is failing from osx10.14 onwards should be ignored from now onwards

RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-21 Thread Prasanta Sadhukhan
Hi All, Since Textured JFrame property is not supported anymore by Apple, the test which is failing from osx10.14 onwards should be ignored from now onwards diff -r 20374b37dd01 test/jdk/javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java --- a/test/jdk/javax/swing/JFrame/NSTexturedJFrame