On 4/22/20 2:35 am, Prasanta Sadhukhan wrote:
I think since this fix is more about margin, it should be placed in more
appropriate class related to borders/margin so I have placed my fix in
BasicBorders and not in BasicTextUI.
Does it mean that the next line in the test:
pane.setMargin(new
ping?
On 22-Apr-20 3:05 PM, Prasanta Sadhukhan wrote:
The regression caused by change in this method was because the
rootView layout was changed in those fix(es), but this code is only
changing the preferredSize height but I can understand the scepticism.
I think since this fix is more about
The regression caused by change in this method was because the rootView
layout was changed in those fix(es), but this code is only changing the
preferredSize height but I can understand the scepticism.
I think since this fix is more about margin, it should be placed in more
appropriate class
Hi, Prasanta.
Remembering the number of regressions caused by the changes in this method, I
suggest to improve it by some additional code only when we investigate the root
cause of all previous issues. The general approach of using zeros as
non-initialized flags seems broken.
On 4/13/20 3:06
Hi All,
Please review a fix for an issue where it is seen that when JEditorPane
is created with empty text and zero top and bottom insets, the text is
not shown after updating it by the method setText(String)
This is because the the JEditorPane height is not updated and remains 0
if the
