Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

The fix looks good to me. Thanks, Alexandr. On 12/9/2015 10:09 AM, Avik Niyogi wrote: Hi Alexander, Since there is no change in char from this depending on status of the method, the check is not required. With Regards, Avik Niyogi On 09-Dec-2015, at 11:29 pm, Alexander Scherbatiy

Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

Looks fine. On 08.12.15 7:08, Avik Niyogi wrote: Hi All, Please find the updated web rev.02 with inputs provided below. Small minor change as suggested was inserted. Please commit the change if acceptable now. Thank you. http://cr.openjdk.java.net/~aniyogi/8139169/webrev.02/ With Regards,

Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

On 08/12/15 08:08, Avik Niyogi wrote: Hi All, Please find the updated web rev.02 with inputs provided below. Small minor change as suggested was inserted. Please commit the change if acceptable now. Thank you. http://cr.openjdk.java.net/~aniyogi/8139169/webrev.02/

Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

Hi Alexander, Since there is no change in char from this depending on status of the method, the check is not required. With Regards, Avik Niyogi > On 09-Dec-2015, at 11:29 pm, Alexander Scherbatiy > wrote: > > paramErr

Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

Hi, Avik. The fix looks fine for me. But I think that you incorrectly tried to place the window in the center of the screen, you need to place frame.setLocationRelativeTo(null); after call to setSize(). On 03.12.15 8:26, Avik Niyogi wrote: Hi All, Please find updated webrev.01 with inputs

Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

Hi All, Please find the updated web rev.02 with inputs provided below. Small minor change as suggested was inserted. Please commit the change if acceptable now. Thank you. http://cr.openjdk.java.net/~aniyogi/8139169/webrev.02/ With

Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

Hello Avik,   Can you use @requires (os.family == "mac") instead of a method to check the OS type.   Regards, Rajeev Chamyal   From: Avik Niyogi Sent: 30 November 2015 17:22 To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Review Request for

Review Request for 8139169: Action registered for keyboard shortcut is called twice

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8139169 Webrev: http://cr.openjdk.java.net/~aniyogi/8139169/webrev.00/ Issue: Swing action with an