By both I meant like this :
@run main/timeout=400 ShellFolderMemoryLeak
@run main/timeout=400 -XX:+UseParallelGC ShellFolderMemoryLeak
but its up to you .. at least having the default is the best single option.
Approved.
-phil.
On 11/15/2015 09:21 PM, Rajeev Chamyal wrote:
Hello Phil,
I
Hello Phil,
I have updated the test case as per your review comments.
Could you please review it.
http://cr.openjdk.java.net/~rchamyal/8030099/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 12 November 2015 16:02
To: Rajeev Chamyal; Philip Race;
Still looks fine to me.
On 02.11.15 19:19, Rajeev Chamyal wrote:
Hello Phil,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8030099/webrev.02/
The test case has been updated as per review comments. Added tests for both
Parallel and default collector.
Regards,
Rajeev
Hello Phil,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8030099/webrev.02/
The test case has been updated as per review comments. Added tests for both
Parallel and default collector.
Regards,
Rajeev Chamyal
-Original Message-
From: Phil Race
Sent: 30
It is arguably most important to run this with the *default* collector.
If that changes to G1 (I think it is at least temporarily so changed in
JDK 9)
then we will never see problems in the case people end up using.
But you obviously also want to test the case that shows the bug.
So I would
Hello Sergey,
Please review the updated test case.
Webrev : http://cr.openjdk.java.net/~rchamyal/8030099/webrev.01/
As this issue is reported for Parallel GC collector. So, I have added
-XX:+UseParallelGC to child process VM arguments in test case.
Regards,
Rajeev Chamyal
-Original
Hello,
Please review the following fix for Jdk9:
Bug: https://bugs.openjdk.java.net/browse/JDK-8030099
Webrev: http://cr.openjdk.java.net/~rchamyal/8030099/webrev.00/
Issue: The memory usage of java process goes on increasing if we call
ShellFolder:listFiles API
aggressively on some
On 20.10.15 0:50, Philip Race wrote:
The code change looks fine. The test is delightfully complicated.
I still have not got a benefit of weak references in this use case. Does
it mean that weak are always better? If yes, then we should at some
point change default policy for all other cases
The code change looks fine. The test is delightfully complicated.
Did you run it under jtreg ?
-phil.
On 10/19/15, 5:10 AM, Rajeev Chamyal wrote:
Hello,
Please review the following fix for Jdk9:
Bug:https://bugs.openjdk.java.net/browse/JDK-8030099
