Re: [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L&F on HiDPI display

2016-09-21 Thread Semyon Sadetsky
Looks good. --Semyon On 9/20/2016 7:35 PM, Alexandr Scherbatiy wrote: Thank you for the suggested code. Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165594/webrev.04 - the provided method is used to draw triangles in BasicArrowButton class - shift to

Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

2016-09-21 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8156217/webrev.07/all_01 The public API remains unchanged: http://cr.openjdk.java.net/~alexsch/8156217/webrev.07/public-api ParagraphView and GlyphPainter2 are updated to return Recatngel2D shape for ParagraphV

Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

2016-09-21 Thread Alexandr Scherbatiy
When a font size is small and UI scale is large it is possible that a char advance can be smaller than 1. For example, if font is Dialog plain with size 2 and UI scale is 32 the 'j' char width has value 0.47. For this case saved int caret position which is used to move a caret to next line d

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-21 Thread Alexandr Scherbatiy
On 9/20/2016 10:40 AM, Semyon Sadetsky wrote: On 9/20/2016 12:00 AM, Alexandr Scherbatiy wrote: On 9/14/2016 11:51 AM, Semyon Sadetsky wrote: On 9/13/2016 9:03 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On 9/13

Re: [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L&F on HiDPI display

2016-09-21 Thread Andrej Golovnin
Hi Alexandr, looks good. Thanks! Best regards, Andrej Golovnin > On 20 Sep 2016, at 18:35, Alexandr Scherbatiy > wrote: > > > Thank you for the suggested code. > > Could you review the updated fix: >http://cr.openjdk.java.net/~alexsch/8165594/webrev.04 > > - the provided method is u