Is it necessary to remove tese fields? For example
MetalScrollBarUI.bumps looks similar to other fields
MetalScrollButton.increaseButton/decreaseButton.
On 13.10.16 16:15, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8167176
Please review the following.
The .h files and .c file provided to allow Assistive Technology to
interface to the Java Access Bridge API are being removed from the built
JRE/JDK images. They are not used much and they can be obtained online
via the OpenJDK web site. The pubs will be updated to
Looks good.
--Semyon
On 13.10.2016 16:15, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8167176
webrev: http://cr.openjdk.java.net/~alexsch/8167176/webrev.00
- Inaccessible classes returned by public API in swing are changed
One big problem I see with this is that it means they will only be
available under the GPL license
as they will not be in an Oracle JDK which strips the GPL
So if you are going to do this then these files first need to be
dual-licensed
because otherwise people can't link their commercial
The fix looks good to me.
Thanks,
Alexandr.
On 10/11/2016 8:56 PM, Alexander Zvegintsev wrote:
+1
On 10/6/16 11:18 AM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8164321
webrev:
On 03.10.16 12:35, Semyon Sadetsky wrote:
But if layout was done, why we get any notifications? Should the check
be (cnt != 0)?
Okay. I have changed it to zero:
http://cr.openjdk.java.net/~ssadetsky/8163167/webrev.01/
Looks fine.
I assume that each notification should be called when the
It sounds like it would be easier to keep the files in the JDK then.
I'll wait for other comments before I redo the patch.
On 10/14/16 12:28 PM, Phil Race wrote:
> One big problem I see with this is that it means they will only be
> available under the GPL license
> as they will not be in an
The fix looks good to me.
Thanks,
Alexandr.
On 10/14/2016 8:52 PM, Sergey Bylokhov wrote:
On 03.10.16 12:35, Semyon Sadetsky wrote:
But if layout was done, why we get any notifications? Should the check
be (cnt != 0)?
Okay. I have changed it to zero: