Re: [11] RFR for JDK-8199627: Use "Per-Monitor V2" High DPI awareness for Windows 10 v1703

2018-04-16 Thread Magnus Ihse Bursie
Hi Alexey, Since this patch, I'm getting lots of warnings on Windows: c:/cygwin64/home/magnusi/hg/sandbox/open/src/java.base/windows/native/launcher/java.manifest : manifest authoring warning 81010002: Unrecognized Element "dpiAwareness" in namespace "http://schemas.microsoft.com/SMI/2016/Win

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

2019-11-04 Thread Magnus Ihse Bursie
On 2019-11-03 16:38, Dmitry Markov wrote: Alexey and Sergey, thank you for the approval! I wonder whether it is enough or I need one more “+1” from build-folk. You really don't need it, but here you get one. :-) I think it was good that you continued polish the addition. The latest version l

Re: RFR: JDK-8242808 Fix all remaining deprecation warnings in jdk.hotspot.agent

2020-04-15 Thread Magnus Ihse Bursie
just Rectangles (not Rectangle2D). /Magnus On 2020-04-15 11:37, David Holmes wrote: Hi Magnus, This one sounds like it needs a Swing/Java2D developer to review it :) Cheers, David On 15/04/2020 7:13 pm, Magnus Ihse Bursie wrote: After JDK-8242804, a few places remain which are using deprecated me

Re: RFR: JDK-8242808 Fix all remaining deprecation warnings in jdk.hotspot.agent

2020-04-15 Thread Magnus Ihse Bursie
15-Apr-20 3:35 PM, Magnus Ihse Bursie wrote: Hi swing-dev, Do you have any other suggestions for how to resolve the deprecation of modelToView() in this code? Basically, the code does this:    Rectangle rect = source.modelToView(offset);    source.scrollRectToVisible(r

Re: RFR: JDK-8242808 Fix all remaining deprecation warnings in jdk.hotspot.agent

2020-04-15 Thread Magnus Ihse Bursie
Here is an updated version, that avoids the SuppressWarnings for modelToView: http://cr.openjdk.java.net/~ihse/JDK-8242808-fix-all-SA-deprecation/webrev.02 (Only change is in SourceCodePanel.java compared to v01) /Magnus On 2020-04-15 14:30, Magnus Ihse Bursie wrote: On 2020-04-15 12:59

Re: RFR: 8253753 Enable default constructor warning in client modules

2020-11-26 Thread Magnus Ihse Bursie
On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy wrote: > With the default constructors warnings in java.desktop and jdk.accessibility > now fixed, the warning should be enabled in the build for those modules. Looks good! Thank you for your continued efforts to clean up the code base. ---

Re: [OpenJDK 2D-Dev] Request for comment: merging the openjdk client groups ?

2015-02-25 Thread Magnus Ihse Bursie
On 2015-02-19 01:06, Phil Race wrote: There would still be some 'division' as I expect the individual mailing lists to persist. From my "outsider" perspective, I think the suggested move makes sense. However, I hope one outcome would be the addition of a common mailing list. I'm often just gu

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-26 Thread Magnus Ihse Bursie
b/Lib-jdk.accessibility.gmk - removed the source for the Ferret and Monkey test tools which will be the subject of a later patch - removed the DEF files; although they were used in the build, there are no build or runtime problems after their removal On 3/24/15 8:08 AM, Magnus Ihse Bursie wrote

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-17 Thread Magnus Ihse Bursie
On 2016-10-14 17:51, Pete Brunet wrote: Please review the following. The .h files and .c file provided to allow Assistive Technology to interface to the Java Access Bridge API are being removed from the built JRE/JDK images. They are not used much and they can be obtained online via the OpenJDK

Re: [10] RFR JDK-6461834: Minimize WindowsLookAndFeel classes included with Unix JDKs

2017-05-17 Thread Magnus Ihse Bursie
Build changes looks good. However in src/java.desktop/share/classes/module-info.java you are trying to check in commented-out code instead of removing it. /Magnus On 2017-05-17 12:31, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue whereby it is seen that WindowsLookAndFe