Re: Review request for JDK-6288609 JInternalFrame.setDefaultCloseOperation() interferes with "close" behavior

2015-11-16 Thread prasanta sadhukhan
Looks ok to me. Regards Prasanta On 11/16/2015 2:24 PM, Rajeev Chamyal wrote: Hello Prasanta, Please review the updated webrev. I have updated it as per review comments. http://cr.openjdk.java.net/~rchamyal/6288609/webrev.01 Regards, Rajeev Chamyal -Original Message- From: prasanta

Re: Review request for JDK-6288609 JInternalFrame.setDefaultCloseOperation() interferes with "close" behavior

2015-11-15 Thread prasanta sadhukhan
Hi Rajeev, The fix looks ok to me. But, Don't we need to put this testcode in EDT? JInternalFrame internalFrame = desktopPane.getSelectedFrame(); 133 internalFrame.doDefaultCloseAction(); 134 internalFrame = desktopPane.getSelectedFrame(); Also, there are wildcard imports

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-10-14 Thread prasanta sadhukhan
On 10/9/2015 3:00 PM, Alexander Scherbatiy wrote: On 10/7/2015 3:10 PM, prasanta sadhukhan wrote: Hi All, @Sergey,Phil,Alexander Z http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.10/ Have you checked the corner cases like printing a table which has only one row (with and without

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-10-07 Thread prasanta sadhukhan
Hi All, @Sergey,Phil,Alexander Z http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.10/ Any more comments/feedback? Can I get a +1 for this? Regards Prasanta On 09/25/2015 04:47 AM, prasanta sadhukhan wrote: Thanks Alexander. Can I get a +1 for this? Regards Prasanta On 9/25/2015 2:43

Re: Swing Dev RFR: [9] [JDK-8081491] The case print incomplete.

2015-08-28 Thread prasanta sadhukhan
On 8/26/2015 6:24 PM, Alexander Scherbatiy wrote: On 8/25/2015 1:51 PM, prasanta sadhukhan wrote: On 8/25/2015 3:53 PM, Alexander Scherbatiy wrote: On 8/24/2015 2:23 PM, prasanta sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8081491 webrev: http

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-04 Thread prasanta sadhukhan
Any reviewers for this please? On 9/2/2015 5:06 PM, prasanta sadhukhan wrote: Hi, Can this fix be reviewed? Regards Prasanta On 8/28/2015 4:48 PM, prasanta sadhukhan wrote: On 8/26/2015 6:24 PM, Alexander Scherbatiy wrote: On 8/25/2015 1:51 PM, prasanta sadhukhan wrote: On 8/25/2015 3

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-07 Thread prasanta sadhukhan
Scherbatiy wrote: Could the clip.getLocation() be differ from them visibleBounds.getLocation()? Thanks, Alexandr. On 9/4/2015 3:32 PM, prasanta sadhukhan wrote: Any reviewers for this please? On 9/2/2015 5:06 PM, prasanta sadhukhan wrote: Hi, Can this fix be reviewed? Regards Prasanta

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread prasanta sadhukhan
the push. Thanks, Alexandr. On 9/8/2015 12:26 PM, prasanta sadhukhan wrote: On 9/7/2015 5:50 PM, Alexander Scherbatiy wrote: On 9/7/2015 9:23 AM, prasanta sadhukhan wrote: I guess it will be same but anyways have modified to use visibleBounds.getLocation() to be on safeside as we are dealing

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread prasanta sadhukhan
;1850 // otherwise 1 extra rows are ptinted" - ImageableAreaTest: the test instructions have copy pasted numbers 1/2/2/2 etc. On 08.09.15 12:43, prasanta sadhukhan wrote: Thanks for your review. I need +1 for this. Alexander Z/Sergey, can you please approve this fix? Regards Prasanta On 9/8

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-02 Thread prasanta sadhukhan
Hi, Can this fix be reviewed? Regards Prasanta On 8/28/2015 4:48 PM, prasanta sadhukhan wrote: On 8/26/2015 6:24 PM, Alexander Scherbatiy wrote: On 8/25/2015 1:51 PM, prasanta sadhukhan wrote: On 8/25/2015 3:53 PM, Alexander Scherbatiy wrote: On 8/24/2015 2:23 PM, prasanta sadhukhan

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-10 Thread prasanta sadhukhan
On 9/10/2015 3:42 PM, Sergey Bylokhov wrote: On 10.09.15 9:36, prasanta sadhukhan wrote: Please review the modified webrev which solves this artifacts. http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.05/ What will happen if the table will be added to the jpanel and the jpanel

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-16 Thread prasanta sadhukhan
Hi Alexander, Sergey, Waiting for your review on this. http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.06/ Regards Prasanta On 9/15/2015 10:55 AM, prasanta sadhukhan wrote: On 9/14/2015 12:48 PM, prasanta sadhukhan wrote: On 9/11/2015 2:20 PM, prasanta sadhukhan wrote: On 9/10

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-11 Thread prasanta sadhukhan
On 9/10/2015 4:48 PM, Sergey Bylokhov wrote: On 10.09.15 13:35, prasanta sadhukhan wrote: On 9/10/2015 3:42 PM, Sergey Bylokhov wrote: On 10.09.15 9:36, prasanta sadhukhan wrote: Please review the modified webrev which solves this artifacts. http://cr.openjdk.java.net/~psadhukhan/8081491

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-14 Thread prasanta sadhukhan
On 9/14/2015 12:48 PM, prasanta sadhukhan wrote: On 9/11/2015 2:20 PM, prasanta sadhukhan wrote: On 9/10/2015 4:48 PM, Sergey Bylokhov wrote: On 10.09.15 13:35, prasanta sadhukhan wrote: On 9/10/2015 3:42 PM, Sergey Bylokhov wrote: On 10.09.15 9:36, prasanta sadhukhan wrote: Please

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-10 Thread prasanta sadhukhan
Prasanta On 9/8/2015 4:27 PM, Sergey Bylokhov wrote: Hi, Prasanta. Just before the push of this fix I made small pit, and found a regression. Please run the SwingSet2, open JTable demo, and scroll the table. You will see some artifacts. On 08.09.15 13:13, prasanta sadhukhan wrote: Thanks Sergey

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-14 Thread prasanta sadhukhan
On 9/11/2015 2:20 PM, prasanta sadhukhan wrote: On 9/10/2015 4:48 PM, Sergey Bylokhov wrote: On 10.09.15 13:35, prasanta sadhukhan wrote: On 9/10/2015 3:42 PM, Sergey Bylokhov wrote: On 10.09.15 9:36, prasanta sadhukhan wrote: Please review the modified webrev which solves

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-29 Thread prasanta sadhukhan
833 if (rMax == -1) { 1834 rMax = table.getRowCount(); 1835 } -phil. On 09/25/2015 04:47 AM, prasanta sadhukhan wrote: Thanks Alexander. Can I get a +1 for this? Regards Prasanta On 9/25/2015 2:43 PM, Alexander Scherbatiy wrote: The fix looks good to me. Tha

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-30 Thread prasanta sadhukhan
/ Regards Prasanta On 9/30/2015 4:14 AM, Phil Race wrote: On 09/28/2015 11:53 PM, prasanta sadhukhan wrote: Have updated the webrev to cater to this empty lines http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.09/ The below code was there initially and I have not added

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-23 Thread prasanta sadhukhan
I have updated the code as per your comment. Please review this webrev http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.07/ Regards Prasanta On 9/22/2015 7:01 PM, Alexander Scherbatiy wrote: On 9/21/2015 12:05 PM, prasanta sadhukhan wrote: On 9/21/2015 2:20 PM, Alexandr Scherbatiy wrote

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-21 Thread prasanta sadhukhan
On 9/21/2015 2:20 PM, Alexandr Scherbatiy wrote: 18.09.2015 10:16, prasanta sadhukhan пишет: On 9/17/2015 8:18 PM, Alexander Scherbatiy wrote: On 9/16/2015 2:04 PM, prasanta sadhukhan wrote: Hi Alexander, Sergey, Waiting for your review on this. http://cr.openjdk.java.net/~psadhukhan

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-23 Thread prasanta sadhukhan
On 9/23/2015 2:46 PM, Alexander Scherbatiy wrote: On 9/23/2015 9:42 AM, prasanta sadhukhan wrote: I have updated the code as per your comment. Please review this webrev http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.07/ - Is it possible that SwingUtilities.getUnwrappedParent(table

Re: JDK9 Review Request for 8067660: JFileChooser create new folder fails silently

2015-12-01 Thread prasanta sadhukhan
To: Rajeev Chamyal Cc: Prasanta Sadhukhan; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: JDK9 Review Request for 8067660: JFileChooser create new folder fails silently 27.11.2015 13:45, Rajeev Chamyal пишет: Hello Alexandr, I have updated the webrev as per review comm

[9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-13 Thread prasanta sadhukhan
Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a JTable, the text painted in the rows goes missing. Bug: https://bugs.openjdk.java.net/browse/JDK-8159068 webrev: http://cr.openjdk.java.net/~psadhukhan/8159068/webrev.00/ The issue was rMax value

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-14 Thread prasanta sadhukhan
Gentle reminder for review. Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a JTable, the text painted in the rows goes missing

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-13 Thread prasanta sadhukhan
On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a JTable, the text painted in the rows goes missing. Bug: https://bugs.openjdk.java.net/browse/JDK-8159068 webrev: http://cr.openjdk.java.net

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-21 Thread Prasanta Sadhukhan
On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrote: On 6/20/2016 8:10 AM, prasanta sadhukhan wrote: Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-19 Thread prasanta sadhukhan
Gentle reminder for review!! Regards Prasanta On 6/13/2016 4:31 PM, prasanta sadhukhan wrote: On 6/13/2016 12:51 PM, prasanta sadhukhan wrote: Hi All, Please review a fix for jdk9 where it was seen that if we try to select some rows in a JTable, the text painted in the rows goes missing

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-23 Thread Prasanta Sadhukhan
On 6/23/2016 12:10 PM, Alexandr Scherbatiy wrote: On 6/21/2016 2:57 PM, Prasanta Sadhukhan wrote: On 6/21/2016 5:16 PM, Alexandr Scherbatiy wrote: On 6/21/2016 1:58 PM, Prasanta Sadhukhan wrote: On 6/21/2016 4:14 PM, Alexandr Scherbatiy wrote: On 6/20/2016 8:10 AM, prasanta sadhukhan

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-24 Thread Prasanta Sadhukhan
On 6/24/2016 1:41 PM, Alexandr Scherbatiy wrote: On 6/24/2016 10:04 AM, Prasanta Sadhukhan wrote: Hi Alexandr, Thanks for your suggestion. Have modified as per the comment to decide based on selected row. 8081491 <https://bugs.openjdk.java.net/browse/JDK-8081491> testcase and Swi

Re: [9] RFR JDK-8159068:The rendering of JTable is broken

2016-06-24 Thread Prasanta Sadhukhan
webrev.01/ Regards Prasanta On 6/23/2016 12:41 PM, Alexandr Scherbatiy wrote: On 6/23/2016 9:53 AM, Prasanta Sadhukhan wrote: On 6/23/2016 12:10 PM, Alexandr Scherbatiy wrote: On 6/21/2016 2:57 PM, Prasanta Sadhukhan wrote: On 6/21/2016 5:16 PM, Alexandr Scherbatiy wrote: On 6/21/2016 1

Re: JDK9 Review Request for JDK-7104635 HTMLEditorKit fails to write down some html files

2016-01-14 Thread prasanta sadhukhan
Fix looks good to me. Regards Prasanta On 11/26/2015 2:06 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-7104635 Webrev: http://cr.openjdk.java.net/~rchamyal/7104635/webrev.00/

Re: Review Request JDK-8159152 Ctrl+F6, Ctrl+F5 doesn't work for iconified InternalFrame

2016-06-29 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 6/22/2016 6:04 PM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 6/22/2016 2:46 PM, Rajeev Chamyal wrote: Hello Alexandr, Thanks for the review. JDK-4878528 keyboard focus test was

Re: Review request for JDK-8146276 : Right aligned ToolBar component does not appear

2016-01-21 Thread prasanta sadhukhan
the minimumLayoutSize with preferredLayoutSize and updated the webrev. http://cr.openjdk.java.net/~rchamyal/8146276/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Alexander Scherbatiy Sent: 19 January 2016 21:33 To: Rajeev Chamyal; Sergey Bylokhov; Prasanta Sadhukhan; swing

Re: Review request for JDK-8139213 : Mac OS X Aqua Look and Feel: JOptionPane can truncate the first button.

2016-01-21 Thread prasanta sadhukhan
to me. Thanks, Alexandr. Regards, Rajeev Chamyal -Original Message- From: Alexander Scherbatiy Sent: 20 January 2016 17:04 To: Rajeev Chamyal Cc: Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8139213 : Mac OS X Aqua Look

Re: Review request for 8025430: [TEST_BUG] javax/swing/JEditorPane/5076514/bug5076514.java failed since jdk8b108

2016-04-13 Thread prasanta sadhukhan
You need to add @run main for latest jtreg to run. Have you run against latest jtreg? Regards Prasanta On 4/13/2016 6:10 PM, Muneer Kolarkunnu wrote: Hi All, Please review the fix for test bug 8025430, Webrev:

Re: Review Request JDK-8153056 : 8152647(duplicate of 6439354) Manual Test always passes

2016-04-15 Thread prasanta sadhukhan
Hi Prem, Why did you remove 1999 from the copyright? I guess that's the initial year when this test was written. I guess we need to keep it and make like 1999,2016. I guess also this try/catch block is redundant try { 56 latch.await(); 57 } catch (InterruptedException ie) { 58 throw ie; 59 }

[9] RFR JDK-8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java

2017-02-24 Thread Prasanta Sadhukhan
Hi All, Please review a testbug fix where although the test description mention about keyboard garbage, but I was getting NPE in windows7. Bug: https://bugs.openjdk.java.net/browse/JDK-8039888 webrev: http://cr.openjdk.java.net/~psadhukhan/8039888/webrev.00/ NPE was caused by the fact that

[9] RFR JDK-8174717: [TEST_BUG] javax/swing/text/html/StyleSheet/bug4936917.java

2017-02-13 Thread Prasanta Sadhukhan
Hi All, Please review a simple fix for an issue where the tests fails due to lack of delay before checking for robot output value. Bug: https://bugs.openjdk.java.net/browse/JDK-8174717 webrev: http://cr.openjdk.java.net/~psadhukhan/8174717/webrev.00/ Added a delay before output condition is

[9] RFR JDK-8174720: [TEST_BUG] add :open to a @modules annotation for bug7089914.java

2017-02-12 Thread Prasanta Sadhukhan
Hi All, Please review a simple fix to add "open" to module to aid jigsaw accessibility. Bug: https://bugs.openjdk.java.net/browse/JDK-8174720 webrev: http://cr.openjdk.java.net/~psadhukhan/8174720/webrev.00/ Regards Prasanta

Re: [9] RFR: JDK-8172012: [TEST_BUG] delays needed in javax/swing/JTree/4633594/bug4633594.java

2017-01-17 Thread Prasanta Sadhukhan
. +1 On 01/13/2017 01:48 PM, Prasanta Sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8172012 The issue of not having a delay between robot events is already addressed by adding autodelay and has been approved in closed crucible review. This webrev addresses moving

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-27 Thread Prasanta Sadhukhan
can't think why it would not work on Solaris just as it works everywhere else. And when I run 'java -help' on Solaris it lists the option :- -splash: show splash screen with specified image -phil. On 10/26/16, 8:27 AM, Prasanta Sadhukhan wrote: No, as I understand

Re: 8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

2016-10-27 Thread Prasanta Sadhukhan
Hi Avik, Did the test fail for you? I ran with the launcher auto-hidden in ubuntu14.04 but it passed for me with the original testcode. Regards Prasanta On 10/26/2016 12:39 PM, Avik Niyogi wrote: Hi All, Kindly review the proposed fix for JDK9. *Bug:

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Prasanta Sadhukhan
No, as I understand splashscreen support is not there for solaris. Regards Prasanta On 10/26/2016 8:55 PM, Sergey Bylokhov wrote: Should this test work on Solaris as well? On 26.10.16 10:19, Prasanta Sadhukhan wrote: Hi All, Please review a simple fix for splasscreen testissue where we need

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

2016-11-24 Thread Prasanta Sadhukhan
+1 On 11/23/2016 7:52 PM, Sergey Bylokhov wrote: On 22.11.16 8:49, Avik Niyogi wrote: Hi All, Please review the code changes made as suggested by reviewers for JDK9 as available for perusal in the link below: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.02/ Change note: Instead of

Re: [9] RFR JDK-7190578: Nimbus: css test for 4936917 fails

2016-11-21 Thread Prasanta Sadhukhan
, Sergey Bylokhov wrote: Hi, Prasanta Note that editorPane still accessed on non-EDT: blockTillDisplayed(editorPane); Point p = editorPane.getLocationOnScreen(); On 18.11.16 14:11, Prasanta Sadhukhan wrote: Updated test to access swing component on EDT and dispose frame

Re: [9] RFR JDK-7190578: Nimbus: css test for 4936917 fails

2016-11-16 Thread Prasanta Sadhukhan
necessary? On 16.11.16 12:38, Prasanta Sadhukhan wrote: I intended to open this testcase so remove dependancy on Util library. I tested with other LAFs and it passed.

Re: [9] RFR JDK-7190578: Nimbus: css test for 4936917 fails

2016-11-18 Thread Prasanta Sadhukhan
Friday, November 18, 2016 2:23 PM To: Prasanta Sadhukhan; Alexandr Scherbatiy; Avik Niyogi; swing-dev@openjdk.java.net Subject: Re: [9] RFR JDK-7190578: Nimbus: css test for 4936917 fails On 18.11.16 11:44, Prasanta Sadhukhan wrote: Any further objection on this? If not, can I get +1 ? It seems

Re: [9] RFR JDK-7190578: Nimbus: css test for 4936917 fails

2016-11-18 Thread Prasanta Sadhukhan
Any further objection on this? If not, can I get +1 ? Regards Prasanta On 11/16/2016 9:12 PM, Prasanta Sadhukhan wrote: Ok. Removed html file and updated test not to use JApplet. Please find the updated webrev http://cr.openjdk.java.net/~psadhukhan/7190578/webrev.01/ Regards Prasanta On 11

Re: [9] RFR JDK-7190578: Nimbus: css test for 4936917 fails

2016-11-21 Thread Prasanta Sadhukhan
Any further feedback on this? Regards Prasanta On 11/18/2016 4:41 PM, Prasanta Sadhukhan wrote: Updated test to access swing component on EDT and dispose frame at end of test. Also, updated test to check background color (cc) and not white. But it seems robot.getPixelColor() gives

Re: [9] RFR JDK-8048702: Deprecate obsolete classes in javax/swing/plaf/metal/MetalFileChooserUI.java

2016-10-27 Thread Prasanta Sadhukhan
Please find the webrev with the proposed changes. http://cr.openjdk.java.net/~psadhukhan/8048702/ Regards Prasanta On 10/27/2016 8:03 PM, Alexandr Scherbatiy wrote: On 10/26/2016 10:28 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for the issue where this obsolete class needs

[9] RFR JDK-8048702: Deprecate obsolete classes in javax/swing/plaf/metal/MetalFileChooserUI.java

2016-10-26 Thread Prasanta Sadhukhan
Hi All, Please review a fix for the issue where this obsolete class needs to be deprecated: Bug: https://bugs.openjdk.java.net/browse/JDK-8048702 diff -r aae3690e53e3 src/java.desktop/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java ---

[9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Prasanta Sadhukhan
Hi All, Please review a simple fix for splasscreen testissue where we need to restrict this test from running on linux as this test uses linux enviroment variable GDK_SCALE so restricting to run only on linux. Bug: https://bugs.openjdk.java.net/browse/JDK-8168657 diff -r aae3690e53e3

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Prasanta Sadhukhan
/sun.java2d + * @requires (os.family == "linux") * @run main UnixMultiResolutionSplashTest */ public class UnixMultiResolutionSplashTest { Regards Prasanta On 10/26/2016 12:49 PM, Prasanta Sadhukhan wrote: Hi All, Please review a simple fix for splasscreen testissue where we need to

Re: [9] RFR JDK-8048702: Deprecate obsolete classes in javax/swing/plaf/metal/MetalFileChooserUI.java

2016-10-30 Thread Prasanta Sadhukhan
, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 10/28/2016 7:19 AM, Prasanta Sadhukhan wrote: Please find the webrev with the proposed changes. http://cr.openjdk.java.net/~psadhukhan/8048702/ Regards Prasanta On 10/27/2016 8:03 PM, Alexandr Scherbatiy wrote: On 10/26

Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-11-02 Thread Prasanta Sadhukhan
Do we need the suppression in JavaSoundAudioClip.java as I could not find any mention of Applet in that class? In AppletViewer.java shouldn't we need to add "deprecation" to 45 @SuppressWarnings("serial") // JDK implementation class Do we still need this 160

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-28 Thread Prasanta Sadhukhan
On 10/27/2016 7:49 PM, Sergey Bylokhov wrote: On 27.10.16 9:45, Prasanta Sadhukhan wrote: What I meant to say is hidpi splashscreen support is not there in solaris (already told earlier too) http://mail.openjdk.java.net/pipermail/awt-dev/2016-March/010813.html I think that it should

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-12-06 Thread Prasanta Sadhukhan
On 12/6/2016 8:17 PM, Alexandr Scherbatiy wrote: On 12/1/2016 9:16 AM, Prasanta Sadhukhan wrote: On 11/30/2016 2:53 PM, Prasanta Sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8170349 webrev: http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.00/ Please review

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-12-14 Thread Prasanta Sadhukhan
Gentle reminder... Regards Prasanta On 12/9/2016 8:27 PM, Prasanta Sadhukhan wrote: On 12/9/2016 8:18 PM, Alexandr Scherbatiy wrote: On 12/6/2016 5:52 PM, Prasanta Sadhukhan wrote: On 12/6/2016 8:17 PM, Alexandr Scherbatiy wrote: On 12/1/2016 9:16 AM, Prasanta Sadhukhan wrote: On 11/30

[9] RFR JDK-8172558: [PIT][TEST_BUG] Bad filename for javax/swing/JTable/8133919/DrawGridLinesTest.java

2017-01-11 Thread Prasanta Sadhukhan
Hi All, Please review the name change for this regression test which was causing jtreg to fail as it was not finding the test. Bug: https://bugs.openjdk.java.net/browse/JDK-8172558 Filename was javax/swing/JTable/8133919/DrawGridLInesTest.java [whith capital I] but test has jtreg tag @run

[9] RFR: JDK-8172012: [TEST_BUG] delays needed in javax/swing/JTree/4633594/bug4633594.java

2017-01-13 Thread Prasanta Sadhukhan
Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8172012 The issue of not having a delay between robot events is already addressed by adding autodelay and has been approved in closed crucible review. This webrev addresses moving the closed test to open in addition to modify test to

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Prasanta Sadhukhan
I guess we need to throw the exception if changing LaF fails instead of silently consuming it!! Regards Prasanta On 1/11/2017 2:16 PM, Avik Niyogi wrote: Hi All, Kindly review the proposed fix for JDK9. *Bug: https://bugs.openjdk.java.net/browse/JDK-8172509* * * *Webrev:

Re: [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

2016-11-29 Thread Prasanta Sadhukhan
nd provide your suggestions Thank you Have a good day Prahalad N. -Original Message- From: Phil Race Sent: Tuesday, November 22, 2016 12:21 AM To: Prahalad Kumar Narayanan; Prasanta Sadhukhan; Sergey Bylokhov; 2d-...@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] Review Request: [J

[9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-11-30 Thread Prasanta Sadhukhan
Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8170349 webrev: http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.00/ Please review a fix for a continuation/regression of JDK-8081491 in which we made sure that we print only the

Re: [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

2016-11-30 Thread Prasanta Sadhukhan
ave a good day Prahalad N. From: Prasanta Sadhukhan Sent: Tuesday, November 29, 2016 7:15 PM To: Prahalad Kumar Narayanan; swing-dev@openjdk.java.net Cc: Sergey Bylokhov Subject: Re: [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation f

Re: [9] Review request for JDK-8159906: [TEST_BUG] javax/swing/JDialog/Transparency/TransparencyTest.java

2016-12-05 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 12/5/2016 5:38 PM, Maksim Khramov wrote: Hello, webrev updated: http://cr.openjdk.java.net/~yan/8159906/webrev.01/ <http://cr.openjdk.java.net/%7Eyan/8159906/webrev.01/> Added bugid DlgPos variable marked as volatile. Thanks, Maksim. On 02.12.2016 18:01, Pr

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-11-30 Thread Prasanta Sadhukhan
On 11/30/2016 2:53 PM, Prasanta Sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8170349 webrev: http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.00/ Please review a fix for a continuation/regression of JDK-8081491 <https://bugs.openjdk.java.net/browse/

Re: [9] Review request for JDK-8159906: [TEST_BUG] javax/swing/JDialog/Transparency/TransparencyTest.java

2016-12-02 Thread Prasanta Sadhukhan
You need to add 8159906 to @bug tag. Also, one more thing, since dlgPos is accessed from EDT and main thread shouldn't it be declared volatile? Rest looks fine. Regards Prasanta On 12/2/2016 5:52 PM, Maksim Khramov wrote: Hello, please review this request... Webrev:

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-12-21 Thread Prasanta Sadhukhan
/webrev.01/ Regards Prasanta On 12/9/2016 5:57 PM, Prasanta Sadhukhan wrote: On 12/9/2016 8:18 PM, Alexandr Scherbatiy wrote: On 12/6/2016 5:52 PM, Prasanta Sadhukhan wrote: On 12/6/2016 8:17 PM, Alexandr Scherbatiy wrote: On 12/1/2016 9:16 AM, Prasanta Sadhukhan wrote: On 11/30/2016 2:53 PM

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-12-22 Thread Prasanta Sadhukhan
Used put/getClientProperty instead of UIManager.put/get. Please find modified webrev: http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.02/ Regards Prasanta On 12/21/2016 5:06 PM, Prasanta Sadhukhan wrote: Hi Alex, Further to our discussion where you suggested not to modify table

Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-03-15 Thread Prasanta Sadhukhan
ce. Arial is a Sans Serif font and Serif fonts are not usually used in UIs. So "SansSerif" would be better -phil. On 3/14/17, 4:46 AM, Prasanta Sadhukhan wrote: Hi All, Please review a testbug fix where the testcase is failing in linux because it is not able to find "Arial"

[9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-03-14 Thread Prasanta Sadhukhan
Hi All, Please review a testbug fix where the testcase is failing in linux because it is not able to find "Arial" font and tries to use the font found in 0th index of getAvailableFontFamilyNames() which is "Abyssinica SIL". Bug: https://bugs.openjdk.java.net/browse/JDK-8169897 webrev:

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

2017-08-17 Thread Prasanta Sadhukhan
Fix looks good. But, can you update test/javax/swing/JTabbedPane/4310381/bug4310381.java to include the test for all installed l so that we can see if there is problem in any other l? Regards Prasanta On 8/17/2017 2:08 PM, Shashidhara Veerabhadraiah wrote: Hi All, Please review a fix for

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-07 Thread Prasanta Sadhukhan
e that you did not keep references to those objects and they were garbage collected. --Semyon On 07/07/2017 08:13 AM, Prasanta Sadhukhan wrote: I tried that putting the initialization in initIDs() which will be called once only but am getting jni crash citing " Pointing to zapped

Re: [10] RFR JDK-8173739: JPopupMenu does not disappear on KeyEvent

2017-07-12 Thread Prasanta Sadhukhan
Any further comments on this? Can it be committed now? Regards Prasanta On 7/4/2017 12:35 PM, Prasanta Sadhukhan wrote: OK. Updated webrev to post ungrab from a method when internal frame is deselected. There is no grab event. When popup menu is visible, it grab window in BasicPopupMenuUI

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-11 Thread Prasanta Sadhukhan
.07/ Regards Prasanta On 7/12/2017 12:21 AM, Semyon Sadetsky wrote: On 7/10/2017 8:57 AM, Prasanta Sadhukhan wrote: On 7/10/2017 8:37 PM, Semyon Sadetsky wrote: On 07/10/2017 08:01 AM, Prasanta Sadhukhan wrote: On 7/10/2017 8:29 PM, Semyon Sadetsky wrote: Hi Prasanta, Please, add

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Prasanta Sadhukhan
On 7/10/2017 8:37 PM, Semyon Sadetsky wrote: On 07/10/2017 08:01 AM, Prasanta Sadhukhan wrote: On 7/10/2017 8:29 PM, Semyon Sadetsky wrote: Hi Prasanta, Please, add static modifier to those java constants. It causes "NoSuchFieldError" if we access static field defined in

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Prasanta Sadhukhan
> > > > > > > > On 7/10/2017 8:37 PM, Semyon Sadetsky wrote: > > On 07/10/2017 08:01 AM, Prasanta Sadhukhan wrote: > > > > > > > > On 7/10/2017 8:29 PM, Semyon Sadetsky

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-07 Thread Prasanta Sadhukhan
r.openjdk.java.net/~psadhukhan/8183529/webrev.05/ Regards Prasanta --Semyon On 07/07/2017 09:26 AM, Prasanta Sadhukhan wrote: Modified webrev to not create new string objects every time doGetColumnInfo() is called, rather it "gets" the string objects. http://cr.openjdk.java.net

Re: [10] RFR JDK-8175968: The javax.swing.filechooser.FileSystemView constructor consumes memory by adding a PropertyChangeListener that is never removed.

2017-07-07 Thread Prasanta Sadhukhan
release of those resources, Regards Prasanta Not the nicest way to do such cleanup (which should probably happen on the EDT) in a finalizer, but imho it still beats adding an extra method to the API and shifting the burden to the API user. Robin On Thu, Jul 6, 2017 at 3:15 PM, Prasanta Sadhukhan

[10] RFR JDK-8184244: UIDefaults.addResourceBundle uses system class loader

2017-07-12 Thread Prasanta Sadhukhan
Hi All, Please review a doc fix to use correct "system" classloader instead of mentioned "application" classloader. Bug: https://bugs.openjdk.java.net/browse/JDK-8184244 webrev: http://cr.openjdk.java.net/~psadhukhan/8184244/webrev.00/ Regards Prasanta

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-12 Thread Prasanta Sadhukhan
On 7/13/2017 6:58 AM, Semyon Sadetsky wrote: On 7/11/2017 10:54 PM, Prasanta Sadhukhan wrote: Thanks Semyon for the pointer. Calling NewGlobalRef makes these fields a global ref which can then be accessed from different thread, as doGetColumnInfo() is called from COM invoker thread

Re: [10] RFR JDK-8184272 : Jemmy JFileChooserOperator.enterSubDir does not navigate to sub directory

2017-07-13 Thread Prasanta Sadhukhan
looks good to me. Regards Prasanta On 7/13/2017 3:20 PM, Vikrant Agarwal wrote: Hi All, Please review the following: Bug : JDK-8184272 JDK 10 Webrev: http://cr.openjdk.java.net/~vagarwal/8184272/webrev.00/

[10] RFR JDK-7163851:Swing. Documentation for AbstractButton.setMnemonic(int) describes behavior not correctly

2017-07-18 Thread Prasanta Sadhukhan
Hi All, Please review a doc modification making it clear that mnemonic display depends on L It seems, the doc in current form, may imply that first occurence of the character defined by the mnemonic will be underlined "always" but it is not so. For windows L, it is underlined only when ALT

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-07 Thread Prasanta Sadhukhan
each time when getFolderColumns() is called the title keys are initialized. That will be more optimal to initialize them once only and reuse them in consequent calls, won't it? --Semyon On 07/06/2017 11:26 PM, Prasanta Sadhukhan wrote: Modified webrev after removal of intermediate var

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-10 Thread Prasanta Sadhukhan
ColumnInfo() to _initIDs()? GetObjectField() needs jobject parameter which is not available in initIDs() Regards Prasanta --Semyon On 07/07/2017 10:49 PM, Prasanta Sadhukhan wrote: On 7/8/2017 2:22 AM, Semyon Sadetsky wrote: Why you declared fields instead of constants? Are they supposed to

Re: [10] RFR JDK-8173739: JPopupMenu does not disappear on KeyEvent

2017-07-20 Thread Prasanta Sadhukhan
Prasanta On 7/4/2017 12:35 PM, Prasanta Sadhukhan wrote: OK. Updated webrev to post ungrab from a method when internal frame is deselected. There is no grab event. When popup menu is visible, it grab window in BasicPopupMenuUI public void stateChanged(ChangeEvent e

[10] RFR JDK-8184813:Class javax/swing/plaf/metal/MetalFontDesktopProperty is broken in JDK10

2017-07-20 Thread Prasanta Sadhukhan
Hi All, This is a back-out of 6461834: Minimize WindowsLookAndFeel classes included with Unix JDKs fix which was done to make sure WindowsLookAndFeel classes are not built for non-windows platform but it seems there are some classes in shared folder which uses

Re: [10] RFR JDK-8173739: JPopupMenu does not disappear on KeyEvent

2017-07-21 Thread Prasanta Sadhukhan
: I'll take a look tomorrow just to refresh the memory on how this part of code works. - prasanta.sadhuk...@oracle.com wrote: Any further comments on this? Can it be committed now? Regards Prasanta On 7/4/2017 12:35 PM, Prasanta Sadhukhan wrote: OK. Updated webrev to post ungrab from

Re: [10] RFR JDK-7190581: Nimbus: PgDn at the bottom causes scrolling

2017-07-27 Thread Prasanta Sadhukhan
it testing page scrolling on all available L? --Semyon On 07/25/2017 11:52 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that pressing "Page down" after "ctrl-END" in TextArea causes extra scroll down for Nimbus L ctrl-END is sup

Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button

2017-07-26 Thread Prasanta Sadhukhan
e: Yes. Now this fix has been tested on window 7 and windows 8.1 as well. The way to set the folder properties is same and the expected error message pops up if we tried to create a new folder under the read-only directory. Thanks and regards, Shashi *From:*Prasanta Sadhukhan *Sent:* Monday,

Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button

2017-07-26 Thread Prasanta Sadhukhan
*From:*Prasanta Sadhukhan *Sent:* Wednesday, July 26, 2017 1:52 PM *To:* Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com>; swing-dev@openjdk.java.net *Subject:* Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button ok. Probably,

[10] RFR JDK-7190581: Nimbus: PgDn at the bottom causes scrolling

2017-07-26 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where it is seen that pressing "Page down" after "ctrl-END" in TextArea causes extra scroll down for Nimbus L ctrl-END is supposed to go the very end of the document and show the caret at the end, so any "page down" should not cause any further scroll

Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button

2017-07-24 Thread Prasanta Sadhukhan
Hi Shashi, Which windows version you tested? Could you also verify with windows 10 (if not already tested) if this way of making folder read-only is valid or doable (if not, then the instructions may need to be changed)? Regards Prasanta On 7/24/2017 3:28 PM, Shashidhara Veerabhadraiah

Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button

2017-07-24 Thread Prasanta Sadhukhan
On 7/24/2017 4:04 PM, Prasanta Sadhukhan wrote: ok. Then what about windows 7? Did you test there as well? and windows 8.1 since the affected OS is 8.1. Regards Prasanta On 7/24/2017 3:56 PM, Shashidhara Veerabhadraiah wrote: Hi Prasanta, I have verified this on Windows 10 itself. Below

Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button

2017-07-24 Thread Prasanta Sadhukhan
*From:*Prasanta Sadhukhan *Sent:* Monday, July 24, 2017 3:43 PM *To:* Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com>; swing-dev@openjdk.java.net *Cc:* Philip Race <philip.r...@oracle.com>; Sergey Bylokhov <sergey.bylok...@oracle.com> *Subject:* Re:

Re: [10] RFR JDK-8075063:Context menu closes on mouse scroll

2017-06-28 Thread Prasanta Sadhukhan
Is there anything more to be done? Can I commit this? Regards Prasanta On 6/18/2017 8:01 PM, Prasanta Sadhukhan wrote: Fair enough suggestion, modified webrev to never ungrab for wheel event http://cr.openjdk.java.net/~psadhukhan/8075063/webrev.02/ Regards Prasanta On 6/16/2017 9:37 PM

Re: [10] RFR: 8182577: Crash when Tab key moves focus to a JCheckbox with a custom ButtonModel

2017-06-29 Thread Prasanta Sadhukhan
Since CSR is approved, and if there is no objection to this, I will commit this fix today. Regards Prasanta On 6/29/2017 10:37 AM, Prasanta Sadhukhan wrote: Modified JToogleButton.getGroupSelection() to remove check-and-cast to DefautlButtonModel since we have added getGroup() to ButtonModel

[10] RFR JDK-8175968: The javax.swing.filechooser.FileSystemView constructor consumes memory by adding a PropertyChangeListener that is never removed.

2017-07-04 Thread Prasanta Sadhukhan
Hi All, Please review a fix for a memory leak issue where PropertyChangeListener object added by FileSystemView constructor is never removed. Proposed fix is to add dispose() method to be called by app when they want to remove this resource. Bug:

[10] RFR JDK-7190539:Nimbus LaF: JPopupMenu reacts on Ctrl+Enter.

2017-07-03 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where when a JPopupMenu is displayed, an underlying Default JButton still responds to the CTRL-ENTER keystroke for NimbusLookAndFeel. This is a continuation to JDK-4870644 fix where it is fixed for Basic L The problem there was that we do not override

Re: [10] RFR JDK-7190539:Nimbus LaF: JPopupMenu reacts on Ctrl+Enter.

2017-07-03 Thread Prasanta Sadhukhan
Modified testcase to iterate over all installed l and extended fix to Motif L too. http://cr.openjdk.java.net/~psadhukhan/7190539/webrev.01/ Regards Prasanta On 7/3/2017 1:21 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where when a JPopupMenu is displayed

  1   2   3   4   5   6   7   >