+1
--Semyon
On 10/8/18 12:34 PM, Phil Race wrote:
Hi,
I've looked over the code and tested on Ubuntu 18.04 and can confirm
it works
as well as the JDK 11 code does.
I reproduced the problems Semyon noted that are present on JDK 11 as
well.
The UI hang when switching themes is not specif
Hello,
Please review a fix for JDK 12.
JBS: https://bugs.openjdk.java.net/browse/JDK-8218473
webrev: http://cr.openjdk.java.net/~ssadetsky/8218473/webrev.00/
This is a JCK test failure fix. The test fails under the GTKLookAndFeel
on Linux platforms with gtk+-3.20+ library installed.
Startin
Hello,
Please review a fix for JDK 12.
JBS: https://bugs.openjdk.java.net/browse/JDK-8218479
webrev: http://cr.openjdk.java.net/~ssadetsky/8218479/webrev.00/
This is a JCK test failure fix. The test fails under the GTKLookAndFeel
on Linux platforms with gtk+-3.20+ library installed.
Startin
bugs:
https://bugs.openjdk.java.net/browse/JDK-8153090
https://bugs.openjdk.java.net/browse/JDK-8223788
https://bugs.openjdk.java.net/browse/JDK-8224149
webrev: http://cr.openjdk.java.net/~ssadetsky/8153090/webrev.00/
The fix eliminates issues in JColorChooser dialog making it more
accessibl
On 5/20/19 11:04 AM, Philip Race wrote:
Hi,
I'm afraid I know next to nothing about the focus traversal
code in Swing or AWT, but it smells very wrong to have
such knowledge of a specific Swing component in the
AWT focus code.
I don't see anything wrong here. You can find a lot of Swing compone
JBS: https://bugs.openjdk.java.net/browse/JDK-8196096
webrev: http://cr.openjdk.java.net/~ssadetsky/8196096/webrev.00/
This is a fix for an unstable test:
- inside EDT execution is ensured where necessary.
- To pass on the mac platform the check for lightweight popup is
excluded and the taskb
On 5/22/19 2:29 PM, Sergey Bylokhov wrote:
Hi, Semyon.
Why it s necessary to change the adjustPopupLocationToFit value? why
on macOS it does not work by default like on others platforms?
If I read an initial bug 6580930 correctly there was an intention that
HW popup should be able to overlap
On 5/20/19 11:48 PM, Prasanta Sadhukhan wrote:
Probably we can move this traversal code to
javax.swing.SortingFocusTraversalPolicy#SwingContainerOrderFocusTraversalPolicy
for this JToggleButton swing component to avoid this scepticism.
Hi Prasanta,
We cannot move it there because it'd not be c
On 5/22/19 3:15 PM, Sergey Bylokhov wrote:
On 22/05/2019 14:59, semyon.sadet...@oracle.com wrote:
On 5/22/19 2:29 PM, Sergey Bylokhov wrote:
Why it s necessary to change the adjustPopupLocationToFit value? why
on macOS it does not work by default like on others platforms?
If I read an initial
On 5/23/19 9:12 AM, Sergey Bylokhov wrote:
On 23/05/2019 08:58, semyon.sadet...@oracle.com wrote:
This property was introduced long before the macosx-port via
JDK-4425878.
If the test does not work properly because of the product bug, then
you should not work around it, but instead, you should
On 5/23/19 9:37 AM, Sergey Bylokhov wrote:
On 23/05/2019 09:28, semyon.sadet...@oracle.com wrote:
You just workaround the case for which the test was created, this is
not a test bug, and it should not be fixed by the change in the test
during test_sprint.
What product issue do you suggest to
webrev: http://cr.openjdk.java.net/~ssadetsky/7184956/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-7184956
Fix for a test: Mac light weigh popup testing excluded.
--Semyon
On 5/24/19 2:07 PM, Sergey Bylokhov wrote:
Hi, Semyon.
I am not sure that this is a test bug, the Aqua L&F uses HW popup by
default, but the case when the user requests LW popup for some reason
should work, it is just not implemented yet.
Hi Sergey,
I think your understanding of the lightWei
On 5/28/19 1:55 PM, Sergey Bylokhov wrote:
On 28/05/2019 09:19, semyon.sadet...@oracle.com wrote:
Hi Sergey,
I think your understanding of the lightWeightPopupEnabled property
purpose is not fully correct. The specification of the property is
very clear on that:
/**
* Sets the va
On 5/28/19 3:56 PM, Sergey Bylokhov wrote:
On 28/05/2019 15:19, semyon.sadet...@oracle.com wrote:
I guess the spec above is from the different method, which is not
used in the test? But as of the spec for
setDefaultLightWeightPopupEnabled()/getDefaultLightWeightPopupEnabled()
we of course wor
On 5/29/19 5:41 PM, Sergey Bylokhov wrote:
On 29/05/2019 08:58, semyon.sadet...@oracle.com wrote:
And why it shouldn't when the spec states the opposite? :
* Some look and feels might always use heavyweight popups,
* no matter what the value of this property.
Maybe the thing is th
On 6/3/19 1:07 PM, Phil Race wrote:
The test update tests the OS but if I understand correctly, it is the
Aqua L&F that does not support
lightweight popups. Can we check if it is Aqua rather than by OS ?
If you don't want to hard code Aqua then check if it is macos and
system L&F.
Ideally ther
Hi Sergey,
Please add also Ctrl+BackSpace (delete previous char) and
Command+BackSpace (delete previous word) keystrokes which are ignored in
Aqua as well.
--Semyon
On 6/3/19 5:16 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for JDK 13.
Bug: https://bugs.openjdk.java.net/browse
On 6/3/19 5:19 PM, Philip Race wrote:
I don't know how much I agree with the earlier email but this much is
true,
i.e. it doesn't make any practical difference to avoid running the
test in a different way.
The practical difference is the coverage. We avoid running only one
specific scenario of
On 6/4/19 7:24 PM, Sergey Bylokhov wrote:
Hi, Semyon.
I would like to investigate other macOS specific shortcuts in a
separate CR
What specifically you need to investigate? Those keystrokes work for all
other L&Fs.and I see no other actions mapped to them.
Please add also Ctrl+BackSpace (de
On 6/6/19 12:29 AM, Prasanta Sadhukhan wrote:
Hi Semyon,
I do not have much idea of focus traversal code but it seems when your
regression testcase is run, SwingContainerOrderFocusTraversalPolicy
does get called as I can see, so I see no harm in putting the code
there, given Phil's objection
bug: https://bugs.openjdk.java.net/browse/JDK-8226513
webrev: http://cr.openjdk.java.net/~ssadetsky/8226513/webrev.00/
The fix adds resetting the root view initialization flag when the text
component underling document is changed and also removes the check for
the zero component size for the r
Hello,
Please review the fix for JDK 9.
The component.isOpaque() is now taken into account in the XP System LAF
if it is available to do not render component background in case of FALSE.
Bug: https://bugs.openjdk.java.net/browse/JDK-8073454
Webrev:
http://cr.openjdk.java.net/~alexsch/semyon
fix updated:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8073454/webrev.02/
On 2/25/2015 2:14 PM, Semyon Sadetsky wrote:
Hello,
Please review the fix for JDK 9.
The component.isOpaque() is now taken into account in the XP System
LAF if it is available to do not render component
Finally determined as not an issue. The ticket will be closed.
On 2/26/2015 10:41 AM, Semyon Sadetsky wrote:
fix updated:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8073454/webrev.02/
On 2/25/2015 2:14 PM, Semyon Sadetsky wrote:
Hello,
Please review the fix for JDK 9.
The
Hello,
please review a fix for JDK 9.
Bug: https://bugs.openjdk.java.net/browse/JDK-4473075
Webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/4473075/webrev.00/
The thing is the general logic of the viewport layout requires the right
component size which is requested by the
content."
Also I think it is possible to write a test for this issue.
- semyon.sadet...@oracle.com wrote:
Hello,
please review a fix for JDK 9.
Bug: https://bugs.openjdk.java.net/browse/JDK-4473075
Webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/4473075/webrev.00/
The thing i
Regression test scenario was added. Please review the fix.
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/4473075/webrev.01/
2Sergey:
the garbage mentioned comments in the JBS is not reproducible anymore.
In any case it is another problem than the described in the bug header
Hello,
Please review the fix:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6894632/webrev.01/
for bug: https://bugs.openjdk.java.net/browse/JDK-6894632
The thing is the sorter logic uses its internal data structures to
restore selection when the table model has been changed.
For
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/4473075/webrev.02/
null check is not needed because isPreferredSizeSet() is true only if
preferred size is not null.
Others are accepted.
On 3/3/2015 1:09 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Just few comments
Hello,
the next JBS issue were closed as not an issue:
https://bugs.openjdk.java.net/browse/JDK-8073454
https://bugs.openjdk.java.net/browse/JDK-8065359
https://bugs.openjdk.java.net/browse/JDK-8055750
https://bugs.openjdk.java.net/browse/JDK-8050248
https://bugs.openjdk.java.net/browse/JDK-8042
synchronization is not necessary because the invokeAndWait() method
guarantee that the variable will never be accessed from EDT after it.
On 3/3/2015 4:45 PM, Alexander Scherbatiy wrote:
On 3/3/2015 3:30 PM, Semyon Sadetsky wrote:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/4473075
t has unsorted sort order but others do not.
Thanks,
Alexandr.
On 3/2/2015 5:47 PM, Semyon Sadetsky wrote:
Hello,
Please review the fix:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6894632/webrev.01/
for bug: https://bugs.openjdk.java.net/browse/JDK-6894632
The thing is the sorter logic
ame should be disposed at the end of the test.
Small issues, not necessary to be fixed:
- You can add @override to the new method
- The test can iterate over all supported l&f.
On 03.03.2015 16:53, Semyon Sadetsky wrote:
synchronization is not necessary because the invokeAndWait() method
g
the updated webrev
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/4473075/webrev.03/
On 3/4/2015 3:49 PM, Semyon Sadetsky wrote:
Hi Sergey,
Thank you for another fast review.
all comments are accepted exept for this:
> - The test can iterate over all supported l&f.
At first do y
Thank you Sergey.
Please review the corresponding CCC request:
http://ccc.us.oracle.com/4473075?edit
--Semyon
On 3/4/2015 11:28 PM, Sergey Bylokhov wrote:
On 04.03.2015 17:58, Semyon Sadetsky wrote:
the updated webrev
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/4473075/webrev.03
Hi Sergey,
Good catch! Yes it should be inverted.
I fix that and added more extensive test scenarios to double check
different table states.
Please review.
It's here:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6894632/webrev.02/
Thanks!
Semyon
On 3/6/2015 1:26 AM, Sergey Byl
Hi,
please review a fix for JDK9.
bug: https://bugs.openjdk.java.net/browse/JDK-8013566
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8013566/webrev.00/
User got here an infinite loop inside GroupLayout's auto-gap-insertion
mechanism that was triggered by getPreferre
On 3/10/2015 2:09 PM, Alexander Scherbatiy wrote:
What is the reason that the class of the manual inserted gap is
AutoPreferredGapSpring and not GapSpring?
According to comments in the code
*AutoPreferredGapSpring*
Spring reprensenting the distance between any number of sources and
targets.
On 3/10/2015 2:38 PM, Alexander Scherbatiy wrote:
*AutoPreferredGapSpring*
Spring reprensenting the distance between any number of sources and
targets. The targets and sources are computed during layout. An
instance of this can either be dynamically created when
autocreatePadding is true, or ex
Hi Alexander,
your remarks are taken into account :
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8013566/webrev.01/
jtreg result:
Execution successful
* javax/swing/GroupLayout/6613904/bug6613904.java
<../../JTwork/javax/swing/GroupLayout/6613904/bug6613904.
://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8013566/webrev.01/
jtreg result:
Execution successful
* javax/swing/GroupLayout/6613904/bug6613904.java
<../../JTwork/javax/swing/GroupLayout/6613904/bug6613904.jtr>:
javax.swing.GroupLayout.createParallelGroup(..) doesn&#
Hello,
please review fix for jdk9
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8040328/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8040328
Thanks,
--Semyon
Hi Sergey,
I couldn't find this 6494656 in jdk and jck test repositories.
How can I find it?
Thanks,
--Semyon
On 3/11/2015 8:05 PM, Sergey Bylokhov wrote:
Hi, Semyon.
Please confirm that the test for 6494656 completed successfully also.
11.03.15 4:01, Semyon Sadetsky wrote:
JCK run
I've found it. Thanks!
$ ~/jtreg/win32/bin/jtreg
-jdk:../build/windows-x86_64-normal-server-fastdebug/jdk/
test/closed/javax/swing/GroupLayout/UnitTest
Test results: passed: 1
--Semyon
On 3/12/2015 9:35 AM, Semyon Sadetsky wrote:
Hi Sergey,
I couldn't find this 6494656 in jdk an
javadoc to the introduced JTableHeader.getPreferredSize() was changed
according to Phil's corrections:
The last webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/4473075/webrev.04/
On 3/4/2015 11:28 PM, Sergey Bylokhov wrote:
On 04.03.2015 17:58, Semyon Sadetsky wrote:
Hello,
please review JDK9 fix:
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8041642/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8041642
Nimbus uses hard-coded images of 27x19 size for progress bar which is
stretched using 9-squares caching algorithm.
The image
Reg test is updated because it failed on OSX platform:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8040328/webrev.01/
On 3/12/2015 12:43 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 3/12/2015 8:59 AM, Semyon Sadetsky wrote:
Hello,
please
That's correct. Because with the insets left+right=5+5px those values
are <10px and cannot be painted.
The bar style image contains a gradient pattern along with transparent
shadows for the bar margins. The squeezing will distort it and user will
see a different pattern. That was the point of bu
Hello,
please review JDK9 fix
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8075314/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8075314
Thanks!
--Semyon
Hello,
Please review JDK9 fix.
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6921687/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-6921687
Thanks!
--Semyon
Hello,
Please review JDK9 fix.
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6866751/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-6866751
Thanks!
--Semyon
+description
When ALT PRESSED event comes for the second time it can be the case to
clear menu focus and srokes or the case when ALT+key combination is
about to be pressed. The last one was missed in the ALT key handler.
On 3/23/2015 2:22 PM, Semyon Sadetsky wrote:
Hello,
Please review
+description
A check for the closed state of the previous topmost window is added for
the top window selection procedure.
On 3/23/2015 1:58 PM, Semyon Sadetsky wrote:
Hello,
please review JDK9 fix
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8075314/webrev.00/
bug: https
+description
Cursor size is added to any text control preferred width.
On 3/23/2015 2:33 PM, Semyon Sadetsky wrote:
Hello,
Please review JDK9 fix.
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6866751/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-6866751
Thanks
components will
receive large right padding.
--Semyon
23.03.15 14:57, Semyon Sadetsky wrote:
+description
Cursor size is added to any text control preferred width.
On 3/23/2015 2:33 PM, Semyon Sadetsky wrote:
Hello,
Please review JDK9 fix.
webrev:
http://cr.openjdk.java.net/~alexsch/se
On 3/23/2015 5:36 PM, Alexander Scherbatiy wrote:
On 3/23/2015 2:22 PM, Semyon Sadetsky wrote:
Hello,
Please review JDK9 fix.
webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6921687/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-6921687
- What was the reason
functionality was tested on all supported look and feels and the new
test always passed. So I suggest to change the test and cover all l&f,
to be sure that this bug will not be integrated back in some other/new
looks and feels.
23.03.15 13:58, Semyon Sadetsky wrote:
Hello,
please review JDK9 fix
we
Hi Sergey,
I have added reading of the client property. It will also allow user to
adjust the right margin for caret. The test scenario is also extended.
the updated webrev: http://cr.openjdk.java.net/~ssadetsky/6866751/webrev.01/
--Semyon
On 3/24/2015 9:10 AM, Semyon Sadetsky wrote:
Hi
Sadetsky wrote:
Hi Sergey,
Good catch! Yes it should be inverted.
I fix that and added more extensive test scenarios to double check
different table states.
Please review.
It's here:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6894632/webrev.02/
Thanks!
Semyon
On 3/6/2015 1:
batiy wrote:
On 4/1/2015 5:45 PM, Semyon Sadetsky wrote:
Hi Sergey,
I have added reading of the client property. It will also allow user
to adjust the right margin for caret. The test scenario is also
extended.
the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/6866751/webrev.01/
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-7072653
webrev: http://cr.openjdk.java.net/~ssadetsky/7072653/webrev.00/
*THE ROOT CAUSE
Incorrect bounds calculation of heavy weight popup window in the
BasicComboPopup when the requested popup menu height exceed
Subject corrected.
On 4/16/2015 3:55 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-7072653
webrev: http://cr.openjdk.java.net/~ssadetsky/7072653/webrev.00/
*THE ROOT CAUSE
Incorrect bounds calculation of heavy weight popup window
Hello,
please review a fix for JDK9:
webrev: http://cr.openjdk.java.net/~ssadetsky/7172652/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-7172652
***ROOT CAUSE
This is a bug in Label UI's key release event processing routine for key
mnemonics: only one release event is captured inste
Hello,
Please review JDK9 fix:
webrev: http://cr.openjdk.java.net/~ssadetsky/7190544/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-7190544
***ROOT CAUSE
The divider size field is not set for the split pane UI during Synth
style initialization.
***SOLUTION
Set the field.
***TESTIN
variable.
borderHeight looks strange to me, it is initialized with left and
right insets(related to width) and then used as height.
The test uses full screen bounds and does not subtracts screen insets.
Thanks,
Alexander.
On 04/16/2015 04:14 PM, Semyon Sadetsky wrote:
Subject corrected.
On
above the combo.
--Semyon
On 4/22/2015 2:33 PM, Alexander Scherbatiy wrote:
On 4/21/2015 5:31 PM, Semyon Sadetsky wrote:
Hi Alexander,
Thanks for the review.
The updated webrev:
http://cr.openjdk.java.net/~ssadetsky/7072653/webrev.01/
1299 if (py + ph > screenBound
Hello,
Please review fix for JDK9:
web rev: http://cr.openjdk.java.net/~ssadetsky/6260348/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-6260348
***ROOT CAUSE
GTK L&F never took care about native GTK cursor blink settings.
***SOLUTION
Implement this feature.
***TESTING
Two test scen
Hello,
Please review fix for JDK9:
webrev: http://cr.openjdk.java.net/~ssadetsky/8078483/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8078483
***ROOT CASE
Text component root view should receive the component dimension without
margins.
The caret margin introduced in
https://bugs.o
Hello,
Please review JDK9 fix.
webrev: http://cr.openjdk.java.net/~ssadetsky/8001470/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8001470
***ROOT CAUSE
The setVisible() call without pack() or setBounds() means set the frame
size to the initial window size. The initial window size u
On 4/27/2015 4:58 PM, Alexander Scherbatiy wrote:
On 4/23/2015 2:02 PM, Semyon Sadetsky wrote:
Updated fix: http://cr.openjdk.java.net/~ssadetsky/7072653/webrev.02/
(Aqua LnF had own logic need to be fixed as well as it was noticed by
Alexander Z.)
Alexander,
This is because the
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8079640
webrev: http://cr.openjdk.java.net/~ssadetsky/8079640/webrev.00/
*THE ROOT CAUSE
Component minimum size is limited to Short.MAX_VALUE in GroupLayout.
JDK turtorial
https://docs.oracle.com/javase/tutorial/u
Hi Alexander,
gboolean and gint are equivalent.
--Semyon
On 4/27/2015 5:31 PM, Alexander Scherbatiy wrote:
On 4/23/2015 5:23 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
web rev: http://cr.openjdk.java.net/~ssadetsky/6260348/webrev.00/
bug: https://bugs.openjdk.java.net
modifiers)
Thanks,
Alexandr.
On 4/20/2015 5:53 PM, Semyon Sadetsky wrote:
Hello,
please review a fix for JDK9:
webrev: http://cr.openjdk.java.net/~ssadetsky/7172652/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-7172652
***ROOT CAUSE
This is a bug in Label UI's key release
Alexander, thanks. all is relevant.
http://cr.openjdk.java.net/~ssadetsky/7172652/webrev.02/
--Semyon
On 5/13/2015 6:06 PM, Alexander Scherbatiy wrote:
On 5/8/2015 12:13 PM, Semyon Sadetsky wrote:
updated: http://cr.openjdk.java.net/~ssadetsky/7172652/webrev.01/
- Should the labelFor
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8078269
webrev: http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.00/
This is regression of the 8007563 which was incorrect fix of the 4690946
regression.
Actually the 4690946 was a test bug because tab area's
color of component
explicitly to the value other than from UI property?
On 14.05.15 17:12, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8078269
webrev: http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.00/
This is regression of the
On 5/15/2015 2:06 PM, Sergey Bylokhov wrote:
On 14.05.15 18:00, Semyon Sadetsky wrote:
Sergey,
Why the component background priority looks reasonable for you?
Because otherwise there is no way to change the color of one
particular component.
A component has only one background color which is
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8078514
webrev: http://cr.openjdk.java.net/~ssadetsky/8078514/webrev.00/
The 6894632 fix violated a contract between the table and its row
sorter: the sorter should receive TableChanged events even if table is
no
updated also.
On 08.05.15 11:47, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8079640
webrev: http://cr.openjdk.java.net/~ssadetsky/8079640/webrev.00/
*THE ROOT CAUSE
Component minimum size is limited to Short.MAX_VALUE in GroupLayout
JDK-8080604 created.
On 5/18/2015 4:20 PM, Sergey Bylokhov wrote:
Looks fine then.
Please file a separate issue to update tutorial.
On 18.05.15 15:19, Semyon Sadetsky wrote:
Sergey,
I have dug into the SCCS history. This was set initially and was not
related to any issues.
--Semyon
On 5
ue it
can leads to the integer overflow.
May be Integer.MAX_VALUE / 2 can be used instead of Short.MAX_VALUE?
Thanks,
Alexandr.
On 5/18/2015 3:19 PM, Semyon Sadetsky wrote:
Sergey,
I have dug into the SCCS history. This was set initially and was not
related to any issues.
--Semyon
O
e the test and add noreg-hard label to the issue.
--
Thanks,
Alexander.
On 23.04.2015 17:23, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
web rev: http://cr.openjdk.java.net/~ssadetsky/6260348/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-6260348
***ROOT CAUSE
GTK L&am
INFINITE is a bit inaccurate name.
Personally, I think that there is no need in extra variable here.
Why just not inline MAX_VALUE / 2 (with comment about integer
overflow) into constrain()?
Thanks,
Alexander.
On 05/19/2015 05:38 PM, Semyon Sadetsky wrote:
Alexander, thanks that's true.
.
--Semyon
On 5/19/2015 2:03 PM, Alexander Scherbatiy wrote:
On 5/15/2015 5:49 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8078514
webrev: http://cr.openjdk.java.net/~ssadetsky/8078514/webrev.00/
DefaultRowSorter
221
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8075785
webrev: http://cr.openjdk.java.net/~ssadetsky/8075785/webrev.00/
*.disabledText properties are not suported in in Windows Classic L&F &
Windows XP L&F.
In the fix the properties remain optional but are tak
khov wrote:
Hi, Semyon.
Why not set this properties in the look and feel to the same color as
"Button.shadow" and use it WindowsGraphicsUtils?
On 28.05.15 18:29, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-
Hi Sergey,
as agreed I've added UIResource check:
http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.01/
--Semyon
On 5/15/2015 3:10 PM, Semyon Sadetsky wrote:
On 5/15/2015 2:06 PM, Sergey Bylokhov wrote:
On 14.05.15 18:00, Semyon Sadetsky wrote:
Sergey,
Why the component backg
On 6/8/2015 8:33 PM, Sergey Bylokhov wrote:
On 08.06.15 20:29, Sergey Bylokhov wrote:
On 08.06.15 16:33, Semyon Sadetsky wrote:
Hi Sergey,
as agreed I've added UIResource check:
http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.01/
Note that null value is not a UIResource
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8098835
webrev: http://cr.openjdk.java.net/~ssadetsky/8098835/webrev.00/
It is regression of https://bugs.openjdk.java.net/browse/JDK-6866751.
Some important palaces in the BasicTextUI where width should be
increa
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8076164
webrev: http://cr.openjdk.java.net/~ssadetsky/8076164/webrev.00/
It is a regression from 6973777. In 6973777 GlyphView minimum span with
calculation was changed to use text wrapping into several lines. Tha
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8129830
webrev: http://cr.openjdk.java.net/~ssadetsky/8129830/webrev.00/
It is not possible to insert a tree node as a last child of any parent
using Drag&Drop because the node is inserted as a sibling after the
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8129940
webrev: http://cr.openjdk.java.net/~ssadetsky/8129940/webrev.00/
It is a regression from 8033699. In this fix focus traversal keys were
hard-coded in JRadioButton to be TAB and SHIFT+TAB only. But those ke
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8081484
webrev: http://cr.openjdk.java.net/~ssadetsky/8081484/webrev.00/
Frame need to be re-layouted after the caret with changed.
--Semyon
ified to return
keys != null && keys.contains(stroke)
Thanks,
Alexandr.
On 6/26/2015 4:22 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8129940
webrev: http://cr.openjdk.java.net/~ssadetsky/8129940/webrev.00/
It is a regr
Sorry, I forget to add the link:
http://cr.openjdk.java.net/~ssadetsky/8129940/webrev.01/
On 7/2/2015 3:53 PM, Semyon Sadetsky wrote:
Hi Alexander,
1. It seems bug8075609.java is wrong . Tab key should not move focus
to the next option in the group.
2. I have changed the if-statement to
Scherbatiy wrote:
The fix looks good to me.
Just update the copyright in the test, use Swing component on EDT
and format the code.
Thanks,
Alexandr.
On 6/25/2015 5:27 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8076164
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8130735
webrev: http://cr.openjdk.java.net/~ssadetsky/8130735/webrev.00/
The root cause is the setting larger expiration time for the timer which
is already inserted into the delay queue. So all timers behind the
looks good to me.
Thanks,
Alexandr.
On 6/16/2015 8:27 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8098835
webrev: http://cr.openjdk.java.net/~ssadetsky/8098835/webrev.00/
It is regression of https://bugs.openjdk.java.net/browse
ander.
On 07/09/2015 08:08 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8130735
webrev: http://cr.openjdk.java.net/~ssadetsky/8130735/webrev.00/
The root cause is the setting larger expiration time for the timer
which is already
1 - 100 of 675 matches
Mail list logo
