Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-29 Thread Troy A. Griffitts
OK, looked at the patch. Not sure what the strip filters are being added for. Any comments? Jonathan Marsden wrote: Greg Hellings wrote: I have some patches on crosswire.org/~ghellings that used to apply back in about r2150 range. OK, I just grabbed it and beat it into submission a

Re: [sword-devel] Release-critical TODO items

2009-04-29 Thread Troy A. Griffitts
Yeah yeah. I know I know. It's been a hard decision, but I've held back on another RC as we've still been getting patch submissions for RC2. Can't very well justify calling something Release Candidate 3 until patch submission start dying down. That's my reasoning for the wait, anyway. But

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-29 Thread Greg Hellings
On Wed, Apr 29, 2009 at 2:32 AM, Troy A. Griffitts scr...@crosswire.org wrote: OK, looked at the patch.  Not sure what the strip filters are being added for.  Any comments? My only comment is that the seem to already have been applied some time ago. I had put them in there so that all the

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-29 Thread Troy A. Griffitts
Dear Greg, I don't understand :) Looking at the current SVN code, there are no strip filters at all (and I can't think of any reason there should be-- but maybe I'm overlooking something). There is one filter in there, but all uses of it are commented out, so I believe someone was just

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-29 Thread Greg Hellings
Troy, Excuse the late hour - I thought you mean the changes I had in my patchset for the the filters in the library. I should have remembered... they weren't even part of the patch Jonathan used, seeing as they were incorporated into the engine some time ago. Since it's past 3 AM for me and I

Re: [sword-devel] Release-critical TODO items (update 2009-04-29)

2009-04-29 Thread Jonathan Marsden
Troy A. Griffitts wrote: It's been a hard decision, but I've held back on another RC as we've still been getting patch submissions for RC2. Can't very well justify calling something Release Candidate 3 until patch submission start dying down. That's my reasoning for the wait, anyway. I

Re: [sword-devel] Release-critical TODO items (update 2009-04-29)

2009-04-29 Thread Matthew Talbert
5) Does it build OK under mingw? Did someone already confirm or deny this? It builds under mingw. Troy has committed my patches for sword, utilities, and tests so they all compile and work. Matthew ___ sword-devel mailing list:

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread Jonathan Marsden
Greg Hellings wrote: I have some patches on crosswire.org/~ghellings that used to apply back in about r2150 range. OK, I just grabbed it and beat it into submission a little... now it applies to svn head :) New version is at http://computeroptions.net/sword/mod2osis-new.diff Now to test

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread Greg Hellings
On Mon, Apr 27, 2009 at 1:00 AM, Jonathan Marsden jmars...@fastmail.fm wrote: Greg Hellings wrote: I have some patches on crosswire.org/~ghellings that used to apply back in about r2150 range. OK, I just grabbed it and beat it into submission a little... now it applies to svn head :)  New

Re: [sword-devel] Release-critical TODO items

2009-04-27 Thread Ben Morgan
On Mon, Apr 27, 2009 at 2:39 PM, Jonathan Marsden jmars...@fastmail.fmwrote: 3) SWIG issues and related segfaults (Ben) This came with r2313, and I'm at a loss how to deal with it... Python program (this worked r2312, crashes r2313): import Sword Sword.VerseKey() valgrind gives this (as well

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread Jonathan Marsden
Greg Hellings wrote: The way I tested it was to create a .conf file for KJVTEST and export KJV with it, then import to the KJVTEST directory. Then run either a script or even write a program to compare the output of KJV and KJVTEST across all the verses, with all the options enabled, to see

Re: [sword-devel] Release-critical TODO items

2009-04-27 Thread Troy A. Griffitts
Ben, I know you realize this, but we're at 2349 now. I realize the revision you're giving is the first revision you see the troubles, but I just want to make sure you're seeing the troubles with 2349. I just ran valgrind against a basic test that instantiates a few VerseKey objects and

Re: [sword-devel] Release-critical TODO items

2009-04-27 Thread Ben Morgan
Sorry, I found the problem. SWIG was being defined while building, so it was ommitting a part of the versekey definition. Sorry about that. It needs a #ifndef SWIG around that mutable inline struct in versekey.h as SWIG can't understand this. God Bless, Ben

Re: [sword-devel] Release-critical TODO items

2009-04-27 Thread Troy A. Griffitts
Hey Ben, I changed things to a more traditional 2 step declaration/definition on that anonymous struct in VerseKey. Please let me know if this helps swig, or if I still need to do something for you. -Troy. Ben Morgan wrote: Sorry, I found the problem. SWIG was being defined while

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread Gregory Hellings
On Apr 27, 2009, at 2:01, Jonathan Marsden jmars...@fastmail.fm wrote: Greg Hellings wrote: The way I tested it was to create a .conf file for KJVTEST and export KJV with it, then import to the KJVTEST directory. Then run either a script or even write a program to compare the output of

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread DM Smith
On Apr 27, 2009, at 3:01 AM, Jonathan Marsden wrote: Greg Hellings wrote: The way I tested it was to create a .conf file for KJVTEST and export KJV with it, then import to the KJVTEST directory. Then run either a script or even write a program to compare the output of KJV and KJVTEST across

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread Jonathan Marsden
DM Smith wrote: I am. You can get the input text from www.crosswire.org/~dmsmith/kjv2006. Aha! Thanks, I'll try it tonight. BTW, wouldn't putting this URL somewhere in the kjv.conf file be both useful and appropriate? Note, some of the transformations by osis2mod create a module that

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread Greg Hellings
On Mon, Apr 27, 2009 at 6:48 PM, Jonathan Marsden jmars...@fastmail.fm wrote: DM Smith wrote: I am. You can get the input text from www.crosswire.org/~dmsmith/kjv2006. Aha!  Thanks, I'll try it tonight.  BTW, wouldn't putting this URL somewhere in the kjv.conf file be both useful and

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread DM Smith
On Apr 27, 2009, at 8:09 PM, Greg Hellings wrote: On Mon, Apr 27, 2009 at 6:48 PM, Jonathan Marsden jmars...@fastmail.fm wrote: Longer term, this need for strange transformations looks to me like a problem that stems from an inadequate or incomplete underlying book representation in SWORD

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread Jonathan Marsden
DM Smith wrote: BTW, wouldn't putting this URL somewhere in the kjv.conf file be both useful and appropriate? Perhaps, but the location is temporary and I've documented it on the wiki. It'd be better to put it in a more permanent place first. Good point. Maybe

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread DM Smith
On Apr 27, 2009, at 8:53 PM, Jonathan Marsden wrote: DM Smith wrote: BTW, wouldn't putting this URL somewhere in the kjv.conf file be both useful and appropriate? Perhaps, but the location is temporary and I've documented it on the wiki. It'd be better to put it in a more permanent place

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread Troy A. Griffitts
Greg Hellings wrote: Longer term, this need for strange transformations looks to me like a problem that stems from an inadequate or incomplete underlying book representation in SWORD itself? That may be something for SWORD 2.x, not 1.6 :) I'm an advocate of this - but there is strong feeling

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread DM Smith
On Apr 27, 2009, at 7:48 PM, Jonathan Marsden wrote: DM Smith wrote: I am. You can get the input text from www.crosswire.org/~dmsmith/kjv2006 . Aha! Thanks, I'll try it tonight. BTW, wouldn't putting this URL somewhere in the kjv.conf file be both useful and appropriate? Perhaps, but

Re: [sword-devel] Release-critical TODO items (updated mod2osis patch)

2009-04-27 Thread Daniel Owens
DM Smith wrote: On Apr 27, 2009, at 8:09 PM, Greg Hellings wrote: On Mon, Apr 27, 2009 at 6:48 PM, Jonathan Marsden jmars...@fastmail.fm wrote: Longer term, this need for strange transformations looks to me like a problem that stems from an inadequate or incomplete underlying book

[sword-devel] Release-critical TODO items

2009-04-26 Thread Jonathan Marsden
Troy A. Griffitts wrote: Is there is list of all known release-critical bugs and TODO items somewhere? No, the bugtracker is clean now for critical 1.6.x changes, as far as I know (right?). We're only fixing feedback we get on the RCs now. The only outstanding issue of which I know is the

Re: [sword-devel] Release-critical TODO items

2009-04-26 Thread Greg Hellings
On Sun, Apr 26, 2009 at 11:39 PM, Jonathan Marsden jmars...@fastmail.fm wrote: Troy A. Griffitts wrote: Is there is list of all known release-critical bugs and TODO items somewhere? No, the bugtracker is clean now for critical 1.6.x changes, as far as I know (right?).  We're only fixing