Re: [sword-devel] poetry formatting (was Re: Vertical whitespace)

2013-02-03 Thread Nic Carter
Reading the OSIS stuff at http://crosswire.org/wiki/OSIS_Bibles#Marking_poetic_material it says: • While OSIS defines a milestoned version of the lg element, its use (rather than the container version) will not produce a valid XML document. The l element can only occur within an lg

Re: [sword-devel] poetry formatting (was Re: Vertical whitespace)

2013-02-03 Thread Nic Carter
Thanks heaps for this, Ben :) Appears I had a little bug in the previous patch I emailed around. When closing the div on line 379 of osishtmlhref.cpp I had added a br / which shouldn't be there! I like how you have BPBible displaying this stuff, and so it's inspired me to fix up some of the

Re: [sword-devel] poetry formatting (was Re: Vertical whitespace)

2013-02-03 Thread Ben Morgan
Some of it is going to require CSS support anyway to do the layout. If there's just a div with a CSS class, frontends can handle that as they require, and the indenting support shouldn't cause an issue. BTW, with the Proverbs 28 issue, my guess is the opening lg is a few chapters earlier. In the

Re: [sword-devel] poetry formatting (was Re: Vertical whitespace)

2013-02-02 Thread Nic Carter
It's been a while since I created a diff file, so I'm fairly rusty.Note that I've simply done a direct diff from my working copy of osishtmlhref.cpp and so it has some of my other hacks in there as well. Pick and choose the pieces you want. :)#worksforme#takeitorleaveit poetryFormatting.diff

Re: [sword-devel] poetry formatting (was Re: Vertical whitespace)

2013-02-02 Thread Ben Morgan
Hi Nic, Structural content in verse 0 is another good example why you shouldn't turn introductions off - I think they should always be on, just the headings inside them (when non-canonical) should be able to be turned off. As for floating the whitespace around, this is a post-process and mostly

[sword-devel] poetry formatting (was Re: Vertical whitespace)

2013-02-01 Thread Nic Carter
Thanks heaps for this :) I'm getting there, but have encountered a few interesting bits. I'm using the ESV and something I just realised was that Psalm 1 only had a closing lg tag at the end of verse 6 no opening tag: lg eID=w106/ I couldn't find the opening one anywhere in the chapter.