Re: [sword-devel] swld.cpp at line 111 - is this a bug?

2016-10-11 Thread Jaak Ristioja
Hi!

On 12.10.2016 01:08, TS wrote:
> Xcode was warning me that in PocketSword's Sword framework, swld.cpp at
> line 111 with
> 
> "delete buf;"
> may be wrong and it should perhaps be
> 
> "delete[] buf;"
> instead. Is this correct? I looked at the code and I think Xcode is
> correct in that the variable is an array and needs the brackets to
> delete properly.

Yes, Xcode has it correct. It should be `delete[] buf;`. This was also
fixed in Sword++ in March.

Many blessings,
J

___
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page


Re: [sword-devel] How can I tell which version of the Sword framework is being used? (e.g. in PocketSword)

2016-10-11 Thread Greg Hellings
There should be a file, include/swversion.h or the like, that will
tell you. But PocketSword maintains a dose of patches against the
library, if memory serves, so you won't find an exact match with the
stated version. But that file should give you the information you're
looking for.

--Greg

On Tue, Oct 11, 2016 at 6:13 PM, TS  wrote:
> Hi,
>
> How can I tell which version of the Sword framework is being used? ( e.g. in
> PocketSword.) I've done a search of the code and some comparison to two
> different versions of the framework, but nether version 1.7.5 nor 1.6.2 seem
> to match. Is there a place where it's stated?
>
> -TS
>
> ___
> sword-devel mailing list: sword-devel@crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page

___
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page


[sword-devel] How can I tell which version of the Sword framework is being used? (e.g. in PocketSword)

2016-10-11 Thread TS

Hi,

How can I tell which version of the Sword framework is being used? ( e.g. in 
PocketSword.) I've done a search of the code and some comparison to two 
different versions of the framework, but nether version 1.7.5 nor 1.6.2 seem to 
match. Is there a place where it's stated?

-TS
___
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page

[sword-devel] swld.cpp at line 111 - is this a bug?

2016-10-11 Thread TS

Hi,

Xcode was warning me that in PocketSword's Sword framework, swld.cpp at line 
111 with

"delete buf;"
may be wrong and it should perhaps be

"delete[] buf;"
instead. Is this correct? I looked at the code and I think Xcode is correct in 
that the variable is an array and needs the brackets to delete properly.

-TS
___
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page

Re: [sword-devel] Announcing Sword++

2016-10-11 Thread Konstantin Maslyuk
I would like API that you can't even thought to make wrapper around that.

It is not healthy thing to make wrapper around API for convenience of fixing 
when it becomes broken or deprecated. And I want to keep fewer chain links in 
system, spend my energy on something useful for anyone else but me.


Blessings.

-Исходное сообщение-
От: "Manfred Bergmann" 
Отправлено: ‎03.‎10.‎2016 15:08
Кому: "SWORD Developers' Collaboration Forum" 
Тема: Re: [sword-devel] Announcing Sword++

If you want a nice new, clean and convenient API, why don’t you build one on 
top of the current API?




Manfred




Am 28.09.2016 um 16:49 schrieb Konstantin Maslyuk :


Thank you, Jaak, for your good starting. I still hope that your knowledge in 
C++ development and Troy's experience in Sword development would unite in 
development of next major libsword iteration (reword libsword2). I think you 
both have many great ideas for that. 

I also expect from libsword2 more convenient api. Since we managed to work with 
existing, it leave many questions and unobvious things (SWMgr that is actually 
iterator, Upper/Lower bound that do not say where is module beginning for new 
ones). A lot of code in Sword is hard to maintain, only few people knows how it 
actually works. It is not look like good C++ code. And it will never evolve if 
we will focus on elder devices.

So I suggest to not extinguish any kind of energy here but to support. It is so 
little here.

As for me, i like elder devices, and at this moment they are in my priority.


Blessings.


От: Jaak Ristioja
Отправлено: ‎25.‎09.‎2016 21:56
Кому: SWORD Developers' Collaboration Forum
Тема: [sword-devel] Announcing Sword++


Hello!

Sometime in May this year my efforts to improve the Sword library as the
backend for BibleTime led me to create branch or fork of the Sword
codebase, which I eventually called Sword++. The main goals for this
were to (with respect to BibleTime development) improve the API, build
system and overall code quality, modernize, and to try to fix any bugs I
find when refactoring and reviewing the code. With experience as a C++
backend engineer and being no Sword expert, my refactoring effort also
serves the purpose of educating myself about Sword and its internals.
While I'm just starting out and have barely touched the amount of work
that needs to be done, I've already accumulated over 200 new commits to
the Sword++ repository so far. So this seems to be a more-or-less
reasonable time to publicly announce my publicly before the situation
gets too awkward.

Before I proceed, I want to emphasize that none of this is meant to
split or even stir up anything negative in the community. However,
Sword++ is an initiative to stop and reverse the current bit-rot; it is
more of a rescue effort and not a rebel event. Due to the sheer amount
of work that needs to and can be done to reach these goals, it is
evidently impractical for me to push and wait for every such change to
work its way through the issue tracker and/or sword-devel and reach SVN
trunk. To work around this costly threshold for contributing to the
Sword library, Sword++ is now here.

Sword++ is not officially related to CrossWire. The code currently lives
at https://github.com/swordxx/swordxx and as the initiator I'm currently
idling alone on the #sword++ channel on FreeNode IRC. Feel free to
contribute, file bug reports, pull requests etc. Also feel free to
cherry-pick or merge any fixes back to Sword. I don't think I will (or
have time to) flood sword-devel with emails about every bug (or
technical, design or architectural issue) I find. I will try to notify
about most severe security issues. Follow the git log if you're interested.

The code is in sync with enhancements in the Sword SVN trunk and for now
I'll try to keep it that way, although I've changed the layout of source
files etc extensively which makes merging harder. I'm currently
targeting standard C++14, POSIX and Linux, with everything else having
lower priority due to Sword++ currently having only one active
developer. I've also dropped all the language bindings (which I don't
intend on maintaining together with the Sword++ master branch), a bunch
of legacy and unused code, tools and utilities etc. MSVC project files
and autotools were dropped from the build system, which is now only
based on CMake. Ftplib support was also dropped, cURL, CLucene 2, bzip2,
xz and zlib are now unconditionally required by Sword++. There are also
some API changes so switching from Sword to Sword++ requires some
effort. See the git log for details and more.

There is a lot of uncertainty because this is just the beginning of the
process. Currently Sword++ must be considered unstable. I haven't tested
it much at runtime. I'm mostly doing code review, modernizing, fixing
bugs and compiler warnings and static analysis warnings,
despaghettification and deduplication of code,