Re: [sympy] Idea for PR reviewing

2016-09-15 Thread Ondřej Čertík
I went there: https://github.com/sympy/sympy/settings/branches/master and checked "Require pull request reviews before merging" (including administrators), then reviewed & approved this PR: https://github.com/sympy/sympy/pull/11601 But it says "Required statuses must pass before merging". But

Re: [sympy] Idea for PR reviewing

2016-09-14 Thread Aaron Meurer
I can't tell. Like I said, the UI is pretty confusing. We'll have to play around with it. Aaron Meurer On Wed, Sep 14, 2016 at 9:31 PM, Ondřej Čertík wrote: > I was just about to post here: > > https://github.com/blog/2256-a-whole-new-github-universe- >

Re: [sympy] Idea for PR reviewing

2016-09-14 Thread Ondřej Čertík
I was just about to post here: https://github.com/blog/2256-a-whole-new-github-universe-announcing-new-tools-forums-and-features Will this make it obvious when a PR is waiting for the author to do more work, and can the author "flip a switch" and we can quickly see that the work got done?

Re: [sympy] Idea for PR reviewing

2016-09-14 Thread Aaron Meurer
So it looks like GitHub has added direct support for this. The UI so far is a little confusing. Hopefully they will improve that. Aaron Meurer On Thu, Sep 8, 2016 at 3:59 PM, Jason Moore wrote: > I agree that closing is not a good idea. > > > Jason > moorepants.info > +01

Re: [sympy] Idea for PR reviewing

2016-09-08 Thread Jason Moore
I agree that closing is not a good idea. Jason moorepants.info +01 530-601-9791 On Thu, Sep 8, 2016 at 12:15 PM, Ondřej Čertík wrote: > On Thu, Sep 8, 2016 at 12:09 PM, Aaron Meurer wrote: > > I'm not a fan of that. Closing gives people the

Re: [sympy] Idea for PR reviewing

2016-09-08 Thread Ondřej Čertík
On Thu, Sep 8, 2016 at 12:09 PM, Aaron Meurer wrote: > I'm not a fan of that. Closing gives people the impression that the pull > request is being rejected. I know. GitHub should improve this workflow a lot. Ondrej -- You received this message because you are subscribed to

Re: [sympy] Idea for PR reviewing

2016-09-08 Thread Aaron Meurer
I'm not a fan of that. Closing gives people the impression that the pull request is being rejected. Aaron Meurer On Thu, Sep 8, 2016 at 1:48 PM, Ondřej Čertík wrote: > One option is to close the PR if it's not ready, since I think the > author of the PR can reopen it.

Re: [sympy] Idea for PR reviewing

2016-09-08 Thread Ondřej Čertík
One option is to close the PR if it's not ready, since I think the author of the PR can reopen it. That solves the issue that the author of the PR can't touch the labels. On Fri, Sep 2, 2016 at 1:55 PM, Aaron Meurer wrote: > It seems several similar tools already exist.

Re: [sympy] Idea for PR reviewing

2016-09-02 Thread Aaron Meurer
It seems several similar tools already exist. https://about.pullapprove.com/ and https://lgtm.co/ are two that were pointed out to me. They both seem more focused on making sure a review happens before merging, which I'm less worried about. My main concern is seeing which PRs are ready for

Re: [sympy] Idea for PR reviewing

2016-09-01 Thread Isuru Fernando
I think that's great idea, given the large number of open PRs. Implementing this is very easy to do. What's hard is to find the correct workflow. How do you trigger the red X status? A comment in the PR with a specific message? How do you suggest turning the red X status off when the reviewer's