Re: [sympy] Re: Feedback requested on new deprecations policy

2023-01-15 Thread S.Y. Lee
However, in the future, we may need have a complete review guideline even for setting up the parameter names, or to check if the bad naming choices are not marked as positional-only arguments. Although I believe that there are a lot of immature sympy commits before, but this is quite difficult

Re: [sympy] Re: Feedback requested on new deprecations policy

2022-02-18 Thread Aaron Meurer
On Fri, Feb 18, 2022 at 7:39 PM Chris Smith wrote: > A concern I have about the policy is that "positional argument names are > not Public API". I hope this is not correct, because if a function `f(a, > b)` is changed to `f(b, a)` this would start failing without warning. The names are

[sympy] Re: Feedback requested on new deprecations policy

2022-02-18 Thread Chris Smith
A concern I have about the policy is that "positional argument names are not Public API". I hope this is not correct, because if a function `f(a, b)` is changed to `f(b, a)` this would start failing without warning. I'm not even sure that `f(a, b, c=1, d=2)` should be allowed to be changed to