Re: [sympy] Implement solvers for symengine

2019-04-15 Thread brijesh vora
Can someone suggest how to setup development for symengine, so that if I change a code in some file I can run the updated symengine easily. What is the easiest way to do this? -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this

Re: [sympy] Implement solvers for symengine

2019-04-10 Thread brijesh vora
PR- #16617-https://github.com/sympy/sympy/pull/16617 #16580-https://github.com/sympy/sympy/pull/16580 Can someone please review it. In the coming days I will send more PR as I couldn't send before the proposal time. -- You received this message because you are subscribed to the Google

Re: [sympy] Implement solvers for symengine

2019-04-08 Thread Ondřej Čertík
Try to put more details into the timeline, and the section where you describe what you want to implement. Also, submit the proposal now, you can still edit it afterwards. When we review proposals, the patches are very important to show your skills, so I suggest you do the modifications above,

Re: [sympy] Implement solvers for symengine

2019-04-07 Thread brijesh vora
I have written a draft proposal, can you please review it. https://docs.google.com/document/d/1qLJR_Ojw6M-cqaV8orHun7m7bOhGh1Bjyc7eA_o7Jfc/edit?usp=sharing Thanks -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and

Re: [sympy] Implement solvers for symengine

2019-04-07 Thread brijesh vora
In solvers in sympy they have used tuples,list and dict, for returning and printing, so whether we have to make 3 separate data structure in c++ which functions like tuples,list and dict and can return that. Also once we have made it ,it would be easy to use everywhere. -- You received this

Re: [sympy] Implement solvers for symengine

2019-04-07 Thread brijesh vora
So, a user should be given a choice whether he wants to solve a problem through sympy or symengine, right? -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: [sympy] Implement solvers for symengine

2019-04-07 Thread brijesh vora
On Sunday, April 7, 2019 at 9:42:13 PM UTC+5:30, Ondřej Čertík wrote: > > Thanks for the PR. I think the first step would be to extend > sympy.core.backend to work with solvers and ensure sympy tests pass with > symengine on. That way one is using symengine instead of sympy.core, but > sympy

Re: [sympy] Implement solvers for symengine

2019-04-07 Thread Ondřej Čertík
Thanks for the PR. I think the first step would be to extend sympy.core.backend to work with solvers and ensure sympy tests pass with symengine on. That way one is using symengine instead of sympy.core, but sympy solvers would still be used. The next step would be to rewrite some of the

Re: [sympy] Implement solvers for symengine

2019-04-07 Thread brijesh vora
also can you please can let me know what find of functionality do you want in solvers in symengine , so that I can work on important things first and latter other things > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this

Re: [sympy] Implement solvers for symengine

2019-04-07 Thread brijesh vora
can you please review my PR before 9th april - #16580 -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: [sympy] Implement solvers for symengine

2019-04-06 Thread Ondřej Čertík
Per instructions, you have to have at least one PR submitted by April 9. https://github.com/sympy/sympy/wiki/GSoC-2019-Application-Template#patch-requirement Ondrej On Sat, Apr 6, 2019, at 12:31 PM, brijesh vora wrote: > I was thinking of implementing algebraic and ode solvers. I will upload

Re: [sympy] Implement solvers for symengine

2019-04-06 Thread brijesh vora
I was thinking of implementing algebraic and ode solvers. I will upload draft proposal very soon and please do comment about it. And regarding the PR Merging ,is it okay if I sent them after 9th april , they will not be written in draft proposal but please do consider it. -- You received this

Re: [sympy] Implement solvers for symengine

2019-04-06 Thread Ondřej Čertík
Yes, we would like to see such a proposal. Can you write up in details which solvers, what algorithms etc? Also don't forget about the patch requirement. On Sat, Apr 6, 2019, at 8:30 AM, brijesh vora wrote: > Hi, > what is the status of this project- Implement solvers for symengine > > I was

[sympy] Implement solvers for symengine

2019-04-06 Thread brijesh vora
Hi, what is the status of this project- Implement solvers for symengine I was thinking to implement this in symengine with c++ to improve the performance gain and write tests and bechmark it. -- You received this message because you are subscribed to the Google Groups "sympy" group. To