Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Thank you for response. So should i submit this proposal? On Thu, Mar 26, 2020, 3:20 AM Oscar Benjamin wrote: > I had a quick look and it seems reasonable. > > On Wed, 25 Mar 2020 at 16:11, mohit balwani > wrote: > > > > Hello everyone, > > > > I have made a final draft proposal on

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

I had a quick look and it seems reasonable. On Wed, 25 Mar 2020 at 16:11, mohit balwani wrote: > > Hello everyone, > > I have made a final draft proposal on "Refactoring the ODE module and make it > fast". If someone can please review this and suggest changes so that I can > incorporate them

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Hello everyone, I have made a final draft proposal on "Refactoring the ODE module and make it fast". If someone can please review this and suggest changes so that I can incorporate them accordingly before the GSoC timeline. link:

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

https://docs.google.com/document/d/1slfj2CJRgKpmf0zOW93YkxYUDUvutTmkDX6BmsFfmIs/edit?usp=sharing can someone provide feedback on this? On Fri, Mar 20, 2020 at 1:55 PM mohit balwani wrote: > +oscar.j.benja...@gmail.com I have made changes you suggested about > refactoring test_ode.py in

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

+oscar.j.benja...@gmail.com I have made changes you suggested about refactoring test_ode.py in phase-I. could you please review it again? On Sun, Mar 15, 2020 at 7:40 PM Oscar Benjamin wrote: > I think it would be better to refactor the tests at the start as in >

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

I think it would be better to refactor the tests at the start as in https://github.com/sympy/sympy/issues/18377 That can significantly increase test coverage which gives more confidence when refactoring everything else. It would also make it possible to compare timings before and after the

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

+oscar.j.benja...@gmail.com can you please review the changes in proposal so that i know what i need to make changes in it? On Friday, March 13, 2020 at 10:27:39 PM UTC+5:30, mohit balwani wrote: > > hello, > I have made some changes in project motivation. Does this look good or > Should I

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

hello, I have made some changes in project motivation. Does this look good or Should I detail that more? On Thu, Mar 12, 2020 at 5:15 AM Oscar Benjamin wrote: > I think it would be good to spend more time explaining what changes > you will make and why. > > Don't assume that someone reviewing

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

I think it would be good to spend more time explaining what changes you will make and why. Don't assume that someone reviewing this proposal will understand the current problems of the ODE module or why your proposal is beneficial. You should make it clear to them what the problems are and how

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Hi, Here is rough draft of my GSoC proposal https://docs.google.com/document/d/1slfj2CJRgKpmf0zOW93YkxYUDUvutTmkDX6BmsFfmIs/edit?usp=drivesdk Any suggestions would really be appreciated. On Tue, Mar 10, 2020, 9:15 PM Oscar Benjamin wrote: > Hi Mohit, > > You don't need to resend the previous

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Hi Mohit, You don't need to resend the previous emails. This discussion is becoming too detailed though and belongs on the Github issue for refactoring the ODE module: https://github.com/sympy/sympy/issues/18348 Oscar On Tue, 10 Mar 2020 at 15:26, mohit balwani wrote: > > hello, > > so should

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Hi Mohit, I'm replying on the mailing list. I didn't realise we had gone off-list in the last couple of emails. This conversation belongs in the issue on github. Oscar On Tue, 10 Mar 2020 at 13:29, mohit balwani wrote: > > For pattern matching, I kept in mind that we can extract the elements

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Hi, currently, there are 28 solvers in the ODE module out of which 6 solvers have been refactored already. I have classified the remaining 22 solvers on the basis of their parent class whether they should inherit SinglePatternODESolver or SingleODESolver SinglePatternODESolver 1. separable

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Hi, oscar I started looking at the (Single) ODE solver closely and as suggested by you, they are to be refactored in the form of classes. After performing all this work it will be easier to maintain the code and whenever a new solver is to be added it will be very easy to add it. In my GSoC

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Hi Mohit, That's plenty enough for a GSOC project. You should try to go into more detail in your proposal about exactly what you think should happen though. Perhaps review all of the (single) ODE solvers that are there now and how they can be refactored and simplified or improved in the process.

[sympy] Re: [DISCUSSION] GSOC idea about ODE

I am planning to take Refactoring ODE module as a GSoC project. For every solver we need to make it as a separate class so that classify_ode() can easily match the ode and return the solution right away. After that the test_ode.py also needs to be refactored as there are lot of redundant test

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Thanks for the response. I just wanted apporoval that,are they worth enough to implement? Now i will try to help in refactoring as soon as possible. On Fri, Jan 24, 2020, 12:14 AM Oscar Benjamin wrote: > Those might be able to speed things up but not until the ODE module is > refactored. The

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

Those might be able to speed things up but not until the ODE module is refactored. The reason the module needs to be refactored is that right now it runs the whole of classify_ode including the matching code for every single solver. If it just returned the first match straight away and computed

[sympy] Re: [DISCUSSION] GSOC idea about ODE

On Thursday, January 9, 2020 at 10:00:33 PM UTC+5:30, mohit balwani wrote: > > I have ideas of implementing functionalities in ODE mentioned in wiki > page. with whom should I discuss it? > I have attached a pdf file in which there are shortcut tricks to solve linear ode, i don't know

Re: [sympy] Re: [DISCUSSION] GSOC idea about ODE

I've added some stuff about ODEs: https://github.com/sympy/sympy/wiki/GSoC-2020-Ideas#systems-of-ordinary-differential-equations https://github.com/sympy/sympy/wiki/GSoC-2020-Ideas#refactor-the-ode-module-and-make-it-fast I'll try to add more later On Wed, 15 Jan 2020 at 18:42, mohit balwani

[sympy] Re: [DISCUSSION] GSOC idea about ODE

Is GSOC 2020 ideas page updated now? -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To view this discussion on the web visit

[sympy] Re: [DISCUSSION] GSOC idea about ODE

I have already implemented things from the ideas page so I will update the idea page very soon. But still, you can share your ideas here, and then we can discuss here, and then also,