Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-03-25 Thread Naman Nimmo
Jason, I have uploaded my final proposal on the GSoC website. But Google allows us to edit our proposals before the deadline, so if you have any suggestions or improvements, please let me know. https://docs.google.com/document/d/1Sifc2injFLrdsSfG7FCN0PN3ZRrwRXCaKVFUcjME2Kg/edit?usp=sharing O

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-03-18 Thread Naman Nimmo
The application period has started for GSoC. Is it okay to submit this application or should I change something in it? I haven't received any feedback on this. On Sun, Mar 8, 2020 at 11:38 PM Naman Nimmo wrote: > Hi, > > I have completed the first draft of my GSoC Application. I know it's too >

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-03-08 Thread Naman Nimmo
Hi, I have completed the first draft of my GSoC Application. I know it's too early right now but I had discussed the implementation plan in Feb first week and now it took me a week to finally write it down. Some small tweaks might be needed, but I think this is ready from my side. Please review th

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-04 Thread Oscar Benjamin
Hi Naman, Sorry I wasn't objecting to the proposal. If this is something that you are interested in then I think it is a good addition. Oscar On Tue, 4 Feb 2020 at 19:35, Aaron Meurer wrote: > > I agree with Jason. The idea is on the ideas page so it is valid for GSoC. > > If the proposal gets

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-04 Thread Aaron Meurer
I agree with Jason. The idea is on the ideas page so it is valid for GSoC. If the proposal gets accepted and we decide that the package is better suited as a separate library, we can do that. But this shouldn't impact the proposal or the likelihood of the project being accepted. Aaron Meurer On

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-04 Thread Naman Nimmo
Thanks, Jason. I'm excited about this topic. I don't usually get to implement the things I learn in college, so it's just pure theory.. and it gets kind of boring. This topic is related to my major so that would be like a cherry on the top. I hope *my* coding skills will take a giant leap and I'll

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-04 Thread Jason Moore
Naman, If you are excited about the control package, I think you should work on it. It is a very nice addition that an electrical engineering student is ideal to work on. Don't let this broader conversation happening here discourage you. We shouldn't have hijacked your thread. I'm very supportiv

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-04 Thread Naman Nimmo
Thanks for confirming the current scope of adding such type of package. I only started working on this because of the current stalling PRs: #12189 and #17866 "Control theory" is currently listed on the GSoC idea

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-03 Thread Aaron Meurer
On Mon, Feb 3, 2020 at 2:02 PM Oscar Benjamin wrote: > > On Mon, 3 Feb 2020 at 20:40, Aaron Meurer wrote: > > > > This isn't against the rules of GSoC. However, I would caution against > > doing such a thing. Unless there are other people other than the GSoC > > student who are willing to help de

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-03 Thread Oscar Benjamin
On Mon, 3 Feb 2020 at 20:40, Aaron Meurer wrote: > > This isn't against the rules of GSoC. However, I would caution against > doing such a thing. Unless there are other people other than the GSoC > student who are willing to help develop and maintain the package after > the end of GSoC, the packag

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-03 Thread Aaron Meurer
This isn't against the rules of GSoC. However, I would caution against doing such a thing. Unless there are other people other than the GSoC student who are willing to help develop and maintain the package after the end of GSoC, the package has a very high risk of falling on the wayside. An advant

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-03 Thread Oscar Benjamin
I don't know if this fits with GSOC rules but I wonder if a better model might be for a GSOC project to do something like: 1. Create a new symcontrol project to go on PyPI. 2. Make improvements to the sympy codebase as needed in order to implement the control theory calculations. 3. Add an example

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-03 Thread Jason Moore
Historically we've been very supportive of adding well designed domain specific packages. SymPy, in fact, was built originally with at least a partial desire for solving symbolic physics. There are of course advantages and disadvantages in doing this. My personal opinion is that we limit GSoC pro

Re: [sympy] Re: [Discussion] GSoC 2020 -- Adding control package to sympy.physics

2020-02-03 Thread Oscar Benjamin
In general I question whether things like this need to be part of the main sympy project rather than as another project on pypi that can be installed separately. If we are going to include domain-specific modules that are really just built on top of sympy then I think that it is important that they