Re: [SyncEvolution] Release preparations for 1.5.2
I splitted both (tde and tdepim)
tde.patch is to prevent the wallet backend from crashing syncevolution when
enabled. Again tdewallet backend is not tested by any means as I am not
using it.
tdepim.patch is to make the notes backend build.
Unfortunately I was still not able to perform an e2e test with this version.
I am looking forward to do it next. Again I do not expect any functional
issues as I am using the code from the previous version on daily bases.
I hope this helps
regards
diff --git a/tmp/syncevolution-1.5.1+20161014+SE+46a81a3+SYSYNC+7c9a4bf/src/backends/tde/TDEPlatform.cpp b/syncevolution-1.5.1+20161014+SE+46a81a3+SYSYNC+7c9a4bf/src/backends/tde/TDEPlatform.cpp
index d262f57..bf459b1 100644
--- a/tmp/syncevolution-1.5.1+20161014+SE+46a81a3+SYSYNC+7c9a4bf/src/backends/tde/TDEPlatform.cpp
+++ b/syncevolution-1.5.1+20161014+SE+46a81a3+SYSYNC+7c9a4bf/src/backends/tde/TDEPlatform.cpp
@@ -37,12 +37,13 @@
#include
#include
+
+#include
+#include
#include
#include
#include
-#include
-
#include
SE_BEGIN_CXX
@@ -51,22 +52,18 @@ SE_BEGIN_CXX
void TDEInitMainSlot(const char *appname)
{
-
- int argc = 1;
- static char *argv[] = { const_cast(appname), NULL };
- TDEAboutData aboutData( "syncevotdewlt", // internal program name
- "SyncEvolution-TDEPIM-plugin", // displayable program name.
- "0.1", // version string
- "SyncEvolution TDEPIM plugin",// short porgram description
- TDEAboutData::License_GPL, // license type
- "(c) 2016, emanoil.kot...@fincom.at" // copyright statement
- );
+ //connect to dcop
+ DCOPClient *kn_dcop = TDEApplication::kApplication()->dcopClient();
+ if (!kn_dcop)
+ Exception::throwError(SE_HERE, "internal init error, unable to make new dcop instance for tdenotes");
- TDECmdLineArgs::init(argc, argv, );
-
- TDEApplication syncevotdewallet( "syncevolution-tdewallet" );
- syncevotdewlt.dcopClient()->registerAs(syncevotdewallet.name());
+ TQString appId = kn_dcop->registerAs("syncevolution-tdewallet");
+
+/* SyncSourceLogging::init(InitList("SUMMARY") + "LOCATION",
+" ",
+m_operations);
+*/
}
@@ -125,7 +122,8 @@ bool TDEWalletLoadPasswordSlot(const InitStateTri ,
TQString(key.authtype.c_str())+','+
TQString::number(key.port);
- TQString wallet_name = TDEWallet::Wallet::NetworkWallet();
+// TQString wallet_name = TDEWallet::Wallet::NetworkWallet();
+ TQString wallet_name = TDEWallet::Wallet::LocalWallet();
const TQString folder("Syncevolution");
diff --git a/tmp/syncevolution-1.5.1+20161014+SE+46a81a3+SYSYNC+7c9a4bf/src/backends/tdepim/TDEPIMNotesSource.h b/syncevolution-1.5.1+20161014+SE+46a81a3+SYSYNC+7c9a4bf/src/backends/tdepim/TDEPIMNotesSource.h
index 3276924..632a89d 100644
--- a/tmp/syncevolution-1.5.1+20161014+SE+46a81a3+SYSYNC+7c9a4bf/src/backends/tdepim/TDEPIMNotesSource.h
+++ b/syncevolution-1.5.1+20161014+SE+46a81a3+SYSYNC+7c9a4bf/src/backends/tdepim/TDEPIMNotesSource.h
@@ -27,13 +27,13 @@
#include "config.h"
#include
-SE_BEGIN_CXX
#ifdef ENABLE_TDEPIMNOTES
#include "KNotesIface_stub.h"
#include
+SE_BEGIN_CXX
/**
* Implements access to TDE memo lists (stored as knotes items),
* exporting/importing the memos in plain UTF-8 text.
___
SyncEvolution mailing list
SyncEvolution@syncevolution.org
https://lists.syncevolution.org/mailman/listinfo/syncevolution
Re: [SyncEvolution] Release preparations for 1.5.2
On 23/10/16 15:51, Graham Cobb wrote: > I don't think that is a regression in this version (I guess the previous > version has the same problem), although until I can work out exactly > what is happening I can't be sure. I will look into it a little further > but I may not be able to fix it before I go on holiday. It might even > require proper protocol version handling (which we have avoided so far > -- see an earlier thread about EAS versions some time ago). The problem turned out to be PolicyKey related (I hate "provisioning"). This exchange server seems to handle the need for provisioning differently and doesn't send the 449 status unless you send a bad PolicyKey. The workround is to make sure that the policy-key is configured in the account gsettings. Any non-null value will do, including 0. This triggers provisioning, which will end up eventually with a valid PolicyKey. I have updated the wiki page to include setting that. There are a few things that it might be nice to do one day (i.e. will never happen :-) )... 1) The whole gsettings stuff should be hidden from the users, with some way to pass the necessary parameters from syncevolution. 2) I suspect that provisioning is now being triggered every time activesyncd is restarted as loading the account details from gsettings means activesyncd thinks the policy key has changed when it hasn't really. We rely on this to get it set correctly the first time, but we ought to find a way to work out that it hasn't actually changed. 3) The creation of Office365 means that for users using that service, all the required parameters (except password) can be defaulted sensibly if we know the email address. Maybe we should allow the case of specifying an account which has not been set up in gsettings to use the account name as an email address and then use the Office365 defaults. ___ SyncEvolution mailing list SyncEvolution@syncevolution.org https://lists.syncevolution.org/mailman/listinfo/syncevolution
Re: [SyncEvolution] Release preparations for 1.5.2
On 23/10/16 10:51, Graham Cobb wrote: > I will try to find some time this week to copy libwbxml2.so.1 to my > jessie system and do some functional testing of the release. Hmm. Things are no longer working for me. HOWEVER, since I last tried, my employer has moved me to Office365!!! I strongly suspect that the problem I am now seeing is really to do with that. The user visible problem is that everything works (including listing folders) but whenever data is accessed Exchange returns success but no data (as if all the folders are empty). I don't think that is a regression in this version (I guess the previous version has the same problem), although until I can work out exactly what is happening I can't be sure. I will look into it a little further but I may not be able to fix it before I go on holiday. It might even require proper protocol version handling (which we have avoided so far -- see an earlier thread about EAS versions some time ago). Graham ___ SyncEvolution mailing list SyncEvolution@syncevolution.org https://lists.syncevolution.org/mailman/listinfo/syncevolution
Re: [SyncEvolution] Release preparations for 1.5.2
On 21/10/16 19:46, Patrick Ohly wrote: > These are all problems which should have been caught by the automated > testing. I really need to sign up for some hosted Exchange service :-/ On that note, I am on holiday from Friday for 2 weeks. I am unlikely to be able to do any testing while I am away. I will try to find some time this week to copy libwbxml2.so.1 to my jessie system and do some functional testing of the release. Graham ___ SyncEvolution mailing list SyncEvolution@syncevolution.org https://lists.syncevolution.org/mailman/listinfo/syncevolution
