Re: [SyncEvolution] libopenobex 1.7.2 regression (was: Re: Sync on Debian Stretch)

2017-11-15 Thread Patrick Ohly
On Wed, 2017-11-15 at 19:36 +0100, deloptes wrote:
> Patrick Ohly wrote:
> > On Wed, 2017-11-15 at 13:48 +0100, deloptes wrote:
> > > I don't have the time now to deal with it, so it is just FYI. I
> > > hope
> > > we can follow up on that next.
> > > 
> > > regards
> > > 
> > > 
> > > https://gitlab.com/openobex/mainline/blob/master/UPGRADING.txt
> > > 
> > > Upgrade guide from previous version of openobex
> > > ===
> > > 
> > > Upgrading to version 1.7
> > > 
> > > 
> > > When using an event loop that triggers on incoming data, you must
> > > call
> > > OBEX_HandleInput() after each call to OBEX_Request()
> > > to actually send the
> > > request.
> > 
> > There is a OBEX_HandleInput() call which triggers on incoming data.
> > Is
> > that comment meant to say that each OBEX_Request() must be followed
> > by
> > a OBEX_HandleInput() *immediately*, without waiting for anything?
> > 
> 
> I don't know anything else except what I forwarded, but BTW do you
> mean theĀ 1.6 modifications were adopted?

No, I meant that perhaps SyncEvolution does (and always has done)
what's necessary. I'm not sure what exactly the required behavior is,
even with the comment in the UPGRADING.txt.

What you can try is finding all OBEX_Request() calls and add a
OBEX_HandleInput() directly after them.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.


___
SyncEvolution mailing list
SyncEvolution@syncevolution.org
https://lists.syncevolution.org/mailman/listinfo/syncevolution

Re: [SyncEvolution] libopenobex 1.7.2 regression (was: Re: Sync on Debian Stretch)

2017-11-15 Thread deloptes
Patrick Ohly wrote:

> On Wed, 2017-11-15 at 13:48 +0100, deloptes wrote:
>> Hi Patrick,
>> 
>> I finally got a response from openobex and the secret was in the
>> UPGRADING document.
> 
> Is that response somewhere public?
> 

Well their site is down, sourforge is outdated, I found only the gitlab 1.7 
version, but no extra information except as it looks like in the code

>> I don't have the time now to deal with it, so it is just FYI. I hope
>> we can follow up on that next.
>> 
>> regards
>> 
>> 
>> https://gitlab.com/openobex/mainline/blob/master/UPGRADING.txt
>> 
>> Upgrade guide from previous version of openobex
>> ===
>> 
>> Upgrading to version 1.7
>> 
>> 
>> When using an event loop that triggers on incoming data, you must
>> call
>> OBEX_HandleInput() after each call to OBEX_Request()
>> to actually send the
>> request.
> 
> There is a OBEX_HandleInput() call which triggers on incoming data. Is
> that comment meant to say that each OBEX_Request() must be followed by
> a OBEX_HandleInput() *immediately*, without waiting for anything?
> 

I don't know anything else except what I forwarded, but BTW do you mean the 
1.6 modifications were adopted?

It might be worth I try this next. 

regards

___
SyncEvolution mailing list
SyncEvolution@syncevolution.org
https://lists.syncevolution.org/mailman/listinfo/syncevolution