[Synfig-devl] Add buggy sample files to code repository

2012-09-27 Thread Carlos López González
Hi! Recently I've subscribed to cairo mailing list and I've realized that they do a good practice that consists on add a test sample code for each bug they find out (when possible). I think that it would be good to have a kind of testing area in the repository code that would consists in a list

Re: [Synfig-devl] Add buggy sample files to code repository

2012-09-27 Thread Konstantin Dmitriev
2012/9/27 Carlos López González genet...@gmail.com: Hi! Recently I've subscribed to cairo mailing list and I've realized that they do a good practice that consists on add a test sample code for each bug they find out (when possible). I think that it would be good to have a kind of testing

Re: [Synfig-devl] Add buggy sample files to code repository

2012-09-27 Thread Diego Barrios Romero
Hello! I think this is a great idea that we really need. About how do we do it, I wouldn't choose a hash function, because a very small detail would make the hash differ and in the end the tests would fail all the time. I would include the propper-rendered images together with the test sif file

Re: [Synfig-devl] Add buggy sample files to code repository

2012-09-27 Thread Konstantin Dmitriev
2012/9/27 Diego Barrios Romero eldr...@gmail.com: About putting the test files in a separate repository, for me is ok but I don't see any reason why not including the test files in our repository in the future, so we can include the tests objetive in the makefile for easier testing. The reason

Re: [Synfig-devl] Add buggy sample files to code repository

2012-09-27 Thread Carlos López González
If the repository is separated, how do we ensure that the synfig CLI is found?. Somehow the path to the synfig executable has to be provided. Give it manually? I understand the need of separate the legacy image files but it would be easier to render the tests using make test in the synfig folder

Re: [Synfig-devl] Add buggy sample files to code repository

2012-09-27 Thread Konstantin Dmitriev
2012/9/28 Carlos López González genet...@gmail.com: If the repository is separated, how do we ensure that the synfig CLI is found?. Somehow the path to the synfig executable has to be provided. Give it manually? I understand the need of separate the legacy image files but it would be easier

Re: [Synfig-devl] Add buggy sample files to code repository

2012-09-27 Thread Carlos López González
If we go to separated repositories we can always create a super project that embed both repositories using git submoduleshttps://git.wiki.kernel.org/index.php/GitSubmoduleTutorial. I need to learn more git to achieve that level. ^__^ Carlos 2012/9/27 Carlos López González genet...@gmail.com If

Re: [Synfig-devl] Add buggy sample files to code repository

2012-09-27 Thread Konstantin Dmitriev
2012/9/28 Carlos López González genet...@gmail.com: If we go to separated repositories we can always create a super project that embed both repositories using git submodules. I need to learn more git to achieve that level. ^__^ Yes, but from my opinion git-subtree approach is better: