[Synfig-devl] Why method etl::surface::set_wh(w, h, newdata, pitch) is virtual?

Why flllowing method is virtual? template typename T, typename AT=T, class VP=value_prepT,AT etl::surface::set_wh(typename size_type::value_type w, typename size_type::value_type h, unsigned char* newdata, const typename size_type::value_type pitch) This method have one override: void

Re: [Synfig-devl] Why method etl::surface::set_wh(w, h, newdata, pitch) is virtual?

Yes, you're right. It is one trailing code form the initial steps of Cairo render implementation. Sure it is OK to remove the virtual keyword. Thanks! 2013/8/30 Ivan Mahonin b...@icystar.com Why flllowing method is virtual? template typename T, typename AT=T, class VP=value_prepT,AT

Re: [Synfig-devl] Why method etl::surface::set_wh(w, h, newdata, pitch) is virtual?

Btw, thanks for the rest of warning fixes! 2013/8/30 Carlos López González genet...@gmail.com Yes, you're right. It is one trailing code form the initial steps of Cairo render implementation. Sure it is OK to remove the virtual keyword. Thanks! 2013/8/30 Ivan Mahonin b...@icystar.com

[Synfig-devl] Why 'hbiter_pos' never used in advanced_outline.cpp?

Please, look this code, may be it's bug? https://github.com/blackwarthog/synfig/commit/6e7d2dff6f2ef90647916de3180b3f3e6becafba -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy

[Synfig-devl] Why 'angle' variable never used in svg_parser.cpp

This variable was read from SVG and ignored in code. Is it really unnecessary var? I've commented this var in this commit: https://github.com/blackwarthog/synfig/commit/bc40dca3f90dfd563e4e57d775dedf41bc774e4a -- Learn

[Synfig-devl] I've encountered strange unused code in curveset.cpp

Please look this commit: https://github.com/blackwarthog/synfig/commit/1fa6e2e61f134ab727d907a09f657337c3bf5ba9 -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master

Re: [Synfig-devl] Why 'hbiter_pos' never used in advanced_outline.cpp?

Possibly it is a trace of the development of the Advanced Outline implementation. It can be safely removed I think. Notice that 'iter' becomes 'next' during the iterations so maybe trailing the iter is not needed. If later we find a render artifact we can try to fix it but as far as I know, it

Re: [Synfig-devl] Why 'angle' variable never used in svg_parser.cpp

SVG parser will eventually be removed. It has not maintainer and currently with the svg2sif inkscape script there is not sense to carry it on. 2013/8/30 Ivan Mahonin b...@icystar.com This variable was read from SVG and ignored in code. Is it really unnecessary var? I've commented this var

Re: [Synfig-devl] I've encountered strange unused code in curveset.cpp

I think that curveset.cpp as well as booleancurve.cpp (and their headers) are unfinished code from original developer (darco), with the intention of create a layer that can hold multishapes in it (with boolean operations between them). Would be cool to have! 2013/8/30 Ivan Mahonin

Re: [Synfig-devl] Fix warnings

Merged! 2013/8/30 Ivan Mahonin b...@icystar.com Oops. I forgot to commit this. I've resent pool request with this fix Fantastic! I have one complain form my compiler that seems not fixed: pluginmanager.cpp:124: warning: unused parameter 'synfig_root' Can you add it?

Re: [Synfig-devl] I've encountered strange unused code in curveset.cpp

Ok. I've commented the unused code. May be it will need in future. I think that curveset.cpp as well as booleancurve.cpp (and their headers) are unfinished code from original developer (darco), with the intention of create a layer that can hold multishapes in it (with boolean operations

[Synfig-devl] [synfig/synfig] 79f2b1: Remove unnecessary qualifiers from color.h

Branch: refs/heads/master Home: https://github.com/synfig/synfig Commit: 79f2b13438b9253f99cd9ec520a717416caf99db https://github.com/synfig/synfig/commit/79f2b13438b9253f99cd9ec520a717416caf99db Author: Ivan Mahonin b...@icystar.com Date: 2013-08-30 (Fri, 30 Aug 2013)

Re: [Synfig-devl] Fix warnings

Fantastic! I have one complain form my compiler that seems not fixed: pluginmanager.cpp:124: warning: unused parameter 'synfig_root' Can you add it? 2013/8/30 Ivan Mahonin b...@icystar.com I've fixed all c++ warnings for linux build. So build messages becomes more informative.

[Synfig-devl] Fix warnings

I've fixed all c++ warnings for linux build. So build messages becomes more informative. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous

Re: [Synfig-devl] Fix warnings

Oops. I forgot to commit this. I've resent pool request with this fix Fantastic! I have one complain form my compiler that seems not fixed: pluginmanager.cpp:124: warning: unused parameter 'synfig_root' Can you add it?

Re: [Synfig-devl] Fix warnings

2013/8/30 Ivan Mahonin b...@icystar.com: I've fixed all c++ warnings for linux build. So build messages becomes more informative. Epic! ^___^ K. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!

Re: [Synfig-devl] Fix warnings

2013/8/30 Ivan Mahonin b...@icystar.com: Oops. I forgot to commit this. I've resent pool request with this fix Note for the future: if you push new commits into the same branch, then the pull request is updated automatically. So generally you don't need to open new one. ^__^ BTW, the plugins

[Synfig-devl] [synfig/synfig] a3680b: Linux build: Properly detect if build script belon...

Branch: refs/heads/master Home: https://github.com/synfig/synfig Commit: a3680bd80498f708f55067d091173ffd99e72d9a https://github.com/synfig/synfig/commit/a3680bd80498f708f55067d091173ffd99e72d9a Author: Konstantin Dmitriev ksee.zelga...@gmail.com Date: 2013-08-30 (Fri, 30 Aug