Re: comparing 72_scores.cf files

2017-11-16 Thread Merijn van den Kroonenberg
> First to answer Kevin, the script is mainly for debugging and reviewing. > > I think it should be possible to do something like > > svn diff -r {2017-11-15} --diff-cmd /path/to/compare-rulefiles > http://svn.apache.org/repos/asf/spamassassin/trunk/rulesrc/scores/72_scores.cf > > to get the change

Re: comparing 72_scores.cf files

2017-11-15 Thread Merijn van den Kroonenberg
First to answer Kevin, the script is mainly for debugging and reviewing. I think it should be possible to do something like svn diff -r {2017-11-15} --diff-cmd /path/to/compare-rulefiles http://svn.apache.org/repos/asf/spamassassin/trunk/rulesrc/scores/72_scores.cf to get the changes to 72_sc

Re: comparing 72_scores.cf files

2017-11-15 Thread Dave Jones
Nice script.  Very useful.  Now it would be good to extend it to check the rules still exist.  For example, I wrote a quick bash on-liner to find the rules no longer exist in the main SA rules so we shouldn't expect these 6 to be in the new 72_scores.cf: AXB_XMAILER_MIMEOLE_OL_1ECD5 AXB_XM_FOR

Re: comparing 72_scores.cf files

2017-11-15 Thread Kevin A. McGrail
Very Cool.  Is there a Tl;Dr result you came up with or is this more something prepped for when we get to the stage to review? On 11/15/2017 7:27 AM, Merijn van den Kroonenberg wrote: I wanted to compare the 72_scores.cf file against the one from yesterday and the one from march. However the sv

comparing 72_scores.cf files

2017-11-15 Thread Merijn van den Kroonenberg
I wanted to compare the 72_scores.cf file against the one from yesterday and the one from march. However the svn diff is not very readable and its very hard to see which rules were added or removed. I also wanted to compare the ranges.data file which also contains rules and score ranges. I patched