[systemd-devel] [PATCH] Annotate some functions as _const_

2013-04-30 Thread Cristian Rodríguez
hexchar,unhexchar,octchar,unoctchar,decchar,undecchar are all const functions. --- src/shared/util.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/shared/util.h b/src/shared/util.h index eee66cc..eb82ff4 100644 --- a/src/shared/util.h +++ b/src/shared/util.h

[systemd-devel] [PATCH] zsh_completion: fix udevadm monitor flags

2013-04-30 Thread Daniel Wallace
The brackets in the _arguments description of udevadm monitor need to be escaped. --- shell-completion/systemd-zsh-completion.zsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell-completion/systemd-zsh-completion.zsh b/shell-completion/systemd-zsh-completion.zsh index 73d

[systemd-devel] Fwd: EFI boot generator failing to detect I'm actually booting on EFI

2013-04-30 Thread Léo Gillot-Lamure
Aaaah, crap, that was it : too old gummiboot, I think I was using version 7 or 10... Now (I've stolen a binary from f19 package because I couldn't build it) it works and I've even got firmware time information in systemd-analyze (a 30s spent in firmware…). Thanks for the help and the good job

Re: [systemd-devel] [PATCH] python-systemd: add version number

2013-04-30 Thread Steven Hiscocks
On 30/04/13 03:33, Zbigniew Jędrzejewski-Szmek wrote: On Tue, Apr 23, 2013 at 08:11:03PM +0100, Steven Hiscocks wrote: From: Steven Hiscocks --- Hi, I thought it would be useful to have a version number in the python systemd module. Hi, I haven't replied to this before because of one reserv

Re: [systemd-devel] [PATCH] udev/rules: Add default user access and permissions for vfio

2013-04-30 Thread Alex Williamson
On Tue, 2013-04-30 at 22:44 +0200, Kay Sievers wrote: > On Tue, Apr 30, 2013 at 9:16 PM, Alex Williamson > wrote: > > The /dev/vfio/vfio device file is intended to be an unprivileged > > interface. > > If that is common, and not subject to system policy, the kernel driver > should request that ri

Re: [systemd-devel] EFI boot generator failing to detect I'm actually booting on EFI

2013-04-30 Thread Kay Sievers
On Tue, Apr 30, 2013 at 8:04 PM, Léo Gillot-Lamure wrote: > Yup, I have both. And: /sys/firmware/efi/efivars/LoaderDevicePartUUID-4a67b082-0a4c-41cf-b6c7-440b29bb8c4f exists? And you have a recent version of gummiboot? Kay ___ systemd-devel mailing

Re: [systemd-devel] [PATCH] udev/rules: Add default user access and permissions for vfio

2013-04-30 Thread Kay Sievers
On Tue, Apr 30, 2013 at 9:16 PM, Alex Williamson wrote: > The /dev/vfio/vfio device file is intended to be an unprivileged > interface. If that is common, and not subject to system policy, the kernel driver should request that right away, and better not rely on udev rules to adjust that. Like it

Re: [systemd-devel] [PATCH] [RFCv6] Optionally save core dumps as plain files

2013-04-30 Thread Oleksii Shevchuk
> If it needs review, I could probably do that sometime this week. Or is > it blocked on the "large binary blobs should go in the journal" issue? I don't think it's really blocked, so I will be glad to have review :) ___ systemd-devel mailing list syste

Re: [systemd-devel] [PATCH] [RFCv6] Optionally save core dumps as plain files

2013-04-30 Thread Colin Walters
Since I've been submitting minor bandaid fixes for src/journal/coredump.c, let me say that while I haven't looked at this patch in detail, the idea and the outlines of the code make a lot of sense to me, and I'd be very happy if it landed. If it needs review, I could probably do that sometime this

[systemd-devel] [PATCH] [RFCv6] Optionally save core dumps as plain files

2013-04-30 Thread Oleksii Shevchuk
Introduce configuration file: /etc/systemd/coredump.conf with configurable uid/gid parameters, optional backends to journal and files, per storage size limits Default filestorage choosed as /run/log/coredump or /var/log/coredump with next reason: 1. These files produced with systemd component 2. T

[systemd-devel] [PATCH] udev/rules: Add default user access and permissions for vfio

2013-04-30 Thread Alex Williamson
The /dev/vfio/vfio device file is intended to be an unprivileged interface. Only by attaching it to a group (/dev/vfio/$GROUP) does it allow privileged access. The group is therefore used to grant access and /dev/vfio/vfio can be used by anyone. Update the udev rules to provide this. Signed-off

Re: [systemd-devel] [PATCH 2/2] coredump: Handle programs with spaces in COMM

2013-04-30 Thread Colin Walters
On Tue, 2013-04-30 at 19:47 +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Apr 30, 2013 at 01:12:19PM -0400, Colin Walters wrote: > > This patch makes systemd-coredump handle processes that have > > whitespace in their COMM fields. > > > > fs/coredump.c when given %e (as systemd-coredump uses

Re: [systemd-devel] EFI boot generator failing to detect I'm actually booting on EFI

2013-04-30 Thread Léo Gillot-Lamure
Yup, I have both. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 1/2] util: Add _sentinel_ to strextend()

2013-04-30 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 30, 2013 at 01:11:49PM -0400, Colin Walters wrote: > Since it must be NULL terminated. > --- > src/shared/util.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@list

Re: [systemd-devel] [PATCH 2/2] coredump: Handle programs with spaces in COMM

2013-04-30 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 30, 2013 at 01:12:19PM -0400, Colin Walters wrote: > This patch makes systemd-coredump handle processes that have > whitespace in their COMM fields. > > fs/coredump.c when given %e (as systemd-coredump uses), will end up > joining the process arguments into a string (along with the oth

[systemd-devel] [PATCH 2/2] coredump: Handle programs with spaces in COMM

2013-04-30 Thread Colin Walters
This patch makes systemd-coredump handle processes that have whitespace in their COMM fields. fs/coredump.c when given %e (as systemd-coredump uses), will end up joining the process arguments into a string (along with the other fields), then will split the entire thing up on whitespace, and use it

[systemd-devel] [PATCH 1/2] util: Add _sentinel_ to strextend()

2013-04-30 Thread Colin Walters
Since it must be NULL terminated. --- src/shared/util.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) >From 73f531d65356ecf58c945f316ddcee2201078978 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Tue, 30 Apr 2013 13:01:45 -0400 Subject: [PATCH 1/2] util: Add _sentinel_ to stre

Re: [systemd-devel] EFI boot generator failing to detect I'm actually booting on EFI

2013-04-30 Thread Kay Sievers
On Tue, Apr 30, 2013 at 6:59 PM, Léo Gillot-Lamure wrote: > My module is built in the kernel (actually modules support is disabled > on my kernel), and the /sys/firmware/efi/ is here and properly usable > (for example efibootmgr works). You need: /sys/firmware/efi/efivars/ You have that? Not o

Re: [systemd-devel] EFI boot generator failing to detect I'm actually booting on EFI

2013-04-30 Thread Léo Gillot-Lamure
My module is built in the kernel (actually modules support is disabled on my kernel), and the /sys/firmware/efi/ is here and properly usable (for example efibootmgr works). ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.fr

[systemd-devel] [PATCH] kernel-install: add default 50-depmod.install script

2013-04-30 Thread harald
From: Harald Hoyer Do the depmod in the kernel-install hooks, so hooks can produce/install kernel modules and be part of the depmod. --- Makefile.am | 7 --- src/kernel-install/50-depmod.install | 8 2 files changed, 12 insertions(+), 3 deletions(-) create

Re: [systemd-devel] EFI boot generator failing to detect I'm actually booting on EFI

2013-04-30 Thread Colin Guthrie
Hi, 'Twas brillig, and Léo Gillot-Lamure at 30/04/13 14:08 did gyre and gimble: > I run an EFI system with gentoo, gummiboot and systemd 202 (and no initramfs). > I'm expecting my ESP to be mounted on /boot thanks to the > systemd-efi-boot-generator, however it is not. By stracting it for the > op

Re: [systemd-devel] [systemd-commits] 10 commits - Makefile.am TODO man/sd_id128_to_string.xml man/systemd.unit.xml src/core src/cryptsetup src/libsystemd-id128 src/nspawn src/nss-myhostname src/share

2013-04-30 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 30, 2013 at 04:36:11AM -0700, Lennart Poettering wrote: > commit 5f1dac6bf605871615b35891a3966fa474db5b20 > Author: Lennart Poettering > Date: Mon Apr 29 19:57:29 2013 -0300 > > cryptsetup: warn if keyfiles are world-readable Hi, this part is understandable... > commit 8973790

[systemd-devel] EFI boot generator failing to detect I'm actually booting on EFI

2013-04-30 Thread Léo Gillot-Lamure
Hi. I run an EFI system with gentoo, gummiboot and systemd 202 (and no initramfs). I'm expecting my ESP to be mounted on /boot thanks to the systemd-efi-boot-generator, however it is not. By stracting it for the open syscall, I can see that the last call is this one, before EXIT_SUCCESSing : > op

[systemd-devel] [RFC PATCH] journal: Set the default keep free value to 15% (up from 5%)

2013-04-30 Thread Colin Guthrie
As some SSDs are still seeing performance degredation when reaching 85% usage the default value of 5% seems a little low. Set this to 15% by default. --- So I'm really not sure or educated enough about this one, but we're recently had a user complain about the disk space used by the journal. I a

Re: [systemd-devel] [PATCH] kernel-install: Clean up

2013-04-30 Thread Harald Hoyer
On 04/25/2013 07:59 PM, Mantas Mikulėnas wrote: > - Consistent use of $VAR vs ${VAR} > - Consistent use of && vs 'if' > - Add error checking to some places > - Consistent error messages ("Can't" vs "Cannot", etc.) > - Function declarations at the top > - Miscellaneous adjustments > --- > src/kerne

[systemd-devel] [PATCH] systemd-delta: add support for drop-in snippets

2013-04-30 Thread Lukas Nykryn
--- TODO | 3 - src/delta/delta.c | 179 ++ 2 files changed, 166 insertions(+), 16 deletions(-) diff --git a/TODO b/TODO index 9adec5e..96d90d8 100644 --- a/TODO +++ b/TODO @@ -95,9 +95,6 @@ Features: kmod static-nodes call