Re: [systemd-devel] [PATCH] sd-event: we do not support EPOLLONESHOT correctly

2013-12-13 Thread Shawn Landden
On Fri, Dec 13, 2013 at 8:39 PM, Shawn Landden wrote: > On Fri, Dec 13, 2013 at 8:04 PM, Shawn Landden wrote: >> On Fri, Dec 13, 2013 at 7:17 PM, Lennart Poettering >> wrote: >>> On Fri, 13.12.13 13:08, Shawn Landden (sh...@churchofgit.com) wrote: >>> If this event is not the highest priori

Re: [systemd-devel] [PATCH] sd-event: we do not support EPOLLONESHOT correctly

2013-12-13 Thread Shawn Landden
On Fri, Dec 13, 2013 at 8:04 PM, Shawn Landden wrote: > On Fri, Dec 13, 2013 at 7:17 PM, Lennart Poettering > wrote: >> On Fri, 13.12.13 13:08, Shawn Landden (sh...@churchofgit.com) wrote: >> >>> If this event is not the highest priority, then it will not be >>> dispatched when the epoll triggers

[systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-13 Thread Shawn Landden
If Distribute=n, turns SO_REUSEPORT on, and spawns n workers to handling incoming requests. SO_REUSEPORT sockets on the same port must all be created by the same uid, therefore using the option allows other root programs (or programs of the same user if running in --user mode) to "hijack" this por

Re: [systemd-devel] [PATCH] sd-event: we do not support EPOLLONESHOT correctly

2013-12-13 Thread Shawn Landden
On Fri, Dec 13, 2013 at 7:17 PM, Lennart Poettering wrote: > On Fri, 13.12.13 13:08, Shawn Landden (sh...@churchofgit.com) wrote: > >> If this event is not the highest priority, then it will not be >> dispatched when the epoll triggers, and since we will not get any more >> wakeups (due to the way

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 22:16, Karol Lewandowski (lmc...@gmail.com) wrote: > > On Fri, Dec 13, 2013 at 03:45:36PM +0100, Lennart Poettering wrote: > > On Fri, 13.12.13 12:46, Karol Lewandowski (k.lewando...@samsung.com) wrote: > > > Well, are you suggesting that the AF_UNIX/SOCK_DGRAM code actually han

Re: [systemd-devel] [PATCH] sd-event: we do not support EPOLLONESHOT correctly

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 13:08, Shawn Landden (sh...@churchofgit.com) wrote: > If this event is not the highest priority, then it will not be > dispatched when the epoll triggers, and since we will not get any more > wakeups (due to the way EPOLLONESHOT works) will never be dispatched. Hmm, so the way th

Re: [systemd-devel] [PATCHv2] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-13 Thread David Timothy Strauss
Hold on. This breaks is-enabled if you've enabled an instance *and* that instance has its own override (using def@myinst.service versus using def@.service). ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/ma

Re: [systemd-devel] [PATCH 1/2] nspawn: --populate to run static binaries on empty target directory

2013-12-13 Thread Shawn Landden
On Tue, Dec 10, 2013 at 2:18 PM, Lennart Poettering wrote: > On Mon, 02.12.13 09:41, Shawn Landden (sh...@churchofgit.com) wrote: > >> >> On Mon, Dec 2, 2013 at 8:27 AM, Lennart Poettering >> wrote: >> > On Sat, 30.11.13 10:20, Shawn Landden (sh...@churchofgit.com) wrote: >> > >> >> nspawn has be

Re: [systemd-devel] systemd-consoled: architecture

2013-12-13 Thread Leibowitz, Michael
On Fri, Dec 13, 2013 at 12:12 PM, Jonathan de Boyne Pollard wrote: > The Hurd people have, as I have, already been through the process that you're systemd runs on Hurd? Cheers -- Michael Leibowitz ___ systemd-devel mailing list systemd-devel@lists.fr

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-13 Thread Karol Lewandowski
On Fri, Dec 13, 2013 at 03:45:36PM +0100, Lennart Poettering wrote: > On Fri, 13.12.13 12:46, Karol Lewandowski (k.lewando...@samsung.com) wrote: > Well, are you suggesting that the AF_UNIX/SOCK_DGRAM code actually hands > off the timeslice to the other side as soon as it queued something in? If

Re: [systemd-devel] [PATCHv2] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-13 Thread David Timothy Strauss
This new patch version fixes instance support by "replacing" the instance with nothing, allowing a comparison equivalent to the one we make against the target of the symlink (which is something like abc@.service for instances). ___ systemd-devel mailing l

[systemd-devel] [PATCH] sd-event: we do not support EPOLLONESHOT correctly

2013-12-13 Thread Shawn Landden
If this event is not the highest priority, then it will not be dispatched when the epoll triggers, and since we will not get any more wakeups (due to the way EPOLLONESHOT works) will never be dispatched. Since we only handle one event per epoll_wait() wakeup, and we dequeue a ONE_SHOT event when w

[systemd-devel] [PATCHv2] install: Assume *.wants symlinks have the same name as their target for scalability.

2013-12-13 Thread david
From: David Strauss --- src/shared/install.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/shared/install.c b/src/shared/install.c index 17e8a75..512e3df 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -419,10 +419,15 @@ static int find_symlinks_fd

[systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-13 Thread Shawn Landden
If Distribute=n, turns SO_REUSEPORT on, and spawns n workers to handling incoming requests. SO_REUSEPORT sockets on the same port must all be created by the same uid, therefore using the option allows other root programs (or programs of the same user if running in --user mode) to "hijack" this por

[systemd-devel] [PATCH] bus-util: return errors when encountered

2013-12-13 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen Introduced in: 9f6eb1cd58f2ddf2eb6ba0e4de056e13d938af75 31b403439360c0396a50d77d0a1ee2bca4df --- src/libsystemd-bus/bus-util.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-bus/bus-util.c b/src/libsystemd-bu

Re: [systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-13 Thread Shawn Landden
Forgot to send my notes on the last review On Fri, Dec 13, 2013 at 7:12 AM, Lennart Poettering wrote: > On Thu, 12.12.13 23:46, Shawn Landden (sh...@churchofgit.com) wrote: > >> -Socket.ReusePort,config_parse_bool, 0, >> offsetof(S

[systemd-devel] systemd-consoled: architecture

2013-12-13 Thread Jonathan de Boyne Pollard
There's an adage that holds that the best design is a stolen design. On that basis, I recommend reading about how the Hurd console system works. http://homepage.ntlworld.com./jonathan.deboynepollard/FGA/hurd-daemons.html#console http://gnu.org./software/hurd/hurd/console.html The Hurd peopl

Re: [systemd-devel] Whitepapers

2013-12-13 Thread poma
On 13.12.2013 17:22, Cecil Westerhof wrote: > What would be good things to treat pro subject? Any idea what would be > the amount of time to write those papers for someone who never wrote a > white-paper and is not an expert on systemd? What I really want to say, when you start dreaming systemd

[systemd-devel] systemd-consoled: agetty+login

2013-12-13 Thread Jonathan de Boyne Pollard
The way that you're going right now, you're going to surprise a lot of people, possibly not pleasantly, in a little while. You've presented this as a replacement of agetty and login. But the use cases of getty+login and what you're doing are somewhat different. People expecting to get a systemd-

[systemd-devel] systemd-consoled: terminal hangup misconceptions

2013-12-13 Thread Jonathan de Boyne Pollard
I'll patch the comment. The code is up to you. (-: --- consoled-pty-old.c 2013-12-05 12:53:24.0 + +++ consoled-pty.c 2013-12-05 12:53:11.0 + @@ -40,26 +40,45 @@ #include "sd-event.h" /* - * PTY - * A PTY object represents a single PTY connection between a master and a

[systemd-devel] systemd-consoled: invoking login shells

2013-12-13 Thread Jonathan de Boyne Pollard
In your terminal_run_child() function you invoke the (login) shell for the terminal as, effectively, "$SHELL" "-il". Don't do that. Distributions such as Debian have spent a fair while getting rid of bashisms from the init system and here you are putting more of them in. (-: https://wiki.debi

[systemd-devel] systemd-consoled: consequences

2013-12-13 Thread e-mail j.deboynepollard-newsgroups
I've been following this with some interest. You may be interested in the thoughts that I had on the matter almost three quarters of a decade ago. http://homepage.ntlworld.com./jonathan.deboynepollard/Proposals/linux-console-daemon.html I have since implemented a console daemon of this ilk, b

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Daniel P. Berrange
On Fri, Dec 13, 2013 at 05:20:19PM +0100, Lennart Poettering wrote: > On Fri, 13.12.13 16:15, Lennart Poettering (lenn...@poettering.net) wrote: > > > > We had discussed this back at Linux Plumbers last year, and at the time > > > you had suggested that rather than create /dev/ttyN symlinks we sho

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 15:20, Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, Dec 13, 2013 at 04:15:33PM +0100, Lennart Poettering wrote: > > On Fri, 13.12.13 15:12, Daniel P. Berrange (berra...@redhat.com) wrote: > > > > > > /dev/tty1, /dev/tty2, ... make no sense in containers as there i

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 16:15, Lennart Poettering (lenn...@poettering.net) wrote: > > We had discussed this back at Linux Plumbers last year, and at the time > > you had suggested that rather than create /dev/ttyN symlinks we should > > instead do something like /dev/containerttyN instead, and set a > >

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Daniel P. Berrange
On Fri, Dec 13, 2013 at 04:15:33PM +0100, Lennart Poettering wrote: > On Fri, 13.12.13 15:12, Daniel P. Berrange (berra...@redhat.com) wrote: > > > > /dev/tty1, /dev/tty2, ... make no sense in containers as there is no > > > virtual console. > > > > For each device that you list in the containe

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 15:12, Daniel P. Berrange (berra...@redhat.com) wrote: > > /dev/tty1, /dev/tty2, ... make no sense in containers as there is no > > virtual console. > > For each device that you list in the container configuration > with libvirt, it will allocate a /dev/pts/NNN device, and add

Re: [systemd-devel] [PATCH] core: support Distribute=n to distribute to n workers

2013-12-13 Thread Lennart Poettering
On Thu, 12.12.13 23:46, Shawn Landden (sh...@churchofgit.com) wrote: > -Socket.ReusePort,config_parse_bool, 0, >offsetof(Socket, reuse_port) > +Socket.ReusePort,config_parse_tristate, -1, >

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Daniel P. Berrange
On Fri, Dec 13, 2013 at 04:06:56PM +0100, Lennart Poettering wrote: > On Fri, 13.12.13 16:34, Gao feng (gaof...@cn.fujitsu.com) wrote: > > > >> As we know, systemd only forks getty on ttyX when we press ctrl + alt + > > >> FX. > > >> I whould like to let systemd forks server gettys on all of tty

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 16:34, Gao feng (gaof...@cn.fujitsu.com) wrote: > >> As we know, systemd only forks getty on ttyX when we press ctrl + alt + FX. > >> I whould like to let systemd forks server gettys on all of tty deivces by > >> default. > >> this is very useful in container environment, since w

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 16:10, Gao feng (gaof...@cn.fujitsu.com) wrote: > Hi, > > As we know, systemd only forks getty on ttyX when we press ctrl + alt + FX. > I whould like to let systemd forks server gettys on all of tty deivces > by default. You can control how many VTs logind cares for with NAutoVT

Re: [systemd-devel] [PATCH] libsystemd-bus: the same error codes for sd_bus_release_name() (for kdbus and dbus1)

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 12:12, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: > Due to this patch, sd_bus_release_name() function > returns the same code errors for kdbus and dbus1 > if we try release non-existing name or foreign > name. Applied! Thanks! > --- > src/libsystemd-bus/bus-control.c

Re: [systemd-devel] [PATCH] build-sys: fix help text for --enable-kdbus

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 10:26, Lukasz Skalski (l.skal...@partner.samsung.com) wrote: Applied! Thanks! > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 6ada38a..f85e86e 100644 > --- a/configure.ac > +++ b/configure.ac > @@

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-13 Thread Lennart Poettering
On Fri, 13.12.13 12:46, Karol Lewandowski (k.lewando...@samsung.com) wrote: > >> From 2.6.29 it's in mailine kernel under > >> drivers/staging/android/logger.c > > > > But if the the socket layer is really that much slower than android > > logging, then that's kinda sad, and the kernel socket

Re: [systemd-devel] [systemd-commits] man/systemd-nspawn.xml

2013-12-13 Thread Lennart Poettering
On Thu, 12.12.13 20:20, Zbigniew Jędrzejewski-Szmek (zbys...@kemper.freedesktop.org) wrote: > man/systemd-nspawn.xml | 11 +++ > 1 file changed, 11 insertions(+) > > New commits: > commit f9f4dd51bdb016bab84f7fb3cf47a2ad102b4c76 > Author: Zbigniew J??drzejewski-Szmek > Date: Thu De

Re: [systemd-devel] journal: How to limit the file size of runtime system.journal

2013-12-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 13, 2013 at 01:49:51PM +0800, WANG Chao wrote: > On 12/13/13 at 06:42am, Zbigniew Jędrzejewski-Szmek wrote: > > On Fri, Dec 13, 2013 at 01:33:17PM +0800, WANG Chao wrote: > > > Hi, > > > > > > In kdump environment, memory resource is quite limited. I find that the > > > runtime journal

Re: [systemd-devel] [RFC] [PATCH 0/3] journal: Add deferred log processing to reduce synchonous IO overhead

2013-12-13 Thread Karol Lewandowski
On 12/12/2013 07:05 PM, Lennart Poettering wrote: > On Thu, 12.12.13 17:42, Karol Lewandowski (lmc...@gmail.com) wrote: > >>> Hmm, but this wouldn't be any different from old syslog, right? I mean, >>> old syslog also uses sendv() and recv() on AF_UNIX SOCK_DGRAM sockets... >> >> That's true, howe

[systemd-devel] [PATCH] libsystemd-bus: the same error codes for sd_bus_release_name() (for kdbus and dbus1)

2013-12-13 Thread Lukasz Skalski
Due to this patch, sd_bus_release_name() function returns the same code errors for kdbus and dbus1 if we try release non-existing name or foreign name. --- src/libsystemd-bus/bus-control.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-bus/bus-control.c b/sr

Re: [systemd-devel] [PATCH] dhcp: Move src/dhcp to src/libsystemd-dhcp

2013-12-13 Thread Patrik Flykt
On Thu, 2013-12-12 at 17:50 +0100, Zbigniew Jędrzejewski-Szmek wrote: > In the end I made more changes: not only is src/dhcp renamed to > src/libsystemd-dhcp, but also src/libsystemd-dhcp/*.[ch] to > src/libsystemd-dhcp/dhcp-*.[ch]. This is because we like to have > unique names for files, which ma

[systemd-devel] [PATCH] build-sys: fix help text for --enable-kdbus

2013-12-13 Thread Lukasz Skalski
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6ada38a..f85e86e 100644 --- a/configure.ac +++ b/configure.ac @@ -801,7 +801,7 @@ AM_CONDITIONAL(ENABLE_MULTI_SEAT_X, [test "$have_multi_seat_x" = "yes"]) # -

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Gao feng
Hello Mantas, On 12/13/2013 04:17 PM, Mantas Mikulėnas wrote: > > On Dec 13, 2013 10:09 AM, "Gao feng" > wrote: >> >> Hi, >> >> As we know, systemd only forks getty on ttyX when we press ctrl + alt + FX. >> I whould like to let systemd forks server gettys on all of

Re: [systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Mantas Mikulėnas
On Dec 13, 2013 10:09 AM, "Gao feng" wrote: > > Hi, > > As we know, systemd only forks getty on ttyX when we press ctrl + alt + FX. > I whould like to let systemd forks server gettys on all of tty deivces by default. > this is very useful in container environment, since we can't use ctrl+alt+FX >

[systemd-devel] getty : how to run getty on every ttyX

2013-12-13 Thread Gao feng
Hi, As we know, systemd only forks getty on ttyX when we press ctrl + alt + FX. I whould like to let systemd forks server gettys on all of tty deivces by default. this is very useful in container environment, since we can't use ctrl+alt+FX to trigger getty in container. If there are some configu