Re: [systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-07 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Mon, 06.10.14 13:21, Jan Synacek (jsyna...@redhat.com) wrote: Hmm with this change in place we'd have different behaviour for the cases where systemctl executes the operation client-side, and when it goes via the bus. We really should keep

Re: [systemd-devel] [PATCH 2/2] sysusers.d: split files to cope with split packages.

2014-10-07 Thread Simon McVittie
On 25/09/14 22:12, Gustavo Sverzut Barbieri wrote: move each user/group creation to a file that represents its own split package, so it's possible to ship them in separate. Even if you split out bits of systemd functionality like networkd, timesyncd, kdbus into separate binary packages, what

[systemd-devel] [PATCH] core: don't allow enabling if unit is masked

2014-10-07 Thread Jan Synacek
--- src/shared/install.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/shared/install.c b/src/shared/install.c index fa064c2..945bb27 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -1516,6 +1516,19 @@ int unit_file_enable( return r;

[systemd-devel] [PATCH v2] core: don't allow enabling if unit is masked

2014-10-07 Thread Jan Synacek
I'm not sure about the error type and message the user gets, though. It seems that the only way to do this currently is to return an approximate errno, which gets translated on the client side and the real message is then found in the error log. Changes in v2: - move the funcionality to a

[systemd-devel] [PATCH] core: map the 'rescue' argument to rescue.target

2014-10-07 Thread Mantas Mikulėnas
Even though the 'emergency' and 'single' aliases come from sysvinit, the lack of 'rescue' is still quite confusing (caught me by surprise for the 9th time yet) and inconsistent with `systemctl rescue` as well. --- src/core/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/main.c

[systemd-devel] [PATCH v4] systemctl: add add-wants and add-requires verbs

2014-10-07 Thread Lukas Nykryn
--- Changes in v4 - renamed install_dependency - dependency - removed the enum with dependencies and used the general one instead - add an error meesage in the case that --root is used and it fails - changes in manpage TODO | 1 - man/systemctl.xml

Re: [systemd-devel] [PATCH 2/4] mount-setup: introduce mount_setup_run_dirs()

2014-10-07 Thread Michal Sekletar
On Thu, Oct 02, 2014 at 11:43:22AM +0200, Lennart Poettering wrote: On Thu, 02.10.14 09:57, Michal Sekletar (msekl...@redhat.com) wrote: In cases when we are running as system manager, but we don't have the capability to mount filesystems don't call mount_setup(). However we assume that

Re: [systemd-devel] [PATCH 3/4] shutdown: don't do final unmounting when inside the container and running without CAP_SYS_ADMIN

2014-10-07 Thread Michal Sekletar
On Thu, Oct 02, 2014 at 12:04:02PM +0200, Lennart Poettering wrote: On Thu, 02.10.14 09:57, Michal Sekletar (msekl...@redhat.com) wrote: #define FINALIZE_ATTEMPTS 50 @@ -207,7 +208,11 @@ int main(int argc, char *argv[]) { in_container = detect_container(NULL) 0; -

Re: [systemd-devel] variable expansion in ExecStart

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 06, 2014 at 05:52:40PM +0200, Lennart Poettering wrote: On Sat, 04.10.14 21:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Hi, Environment=X='Y' Z ExecStart=/bin/echo $X ${X} results in echo[31266]: Y Z 'Y' Z i.e., $X not only splits at whitespace, as

Re: [systemd-devel] [PATCH v4] systemctl: add add-wants and add-requires verbs

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 02:09:37PM +0200, Lukas Nykryn wrote: --- Changes in v4 - renamed install_dependency - dependency - removed the enum with dependencies and used the general one instead This part should really be a separate commit. It moves a lot of code around and makes it harder to see

Re: [systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 08:23:32AM +0200, Jan Synacek wrote: While I'm at it, what about disable? Should it behave in the same way, i.e. return error when the unit is masked? My guess is that yes, but I'm not sure. I don't see a reason why disabling should be disallowed. I think we even allow

[systemd-devel] Bug? /dev/disk/by-path symlinks disappear for iSCSI targets

2014-10-07 Thread Lee Duncan
Hi: I am debugging a problem where the symlinks in /dev/disk/by-path disappeared for iSCSI target devices. It looks like it's from systemd/udev commit e98bbfd2074e2b1079b7059341eac25741baf319 udev: path_id - suppress ID_PATH for devices with an unknown parent device type I believe the worry

[systemd-devel] Shell expressions in EnvironmentFile

2014-10-07 Thread Jon Stanley
Since EnvironmentFile in a service isn't sourced by any shell, shell expressions in it will obviously not work the way that they did in a SysV style script. Nor does it seems that the environment gets preserved between ExecStartPre (where one could run a script that sets environment variables to

Re: [systemd-devel] Shell expressions in EnvironmentFile

2014-10-07 Thread Simon Peeters
2014-10-07 19:12 GMT+02:00 Jon Stanley jonstan...@gmail.com: Since EnvironmentFile in a service isn't sourced by any shell, shell expressions in it will obviously not work the way that they did in a SysV style script. Nor does it seems that the environment gets preserved between ExecStartPre

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-07 Thread Rob Owens
- Original Message - From: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl On Mon, Oct 06, 2014 at 02:56:22PM -0400, Rob Owens wrote: On Debian, I came across an unusual dependency. Installing a cd burner (brasero) required me to change my init system to systemd. Sounds kind of

[systemd-devel] [PATCH 0/3 v2] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-07 Thread Ken Sedgwick
Ken Sedgwick (3): Added test for unit file state returned by unit_file_get_state and unit_file_get_list. Made test-enabled units more basic, removing superfluous fields. Cleaned up test path assignment code. ___ systemd-devel mailing list

[systemd-devel] [PATCH 1/3] Added test for unit file state returned by unit_file_get_state and unit_file_get_list.

2014-10-07 Thread Ken Sedgwick
--- .gitignore | 1 + Makefile.am| 44 ++- src/test/test-enabled.c| 143 + .../etc/systemd/system/masked.service | 1 +

[systemd-devel] [PATCH 2/3] Made test-enabled units more basic, removing superfluous fields.

2014-10-07 Thread Ken Sedgwick
--- test/test-enabled-root/etc/systemd/system/some.target | 6 +- test/test-enabled-root/run/systemd/system/other.target | 3 +-- test/test-enabled-root/usr/lib/systemd/system/another.service | 7 ++-

[systemd-devel] [PATCH 3/3] Cleaned up test path assignment code.

2014-10-07 Thread Ken Sedgwick
--- src/test/test-enabled.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/test/test-enabled.c b/src/test/test-enabled.c index 607f68c..104348e 100644 --- a/src/test/test-enabled.c +++ b/src/test/test-enabled.c @@ -75,9 +75,6 @@ */ -const char *subdir =

Re: [systemd-devel] Shell expressions in EnvironmentFile

2014-10-07 Thread Dale R. Worley
From: Simon Peeters peeters.si...@gmail.com 2014-10-07 19:12 GMT+02:00 Jon Stanley jonstan...@gmail.com: [Service] ExecStartPre=/something/that/sets/var ExecStart=/some/file $var ExecStart=/bin/sh -c . /something/that/sets/var; /some/file $var Yeah, I think some thing like this would

[systemd-devel] [PATCH, REVIEW] Added unit enabled-context cache to improve performance w/ many units.

2014-10-07 Thread Ken Sedgwick
The attached patch adds an EnabledContext cache so systems with 1000s of units do not suffer O(N^2) performance when determining unit state. The test-enabled unit test (added to master under other patch) is used to confirm that the returned states are the same as the current master. Please

Re: [systemd-devel] [PATCH 2/3] Made test-enabled units more basic, removing superfluous fields.

2014-10-07 Thread David Timothy Strauss
I think the test additions need to be rebased into a single commit onto master rather than the initial patch plus the fixes as a second commit. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-07 Thread Uoti Urpala
On Tue, 2014-10-07 at 14:15 -0400, Rob Owens wrote: My question really isn't why are the Debian dependencies the way they are. I understand that. I was trying to highlight the strange situation of a desktop application requiring a particular init system. I *think* this is a result of the

Re: [systemd-devel] [PATCH] core: don't allow enabling if unit is masked

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 01:35:41PM +0200, Jan Synacek wrote: --- src/shared/install.c | 13 + 1 file changed, 13 insertions(+) Applied. Making the error messages better is another step that needs to be done. Zbyszek ___ systemd-devel

Re: [systemd-devel] [PATCH v4] systemctl: add add-wants and add-requires verbs

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 05:46:48PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Tue, Oct 07, 2014 at 02:09:37PM +0200, Lukas Nykryn wrote: --- Changes in v4 - renamed install_dependency - dependency - removed the enum with dependencies and used the general one instead This part should

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 06, 2014 at 06:57:38PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Oct 06, 2014 at 06:36:34PM +0200, Jan Janssen wrote: *bump* Sorry, I'll look into this. Doesn't work. Both without or with your other patch sd_journal_enumerate_unique I get bogus results on my test case. It

Re: [systemd-devel] Systemd-nspawn: Cannot create tun device in container

2014-10-07 Thread James Lott
Does anyone have any feedback on this thread? If it's not possible for a container to create its own /dev/net/tun device (or use the host system's), I'll just move on to finding a less preferable solution. On Oct 3, 2014, at 10:46 AM, James Lott ja...@lottspot.com wrote: Hello, list!

[systemd-devel] [PATCH] note on relative symlink in os-release

2014-10-07 Thread Rahul Sundaram
--- man/os-release.xml | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/man/os-release.xml b/man/os-release.xml index 4e02f80..b298304 100644 --- a/man/os-release.xml +++ b/man/os-release.xml @@ -90,11 +90,15 @@ files at the same

[systemd-devel] [PATCH v2] Added test for unit file state returned by unit_file_get_state and unit_file_get_list. Made test-enabled units more basic, removing superfluous fields. Cleaned up test path

2014-10-07 Thread Ken Sedgwick
--- .gitignore | 1 + Makefile.am| 44 ++- src/test/test-enabled.c| 141 + .../etc/systemd/system/masked.service | 1 +

[systemd-devel] [PATCH v2] Added test for unit file state returned by unit_file_get_state and unit_file_get_list

2014-10-07 Thread Ken Sedgwick
Combined initial submission and subsequent fixes into a single patch. Ken Sedgwick (1): Added test for unit file state returned by unit_file_get_state and unit_file_get_list. Made test-enabled units more basic, removing superfluous fields. Cleaned up test path assignment code.