Re: [systemd-devel] [PATCH] libudev: Use correct free function

2014-11-01 Thread Tom Gundersen
This has now been applied. Thanks! On Sat, Nov 1, 2014 at 8:59 PM, Colin Walters wrote: > FILE * wants cleanup_fclose(). > > Spotted by udev hwdb segfaulting in gnome-continuous' buildroot > construction. > --- > src/libudev/libudev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > >

[systemd-devel] [PATCH] libudev: Use correct free function

2014-11-01 Thread Colin Walters
FILE * wants cleanup_fclose(). Spotted by udev hwdb segfaulting in gnome-continuous' buildroot construction. --- src/libudev/libudev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From ab6d4e20cb37dc666bbd80b5014a6bf91d4aa554 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Sat, 1 No

Re: [systemd-devel] [PATCH] scsi_id: fix usage spelling

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Nov 01, 2014 at 12:18:08PM -0400, Joe Lawrence wrote: > s/threat/treat/g Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] kernel-install/90-loaderentry.install: fix cmdline parsing

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 11:54:07AM +1100, Michael Chapman wrote: > A recent commit (2f3a215) changed the parsing of /proc/cmdline to use a > shell array. Unfortunately, this introduced a bug: "read -ar line" > populates the shell variable $r, not $line. This breaks installation of > new loader entr

Re: [systemd-devel] [PATCH] bus: use STR_IN_SET

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 30, 2014 at 03:45:15PM +0900, WaLyong Cho wrote: > --- > src/core/dbus-unit.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.

Re: [systemd-devel] [PATCH] man: explain journalctl --flush correctly

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 11:20:02AM +0100, Umut Tezduyar Lindskog wrote: > --- > NEWS | 4 > man/journalctl.xml | 4 ++-- > 2 files changed, 6 insertions(+), 2 deletions(-) Applied. Zbyszek ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH v3] core: improve error message when machine id is missing

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 31, 2014 at 10:16:45AM +0100, Jan Synacek wrote: > --- > Changes in v3: > - check correct errno > Changes in v2: > - show long explanation only when errno == EROFS > > src/core/machine-id-setup.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/

Re: [systemd-devel] [PATCH] sd-dhcp6-client: fix off-by-two error in DUID length

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 31, 2014 at 12:20:21PM -0500, Dan Williams wrote: > The duid data passed by the caller does not include the DUID type, > but sd_dhcp6_client_set_duid() was treating it like it did. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH 4/5] constant for weekdays_bits

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
Applied this one. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] unit A is WantedBy unit B but unit B does not Want unit A?

2014-11-01 Thread Andrei Borzenkov
Sometimes device gets Wants on mount point; sometimes not. I do not really understand why. Also different mount units apparently behave differently - e.g. mnt.mount "forgets" its history. It almost looks like mnt.mount is destroyed after it is unmounted and t.mount not ... cat /etc/fstab UUID=ec5c

[systemd-devel] [PATCH] scsi_id: fix usage spelling

2014-11-01 Thread Joe Lawrence
s/threat/treat/g --- src/udev/scsi_id/scsi_id.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/udev/scsi_id/scsi_id.c b/src/udev/scsi_id/scsi_id.c index 4d9378a..48c6cf7 100644 --- a/src/udev/scsi_id/scsi_id.c +++ b/src/udev/scsi_id/scsi_id.c @@ -317,8 +317,8 @@ sta