[systemd-devel] SELinux code in method_{disable, enable}_unit_files_generic() functions

2014-11-04 Thread Laurent Bigonville
Hello, After looking a bit around the code, I've two questions about the SELinux code in method_{disable,enable}_unit_files_generic() functions. In method_enable_unit_files_generic(), mac_selinux_unit_access_check_strv() is used to check the SELinux permissions while in

[systemd-devel] [PATCH] smack: introduce new SmackLabelExec option

2014-11-04 Thread WaLyong Cho
In case of systemd has _ label and run as root, if a service file has User= option and the command line file has a special SMACK label then systemd will fail to execute the command. Generally, SMACK label is ignored for the root. But if a service has a User= then systemd will call setresuid() in

Re: [systemd-devel] Detecting inactive sessions

2014-11-04 Thread David Herrmann
Hi Bastien On Mon, Nov 3, 2014 at 5:30 PM, Bastien Nocera had...@hadess.net wrote: On Mon, 2014-11-03 at 17:28 +0100, David Herrmann wrote: Hi On Wed, Oct 29, 2014 at 3:45 PM, Bastien Nocera had...@hadess.net wrote: For a very specific definition of inactive. I'm looking at a way for

Re: [systemd-devel] Detecting inactive sessions

2014-11-04 Thread Bastien Nocera
On Tue, 2014-11-04 at 10:09 +0100, David Herrmann wrote: Hi Bastien On Mon, Nov 3, 2014 at 5:30 PM, Bastien Nocera had...@hadess.net wrote: On Mon, 2014-11-03 at 17:28 +0100, David Herrmann wrote: Hi On Wed, Oct 29, 2014 at 3:45 PM, Bastien Nocera had...@hadess.net wrote: For a very

Re: [systemd-devel] Unicode support in console after boot

2014-11-04 Thread David Herrmann
Hi On Thu, Oct 23, 2014 at 6:01 PM, Ray Strode halfl...@gmail.com wrote: Hi, On Tue, Oct 21, 2014 at 1:39 PM, Ivan Shapovalov intelfx...@gmail.com wrote: Please try editing /usr/lib/systemd/system/systemd-vconsole-setup.service and remove RemainAfterExit=yes, then regenerate your

Re: [systemd-devel] [PATCH 2/5] libsystemd:terminal :fix uninitialized warning

2014-11-04 Thread David Herrmann
Hi On Mon, Nov 3, 2014 at 1:50 PM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 03.11.14 13:46, David Herrmann (dh.herrm...@gmail.com) wrote: static inline int negative_errno(void) { assert_return(errno 0, -EINVAL); return -errno; } Looks great to me! But

[systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-04 Thread Jan Synacek
As mentioned in [1], it would probably be better if the validation errors were just warnings, but I'm not sure if that can be achieved over dbus. [1] http://lists.freedesktop.org/archives/systemd-devel/2014-October/024129.html Jan Synacek (1): localed: validate set-x11-keymap input

[systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-04 Thread Jan Synacek
Try to validate the input similarly to how setxkbmap does it. Multiple layouts and variants can be specified, separated by a comma. Variants can also be left out, meaning that the user doesn't want any particular variant for the respective layout. Variants are validated respectively to their

[systemd-devel] [PATCH] man/tmpfiles.d: fix typo

2014-11-04 Thread Jan Synacek
--- man/tmpfiles.d.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/tmpfiles.d.xml b/man/tmpfiles.d.xml index f2360ba..1b14d69 100644 --- a/man/tmpfiles.d.xml +++ b/man/tmpfiles.d.xml @@ -108,8 +108,8 @@ filename in lexicographic order, regardless

[systemd-devel] systemd-machined sigterm, cgroups trimmed

2014-11-04 Thread Major Hayden
Hello there, I'm currently running systemd 216 on Fedora 21 and I've found an issue where systemd-machined stops running and cgroups are trimmed from the scope of running qemu virtual machines. The series of events looks like this: 1) OpenStack nova creates a KVM virtual machine via libvirt

Re: [systemd-devel] Race condition on systemd-run --scope

2014-11-04 Thread Umut Tezduyar Lindskog
Hi Lennart, Were you able to figure out the problem? You were suspecting that we might not be getting cgroup empty notifications from kernel. Umut On Fri, Oct 24, 2014 at 3:19 PM, Umut Tezduyar Lindskog u...@tezduyar.com wrote: Hi, Since you said you have covered my theories when you

[systemd-devel] systemd-nspawn - exporting /dev/video0

2014-11-04 Thread MohanR
Hi, I'm in need to passthrough /dev/video0 for a gstreamer based application development. Is it possible using systemd-nspawn? I tried enabling CAP_MKNOD and manually creating /dev/video0. But it was not recognized. Is there any way to do it? Thanks, Mohan R

[systemd-devel] [PATCH] switch_root: do not fail, if base_filesystem_create() failed

2014-11-04 Thread harald
From: Harald Hoyer har...@redhat.com Not all switch roots are like base_filesystem_create() wants them to look like. They might even boot, if they are RO and don't have the FS layout. Just ignore the error and switch_root nevertheless. base_filesystem_create() should have logged, what went

Re: [systemd-devel] Changing configurations with networkd

2014-11-04 Thread Dan Williams
On Wed, 2014-07-23 at 16:46 +0200, Marcel Holtmann wrote: Hi Michael, I think the lease should be remembered and reused in this case. Hm, this sounds like a bug somewhere. When the new discover is sent out it should send the same identifying information to the server, and hence be

[systemd-devel] [PATCH] sd-dhcp-client: fix REBOOT state handling

2014-11-04 Thread Dan Williams
client-secs wasn't getting set in the REBOOT state, causing an assertion. REBOOT should work the same way as INIT, per RFC 2131: secs 2 Filled in by client, seconds elapsed since client began address acquisition or renewal process. REBOOT is necessary because some DHCP servers

[systemd-devel] [PATCH] sd-dhcp-lease: expose load/save functions

2014-11-04 Thread Dan Williams
They're useful outside of networkd itself in the libsystemd-network library. --- src/libsystemd-network/dhcp-lease-internal.h | 3 --- src/libsystemd-network/sd-dhcp-lease.c | 4 ++-- src/network/networkd-link.c | 2 +- src/systemd/sd-dhcp-lease.h | 3 +++

[systemd-devel] [PATCH] sd-dhcp-client: allow getting/setting the client ID

2014-11-04 Thread Dan Williams
The client identifier can be in many different formats, not just the one that systemd creates from the Ethernet MAC address. Non- ethernet interfaces have different client IDs formats too. Users may also have custom client IDs that they wish to use to preserve lease options delivered by servers

Re: [systemd-devel] [question] networkd: Any support for hooks?

2014-11-04 Thread Tomasz Torcz
On Thu, Oct 02, 2014 at 08:36:10AM +0200, Lennart Poettering wrote: On Wed, 01.10.14 21:36, Cameron Norman (camerontnor...@gmail.com) wrote: Hello, ifupdown [1], NetworkManager, and WICD all support hooks for when a network interface is configured or deconfigured (before and after

Re: [systemd-devel] [PATCH] switch_root: do not fail, if base_filesystem_create() failed

2014-11-04 Thread Daniel Buch
I think you might want to cast it to avoid compiler warning. Like: (void) base_filesystem_create() Den 04/11/2014 17.36 skrev har...@redhat.com: From: Harald Hoyer har...@redhat.com Not all switch roots are like base_filesystem_create() wants them to look like. They might even boot, if they

Re: [systemd-devel] [question] networkd: Any support for hooks?

2014-11-04 Thread Lennart Poettering
BOn Tue, 04.11.14 19:07, Tomasz Torcz (to...@pipebreaker.pl) wrote: On Thu, Oct 02, 2014 at 08:36:10AM +0200, Lennart Poettering wrote: On Wed, 01.10.14 21:36, Cameron Norman (camerontnor...@gmail.com) wrote: Hello, ifupdown [1], NetworkManager, and WICD all support hooks for when

Re: [systemd-devel] [question] networkd: Any support for hooks?

2014-11-04 Thread Jóhann B. Guðmundsson
On 11/04/2014 06:07 PM, Tomasz Torcz wrote: Example: I'd like to add interface to proper firewalld zone. Ideally it could be done by networkd itself (it just one dbus call: addInterface(in s zone, in s interface, …) based on new Zone=string setting in .netdev file. Hook can determine

Re: [systemd-devel] [PATCH] man/tmpfiles.d: fix typo

2014-11-04 Thread David Herrmann
Hi On Tue, Nov 4, 2014 at 1:38 PM, Jan Synacek jsyna...@redhat.com wrote: --- man/tmpfiles.d.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied! Thanks David diff --git a/man/tmpfiles.d.xml b/man/tmpfiles.d.xml index f2360ba..1b14d69 100644 --- a/man/tmpfiles.d.xml

Re: [systemd-devel] Poor man's reboot doesn't work

2014-11-04 Thread Thomas Meyer
Am 02.11.2014 um 12:48 schrieb Thomas Meyer tho...@m3y3r.de: Hi, I tried to switch to the emergency target and back to the graphical target, but this doesn't seem to work. Should this work, i.e.? # systemctl isolate emergency.target # systemctl isolate graphical.target The

[systemd-devel] [PATCH] sysusers.c: make use of negative_errno()

2014-11-04 Thread Daniel Buch
This is recently added by david. And i like replace return -errno treewide if desired? I suppose its safe and correct to assume every return -errno can be replaced? --- src/sysusers/sysusers.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [systemd-devel] instantiated services set up

2014-11-04 Thread Jan Včelák
Hi! OK. I will remove the syslog. But I will have to keep network.target for now as we support non-Linux systems as well. Adding support for rtnl or IP_FREEBIND would mean duplicating a lot of code... probably. Note that invoking IP_FREEBIND is just a single setsockopt() line... You are

Re: [systemd-devel] [PATCH] sysusers.c: make use of negative_errno()

2014-11-04 Thread Daniel Buch
Nevermind, ignore this. This is of course only where gcc complaints. Den 04/11/2014 20.53 skrev Daniel Buch boogiewasth...@gmail.com: This is recently added by david. And i like replace return -errno treewide if desired? I suppose its safe and correct to assume every return -errno can be

Re: [systemd-devel] instantiated services set up

2014-11-04 Thread Tomasz Torcz
On Tue, Nov 04, 2014 at 08:56:48PM +0100, Jan Včelák wrote: Hi! OK. I will remove the syslog. But I will have to keep network.target for now as we support non-Linux systems as well. Adding support for rtnl or IP_FREEBIND would mean duplicating a lot of code... probably. Note that

Re: [systemd-devel] [question] networkd: Any support for hooks?

2014-11-04 Thread Dan Williams
On Tue, 2014-11-04 at 19:40 +0100, Lennart Poettering wrote: BOn Tue, 04.11.14 19:07, Tomasz Torcz (to...@pipebreaker.pl) wrote: On Thu, Oct 02, 2014 at 08:36:10AM +0200, Lennart Poettering wrote: On Wed, 01.10.14 21:36, Cameron Norman (camerontnor...@gmail.com) wrote: Hello,

[systemd-devel] [PATCH] udev: Fix parsing of udev.event-timeout kernel parameter.

2014-11-04 Thread Richard W.M. Jones
--- src/udev/udevd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 2e6c713..206a4d3 100644 --- a/src/udev/udevd.c +++ b/src/udev/udevd.c @@ -994,7 +994,7 @@ static void kernel_cmdline_options(struct udev *udev) {

Re: [systemd-devel] [PATCH] udev: Fix parsing of udev.event-timeout kernel parameter.

2014-11-04 Thread Ronny Chevalier
2014-11-05 0:31 GMT+01:00 Richard W.M. Jones rjo...@redhat.com: Hi, --- src/udev/udevd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 2e6c713..206a4d3 100644 --- a/src/udev/udevd.c +++ b/src/udev/udevd.c @@ -994,7 +994,7 @@

[systemd-devel] [PATCH v2] udev: Fix parsing of udev.event-timeout kernel parameter.

2014-11-04 Thread Richard W.M. Jones
--- src/udev/udevd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index 2e6c713..193702c 100644 --- a/src/udev/udevd.c +++ b/src/udev/udevd.c @@ -994,9 +994,9 @@ static void kernel_cmdline_options(struct udev *udev) {

[systemd-devel] [PATCH v2] udev: Fix parsing of udev.event-timeout kernel parameter.

2014-11-04 Thread Richard W.M. Jones
v2: - Fix the warning message too (thanks Ronny Chevalier). In reply to Ronny's comment about using strlen: I agree, but that's a rather larger patch than I need to fix my immediate bug. Rich. ___ systemd-devel mailing list

[systemd-devel] [PATCH] buildsys: test-util needs -lm for fabs()

2014-11-04 Thread Cristian Rodríguez
--- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index ff5f61b..3686103 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1543,6 +1543,7 @@ test_util_SOURCES = \ src/test/test-util.c test_util_LDADD = \ + -lm \ libsystemd-core.la