Re: [systemd-devel] [PATCH][Resend][RFC] core: Fix wrong timestamps in rtc-in-local time mode.

2014-12-25 Thread Chunhui He
Thanks David! Yes, I missed Lennart's reply. Thanks Lennart! Yes, I agree rtc-in-local-time is a compatibility hack. But I think similar issues in other components is orthogonal to this bug. The key is that systemd records _inconsistent_ timestamps. It's surely a logic _error_ introduced in

Re: [systemd-devel] Variable expansion in ConditionPathExists

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 24, 2014 at 10:37:50AM -0200, Marcos Felipe Rasia de Mello wrote: Hi, I have a system service that runs with a normal user account ([Service] User=bla). I tried [Unit] ConditionPathExists=$HOME/config.xml but it does not work: systemd[1]:

Re: [systemd-devel] Variable expansion in ConditionPathExists

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 25, 2014 at 03:36:15PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Dec 24, 2014 at 10:37:50AM -0200, Marcos Felipe Rasia de Mello wrote: Hi, I have a system service that runs with a normal user account ([Service] User=bla). I tried [Unit]

Re: [systemd-devel] [PATCH 0/9] capabilities: remove include of sys/capability.h where possible

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:45:07AM -0800, Filipe Brandenburger wrote: On Tue, Dec 23, 2014 at 5:23 AM, David Herrmann dh.herrm...@gmail.com wrote: I cannot find these patches on systemd-devel@lists.freedesktop.org. This might be due to fdo mail-server issues, or me just being incapable of

Re: [systemd-devel] [PATCHv2] test: do not use last cap from kernel in test-cap-list

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 01:51:40PM -0800, Filipe Brandenburger wrote: The new test-cap-list introduced in commit 2822da4fb7f891 uses the included table of capabilities. However, it uses cap_last_cap() which probes the kernel for the last available capability. On an older kernel (e.g. 3.10 from

Re: [systemd-devel] [PATCHv2] update .gitignore to include test-lldp

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:51:54AM -0800, Filipe Brandenburger wrote: --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 1b5d60f..078fd9a 100644 --- a/.gitignore +++ b/.gitignore @@ -207,6 +207,7 @@ /test-libudev-sym* /test-list

Re: [systemd-devel] [PATCH] doc: os-release: mention all shell characters that must be escaped

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 24, 2014 at 02:46:20PM +0200, Mantas Mikulėnas wrote: Since the manpage already talks about shell-compatibility, it should be more accurate about what needs to be escaped and how. --- Applied. Zbyszek ___ systemd-devel mailing list

Re: [systemd-devel] [PATCHv2 2/2] build-sys: remove references to dbusinterfacedir

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:59:15AM -0800, Filipe Brandenburger wrote: This directory is not used by systemd. Tested by running a full build, running `make install` and comparing the file list in the target trees and making sure that `make distcheck` still works. --- configure.ac | 7

Re: [systemd-devel] [PATCH] timesync: remove square(), use pow instead

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 05:52:51PM -0300, Cristian Rodríguez wrote: In any case, the compiler generates the same code inline and never actually calls the library function. Applied. Zbyszek ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH 1/3] machined: add org.freedesktop.machine1.policy.in to POTFILES.in

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 03:02:14PM -0800, Filipe Brandenburger wrote: The new polkit file was introduced in commit d04c1fb8e21560 (machined: introduce polkit for OpenLogin() call). Applied. Zbyszek ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH 2/3] build-sys: update path in reference to sd-lldp.h

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 03:03:21PM -0800, Filipe Brandenburger wrote: The file was moved from src/libsystemd-network to src/systemd in commit 7a6f1457462840 (sd-lldp: minor header cleanup). This fixes make distcheck. Applied. Zbyszek ___

Re: [systemd-devel] [PATCH 2/2] udev: fix another strict aliasing issue

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 03:04:37PM -0800, Shawn Paul Landden wrote: --- src/udev/ata_id/ata_id.c | 62 +++- 1 file changed, 30 insertions(+), 32 deletions(-) Both applied. I made a follow up commit to remove an uint64_t* temp variable. The compiler

Re: [systemd-devel] [PATCH 2/2] test: wait for cloned thread to exit

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:15:49AM -0800, Filipe Brandenburger wrote: In test_raw_clone, make sure the cloned thread calls _exit() and in the parent thread call waitpid(..., __WCLONE) to wait for the child thread to terminate, otherwise there is a race condition where the child thread will log

Re: [systemd-devel] [PATCH 1/2] test: only use assert_se in test_raw_clone

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:14:46AM -0800, Filipe Brandenburger wrote: The asserts used in the tests should never be allowed to be optimized away. Applied 1/2 too. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] Variable expansion in ConditionPathExists

2014-12-25 Thread Marcos Felipe Rasia de Mello
2014-12-25 14:18 GMT-02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Thu, Dec 25, 2014 at 03:36:15PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Dec 24, 2014 at 10:37:50AM -0200, Marcos Felipe Rasia de Mello wrote: Hi, I have a system service that runs with a normal user

[systemd-devel] Delegate=yes and user instance's resource controlling

2014-12-25 Thread Ivan Shapovalov
Hi! Judging from commit a931ad47a8623163a29d898224d8a8c1177ffdaf, the systemd user instance is intentionally restricted from touching !systemd hierarchies. So, things like systemctl --user set-property foo.service MemoryLimit=XYZ do not work. Is this restriction going to be lifted in the future?

Re: [systemd-devel] [PATCH] gummiboot: freeing the wrong variable

2014-12-25 Thread Kay Sievers
On Mon, Dec 22, 2014 at 9:44 PM, David Härdeman da...@hardeman.nu wrote: The error path in efivar_get free's what would have been the copy of the string if the strcpy had succeeded, which it did not (or we wouldn't be in the error path). Applied. Thanks, Kay

Re: [systemd-devel] [PATCH 0/5] Enhancements to libabc template project

2014-12-25 Thread Kay Sievers
On Sat, Dec 6, 2014 at 11:46 PM, Josh Triplett j...@joshtriplett.org wrote: I went to use libabc as the basis for a new library, and found a few issues; rather than just correcting them in my own library, I'd like to push the changes back into libabc. Josh Triplett (5): Makefile.am: Don't

Re: [systemd-devel] [PATCH 1/4] path-lookup, systemctl: export lookup_paths_init_from_scope() from shared/install.c and use it

2014-12-25 Thread Ivan Shapovalov
On Friday 19 December 2014 at 17:08:07, Ivan Shapovalov wrote: --- src/shared/install.c | 16 src/shared/path-lookup.c | 16 src/shared/path-lookup.h | 4 src/systemctl/systemctl.c | 6 +- 4 files changed, 21 insertions(+), 21

Re: [systemd-devel] [PATCH 0/5] Enhancements to libabc template project

2014-12-25 Thread Josh Triplett
On Thu, Dec 25, 2014 at 10:20:14PM +0100, Kay Sievers wrote: On Sat, Dec 6, 2014 at 11:46 PM, Josh Triplett j...@joshtriplett.org wrote: I went to use libabc as the basis for a new library, and found a few issues; rather than just correcting them in my own library, I'd like to push the