Re: [systemd-devel] requiring all template instances in a service

2015-02-26 Thread Benjamin Rose
Thank you very much for this, it greatly helped me understand how this all works. I have therefore solved this issue with the following simple solution: [root@example ~]# cat /etc/systemd/system/teamd\@.service.d/before_network.conf [Unit] Before=network.target I will post this in RH

Re: [systemd-devel] Linking containers

2015-02-26 Thread Peter Paule
Excerpts from Lennart Poettering's message of 2015-02-25 19:57:10 +0100: dhcp client you mean? Yes. In general, I am not really keen on doing IP configuration in nspawn. We have one solution for doing IP configuration already in systemd, and that's networkd, and it's a ton more powerful than

Re: [systemd-devel] [PATCH] hwdb: add sdio identifiers for Broadcom WLAN cards

2015-02-26 Thread Marcel Holtmann
Hi Arend, This patch adds the sdio identifiers known to be supported by the brcmfmac open-source driver. Cc: Marcel Holtmann mar...@holtmann.org Signed-off-by: Arend van Spriel ar...@broadcom.com I remove the signed-off-by line since it is not standard practice here and then applied the

Re: [systemd-devel] requiring all template instances in a service

2015-02-26 Thread Benjamin Rose
So given the distro unit file for teamd on RHEL7: [Unit] Description=Team Daemon for device %I [Service] BusName=org.libteam.teamd.%i ExecStart=/usr/bin/teamd -U -D -t %i -f /run/teamd/%i.conf Should I just make something like this...? /etc/systemd/system/teamd@.service.d/require_network.conf:

Re: [systemd-devel] [PATCH] unit: When stopping due to BindsTo=, log which unit caused it

2015-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Feb 17, 2015 at 01:47:34PM -0500, Colin Walters wrote: I'm trying to track down a relatively recent change in systemd which broke OSTree; see https://bugzilla.gnome.org/show_bug.cgi?id=743891 Systemd started to stop sysroot.mount, and this patch should help me debug why at least.

Re: [systemd-devel] [PATCH] unit: When stopping due to BindsTo=, log which unit caused it

2015-02-26 Thread Martin Pitt
Hey Colin, Colin Walters [2015-02-24 15:05 -0500]: http://cgit.freedesktop.org/systemd/systemd/commit/?id=06e9783e2cc12eb6514e80c7f0014295f59b broke OSTree: https://bugzilla.redhat.com/show_bug.cgi?id=1195761#c1 I'm likely going to carry a revert downstream until I get a chance to

Re: [systemd-devel] [PATCH] core: emit changes for NFailedUnits property

2015-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 26, 2015 at 12:31:50AM -0300, Lucas De Marchi wrote: On Wed, Feb 18, 2015 at 2:22 PM, lucas.de.mar...@gmail.com wrote: From: Lucas De Marchi lucas.demar...@intel.com By notifying the clients when this property is changed it's possible to allow system health monitor tools to

Re: [systemd-devel] [PATCH 2/2] vconsole: set font on tty16..tty63 as well

2015-02-26 Thread Jan Engelhardt
On Wednesday 2015-02-25 21:10, Lennart Poettering wrote: The setup program would not set the font on tty16 upwards. There is a maximum of 63 VCs possible in Linux. (That number is hardcoded.) We deliberately do not support such high VTs in systemds. And what's the rationale?

Re: [systemd-devel] [PATCH] core/mount: only add dependencies to active units for dynamic mounts [was: Re: unit: When stopping due to BindsTo=, log which unit caused it]

2015-02-26 Thread Colin Walters
Hi Martin, thanks for looking into this. On Thu, Feb 26, 2015, at 12:43 PM, Martin Pitt wrote: The attached patch does that. It's not really pretty, but it works for me: mounts in the initramfs are now left alone, and the automatic unmount of force-ejected media is still working. The patch

[systemd-devel] [PATCH] core/mount: only add dependencies to active units for dynamic mounts [was: Re: unit: When stopping due to BindsTo=, log which unit caused it]

2015-02-26 Thread Martin Pitt
Hey all, Martin Pitt [2015-02-26 16:50 +0100]: IMHO it would be prudent to skip adding the BindsTo= if at the time of creating the .mount unit the backing .device unit doesn't actually exist. In that case it's a mount which isn't managed by systemd, and we shouldn't touch it. We mostly want

Re: [systemd-devel] requiring all template instances in a service

2015-02-26 Thread Andrei Borzenkov
В Thu, 26 Feb 2015 11:56:45 -0500 Benjamin Rose benr...@math.princeton.edu пишет: So given the distro unit file for teamd on RHEL7: [Unit] Description=Team Daemon for device %I [Service] BusName=org.libteam.teamd.%i ExecStart=/usr/bin/teamd -U -D -t %i -f /run/teamd/%i.conf Should I

Re: [systemd-devel] How to make debug-shell more usable?

2015-02-26 Thread Michael Biebl
2015-02-26 1:12 GMT+01:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Thu, Feb 26, 2015 at 01:04:55AM +0100, Michael Biebl wrote: 2015-02-26 0:55 GMT+01:00 Michael Biebl mbi...@gmail.com: To reproduce the problem, add e.g. a non-existing device to /etc/fstab The Waiting for device to

[systemd-devel] Cannot acquire DHCP lease

2015-02-26 Thread Jan Janssen
Hi, since commit commit 5bac5235934fabe5a3e6a9d47f4812f81034c427, networkd cannot acquire DHCP leases on my router if I dual boot with windows. It seems to be that my router is borked since I do get leases after resetting it to factory defaults, but once booting into the other OS, DHCP

Re: [systemd-devel] [PATCH] timedated: when performing SetTime compensate for program lag

2015-02-26 Thread David Herrmann
Hi On Mon, Feb 16, 2015 at 8:47 PM, Shawn Landden sh...@churchofgit.com wrote: I can't test this as kdbus doesn't build against Linux 3.19 --- TODO | 2 -- src/timedate/timedated.c | 14 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git

Re: [systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-26 Thread Jan Janssen
Shawn Landden shawn at churchofgit.com writes: void strv_free(char **l) { -strv_clear(l); +char **k; + +if (!l) +return; + +for (k = l; *k; k++) +free(*k); + free(l); } What are you trying to achieve here? I

[systemd-devel] [PATCH] boot: efi - move background pixel variable into different scope

2015-02-26 Thread Marcel Holtmann
CC src/boot/efi/splash.o src/boot/efi/splash.c: In function ‘graphics_splash’: src/boot/efi/splash.c:256:9: warning: missing initializer for field ‘Blue’ of ‘EFI_GRAPHICS_OUTPUT_BLT_PIXEL’ [-Wmissing-field-initializers] EFI_GRAPHICS_OUTPUT_BLT_PIXEL pixel = { }; ^ In

Re: [systemd-devel] [PATCH] boot: efi - fix missing include

2015-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 27, 2015 at 01:20:43AM +0100, Marcel Holtmann wrote: src/boot/efi/splash.c:312:9: warning: implicit declaration of function ‘graphics_mode’ [-Wimplicit-function-declaration] err = graphics_mode(TRUE); ^ Just push such trivial ones directly. Zbyszek

Re: [systemd-devel] [PATCH 5/8] power: these binaries are internal APIs

2015-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 20, 2015 at 02:31:02PM -0800, Shawn Landden wrote: They are not executed by a user (they all check how they were executed) so we can use assert() in main() just like we would anywhere else. --- src/power/shutdown.c | 20 ++-- src/power/shutdownd.c | 22

Re: [systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 20, 2015 at 07:16:36PM -0800, Shawn Landden wrote: Still use helper when Xen Dom0, to avoid duplicating some hairy code. Future: generate BootLoaderSpec files for other kernel install locations v2: support specifying the kernel version support appending to the kernel

Re: [systemd-devel] [PATCH 2/8] man/systemd.timer.xml: improve documentation of WakeSystem=

2015-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 20, 2015 at 02:30:59PM -0800, Shawn Landden wrote: --- man/systemd.timer.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/man/systemd.timer.xml b/man/systemd.timer.xml index 20890f2..4207be0 100644 --- a/man/systemd.timer.xml +++

Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-26 Thread Zbigniew Jędrzejewski-Szmek
I'm not sure we want this... Can you add some justification? Do they share code? On Fri, Feb 20, 2015 at 02:31:00PM -0800, Shawn Landden wrote: --- Makefile.am | 6 +- src/core/shutdown.c | 420 - src/power/Makefile| 28

Re: [systemd-devel] [v1] shutdown: add kexec loading, ?avoid calling `kexec` binary unnessecarily

2015-02-26 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 26, 2015 at 08:04:08AM +, Jan Janssen wrote: Shawn Landden shawn at churchofgit.com writes: void strv_free(char **l) { -strv_clear(l); +char **k; + +if (!l) +return; + +for (k = l; *k; k++) +

Re: [systemd-devel] [PATCH] boot: efi - fix missing include

2015-02-26 Thread Marcel Holtmann
Hi Zbyszek, src/boot/efi/splash.c:312:9: warning: implicit declaration of function ‘graphics_mode’ [-Wimplicit-function-declaration] err = graphics_mode(TRUE); ^ Just push such trivial ones directly. okay, pushed. I couldn't tell if this was intentional because of