[systemd-devel] [v3 3/4] add rpmvercmp()

2015-02-27 Thread Shawn Landden
--- Makefile.am| 2 + src/shared/rpmvercmp.c | 122 + src/shared/rpmvercmp.h | 14 ++ 3 files changed, 138 insertions(+) create mode 100644 src/shared/rpmvercmp.c create mode 100644 src/shared/rpmvercmp.h diff --git a/Makefile.a

[systemd-devel] [v3 4/4] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
Still use helper when Xen Dom0, to avoid duplicating some hairy code. I think the rbtree version was far more understandable as greedy_realloc0() is very messy to do correctly. Future: generate BootLoaderSpec files for other kernel install locations v2: support specifying the kernel version

[systemd-devel] [v3 2/4] update TODO

2015-02-27 Thread Shawn Landden
--- TODO | 2 ++ 1 file changed, 2 insertions(+) diff --git a/TODO b/TODO index e8e4800..1f5bfaa 100644 --- a/TODO +++ b/TODO @@ -32,6 +32,8 @@ External: * When lz4 gets an API for lz4 command output, make use of it to compress coredumps in a way compatible with /usr/bin/lz4. +* Fix emacs f

[systemd-devel] [v3 1/4] man: these binaries are internal APIs

2015-02-27 Thread Shawn Landden
--- man/systemd-halt.service.xml | 1 - man/systemd-shutdownd.service.xml | 1 - man/systemd-suspend.service.xml | 1 - 3 files changed, 3 deletions(-) diff --git a/man/systemd-halt.service.xml b/man/systemd-halt.service.xml index c94e2a1..7e7f8f2 100644 --- a/man/systemd-halt.service.xml

Re: [systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
On Thu, Feb 26, 2015 at 12:04 AM, Jan Janssen wrote: > Shawn Landden churchofgit.com> writes: > > > void strv_free(char **l) { > > -strv_clear(l); > > +char **k; > > + > > +if (!l) > > +return; > > + > > +for (k = l; *k; k++) > > +

[systemd-devel] sd_id128_equal borked

2015-02-27 Thread Shawn Landden
_sd_pure_ static inline int sd_id128_equal(sd_id128_t a, sd_id128_t b) { return memcmp(&a, &b, 16) == 0; } this should either be return memcmp(&a, &b, 16); or return bool -- --- Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list syst

Re: [systemd-devel] bootctl SIGSEGV

2015-02-27 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 27, 2015 at 11:19:25PM +0200, Oleksii Shevchuk wrote: > Program received signal SIGSEGV, Segmentation fault. > bootctl_main.2553 (argc=, argv=) at > /tmp/portage/sys-apps/systemd-/work/systemd-/src/boot/bootctl.c:1333 > 1333efi_tilt_backslashes(loader_path);

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-02-27 Thread Ivan Shapovalov
On 2015-02-27 at 22:25 +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Feb 25, 2015 at 09:40:23PM +0300, Ivan Shapovalov wrote: > > Because the order of coldplugging is not defined, we can reference a > > not-yet-coldplugged unit and read its state while it has not yet been > > set to a meaning

Re: [systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

2015-02-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 25, 2015 at 09:40:23PM +0300, Ivan Shapovalov wrote: > Because the order of coldplugging is not defined, we can reference a > not-yet-coldplugged unit and read its state while it has not yet been > set to a meaningful value. > > This way, already active units may get started again. >

Re: [systemd-devel] [PATCH] user-sessions: move into own subdir and build independently of logind

2015-02-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Feb 25, 2015 at 09:47:26PM +0300, Ivan Shapovalov wrote: > Suggested by Zbyszek on IRC. > > This does not conditionalize on HAVE_PAM. Don't know whether that's right. I added conditionalization on HAVE_PAM back, and will push this in a moment. Zbyszek > > Makefile.am

[systemd-devel] bootctl SIGSEGV

2015-02-27 Thread Oleksii Shevchuk
# bootctl Segmentation fault (core dumped) # gdb bootctl GNU gdb (Gentoo 7.9 vanilla) 7.9 Copyright (C) 2015 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO W

Re: [systemd-devel] pam_mount + mount.crypt regression

2015-02-27 Thread Oleksii Shevchuk
Hi, Looks like this patch works for me. // wbr // Oleksii 2015-02-27 10:25 GMT+02:00 Martin Pitt : > Hey Oleksii, > > Oleksii Shevchuk [2015-02-14 10:11 +0200]: > > This patch 06e9783e2cc12eb6514e80c7f0014295f59b breaks pam_mount for > me. > > Without reverting it, systemd umounts encrypted

Re: [systemd-devel] [PATCH] refactored Re: [PATCH] nspawn: Map all seccomp filters to matching capabilities

2015-02-27 Thread Jay Faulkner
Hi all, My apologies if this is frowned upon, but this has been posted for a week and I haven’t gotten any feedback on it. I’d appreciate if this could get reviewed and if adequate, merged. I’m waiting on this change in order to be able to continue using systemd-nspawn containers, properly conf

Re: [systemd-devel] [PATCH v4] Added support for Uplink Failure Detection using BindCarrier

2015-02-27 Thread Rauta, Alin
Thank you. /Alin -Original Message- From: Tom Gundersen [mailto:t...@jklm.no] Sent: Friday, February 27, 2015 7:05 PM To: Rauta, Alin Cc: systemd-devel@lists.freedesktop.org; Kinsella, Ray Subject: Re: [systemd-devel] [PATCH v4] Added support for Uplink Failure Detection using BindCarri

Re: [systemd-devel] nilfs-cleanerd startup on boot

2015-02-27 Thread Jóhann B. Guðmundsson
On 02/27/2015 06:31 PM, dennis.mur...@wipro.com wrote: I have a fedora 21 system that where I mount an nilfs2 file system. I use a simple /etc/modules-load.d/nilfs.conf file to load the kernel module and have an entry in the fstab. The file system mounts on boot as it should, but the nilfs-c

Re: [systemd-devel] [PATCH] boot: efi - move background pixel variable into different scope

2015-02-27 Thread Kay Sievers
On Fri, Feb 27, 2015 at 6:12 PM, Marcel Holtmann wrote: >>> CC src/boot/efi/splash.o >>> src/boot/efi/splash.c: In function ‘graphics_splash’: >>> src/boot/efi/splash.c:256:9: warning: missing initializer for field ‘Blue’ >>> of ‘EFI_GRAPHICS_OUTPUT_BLT_PIXEL’ [-Wmissing-field-initializers

Re: [systemd-devel] [PATCH v4] Added support for Uplink Failure Detection using BindCarrier

2015-02-27 Thread Tom Gundersen
Hi Alin, On Fri, Feb 27, 2015 at 6:44 AM, Rauta, Alin wrote: > Can we please draw a conclusion in this case ? Sorry for the long time it has taken to get this patchset reviewed. I have just gone through it now, and it looks great. You are right that the LINK_STATE_DOWN can be done separately. P

[systemd-devel] nilfs-cleanerd startup on boot

2015-02-27 Thread dennis.murata
I have a fedora 21 system that where I mount an nilfs2 file system. I use a simple /etc/modules-load.d/nilfs.conf file to load the kernel module and have an entry in the fstab. The file system mounts on boot as it should, but the nilfs-cleanerd program does not startup. If I umount /nilfs the

Re: [systemd-devel] [v1] shutdown: add kexec loading, ?avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
On Fri, Feb 27, 2015 at 9:03 AM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > > We need two operations: sorting kernels to list them, and picking (I > On Fri, Feb 27, 2015 at 08:58:04AM -0800, Shawn Landden wrote: > > On Thu, Feb 26, 2015 at 6:22 PM, Zbigniew Jędrzejewski-Szmek < > >

Re: [systemd-devel] [PATCH] boot: efi - move background pixel variable into different scope

2015-02-27 Thread Marcel Holtmann
Hi Kay, >> CC src/boot/efi/splash.o >> src/boot/efi/splash.c: In function ‘graphics_splash’: >> src/boot/efi/splash.c:256:9: warning: missing initializer for field ‘Blue’ >> of ‘EFI_GRAPHICS_OUTPUT_BLT_PIXEL’ [-Wmissing-field-initializers] >> EFI_GRAPHICS_OUTPUT_BLT_PIXEL pixel = {

Re: [systemd-devel] [v1] shutdown: add kexec loading, ?avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 27, 2015 at 08:58:04AM -0800, Shawn Landden wrote: > On Thu, Feb 26, 2015 at 6:22 PM, Zbigniew Jędrzejewski-Szmek < > zbys...@in.waw.pl> wrote: > > > On Thu, Feb 26, 2015 at 08:04:08AM +, Jan Janssen wrote: > > > Shawn Landden churchofgit.com> writes: > > > > > > > void strv_free

Re: [systemd-devel] [v1] shutdown: add kexec loading, ?avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
On Thu, Feb 26, 2015 at 6:22 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Thu, Feb 26, 2015 at 08:04:08AM +, Jan Janssen wrote: > > Shawn Landden churchofgit.com> writes: > > > > > void strv_free(char **l) { > > > -strv_clear(l); > > > +char **k; > > > + >

Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-27 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 27, 2015 at 08:52:34AM -0800, Shawn Landden wrote: > On Thu, Feb 26, 2015 at 6:26 PM, Zbigniew Jędrzejewski-Szmek < > zbys...@in.waw.pl> wrote: > > > I'm not sure we want this... Can you add some justification? Do they share > > code? > > > I found it confusing what parts each of these

Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-27 Thread Shawn Landden
On Thu, Feb 26, 2015 at 6:26 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > I'm not sure we want this... Can you add some justification? Do they share > code? > I found it confusing what parts each of these handled, and some code sharing is possible, but none is shared currently. Th

Re: [systemd-devel] [PATCH] unit: When stopping due to BindsTo=, log which unit caused it

2015-02-27 Thread Lennart Poettering
On Thu, 26.02.15 16:50, Martin Pitt (martin.p...@ubuntu.com) wrote: > IMHO it would be prudent to skip adding the BindsTo= if at the time of > creating the .mount unit the backing .device unit doesn't actually > exist. In that case it's a mount which isn't managed by systemd, and > we shouldn't to

Re: [systemd-devel] [PATCH 2/2] vconsole: set font on tty16..tty63 as well

2015-02-27 Thread David Herrmann
Hi On Fri, Feb 27, 2015 at 4:09 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Feb 26, 2015 at 01:37:25PM +0100, Jan Engelhardt wrote: >> >> On Wednesday 2015-02-25 21:10, Lennart Poettering wrote: >> >> >> The setup program would not set the font on tty16 upwards. >> >> >> There is a maximum o

Re: [systemd-devel] [PATCH] boot: efi - move background pixel variable into different scope

2015-02-27 Thread Kay Sievers
On Fri, Feb 27, 2015 at 1:35 AM, Marcel Holtmann wrote: > CC src/boot/efi/splash.o > src/boot/efi/splash.c: In function ‘graphics_splash’: > src/boot/efi/splash.c:256:9: warning: missing initializer for field ‘Blue’ of > ‘EFI_GRAPHICS_OUTPUT_BLT_PIXEL’ [-Wmissing-field-initializers] >

Re: [systemd-devel] [PATCH v4] Added support for Uplink Failure Detection using BindCarrier

2015-02-27 Thread Rauta, Alin
Can we please draw a conclusion in this case ? Regards, Alin -Original Message- From: systemd-devel [mailto:systemd-devel-boun...@lists.freedesktop.org] On Behalf Of Rauta, Alin Sent: Friday, February 20, 2015 10:37 AM To: Tom Gundersen Cc: Kinsella, Ray; systemd-devel@lists.freedesktop.

Re: [systemd-devel] [PATCH 1/2] vconsole: match on vtcon events, not fbcon ones

2015-02-27 Thread Jan Engelhardt
On Friday 2015-02-27 04:12, Zbigniew Jędrzejewski-Szmek wrote: >On Tue, Feb 24, 2015 at 05:49:02PM +0100, Jan Engelhardt wrote: > >> +ACTION=="add", SUBSYSTEM=="vtconsole", KERNEL=="vtcon*", >> RUN+="@rootlibexecdir@/systemd-vconsole-setup" >> >> The fbcon driver may be loaded at a time way befo

Re: [systemd-devel] [PATCH] hwdb: add sdio identifiers for Broadcom WLAN cards

2015-02-27 Thread Arend van Spriel
On 02/27/15 01:24, Marcel Holtmann wrote: Hi Arend, This patch adds the sdio identifiers known to be supported by the brcmfmac open-source driver. Cc: Marcel Holtmann Signed-off-by: Arend van Spriel I remove the signed-off-by line since it is not standard practice here and then applied the

Re: [systemd-devel] pam_mount + mount.crypt regression

2015-02-27 Thread Martin Pitt
Hey Oleksii, Oleksii Shevchuk [2015-02-14 10:11 +0200]: > This patch 06e9783e2cc12eb6514e80c7f0014295f59b breaks pam_mount for me. > Without reverting it, systemd umounts encrypted drive, mounted with > dm-crypt/mount.crypt/pam_mount immediately. > > I double checked, that backing device is e