it is ironic that
"The only purpose of this structure is to cast the structure pointer
passed in addr in order to avoid compiler warnings. See EXAMPLE below."
from bind(2)
---
src/udev/udev-ctrl.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/udev/ud
---
src/libsystemd-network/sd-dhcp-client.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/libsystemd-network/sd-dhcp-client.c
b/src/libsystemd-network/sd-dhcp-client.c
index 4224e01..a477ccc 100644
--- a/src/libsystemd-network/sd-dhcp-client.c
+++ b/src/libsy
warning: pointer/integer type mismatch in conditional expression
---
src/shared/socket-util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/shared/socket-util.c b/src/shared/socket-util.c
index 5820279..73e1177 100644
--- a/src/shared/socket-util.c
+++ b/src/shared/so
also switch to
---
src/udev/udev-builtin-usb_id.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/udev/udev-builtin-usb_id.c b/src/udev/udev-builtin-usb_id.c
index ab0d96e..b42b32e 100644
--- a/src/udev/udev-builtin-usb_id.c
+++ b/src/u
Generate pkg-config files during configure as God (Havoc) intended. This fixes
all of systemd's pkg-config files when cross-compiling (and possibly other use
cases).
(Note: I might've missed some things to tidy up in Makefile.am, but not 100%
sure.)
Signed-off-by: Jeff Waugh
---
Makefile.am |
On Tue, Mar 10, 2015 at 11:13 AM, Tobias Hunger wrote:
> Even if all filesystems are encrypted you could factory-reset random
> computers you have access to, simply by editing the bootloader
> configuration file usually found in the poorly protected EFI
> partition!
If you're concerned about boot
On Tue, Mar 10, 2015 at 9:33 PM, Tobias Hunger wrote:
>> presets and machined ID are applied by PID 1, before it begins with
>> starting any units, hence *really* early on. Note though that actually
>> /etc/machine-id is used as flag for "is /etc empty". If the file
>> exists it is assumed that /e
On Tue, Mar 10, 2015 at 6:38 PM, Lennart Poettering
wrote:
> On Tue, 10.03.15 18:13, Tobias Hunger (tobias.hun...@gmail.com) wrote:
>
>> > So you want not just factory reset, but actually a stateless system,
>> > where every single boot is basically a factory reset?
>>
>> Yes, but I do have a stat
Hi all,
This set of patches add two new line types to the tmpfiles files format.
These new types of line are 'h' and 'H' (the recursively version), and
allow to change the file/directory attributes, like chattr(1) does.
One of the motivation of these patches is to get rid of the commit
11689d2a
Add change_attr_fd() function to modify the file/directory attribute.
---
src/shared/util.c | 22 ++
src/shared/util.h | 1 +
2 files changed, 23 insertions(+)
diff --git a/src/shared/util.c b/src/shared/util.c
index ba035ca..56097ec 100644
--- a/src/shared/util.c
+++ b/src/s
Add a new tmpfiles.d snippets to set the NOCOW attributes for the
journal files. This allow better perfomance when the root file system
is BTRFS. Pay attention that the NOCOW flags disables the checksum and
prevent scrub to rebuild a corrupted journal.
---
tmpfiles.d/journal-nocow.conf | 12 ++
Allow systemd-tmpfiles to set the file/directory attributes, like chattr(1)
does. Two more commands are added: 'H' and 'h' to set the attributes,
recursively and not.
---
src/tmpfiles/tmpfiles.c | 140
1 file changed, 140 insertions(+)
diff --git a
Please, forgot these patches: there is a bug inside.
Sorry for the noise.
BR
G.Baroncelli
On 2015-03-10 20:36, Goffredo Baroncelli wrote:
>
> Hi all,
> This set of patches add two new line types to the tmpfiles files format.
> These new types of line are 'h' and 'H' (the recursively version), an
Hi all,
This set of patches add two new line types to the tmpfiles files format.
These new types of line are 'h' and 'H' (the recursively version), and
allow to change the file/directory attributes, like chattr(1) does.
One of the motivation of these patches is to get rid of the commit
11689d2a
Add change_attr_fd() function to modify the file/directory attribute.
---
src/shared/util.c | 22 ++
src/shared/util.h | 1 +
2 files changed, 23 insertions(+)
diff --git a/src/shared/util.c b/src/shared/util.c
index ba035ca..56097ec 100644
--- a/src/shared/util.c
+++ b/src/s
Update the man page of tmpfiles.d(5), to document the new h/H command.
---
man/tmpfiles.d.xml | 32
1 file changed, 32 insertions(+)
diff --git a/man/tmpfiles.d.xml b/man/tmpfiles.d.xml
index 8815bf9..469deeb 100644
--- a/man/tmpfiles.d.xml
+++ b/man/tmpfiles.d.xm
On 2015-03-08 23:06, Lennart Poettering wrote:
> On Sun, 08.03.15 12:48, Goffredo Baroncelli (kreij...@libero.it) wrote:
>
>> dev_t major_minor;
>> +int attrib_value;
>> +int attrib_mask;
>
> "int" appears to be a strange choice for a bitmask. The existing
> chattr_fd() a
On Wed, 2015-02-04 at 23:48 +0200, Uoti Urpala wrote:
> On Wed, 2015-02-04 at 21:57 +0100, Lennart Poettering wrote:
> > currently being started. You are suggesting that the reload can
> > suppressed when a start is already enqueued, but that's really not the
> > case, because you first have to run
On Tue, 10.03.15 18:01, Didier Roche (didro...@ubuntu.com) wrote:
> The context is bug
> https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1411140, where
> systemd-machine-id-commit unit is entering in failed state (the binary
> handles gracefully the fact that it can't unmount the file) on a
On Tue, 10.03.15 18:13, Tobias Hunger (tobias.hun...@gmail.com) wrote:
> > So you want not just factory reset, but actually a stateless system,
> > where every single boot is basically a factory reset?
>
> Yes, but I do have a state that I want to be applied by default at
> all times.
Well, you
On Tue, 10.03.15 18:15, Alban Crequy (alban.cre...@gmail.com) wrote:
> From: Alban Crequy
>
> renameat2() exists since Linux 3.15 but btrfs support for the flag
> RENAME_NOREPLACE was added later.
>
> This patch implements a fallback when renameat2() returns EINVAL.
> EINVAL is the error return
From: Alban Crequy
renameat2() exists since Linux 3.15 but btrfs support for the flag
RENAME_NOREPLACE was added later.
This patch implements a fallback when renameat2() returns EINVAL.
EINVAL is the error returned when the filesystem does not support one of
the flags.
---
src/import/import-raw
Hi Lennart,
thanks for taking the time to answer! It is highly appreciated.
On Tue, Mar 10, 2015 at 5:01 PM, Lennart Poettering
wrote:
> So you want not just factory reset, but actually a stateless system,
> where every single boot is basically a factory reset?
Yes, but I do have a state that I
On Tue, Mar 10, 2015 at 11:49:05AM +0100, Lennart Poettering wrote:
> On Tue, 10.03.15 08:21, Martin Pitt (martin.p...@ubuntu.com) wrote:
>
> > > Please, be more careful with complex code like this, this needs more
> > > rounds of review before something like this can be merged...
> >
> > Okay. I
Le 10/03/2015 11:44, Lennart Poettering a écrit :
On Tue, 10.03.15 11:34, Didier Roche (didro...@ubuntu.com) wrote:
I think it would make more sense to return 0 when ply isn't running,
and 1 if it is, no?
Did this in the attached patch. Due to this, I needed then to return 1
even if we did no
Le 10/03/2015 11:41, Lennart Poettering a écrit :
On Tue, 10.03.15 11:33, Didier Roche (didro...@ubuntu.com) wrote:
diff --git a/src/fsckd/fsckd.c b/src/fsckd/fsckd.c
index 3fc923b..9393379 100644
--- a/src/fsckd/fsckd.c
+++ b/src/fsckd/fsckd.c
@@ -220,7 +220,7 @@ static int manager_connect_ply
Le 10/03/2015 11:36, Lennart Poettering a écrit :
On Tue, 10.03.15 11:32, Didier Roche (didro...@ubuntu.com) wrote:
static int manager_send_plymouth_message(Manager *m, const char *message) {
-const char *plymouth_cancel_message = NULL;
+_cleanup_free_ const char *plymouth_can
On Tue, 10.03.15 17:29, Lennart Poettering (lenn...@poettering.net) wrote:
> On Tue, 10.03.15 17:26, Lennart Poettering (lenn...@poettering.net) wrote:
>
> > On Fri, 20.02.15 13:25, har...@redhat.com (har...@redhat.com) wrote:
> >
> > Sorry for the late review!
> >
> > > --- a/src/shared/path-u
On Tue, 10.03.15 17:34, Alban Crequy (alban.cre...@gmail.com) wrote:
>
> -r = renameat2(AT_FDCWD, i->temp_path, AT_FDCWD,
> i->final_path, RENAME_NOREPLACE);
> +r = rename_noreplace(AT_FDCWD, i->temp_path, AT_FDCWD,
> i->final_path);
> if (r < 0
On Tue, Mar 10, 2015 at 05:34:07PM +0100, Alban Crequy wrote:
> From: Alban Crequy
>
> renameat2() exists since Linux 3.15 but btrfs support for the flag
> RENAME_NOREPLACE was added later.
>
> This patch implements a fallback when renameat2() returns EINVAL.
> EINVAL is the error returned when
On Tue, 10.03.15 17:26, Lennart Poettering (lenn...@poettering.net) wrote:
> On Fri, 20.02.15 13:25, har...@redhat.com (har...@redhat.com) wrote:
>
> Sorry for the late review!
>
> > --- a/src/shared/path-util.c
> > +++ b/src/shared/path-util.c
> > @@ -456,9 +456,9 @@ int path_is_mount_point(con
On Fri, 20.02.15 13:25, har...@redhat.com (har...@redhat.com) wrote:
Sorry for the late review!
> --- a/src/shared/path-util.c
> +++ b/src/shared/path-util.c
> @@ -456,9 +456,9 @@ int path_is_mount_point(const char *t, bool
> allow_symlink) {
>
> union file_handle_union h = FILE_HANDL
Comments inline:
On Tue, Mar 10, 2015 at 4:25 PM, Lennart Poettering
wrote:
> On Tue, 10.03.15 16:16, Alban Crequy (alban.cre...@gmail.com) wrote:
>
>> -if (renameat2(AT_FDCWD, t, AT_FDCWD, to, replace ? 0 :
>> RENAME_NOREPLACE) < 0) {
>> -unlink_noerrno(t);
>> -
On Mon, 09.03.15 08:10, James Hogarth (james.hoga...@gmail.com) wrote:
> >> The reason for this is to simplify finding out where mount points are
> >> for a clean upgrade - it's been felt the easiest way is to just 'ask'
> >> the actual system to do this.
> >>
> >> After the mount points are all u
On Mon, 09.03.15 11:27, Didier Roche (didro...@ubuntu.com) wrote:
> However, some file systems (seems overlayfs at least) would report a
> major(st_dev) as 0 on directories and not on files. The current
> path_is_mount_point() fallback logic would thus reports that every files is
> a mount point.
On Wed, 18.02.15 18:17, Cristian Rodríguez (crrodrig...@opensuse.org) wrote:
> >From ee8e4f440def745b6f0655b897e65d48321e46c5 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Cristian=20Rodr=C3=ADguez?=
> Date: Wed, 18 Feb 2015 18:09:16 -0300
> Subject: [PATCH] tmpfiles: implement specifier substitutio
On Mon, 09.03.15 07:44, Mantas Mikulėnas (graw...@gmail.com) wrote:
> On Mon, Mar 9, 2015 at 12:53 AM, Lennart Poettering
> wrote:
>
> > On Fri, 06.03.15 21:28, Chris Morgan (chmor...@gmail.com) wrote:
> >
> > >
> > http://www.freedesktop.org/software/systemd/man/sd_journal_add_match.html
> > >
On 03/06/2015 02:47 PM, David Herrmann wrote:
Hi
On Wed, Jan 28, 2015 at 8:31 PM, Lennart Poettering
wrote:
On Sat, 17.01.15 18:36, David Herrmann (dh.herrm...@gmail.com) wrote:
I think it's reasonable to allow setting the base-timeout in
/etc/systemd/logind.conf, but I want to know Lennart'
On Mon, 09.03.15 15:11, daurnimator (q...@daurnimator.com) wrote:
Applied! Thanks!
(Usually we prefer commits with proper real name attributions, though...)
> ---
> TODO| 2 --
> man/tmpfiles.d.xml | 2 ++
> src/tmpfiles/tmpfiles.c | 21 +++--
> 3 file
On Mon, 09.03.15 23:18, Ronny Chevalier (chevalier.ro...@gmail.com) wrote:
> >> > +if (!(our_env[n_env++] =
> >> > strappend("REMOTE_ADDR=", addr))) {
> >>
> >> In newer code we try to avoid making assignments and doing if checks
> >> in the same line.
> >>
> > Taking this
On Tue, 10.03.15 08:33, Martin Pitt (martin.p...@ubuntu.com) wrote:
> Lennart Poettering [2015-03-09 19:11 +0100]:
> > Anyway, please look into fixing this, I am kinda relying on patches
> > for this, as I don't use this myself. Fedora isn't set up for it, nor
> > do I use a file system that still
On Tue, 10.03.15 11:33, Didier Roche (didro...@ubuntu.com) wrote:
> diff --git a/src/fsckd/fsckd.c b/src/fsckd/fsckd.c
> index 3fc923b..9393379 100644
> --- a/src/fsckd/fsckd.c
> +++ b/src/fsckd/fsckd.c
> @@ -220,7 +220,7 @@ static int manager_connect_plymouth(Manager *m) {
> goto
On Tue, 10.03.15 11:34, Didier Roche (didro...@ubuntu.com) wrote:
Looks good! Applied!
> >From 32c1aec9bddf21b1380eb8f7b801468d3875e2a9 Mon Sep 17 00:00:00 2001
> From: Didier Roche
> Date: Tue, 10 Mar 2015 10:18:00 +0100
> Subject: [PATCH 5/5] fsckd: clean up log messages
> MIME-Version: 1.0
>
On Tue, 10.03.15 11:34, Didier Roche (didro...@ubuntu.com) wrote:
I think it would make more sense to return 0 when ply isn't running,
and 1 if it is, no?
>
> >From fd28f24d9eaa16737cbc8f33b8fe1a806dc291b1 Mon Sep 17 00:00:00 2001
> From: Didier Roche
> Date: Tue, 10 Mar 2015 10:05:19 +0100
>
From: Alban Crequy
renameat2() exists since Linux 3.15 but btrfs support for the flag
RENAME_NOREPLACE was added later.
This patch implements a fallback when renameat2() returns EINVAL.
EINVAL is the error returned when the filesystem does not support one of
the flags.
---
src/import/import-raw
GetConnectionCredentials method was added to dbus-1 specification
more than one year ago. This method should return "[...] as many
credentials as possible for the process connected to the server",
but at this moment only "UnixUserID", "LinuxSecurityLabel" and
"ProcessID" are defined by the specific
Hey Andrei,
Andrei Borzenkov [2015-03-10 15:12 +0300]:
> Dependency on network-online.target is supposed to be implicitly added
> (oh, those implicit undocumented dependencies ...)
>
> src/core/mount.c:mount_add_default_dependencies()
Ah, thanks for pointing out. Indeed, I was confused by them n
(Note 1: please CC me)
(Note 2: I have CC-ed two contacts from gnome-shell, one from gdm, one
from lightdm, and the system-logind ML)
Hello,
There are currently several ways to ask the DM to switch to the login screen:
- gdm3 uses org.gnome.DisplayManager.LocalDisplayFactory CreateTransientDispla
2015-03-10 14:18 GMT+01:00 Michael Biebl :
> Could you share the relevant /etc/fstab line?
Nvm, I noticed that this info has been added to the relevant bug report.
After adding the line to /etc/fstab and running systemctl daemon-reload, I get
# systemctl show -p Wants -p After mnt-server.mount
W
2015-03-10 12:40 GMT+01:00 Martin Pitt :
> Hello all,
>
> we got a report [1] that NFS fstab mounts (sometimes) aren't being
> mounted at boot as the network is still down:
>
> | mount[866]: mount.nfs: Network is unreachable
> | systemd[1]: mnt-server.mount mount process exited, code=exited status=
On Sun, Mar 8, 2015 at 11:27 PM, Lennart Poettering
wrote:
> Most likely you have RT cgroup scheduling enabled in the kernel, and
> some unit uses CPUShares=, CPUAccounting=, CPUQuota*= in the unit
> file. If a unit does that this will move the unit's cgroup into the
> "cpu" cgroup controller, as
On Tue, Mar 10, 2015 at 01:21:27PM +0100, Ronny Chevalier wrote:
> 2015-03-10 12:41 GMT+01:00 Shawn Landden :
> > ---
> > TODO | 2 -
> > man/systemd.socket.xml | 7 ++-
> > src/core/service.c | 41 -
> >
2015-03-10 12:41 GMT+01:00 Shawn Landden :
> ---
> TODO | 2 -
> man/systemd.socket.xml | 7 ++-
> src/core/service.c | 41 -
> src/libsystemd/sd-resolve/test-resolve.c | 2 +-
> src/shared/socket-util.c
В Tue, 10 Mar 2015 12:40:40 +0100
Martin Pitt пишет:
> Hello all,
>
> we got a report [1] that NFS fstab mounts (sometimes) aren't being
> mounted at boot as the network is still down:
>
> | mount[866]: mount.nfs: Network is unreachable
> | systemd[1]: mnt-server.mount mount process exited, cod
Am 2015-03-10 12:40, schrieb Martin Pitt:
we got a report [1] that NFS fstab mounts (sometimes) aren't being
mounted at boot as the network is still down:
| mount[866]: mount.nfs: Network is unreachable
| systemd[1]: mnt-server.mount mount process exited, code=exited
status=32
| systemd[1]: Fa
---
TODO | 2 -
man/systemd.socket.xml | 7 ++-
src/core/service.c | 41 -
src/libsystemd/sd-resolve/test-resolve.c | 2 +-
src/shared/socket-util.c | 76 +++-
Hello all,
we got a report [1] that NFS fstab mounts (sometimes) aren't being
mounted at boot as the network is still down:
| mount[866]: mount.nfs: Network is unreachable
| systemd[1]: mnt-server.mount mount process exited, code=exited status=32
| systemd[1]: Failed to mount /mnt/server.
| syste
>From 32c1aec9bddf21b1380eb8f7b801468d3875e2a9 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Tue, 10 Mar 2015 10:18:00 +0100
Subject: [PATCH 5/5] fsckd: clean up log messages
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Avoid double logs printing
>From fd28f24d9eaa16737cbc8f33b8fe1a806dc291b1 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Tue, 10 Mar 2015 10:05:19 +0100
Subject: [PATCH 4/5] fsckd: check if plymouth is running before attempting
connection
---
src/fsckd/fsckd.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
>From 3e877d1d493476f63fa6af7997914f93b50218bd Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Tue, 10 Mar 2015 09:57:38 +0100
Subject: [PATCH 3/5] fsckd: Reduce the SAK window when writing to console
We don't want to keep /dev/console open all the time, but only open it when
needed, to avoid
>From 689c3c1808bd286ed96d36e4fc7ff875e2477697 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Tue, 10 Mar 2015 09:01:11 +0100
Subject: [PATCH 2/5] fsckd: Fix some error return values
Change slightly recent changes introduced by
0b02c7c36dbb6f2ec7434eb8d18e0410ee1cc74c and
d42688ef21a695f8a30
Le 09/03/2015 19:11, Lennart Poettering a écrit :
So I fixed a number of issues, but there are some bits I am not really
keen to fix, mostly because it's hard for me to test as I don't use a
file system that still requires fsck...
- /dev/console needs to be opened only on demand but not contino
On Mon, Mar 09, 2015 at 11:27:09AM +0100, Didier Roche wrote:
> Also we could on the longer term maybe getting the whole path_is_mount_point()
> logic into libmount from util-linux, using mnt_get_mountpoint() (but this
> one only use st_dev comparison presently)?
mnt_table_find_mountpoint()
ht
Lennart Poettering writes:
> On Fri, 06.03.15 13:04, Jan Synáček (jsyna...@redhat.com) wrote:
>
>> Hello,
>>
>> when systemd creates a socket file, it explicitly calls a selinux
>> procedure to label it. I don't think that is needed, as the kernel does
>> the right thing when the socket is creat
Le 10/03/2015 08:33, Martin Pitt a écrit :
Lennart Poettering [2015-03-09 19:11 +0100]:
Oh, and I am only realizing now that the whole thing doesn't do *at
all* what we discussed. The idea was to invoke the actual fsck tools
with their stdout connected directly to fsckd. Instead the old
systemd
Lennart Poettering [2015-03-09 19:11 +0100]:
> Anyway, please look into fixing this, I am kinda relying on patches
> for this, as I don't use this myself. Fedora isn't set up for it, nor
> do I use a file system that still requires fsck at boot...
Yep, we'll fix those. But for the record, this can
Hey Lennart,
Lennart Poettering [2015-03-09 18:39 +0100]:
> I looked in more detail at the fsckd code that was commited a few
> weeks ago, and I cannot say I liked what I saw. The code still has all
> kinds of issues, including memory corruptions, fd handling errors, and
> tons and tons of incorre
67 matches
Mail list logo
