Re: [systemd-devel] [PATCH] journal: Introduce journal-network

2015-03-15 Thread Susant Sahani
Hi Zbigniew, Thanks for the review. On 03/16/2015 07:47 AM, Zbigniew Jędrzejewski-Szmek wrote: On Fri, Mar 13, 2015 at 10:55:42PM +0530, Susant Sahani wrote: This tiny daemon enables to pull journal entries and push to a UDP multicast address in syslog RFC 5424 format. journal-sysl

Re: [systemd-devel] tmpfiles.d specifier support on "argument" when operating on files

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Mar 02, 2015 at 08:25:47PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Feb 18, 2015 at 06:17:17PM -0300, Cristian Rodríguez wrote: > > El 18/02/15 a las 07:10, Lennart Poettering escribió: > > >On Tue, 17.02.15 17:35, Cristian Rodríguez (crrodrig...@opensuse.org) > > >wrote: > > >

Re: [systemd-devel] [PATCH 3/4] Update the man page of tmpfiles.d(5), to document the new h/H command.

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 10, 2015 at 09:07:42PM +0100, Goffredo Baroncelli wrote: > Update the man page of tmpfiles.d(5), to document the new h/H command. > --- > man/tmpfiles.d.xml | 32 > 1 file changed, 32 insertions(+) > > diff --git a/man/tmpfiles.d.xml b/man/tmpfiles.d.x

Re: [systemd-devel] [PATCH 2/4] Allow systemd-tmpfiles to set the file/directory attributes

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 10, 2015 at 09:07:41PM +0100, Goffredo Baroncelli wrote: > Allow systemd-tmpfiles to set the file/directory attributes, like chattr(1) > does. Two more commands are added: 'H' and 'h' to set the attributes, > recursively and not. > --- > src/tmpfiles/tmpfiles.c | 140 > +++

Re: [systemd-devel] [PATCH] core: don't change removed devices to state "tentative" [was: Re: [PATCH] unit: When stopping due to BindsTo=, log which unit caused it]

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 13, 2015 at 08:35:59AM +0100, Martin Pitt wrote: > Subject: [PATCH] core: don't change removed devices to state "tentative" > > Commit 628c89c introduced the "tentative" device state, which caused devices > to > go from "plugged" to "tentative" on a remove uevent. This breaks the clea

Re: [systemd-devel] [PATCH] console-getty.service: don't start when /dev/console is missing

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
Looks reasonable. Zbyszek On Fri, Mar 13, 2015 at 12:57:18PM +0100, Lukas Nykryn wrote: > From: Jan Pazdziora > > Create minimal image which runs systemd > >FROM rhel7.1 >RUN yum install -y /usr/bin/ps >ENV container docker >CMD [ "/usr/sbin/init" ] > > When you run the contai

Re: [systemd-devel] [PATCH] journal: Introduce journal-network

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 13, 2015 at 10:55:42PM +0530, Susant Sahani wrote: >This tiny daemon enables to pull journal entries and push to a UDP > multicast address in syslog RFC 5424 format. journal-syslog-network runs with > own > user systemd-journal-push. It starts running after the network is up. Looks

Re: [systemd-devel] [PATCH] vconsole-setup: check error of child process

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 13, 2015 at 05:47:28PM +, lucas.de.mar...@gmail.com wrote: > From: Lucas De Marchi > > If we don't check the error of the child process, systemd-vconsole-setup > would exit with 0 even if it could not really setup the console. Applied. Zbyszek

Re: [systemd-devel] [PATCH] man: standard-conf: change directory reference to wildcard

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 15, 2015 at 04:26:14PM -0700, ali...@she-devel.com wrote: > From: Alison Chaiken > > --- > man/standard-conf.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/standard-conf.xml b/man/standard-conf.xml > index 36af459..004f53f 100644 > --- a/man/standar

[systemd-devel] [PATCH] man: standard-conf: change directory reference to wildcard

2015-03-15 Thread alison
From: Alison Chaiken --- man/standard-conf.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/standard-conf.xml b/man/standard-conf.xml index 36af459..004f53f 100644 --- a/man/standard-conf.xml +++ b/man/standard-conf.xml @@ -54,7 +54,7 @@ directories, and has the l

Re: [systemd-devel] [PATCH] network: add UseNTP DHCP option

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Mar 13, 2015 at 12:01:29PM -0700, Michael Marineau wrote: > Despite having the internal logic in place to enable/disable using NTP > servers provided by DHCP the network config didn't expose the option. Applied. Zbyszek > --- > man/systemd.network.xml | 8 > src

Re: [systemd-devel] [PATCH 4/6] make in_addr_from_string() accept ipv4 addresses even when using AF_INET6

2015-03-15 Thread Shawn Landden
On Sun, Mar 15, 2015 at 1:36 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Sun, Mar 15, 2015 at 01:28:05PM -0700, Shawn Landden wrote: > > On Sun, Mar 15, 2015 at 1:07 PM, Zbigniew Jędrzejewski-Szmek < > > zbys...@in.waw.pl> wrote: > > > > > On Wed, Mar 11, 2015 at 08:13:47AM -0

Re: [systemd-devel] [PATCH 4/6] make in_addr_from_string() accept ipv4 addresses even when using AF_INET6

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 15, 2015 at 01:28:05PM -0700, Shawn Landden wrote: > On Sun, Mar 15, 2015 at 1:07 PM, Zbigniew Jędrzejewski-Szmek < > zbys...@in.waw.pl> wrote: > > > On Wed, Mar 11, 2015 at 08:13:47AM -0700, Shawn Landden wrote: > > > if we are going to have a function to fix up the deficiencies of >

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 15, 2015 at 08:50:03PM +0100, Kay Sievers wrote: > On Sun, Mar 15, 2015 at 8:08 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Sun, Mar 15, 2015 at 07:58:35PM +0100, Kay Sievers wrote: > >> If the filesytem is too dumb to have that info in the superblock flags > >> to store, to reques

Re: [systemd-devel] [PATCH 4/6] make in_addr_from_string() accept ipv4 addresses even when using AF_INET6

2015-03-15 Thread Shawn Landden
On Sun, Mar 15, 2015 at 1:07 PM, Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > On Wed, Mar 11, 2015 at 08:13:47AM -0700, Shawn Landden wrote: > > if we are going to have a function to fix up the deficiencies of > > inet_pton(), better go all the way. > > --- > > src/shared/in-addr-uti

Re: [systemd-devel] [PATCH 4/6] make in_addr_from_string() accept ipv4 addresses even when using AF_INET6

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 11, 2015 at 08:13:47AM -0700, Shawn Landden wrote: > if we are going to have a function to fix up the deficiencies of > inet_pton(), better go all the way. > --- > src/shared/in-addr-util.c | 17 + > src/shared/in-addr-util.h | 1 + > 2 files changed, 18 insertions(+)

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Reindl Harald
Am 15.03.2015 um 20:50 schrieb Kay Sievers: On Sun, Mar 15, 2015 at 8:08 PM, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 15, 2015 at 07:58:35PM +0100, Kay Sievers wrote: If the filesytem is too dumb to have that info in the superblock flags to store, to request a forced fsck, it is the pro

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 8:08 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Mar 15, 2015 at 07:58:35PM +0100, Kay Sievers wrote: >> If the filesytem is too dumb to have that info in the superblock flags >> to store, to request a forced fsck, it is the problem of the file >> system to fix and not

Re: [systemd-devel] [PATCH 2/6] fix strict aliasing violations in src/udev/udev-builtin-usb_id.c

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 11, 2015 at 08:13:45AM -0700, Shawn Landden wrote: > --- > src/udev/udev-builtin-usb_id.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/src/udev/udev-builtin-usb_id.c b/src/udev/udev-builtin-usb_id.c > index 6516d93..3c15b2f 100644 > --- a/s

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 15, 2015 at 07:58:35PM +0100, Kay Sievers wrote: > If the filesytem is too dumb to have that info in the superblock flags > to store, to request a forced fsck, it is the problem of the file > system to fix and nothing we need to solve in systemd. Are there filesystems which have such a

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 7:59 PM, Andrei Borzenkov wrote: > В Sun, 15 Mar 2015 19:48:10 +0100 > Zbigniew Jędrzejewski-Szmek пишет: >> > No, they are absolutely not. Changing the EFI flash comes with >> > unpredictable risks, the flash is not meant to or designed for be >> > written to during any

Re: [systemd-devel] Enabling timesyncd in virtual machines

2015-03-15 Thread Michael Biebl
This was suposed to go to the list. 2015-03-13 21:25 GMT+01:00 Michael Biebl : > 2015-03-13 20:25 GMT+01:00 Michael Marineau : >> I don't know of a robust way to know if a platform needs a little >> extra help from userspace to keep the clock sane or not but it seems >> generally safer to try than

Re: [systemd-devel] Enabling timesyncd in virtual machines

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 7:50 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Mar 15, 2015 at 07:47:46PM +0100, Kay Sievers wrote: >> On Fri, Mar 13, 2015 at 8:25 PM, Michael Marineau >> wrote: >> > Greetings, >> > >> > Currently systemd-timesyncd.service includes >> > ConditionVirtualization=no,

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Andrei Borzenkov
В Sun, 15 Mar 2015 19:48:10 +0100 Zbigniew Jędrzejewski-Szmek пишет: > On Sun, Mar 15, 2015 at 06:48:24PM +0100, Kay Sievers wrote: > > On Sun, Mar 15, 2015 at 4:44 PM, Zbigniew Jędrzejewski-Szmek > > wrote: > > > On Sun, Mar 15, 2015 at 03:23:19PM +0100, Kay Sievers wrote: > > >> On Sun, Mar 15

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 7:48 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Mar 15, 2015 at 06:48:24PM +0100, Kay Sievers wrote: >> It is legacy and does not need new features. It worked in the past and >> will continue to work in the future, but it does not need new >> questionable and possibl

Re: [systemd-devel] Enabling timesyncd in virtual machines

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 15, 2015 at 07:47:46PM +0100, Kay Sievers wrote: > On Fri, Mar 13, 2015 at 8:25 PM, Michael Marineau > wrote: > > Greetings, > > > > Currently systemd-timesyncd.service includes > > ConditionVirtualization=no, disabling it in both containers and > > virtual machines. Each VM platform t

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 15, 2015 at 06:48:24PM +0100, Kay Sievers wrote: > On Sun, Mar 15, 2015 at 4:44 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Sun, Mar 15, 2015 at 03:23:19PM +0100, Kay Sievers wrote: > >> On Sun, Mar 15, 2015 at 11:56 AM, Jan Janssen wrote: > >> > --- > >> > man/systemctl.xml

Re: [systemd-devel] Enabling timesyncd in virtual machines

2015-03-15 Thread Kay Sievers
On Fri, Mar 13, 2015 at 8:25 PM, Michael Marineau wrote: > Greetings, > > Currently systemd-timesyncd.service includes > ConditionVirtualization=no, disabling it in both containers and > virtual machines. Each VM platform tends to deal with or ignore the > time problem in their own special ways, K

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 7:31 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Mar 11, 2015 at 05:22:18PM -0700, Shawn Landden wrote: >> Still use helper when Xen Dom0, to avoid duplicating some hairy code. >> >> I think the rbtree version was far more understandable as greedy_realloc0() >> is very

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 11, 2015 at 05:22:18PM -0700, Shawn Landden wrote: > Still use helper when Xen Dom0, to avoid duplicating some hairy code. > > I think the rbtree version was far more understandable as greedy_realloc0() > is very messy to do correctly. > > Take fopenat() from lsof. > Add opendirat() >

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 4:44 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Sun, Mar 15, 2015 at 03:23:19PM +0100, Kay Sievers wrote: >> On Sun, Mar 15, 2015 at 11:56 AM, Jan Janssen wrote: >> > --- >> > man/systemctl.xml | 26 >> > shell-completion/bash/systemctl.

Re: [systemd-devel] udev breaks hostap linkage of raw/user interfaces, causing wpa_supplicant problems

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 4:07 PM, Thomas Richter wrote: > On 15.03.2015 15:38, Kay Sievers wrote: > >> grep ./sys/class/net/*/name_assign_type > > grep: /sys/class/net/eth0/name_assign_type: Invalid argument > grep: /sys/class/net/lo/name_assign_type: Invalid argument > grep: /sys/class/net/wifi0/n

Re: [systemd-devel] [v3 2/4] update TODO

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 27, 2015 at 05:04:22PM -0800, Shawn Landden wrote: > --- > TODO | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/TODO b/TODO > index e8e4800..1f5bfaa 100644 > --- a/TODO > +++ b/TODO > @@ -32,6 +32,8 @@ External: > * When lz4 gets an API for lz4 command output, make use of

Re: [systemd-devel] [v3 1/4] man: these binaries are internal APIs

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 27, 2015 at 05:04:21PM -0800, Shawn Landden wrote: > --- > man/systemd-halt.service.xml | 1 - > man/systemd-shutdownd.service.xml | 1 - > man/systemd-suspend.service.xml | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/man/systemd-halt.service.xml b/man/systemd-halt.

Re: [systemd-devel] [PATCH] fix compiler warning

2015-03-15 Thread Shawn Landden
On Sun, Mar 15, 2015 at 4:53 AM, Ronny Chevalier wrote: > 2015-03-14 17:54 GMT+01:00 Shawn Landden : > > On Sat, Mar 14, 2015 at 6:31 AM, Ronny Chevalier < > chevalier.ro...@gmail.com> > > wrote: > >> > >> 2015-03-11 4:42 GMT+01:00 Shawn Landden : > >> > warning: pointer/integer type mismatch in

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 15, 2015 at 03:23:19PM +0100, Kay Sievers wrote: > On Sun, Mar 15, 2015 at 11:56 AM, Jan Janssen wrote: > > --- > > man/systemctl.xml | 26 > > shell-completion/bash/systemctl.in | 8 - > > shell-completion/zsh/_systemctl.in | 2 ++ > > src/fsck

Re: [systemd-devel] udev breaks hostap linkage of raw/user interfaces, causing wpa_supplicant problems

2015-03-15 Thread Thomas Richter
On 15.03.2015 15:38, Kay Sievers wrote: Hi Kay, grep ./sys/class/net/*/name_assign_type grep: /sys/class/net/eth0/name_assign_type: Invalid argument grep: /sys/class/net/lo/name_assign_type: Invalid argument grep: /sys/class/net/wifi0/name_assign_type: Invalid argument grep: /sys/class/net/wl

Re: [systemd-devel] udev breaks hostap linkage of raw/user interfaces, causing wpa_supplicant problems

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 1:40 PM, Thomas Richter wrote: > udev seems to create a problem here with the hostap (prism2) kernel driver. > Unlike many wifi devices, the hostap device driver always creates paired > interfaces, a raw interface (wifiX) and a network interface (wlanX) that > represents th

Re: [systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Kay Sievers
On Sun, Mar 15, 2015 at 11:56 AM, Jan Janssen wrote: > --- > man/systemctl.xml | 26 > shell-completion/bash/systemctl.in | 8 - > shell-completion/zsh/_systemctl.in | 2 ++ > src/fsck/fsck.c| 63 + >

[systemd-devel] udev breaks hostap linkage of raw/user interfaces, causing wpa_supplicant problems

2015-03-15 Thread Thomas Richter
Hi folks, udev seems to create a problem here with the hostap (prism2) kernel driver. Unlike many wifi devices, the hostap device driver always creates paired interfaces, a raw interface (wifiX) and a network interface (wlanX) that represents the configured network. Unfortunately, udev (or h

Re: [systemd-devel] [PATCH] fix compiler warning

2015-03-15 Thread Ronny Chevalier
2015-03-14 17:54 GMT+01:00 Shawn Landden : > On Sat, Mar 14, 2015 at 6:31 AM, Ronny Chevalier > wrote: >> >> 2015-03-11 4:42 GMT+01:00 Shawn Landden : >> > warning: pointer/integer type mismatch in conditional expression >> > --- >> > src/shared/socket-util.c | 4 ++-- >> > 1 file changed, 2 inse

Re: [systemd-devel] [PATCH] path-lookup: use secure_getenv()

2015-03-15 Thread Ronny Chevalier
2015-03-15 3:27 GMT+01:00 Shawn Landden : > All these except user_data_home_dir() are certainly vectors for > arbitrary code execution. These should use secure_getenv() > --- Hi, I don't see why secure_getenv() is appropriate here? These functions are never used in the libraries systemd provides,

[systemd-devel] [PATCH 1/2] systemctl: Add reboot to firmware support

2015-03-15 Thread Jan Janssen
--- man/systemctl.xml | 10 shell-completion/bash/systemctl.in | 2 +- shell-completion/zsh/_systemctl.in | 1 + src/shared/efivars.h | 7 +++--- src/systemctl/systemctl.c | 48 ++ 5 files changed, 60 insertion

[systemd-devel] [PATCH 2/2] fsck: Add support for EFI variable based fsck indication

2015-03-15 Thread Jan Janssen
--- man/systemctl.xml | 26 shell-completion/bash/systemctl.in | 8 - shell-completion/zsh/_systemctl.in | 2 ++ src/fsck/fsck.c| 63 + src/shared/efivars.h | 21 +++-- src/systemc