Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Stef Walter
binNF286gWdVu.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] timedatectl: fix when queried system has differn't timezone

2015-03-24 Thread Kay Sievers
On Mon, Mar 23, 2015 at 12:44 PM, Shawn Landden sh...@churchofgit.com wrote: Also allow getting time from time(2) when BUS_TRANSPORT_MACHINE. v2: check for error Applied. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Stef Walter
On 24.03.2015 15:11, Kay Sievers wrote: On Tue, Mar 24, 2015 at 2:15 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Exactly because they do not require being upgraded in lock-step, doing conversion to the local time locally is racy. Assuming we have up-to-date timezone database

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Kay Sievers
On Tue, Mar 24, 2015 at 3:17 PM, Stef Walter st...@redhat.com wrote: On 24.03.2015 15:11, Kay Sievers wrote: On Tue, Mar 24, 2015 at 2:15 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Exactly because they do not require being upgraded in lock-step, doing conversion to the local

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread David Herrmann
Hi On Tue, Mar 24, 2015 at 2:15 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 24, 2015 at 01:59:40PM +0100, Tom Gundersen wrote: [...] But it is not systemd's task to cover for missing functionality in the cockpit architecture. We should not add redundant interfaces

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Stef Walter
/me hates the new thunderbird-enigmail On 24.03.2015 14:15, Zbigniew Jędrzejewski-Szmek wrote: On Tue, Mar 24, 2015 at 01:59:40PM +0100, Tom Gundersen wrote: On Mon, Mar 23, 2015 at 8:13 PM, Stef Walter st...@redhat.com wrote: Sorry about the encrypted email ... I hit the wrong button. On

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Tom Gundersen
On Tue, Mar 24, 2015 at 3:17 PM, Stef Walter st...@redhat.com wrote: On 24.03.2015 15:11, Kay Sievers wrote: On Tue, Mar 24, 2015 at 2:15 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Exactly because they do not require being upgraded in lock-step, doing conversion to the local

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 24, 2015 at 01:59:40PM +0100, Tom Gundersen wrote: On Mon, Mar 23, 2015 at 8:13 PM, Stef Walter st...@redhat.com wrote: Sorry about the encrypted email ... I hit the wrong button. On 23.03.2015 19:07, Shawn Landden wrote: On Mon, Mar 23, 2015 at 8:56 AM, Kay Sievers

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Tom Gundersen
On Mon, Mar 23, 2015 at 8:13 PM, Stef Walter st...@redhat.com wrote: Sorry about the encrypted email ... I hit the wrong button. On 23.03.2015 19:07, Shawn Landden wrote: On Mon, Mar 23, 2015 at 8:56 AM, Kay Sievers k...@vrfy.org wrote: On Mon, Mar 23, 2015 at 3:49 PM, Stef Walter

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Kay Sievers
On Tue, Mar 24, 2015 at 2:15 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Exactly because they do not require being upgraded in lock-step, doing conversion to the local time locally is racy. Assuming we have up-to-date timezone database locally, with the patch that was merged today

Re: [systemd-devel] [PATCH] libsystemd doesn't handle properly empty messages from kernel

2015-03-24 Thread Rauta, Alin
Hi Tom, Nice. Thanks, Alin -Original Message- From: Tom Gundersen [mailto:t...@jklm.no] Sent: Monday, March 23, 2015 9:45 PM To: Rauta, Alin Cc: systemd Mailing List; Kinsella, Ray Subject: Re: [systemd-devel] [PATCH] libsystemd doesn't handle properly empty messages from kernel Hi

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tobias Hunger
On Tue, Mar 24, 2015 at 5:12 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: This wouldn't work if fstype was NULL. We also have a list of network filesystems, whic I assume don't require a device, and we can consult this list instead of including it here. I pushed the patch with

Re: [systemd-devel] [PATCH] timedated: add LocalTimeUSec via dbus

2015-03-24 Thread Kay Sievers
On Tue, Mar 24, 2015 at 2:52 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Mon, Mar 23, 2015 at 04:24:38AM -0700, Shawn Landden wrote: --- src/timedate/timedated.c | 24 1 file changed, 24 insertions(+) diff --git a/src/timedate/timedated.c

Re: [systemd-devel] [PATCH] timedated: add LocalTimeUSec via dbus

2015-03-24 Thread Kay Sievers
On Tue, Mar 24, 2015 at 5:34 AM, Shawn Landden sh...@churchofgit.com wrote: On Mon, Mar 23, 2015 at 6:52 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Mon, Mar 23, 2015 at 04:24:38AM -0700, Shawn Landden wrote: --- src/timedate/timedated.c | 24 1 file

[systemd-devel] regarding to cgroup siblings mask

2015-03-24 Thread WaLyong Cho
Hi, In recent systemd(from some month ago), when a unit has a mask for cpu or blockio or memory, this mask is also propagated to siblings by unit_get_target_mask(). According to some of comments, it seems intentional. Could anyone explain why? In our system, some of service have MemoryLimit=

Re: [systemd-devel] [PATCH] fstab-generator: Do less sanity checking

2015-03-24 Thread Tom Gundersen
Thanks Tobias! I applied a tweaked version of this patch now. Please let me know in case it does not work for you. Most importantly, I dropped the change to the /usr handling, as we don't really have a use-case for that at the moment (could be a separate patch if needed). Also, dropped the

Re: [systemd-devel] [PATCH 1/2] rules: storage - whitelist partitioned MS MMC devices

2015-03-24 Thread Kay Sievers
On Mon, Mar 23, 2015 at 8:55 AM, Mantas Mikulėnas graw...@gmail.com wrote: On Tue, Mar 17, 2015 at 11:50 PM, Kay Sievers k...@vrfy.org wrote: On Tue, Mar 17, 2015 at 5:00 PM, Mantas Mikulėnas graw...@gmail.com wrote: Accidentally dropped in 1aff20687f4868575. ---

[systemd-devel] [PATCH] fstab-generator: Do less sanity checking

2015-03-24 Thread Tobias Hunger
Mount whatever the user asked to be mounted on / and /usr on the kernel command line. Do less sanity check and do *not* bail out when the mount device looks strange or does not exist. This basically makes the changes for deviceless filesystems from yesterday unnecessary and is in line with what

Re: [systemd-devel] [PATCH] automount: add expire support

2015-03-24 Thread Kay Sievers
On Sun, Mar 22, 2015 at 1:36 PM, Michael Olbrich m.olbr...@pengutronix.de wrote: --- man/systemd.automount.xml | 8 ++ man/systemd.mount.xml | 9 ++ src/core/automount.c | 209 -- src/core/automount.h

Re: [systemd-devel] [PATCH 2/2] rules: storage - support MemoryStick (non-Pro) cards

2015-03-24 Thread Kay Sievers
On Tue, Mar 17, 2015 at 5:00 PM, Mantas Mikulėnas graw...@gmail.com wrote: These are handled by a different driver than MemoryStick Pro. Applied. Thanks, Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] [PATCH] fstab-generator: Do less sanity checking

2015-03-24 Thread Tobias Hunger
Thanks Tom! I added the check for the rw /sys so that both the code path for fstab as well as for the kernel cmdline are doing similar checks. I was thinking about putting all the validation for both code paths into one function, but there are so many small things that only make sense in one of

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tom Gundersen
Hi Tobias and Zbigniew, This already went in, but I was just looking at it again. Is there any reason the kernel commandline handling must be treated differently here than the fstab handling? We already support deviceless mounts (obviously) when specified in fstab without the need for any

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Simon McVittie
On 24/03/15 14:40, Stef Walter wrote: On 24.03.2015 15:22, Tom Gundersen wrote: It all comes down to what you intend the fields to mean. Now we mean the field to mean the real localtime of the server (as seen from the client), whereas you want it to mean the localtime the server thinks it

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Andrei Borzenkov
On Tue, Mar 24, 2015 at 6:39 PM, Tom Gundersen t...@jklm.no wrote: Hi Tobias and Zbigniew, This already went in, but I was just looking at it again. Is there any reason the kernel commandline handling must be treated differently here than the fstab handling? We already support deviceless

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Vasiliy Tolstov
For overlayfs you need to check overlayfs and overlay. 24 марта 2015 г. 1:52 пользователь Tobias Hunger tobias.hun...@gmail.com написал: This allows for stateless systems. --- src/fstab-generator/fstab-generator.c | 21 + src/shared/util.c | 30

Re: [systemd-devel] [systemd-commits] Makefile.am src/shared src/timedate

2015-03-24 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Mar 24, 2015 at 03:32:31PM +0100, Kay Sievers wrote: On Tue, Mar 24, 2015 at 3:24 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 24, 2015 at 07:04:11AM -0700, Kay Sievers wrote: Makefile.am|2 src/shared/time-dst.c | 329

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-24 Thread Stef Walter
On 24.03.2015 15:22, Tom Gundersen wrote: On Tue, Mar 24, 2015 at 3:17 PM, Stef Walter st...@redhat.com wrote: On 24.03.2015 15:11, Kay Sievers wrote: On Tue, Mar 24, 2015 at 2:15 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Exactly because they do not require being upgraded in

Re: [systemd-devel] [systemd-commits] Makefile.am src/shared src/timedate

2015-03-24 Thread Tom Gundersen
On Tue, Mar 24, 2015 at 3:24 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 24, 2015 at 07:04:11AM -0700, Kay Sievers wrote: Makefile.am|2 src/shared/time-dst.c | 329 - src/shared/time-dst.h |

Re: [systemd-devel] [systemd-commits] Makefile.am src/shared src/timedate

2015-03-24 Thread Kay Sievers
On Tue, Mar 24, 2015 at 3:24 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 24, 2015 at 07:04:11AM -0700, Kay Sievers wrote: Makefile.am|2 src/shared/time-dst.c | 329 - src/shared/time-dst.h |

Re: [systemd-devel] [systemd-commits] Makefile.am src/shared src/timedate

2015-03-24 Thread Kay Sievers
On Tue, Mar 24, 2015 at 4:07 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 24, 2015 at 03:32:31PM +0100, Kay Sievers wrote: On Tue, Mar 24, 2015 at 3:24 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 24, 2015 at 07:04:11AM -0700, Kay Sievers wrote:

[systemd-devel] How to debug blocking service start?

2015-03-24 Thread Kai Hendry
Hi there, How do I figure out why or where something is stuck? http://s.natalian.org/2015-03-25/systemd-start-issue.png `journalctl -u surf -f` prints nothing. Binary surf runs fine when I run it manually. Many thanks, ___ systemd-devel mailing list

[systemd-devel] systemd-resolved service ignores UseDNS=false

2015-03-24 Thread Mikhail Morfikov
In the systemd-resolved manual we can read something like this: The DNS servers contacted are determined from the global settings in resolved.conf(5), the per-link static settings in .network files, and the per-link dynamic settings received over DHCP. 1. Let's say that I have set all the

[systemd-devel] Providing DNS for DHCPServer configuration

2015-03-24 Thread Ash Charles
Hi, I'm using the DHCPServer option within systemd-networkd along with hostapd to provide a basic wireless access point on an embedded system. When my client systems connect, they make a DHCP request that includes a parameter request for a Domain Name Server (option 6)---standard fare I think.

[systemd-devel] [PATCH] CODING_STYLE: this also help with unaligned memory accesses

2015-03-24 Thread Shawn Landden
And those arches don't get much testing too. --- CODING_STYLE | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CODING_STYLE b/CODING_STYLE index b687e72..8934954 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -14,7 +14,8 @@ - The destructors always unregister the object

Re: [systemd-devel] [PATCH 1/2] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Kay Sievers
On Tue, Mar 24, 2015 at 7:11 PM, Shawn Landden sh...@churchofgit.com wrote: /* Enforce the values of /etc/localtime */ if (getenv(TZ)) { -fprintf(stderr, Warning: Ignoring the TZ variable.\n\n); +fprintf(stderr, Warning: Ignoring the %s

Re: [systemd-devel] [PATCH 1/2] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
On Tue, Mar 24, 2015 at 11:32 AM, Kay Sievers k...@vrfy.org wrote: On Tue, Mar 24, 2015 at 7:11 PM, Shawn Landden sh...@churchofgit.com wrote: /* Enforce the values of /etc/localtime */ if (getenv(TZ)) { -fprintf(stderr, Warning: Ignoring the TZ

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tobias Hunger
Hi Tom, no, root=tmpfs rootfstype=tmpfs does *not* work without my patch. I had thought it should, too, and I did try. fstab-generator was silently ignoring root= since tmpfs is not a device. So no mount unit for /sysroot... Since fstab-generator did evaluate mount.usr* which did point to a

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tom Gundersen
On Tue, Mar 24, 2015 at 5:53 PM, Tobias Hunger tobias.hun...@gmail.com wrote: Hi Tom, no, root=tmpfs rootfstype=tmpfs does *not* work without my patch. I had thought it should, too, and I did try. fstab-generator was silently ignoring root= since tmpfs is not a device. So no mount unit for

[systemd-devel] [PATCH] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. avoid calling gmtime_r() and localtime_r() twice deduplicate some strings v2 --- src/timedate/timedatectl.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git

[systemd-devel] [PATCH] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. v3 --- src/timedate/timedatectl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index ab5c8a1..d529a0a 100644 ---

Re: [systemd-devel] [PATCH 1/2] fstab-generator: Support root on tmpfs (or other deviceless FS)

2015-03-24 Thread Tobias Hunger
I won't promise anything, but I'll give it a try later tonight. It is a bit frightening under what kind of attention you people have to work: Even this tiny patch made it onto phoronix and I just got my first flame about ruining Linux. ___ systemd-devel

Re: [systemd-devel] [PATCH 1/2] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Kay Sievers
On Tue, Mar 24, 2015 at 7:39 PM, Shawn Landden sh...@churchofgit.com wrote: On Tue, Mar 24, 2015 at 11:32 AM, Kay Sievers k...@vrfy.org wrote: On Tue, Mar 24, 2015 at 7:11 PM, Shawn Landden sh...@churchofgit.com wrote: /* Enforce the values of /etc/localtime */ if

[systemd-devel] [PATCH 1/2] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. --- src/timedate/timedatectl.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index ab5c8a1..8daae54

[systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-24 Thread Shawn Landden
Will result in slightly smaller binaries, and cuts out the branch, even if the expression is still executed. --- src/shared/macro.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/shared/macro.h b/src/shared/macro.h index 7f89951..02219ea 100644 ---

Re: [systemd-devel] [PATCH 1/2] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Kay Sievers
On Tue, Mar 24, 2015 at 7:11 PM, Shawn Landden sh...@churchofgit.com wrote: I liked having the DST information. It is a pity glibc doesn't export this information. Yeah, date(1) could use and show that information too, I think. Adding custom parsers to work-around glibc's development style was

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-03-24 Thread Ivan Shapovalov
On 2015-03-23 at 13:45 +, Zbigniew Jędrzejewski-Szmek wrote: On Mon, Mar 23, 2015 at 04:04:28PM +0300, Ivan Shapovalov wrote: Hello, is it possible/allowed/desired to support assigning ExecStartPre= and similar options via dbus interface, i. e. in `systemctl set-property` or