Re: [systemd-devel] [PATCH] systemd-bootchart: Repair Entropy Graph

2015-03-30 Thread Daniel Mack
On 03/29/2015 08:46 PM, Alexander Sverdlin wrote: Entropy Graph code doesn't handle the error condition if open() of /proc entry fails. Moreover, the file is only opened once and only first sample will contain the correct value because the return value of pread() is also not handled properly

Re: [systemd-devel] [PATCH] systemd-bootchart: Prevent leaking file descriptors in open-fdopen combination

2015-03-30 Thread Daniel Mack
On 03/29/2015 08:44 PM, Alexander Sverdlin wrote: Correctly handle the potential failure of fdopen() (because of OOM, for instance) after potentially successful open(). Prevent leaking open fd in such case. Applied, thanks! --- src/bootchart/store.c | 12 ++-- src/bootchart/svg.c

[systemd-devel] systemd-run and waiting for initialization

2015-03-30 Thread Igor Bukanov
As I understand, the systemd-run utility returns immediately even with --service-type=forking. What is the proper way then to wait using a shell until the main service process forks the child and exists signaling initialization? ___ systemd-devel mailing

Re: [systemd-devel] [PATCH v2] Add reboot to EFI support

2015-03-30 Thread Dimitri John Ledkov
I like this. +1 On 26 March 2015 at 15:09, Jan Janssen medhe...@web.de wrote: --- man/systemctl.xml | 6 +++- src/libsystemd/sd-bus/bus-common-errors.h | 1 + src/login/logind-dbus.c | 49 +++--

Re: [systemd-devel] What requires kmod

2015-03-30 Thread Lennart Poettering
On Mon, 30.03.15 00:00, Jan Engelhardt (jeng...@inai.de) wrote: systemd/configure.ac has a AC_CHECK_PROG([KMOD]...) but what actually *uses* this? The way it looks, it's all (udev rules) using libkmod directly. Let me git grep kmod that for you: src/core/kmod-setup.c

[systemd-devel] Drop systemd-ui

2015-03-30 Thread Jóhann B. Guðmundsson
Heyja Should this not be dropped and *DE write,integrate/implement an graphical frontend to systemd for themselves? It's not like this is receiving the love it needs, hence I'm pretty sure nobody is using this. JBG ___ systemd-devel mailing list

Re: [systemd-devel] regarding to cgroup siblings mask

2015-03-30 Thread David Timothy Strauss
On Fri, Mar 27, 2015 at 7:56 PM, WaLyong Cho walyong@gmail.com wrote: Hmm, it seems not. When I added MemoryLimit= option to just one service, cgroups for every unit were generated on memory cgroup. It looks like memory_limit and cpu_quota_per_sec_usec both have this potential issue. The

Re: [systemd-devel] [PATCH 0/3] [RFT] ARM: detect-virt: detect Xen and QEMU/KVM

2015-03-30 Thread Andrew Jones
On Mon, Mar 30, 2015 at 09:15:52PM +0200, Andrew Jones wrote: This series adds support for detecting if an arm or aarch64 deployment is a Xen or QEMU/KVM guest. I've tested the QEMU/KVM detection on an AArch64 guest. The Xen detection has *not* been tested, thus the RFT. I should not that the

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 1:35 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: Heyja Should this not be dropped and *DE write,integrate/implement an graphical frontend to systemd for themselves? It's not like this is receiving the love it needs, hence I'm pretty sure nobody is using this.

[systemd-devel] systemd not in a steady state, although system is fine.

2015-03-30 Thread kenneth topp
Hi, My system appears healthy, but for some reason systemd not in a good state. From the commands and their output, I have two concerns. 1) why is the state starting and not finished? 2) what are these jobs that are running? This happens to be four luks partitions that go into a btrfs

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Jóhann B. Guðmundsson
On 03/30/2015 10:32 PM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 1:35 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: Heyja Should this not be dropped and *DE write,integrate/implement an graphical frontend to systemd for themselves? It's not like this is receiving the love it

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harouni tix...@opendz.org wrote: On Fri, Mar 27, 2015 at 09:51:26AM -0700, Shawn Landden wrote: On Fri, Mar 27, 2015 at 8:16 AM, Tom Gundersen t...@jklm.no wrote: [...] * Current expression may modify/interact with a global state which may cause a

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-30 Thread Djalal Harouni
On Fri, Mar 27, 2015 at 09:51:26AM -0700, Shawn Landden wrote: On Fri, Mar 27, 2015 at 8:16 AM, Tom Gundersen t...@jklm.no wrote: [...] * Current expression may modify/interact with a global state which may cause a fatal error, and if the caller wants to know if that failed, then

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 4:02 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 03/30/2015 10:32 PM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 1:35 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: Heyja Should this not be dropped and *DE write,integrate/implement an graphical

[systemd-devel] [PATCH] macro: allow assert_se() assertions to also be optimized when NDEBUG is set

2015-03-30 Thread Shawn Landden
replaces log with assert() to remove strings. saves 3kB from text section of systemd. --- src/shared/macro.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/shared/macro.h b/src/shared/macro.h index 7f89951..8cbff01 100644 --- a/src/shared/macro.h +++

Re: [systemd-devel] journalctl not showing most boots/logs

2015-03-30 Thread Michael Biebl
2015-03-27 22:58 GMT+01:00 Michael Biebl mbi...@gmail.com: After moving away all ~ files: # journalctl --list-boots | wc -l 100 # journalctl -F _BOOT_ID | wc -l 104 It also scares me a bit, that journald is so prone to create those ~ files that often. My system is not particularly

Re: [systemd-devel] systemd not in a steady state, although system is fine.

2015-03-30 Thread Andrei Borzenkov
В Mon, 30 Mar 2015 19:35:21 -0400 kenneth topp to...@bllue.org пишет: Hi, My system appears healthy, but for some reason systemd not in a good state. From the commands and their output, I have two concerns. 1) why is the state starting and not finished? 2) what are these jobs that are

Re: [systemd-devel] systemd-run and waiting for initialization

2015-03-30 Thread Andrei Borzenkov
В Mon, 30 Mar 2015 09:48:25 +0200 Igor Bukanov i...@mir2.org пишет: As I understand, the systemd-run utility returns immediately even with --service-type=forking. What is the proper way then to wait using a shell until the main service process forks the child and exists signaling

Re: [systemd-devel] systemd-run and waiting for initialization

2015-03-30 Thread Igor Bukanov
It would be really nice to have an utility that waits until a unit is transitioned from the activating state. My problem is that I wanted to replace in a shell script a sequence like: sudo -u some_user ssh -f port_forwarding host use_forwarded_ports kill hopefully rightly guessed ssh PID with

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Andrei Borzenkov
В Mon, 30 Mar 2015 19:30:02 -0700 Shawn Landden shawnland...@gmail.com пишет: What do you feel is missing from systemctl show? It is only suppose to show fields that have been changed by humans (even the developer) not systemd defaults. From its appearance it was supposed to show current

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 8:34 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Mon, 30 Mar 2015 19:30:02 -0700 Shawn Landden shawnland...@gmail.com пишет: What do you feel is missing from systemctl show? It is only suppose to show fields that have been changed by humans (even the

Re: [systemd-devel] systemd not in a steady state, although system is fine.

2015-03-30 Thread kenneth topp
В Mon, 30 Mar 2015 19:35:21 -0400 kenneth topp to...@bllue.org пишет: Hi, My system appears healthy, but for some reason systemd not in a good state. From the commands and their output, I have two concerns. 1) why is the state starting and not finished? 2) what are these jobs

Re: [systemd-devel] regarding to cgroup siblings mask

2015-03-30 Thread WaLyong Cho
On 03/31/2015 05:13 AM, David Timothy Strauss wrote: On Fri, Mar 27, 2015 at 7:56 PM, WaLyong Cho walyong@gmail.com wrote: Hmm, it seems not. When I added MemoryLimit= option to just one service, cgroups for every unit were generated on memory cgroup. It looks like memory_limit and