[systemd-devel] [PATCH] build-sys: Lookup for the location of agetty

2015-02-16 Thread Cristian Rodríguez
May be in /sbin or /usr/sbin --- Makefile.am | 1 + configure.ac | 2 ++ units/console-getty.service.m4.in| 2 +- units/container-ge...@.service.m4.in | 2 +- units/getty@.service.m4 | 2 +- units/serial-getty@.service.m4 | 2

[systemd-devel] [PATCH 5/5] sd-bus: add missing format attribute

2015-02-15 Thread Cristian Rodríguez
--- src/systemd/sd-bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemd/sd-bus.h b/src/systemd/sd-bus.h index 2420d0c..ca2d83e 100644 --- a/src/systemd/sd-bus.h +++ b/src/systemd/sd-bus.h @@ -371,7 +371,7 @@ int sd_bus_error_setf(sd_bus_error *e, const char *name,

Re: [systemd-devel] [PATCH 3/3] core: remove unneeded libgen.h include

2015-02-11 Thread Cristian Rodríguez
El 11/02/15 a las 14:26, Lennart Poettering escribió: On Wed, 11.02.15 18:21, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: So, hmm, so if I got this right: a) The good basame() is in strings.h b) The bad basename() is in libgen.h c) The only other call in libgen.h is dirname()

[systemd-devel] [PATCH 4/4] Always use recvmsg with MSG_CMSG_CLOEXEC

2015-02-10 Thread Cristian Rodríguez
--- src/libsystemd-network/sd-dhcp-client.c | 2 +- src/libsystemd-network/sd-dhcp-server.c | 2 +- src/libsystemd/sd-rtnl/rtnl-message.c | 4 ++-- src/libudev/libudev-monitor.c | 2 +- src/machine/machine-dbus.c | 2 +- src/resolve/resolved-manager.c | 2 +-

Re: [systemd-devel] [PATCH] cryptsetup: Do not warn If the key is /dev/*random

2015-02-02 Thread Cristian Rodríguez
El 02/02/15 a las 12:42, Lennart Poettering escribió: I'd prefer if we'd change the check instead to only apply to S_ISREG() files. This way we wouldn't have to list all RNG device nodes. Yeah.. the other version I had did a !S_ISCHR check but S_ISREG is more adequate in this case.

[systemd-devel] [PATCH] cryptsetup: Do not warn If the key is /dev/*random

2015-02-02 Thread Cristian Rodríguez
Using /dev/urandom as a key is valid for swap, do not warn if this devices are world readable. --- src/cryptsetup/cryptsetup.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c index e6b37ac..38930ae 100644 ---

Re: [systemd-devel] [PATCH] timesyncd: Make saving clock to disk on NTP fix optional

2015-02-01 Thread Cristian Rodríguez
El 01/02/2015 06:36, Kay Sievers k...@vrfy.org escribió: On Feb 1, 2015 5:34 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Kay, Lennart, comments? Sounds like overkill to me for such an exotic requirement. Just link the file to /dev/null and be done? Yeah, I do not see the

Re: [systemd-devel] [PATCH] timesyncd: tighten unit file

2015-02-01 Thread Cristian Rodríguez
El 27/01/15 a las 21:18, Lennart Poettering escribió: On Tue, 27.01.15 15:12, Cameron Norman (camerontnor...@gmail.com) wrote: Lennart: if you really want to test the profile, you just need to spin up an OpenSuSE, Ubuntu, or Debian VM (on debian you need to install and enable apparmor, which

[systemd-devel] crash after commit core: make setting the shutdown watchdog configuration via dbus work

2015-01-29 Thread Cristian Rodríguez
hi: systemd crashes after that commit with gdb --args ./systemd Failed to create root cgroup hierarchy: Permission denied Failed to allocate manager object: Permission denied Program received signal SIGSEGV, Segmentation fault. 0x55574ec4 in main (argc=1, argv=0x7fffdac8) at

[systemd-devel] [PATCH] build-sys: use -fno-semantic-interposition if available

2015-01-25 Thread Cristian Rodríguez
GCC5 introduces -fno-semantic-interposition allowing better code generation in shared libraries at the cost of making interposition of exported symbols impossible (i.e, a 3rd party shared library overriding sd_notify() will not work) Using this particular feature with systemd is not supported and

[systemd-devel] [PATCH] build-sys: lookup for sulogin, it might not be in /sbin

2015-01-23 Thread Cristian Rodríguez
--- Makefile.am | 1 + configure.ac | 2 ++ units/console-shell.service.m4.in | 2 +- units/emergency.service.in| 2 +- units/rescue.service.in | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile.am

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Cristian Rodríguez
El 23/01/15 a las 14:52, Lennart Poettering escribió: On Fri, 23.01.15 12:27, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: El 23/01/15 a las 10:31, Lennart Poettering escribió: The rc-local generator only exists to add compat support for those systems where it never was a sysvinit

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Cristian Rodríguez
El 23/01/15 a las 10:31, Lennart Poettering escribió: The rc-local generator only exists to add compat support for those systems where it never was a sysvinit script anyway... They are not init scripts though. but plain shell scripts with no dependency information. they are installed in

[systemd-devel] [PATCH] mount-setup: Do not bother with /proc/bus/usb

2015-01-23 Thread Cristian Rodríguez
Current systemd requires kernel = 3.7 per the README file but CONFIG_USB_DEVICEFS disappeared from the kernel in upstream commit fb28d58b72aa9215b26f1d5478462af394a4d253 (kernel 3.5-rc1) --- src/core/mount-setup.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/mount-setup.c

[systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-22 Thread Cristian Rodríguez
--- src/sysv-generator/sysv-generator.c | 8 1 file changed, 8 insertions(+) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index b8b77aa..d6e4dfa 100644 --- a/src/sysv-generator/sysv-generator.c +++ b/src/sysv-generator/sysv-generator.c @@

Re: [systemd-devel] systemd build process, stripped ELF flags (MIPS)

2015-01-19 Thread Cristian Rodríguez
El 19/01/15 a las 05:47, Manuel Lauss escribió: The systemd build process manages to create binaries without this .MIPS.abiflags section, and this leads the 3.18 kernel to refuse to load it: Nope, the build process does no such thing, your toolchain is buggy, wild guess is that --gc-sections

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Cristian Rodríguez
El 15/01/15 a las 09:38, Nikolai Zhubr escribió: Hi all, Is it true that readahead collector defaults to only collect files within root filesystem? If so, is it possible to instruct it to also collect for e.g. /home (mounted on a separate media)? This is not mentioned anywhere in the docs. It

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Cristian Rodríguez
El 15/01/15 a las 10:40, Nikolai Zhubr escribió: Hi, 15.01.2015 16:07, Cristian Rodríguez: The readahead collector is no longer included in systemd. Hm. It is still there in not-very-old opensuse 13.2 ... for whatever reason, current openSUSE releases have systemd 210.. that's old

[systemd-devel] [PATCH 3/3] remove RUN_WITH_LOCALE et all, use extended locale functions instead

2015-01-14 Thread Cristian Rodríguez
There were two callers, one can use strtod_l() and the other strptime_l() --- src/import/curl-util.c | 38 +++--- src/shared/util.c | 18 +- src/shared/util.h | 26 -- 3 files changed, 36 insertions(+), 46

Re: [systemd-devel] [PATCH] sysv-generator: only allow regular files in enumerate_sysv()

2015-01-14 Thread Cristian Rodríguez
El 14/01/15 a las 10:39, Colin Guthrie escribió: Cristian Rodríguez wrote on 14/01/15 13:34: El 14/01/15 a las 09:21, Colin Guthrie escribió: If I read the dirent_ensure_type and dirent_is_file code properly, this would mean that symlinks to valid sysvinit scripts are now skipped

[systemd-devel] [PATCH 1/2] remove unneeded libgen.h includes

2015-01-14 Thread Cristian Rodríguez
--- src/core/mount-setup.c| 1 - src/journal/catalog.c | 1 - src/test/test-namespace.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/core/mount-setup.c b/src/core/mount-setup.c index bd3a035..eb9641f 100644 --- a/src/core/mount-setup.c +++ b/src/core/mount-setup.c @@ -24,7

[systemd-devel] [PATCH] sysv-generator: only allow regular files in enumerate_sysv()

2015-01-13 Thread Cristian Rodríguez
Otherwise, if the directory contains other directories we fail at fopen in load_sysv() with EISDIR. --- src/sysv-generator/sysv-generator.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index

[systemd-devel] [PATCH 1/2] machinectl: use GNU basename, not the XPG version

2015-01-11 Thread Cristian Rodríguez
--- src/machine/machinectl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c index 749170e..980fba1 100644 --- a/src/machine/machinectl.c +++ b/src/machine/machinectl.c @@ -32,7 +32,7 @@ #include net/if.h #include

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Cristian Rodríguez
El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. ___ systemd-devel mailing list

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Cristian Rodríguez
El 07/01/15 a las 22:55, Nikolai Zhubr escribió: 08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. Ok. So

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Cristian Rodríguez
El 07/01/15 a las 22:55, Nikolai Zhubr escribió: 08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. Ok. So

[systemd-devel] [PATCH] timesync: remove square(), use pow instead

2014-12-23 Thread Cristian Rodríguez
In any case, the compiler generates the same code inline and never actually calls the library function. --- src/timesync/timesyncd-manager.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c index

Re: [systemd-devel] [PATCH v2] build-sys: remove --gc-sections to fix debugging

2014-11-26 Thread Cristian Rodríguez
El 26/11/14 a las 15:31, Peter Wu escribió: [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=17639 https://bugs.freedesktop.org/show_bug.cgi?id=8 --- v2:removed -ffunction-sections and -fdata-sections too, mention that binutils fixed the bug. --- -1 Just fix the

Re: [systemd-devel] [BUG] too many rfkill services

2014-11-20 Thread Cristian Rodríguez
El 20/11/14 a las 15:40, Lukasz Stelmach escribió: $ ls /sys/class/rfkill/ rfkill41 rfkill42 $ systemctl -t device | grep rfkill sys-devices-pci:00-:00:1a.0-usb3-3\x2d1-3\x2d1:1.0-bluetooth-hci0-rfkill42.device

[systemd-devel] [PATCH] buildsys: test-util needs -lm for fabs()

2014-11-04 Thread Cristian Rodríguez
--- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index ff5f61b..3686103 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1543,6 +1543,7 @@ test_util_SOURCES = \ src/test/test-util.c test_util_LDADD = \ + -lm \ libsystemd-core.la

Re: [systemd-devel] Switch root slowness

2014-10-30 Thread Cristian Rodríguez
El 30/10/14 a las #4, Lennart Poettering escribió: In absence of that we can just fallback to /dev/urandom on EAGAIN I guess, and always pass GRND_NONBLOCK. Before you made this commit, I had a local patch that did exactly that..currently this is the best solution. I suggest to give up on

[systemd-devel] [PATCH] missing: Correct and extend getrandom syscall defines

2014-10-29 Thread Cristian Rodríguez
Add syscall numbers for 32 bit x86 and arm and Correct the system call number for x86_64 (it is 318 not 278) --- src/shared/missing.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/shared/missing.h b/src/shared/missing.h index 00e0287..7fd259a 100644 ---

Re: [systemd-devel] [PATCH] missing: Correct and extend getrandom syscall defines

2014-10-29 Thread Cristian Rodríguez
El 29/10/14 a las #4, Lennart Poettering escribió: On Wed, 29.10.14 14:29, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: Add syscall numbers for 32 bit x86 and arm and Correct the system call number for x86_64 (it is 318 not 278) Hmm? I did my testing on x86_64 3.18rc2, 278 is what

Re: [systemd-devel] [PATCH] missing: Correct and extend getrandom syscall defines

2014-10-29 Thread Cristian Rodríguez
El 30/10/14 a las #4, Cristian Rodríguez escribió: El 29/10/14 a las #4, Lennart Poettering escribió: On Wed, 29.10.14 14:29, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: Add syscall numbers for 32 bit x86 and arm and Correct the system call number for x86_64 (it is 318 not 278) Hmm

Re: [systemd-devel] Timers without matching units?

2014-10-22 Thread Cristian Rodríguez
El 22/10/14 a las #4, Ivan Shapovalov escribió: Hi, The systemd.timer(5) manpage states: For each timer file, a matching unit file must exist, describing the unit to activate when the timer elapses. I guess for now you can create a dummy unit that executes /bin/true to workaround this

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-22 Thread Cristian Rodríguez
El 22/10/14 a las #4, Rob Owens escribió: It is your ML, so I will oblige. But I think it is a mistake to not consider a broader view of your project than just the strictly technical aspects. It is not *his* mailing list..but it is the place where *technical* discussions about the systemd

Re: [systemd-devel] [RFC 11/25] shared/missing.h: fall pack to insecure getenv

2014-09-18 Thread Cristian Rodríguez
El 18/09/14 a las #4, Emil Renner Berthing escribió: --- src/shared/missing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/missing.h b/src/shared/missing.h index b441149..8389c28 100644 --- a/src/shared/missing.h +++ b/src/shared/missing.h @@ -353,7 +353,7 @@

Re: [systemd-devel] [RFC 12/25] shared/missing.h: check for missing canonicalize_file_name

2014-09-18 Thread Cristian Rodríguez
El 18/09/14 a las #4, Emil Renner Berthing escribió: +#if !HAVE_DECL_CANONICALIZE_FILE_NAME +static inline char *canonicalize_file_name(const char *path) { +return realpath(path, NULL); +} +#endif No, no reimplementations of library functions here, only wrappers for syscalls which

Re: [systemd-devel] [RFC 13/25] shared/missing.h: check for missing strndupa

2014-09-18 Thread Cristian Rodríguez
El 18/09/14 a las #4, Emil Renner Berthing escribió: +#if !HAVE_DECL_STRNDUPA +#define strndupa(s, n) \ + ({ \ +const char *__old = (s); \ +size_t __len = strnlen(__old, (n)); \ +char *__new = (char *)alloca(__len + 1); \ +__new[__len] = '\0'; \ +(char *)memcpy(__new,

Re: [systemd-devel] [RFC 00/25] Compile against the musl libc

2014-09-18 Thread Cristian Rodríguez
El 18/09/14 a las #4, Emil Renner Berthing escribió: Hi, Around the internet one can read statements such as systemd is designed with glibc in mind and the systemd developers' idea of a standard libc is one that has bug-for-bug compatibility with glibc. For all practical purposes this is

Re: [systemd-devel] [RFC 21/25] make sure basename that doesn't alter it's argument

2014-09-18 Thread Cristian Rodríguez
El 18/09/14 a las #4, Emil Renner Berthing escribió: --- And all of this because the POSIX versions of basename modify the argument .. see the problem ? it is the standard versions that are wrong. what about implementing a gnu_basename in the C library and using that instead ? -- Cristian I

[systemd-devel] [PATCH] Fix resource leak (coverity CID 1237760)

2014-09-17 Thread Cristian Rodríguez
--- src/libsystemd/sd-bus/bus-kernel.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libsystemd/sd-bus/bus-kernel.c b/src/libsystemd/sd-bus/bus-kernel.c index 505f335..b3cc996 100644 --- a/src/libsystemd/sd-bus/bus-kernel.c +++ b/src/libsystemd/sd-bus/bus-kernel.c

[systemd-devel] [PATCH] systemctl: fix resource leak CID #1237747

2014-09-17 Thread Cristian Rodríguez
..by simply moving the declaration of unit into the STRV_FOREACH loop as suggested by Andreas. --- src/systemctl/systemctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 88be871..9012128 100644 ---

[systemd-devel] [PATCH] missing: memfd_create takes unsigned int flags in final version

2014-09-16 Thread Cristian Rodríguez
--- src/shared/missing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/missing.h b/src/shared/missing.h index 023c680..b441149 100644 --- a/src/shared/missing.h +++ b/src/shared/missing.h @@ -209,7 +209,7 @@ static inline int fanotify_mark(int fanotify_fd,

[systemd-devel] [PATCH] buildsys, missing: include linux/memfd.h if found

2014-09-16 Thread Cristian Rodríguez
That's in order to get the system 's definitions of memfd API flags instead of relying on the locally defined ones. --- configure.ac | 1 + src/shared/missing.h | 4 2 files changed, 5 insertions(+) diff --git a/configure.ac b/configure.ac index fb16904..5ebe6ae 100644 ---

Re: [systemd-devel] [PATCH] core: Don't require cgroups xattr support

2014-06-27 Thread Cristian Rodríguez
El 26/06/14 01:58, Zbigniew Jędrzejewski-Szmek escribió: On Wed, Jun 25, 2014 at 11:45:45AM +, Tom Hirst wrote: Failure to mount cgroups with xattr should not be fatal --- src/core/mount-setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/mount-setup.c

Re: [systemd-devel] [PATCH] rules: don't enable usb pm for Avocent devices

2014-06-25 Thread Cristian Rodríguez
El 25/06/14 07:57, Tom Hirst escribió: The Avocent KVM over IP devices doesn't work correctly with USB power management enabled. Doesn't this also require kernel side blacklisting ? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] systemd m4 library complex systemd example, and coccinelle conversion

2014-06-25 Thread Cristian Rodríguez
El 12/06/14 21:04, Luis R. Rodriguez escribió: - If you want to use the dynamic link loader you should use AX_AVAILABLE_SYSTEMD() but must then ensure to use -rdynamic -ldl when linking, if using automake autotools will deal with this for you, otherwise you must ensure

Re: [systemd-devel] systemd m4 library complex systemd example, and coccinelle conversion

2014-06-25 Thread Cristian Rodríguez
El 25/06/14 13:00, Luis R. Rodriguez escribió: On Wed, Jun 25, 2014 at 9:45 AM, Cristian Rodríguez crrodrig...@opensuse.org wrote: El 12/06/14 21:04, Luis R. Rodriguez escribió: - If you want to use the dynamic link loader you should use AX_AVAILABLE_SYSTEMD() but must then ensure

Re: [systemd-devel] udev-212 and up on Sparc v8

2014-06-21 Thread Cristian Rodríguez
El 21/06/14 01:38, Chase Rayfield escribió: udev up to version 208 builds correctly on Sparc v8. However 212 and greater does not. Complete build logs of 208 and 214 can be found here: https://bugs.gentoo.org/show_bug.cgi?id=514016 Any suggestions or alternatives to how we can fix this would

Re: [systemd-devel] [PATCH 01/11] Ensure that systemd-sysctl.service is applied after modules are loaded

2014-06-16 Thread Cristian Rodríguez
El 16/06/14 08:52, Dr. Werner Fink escribió: On Fri, Jun 13, 2014 at 05:51:34PM +0200, Tom Gundersen wrote: On Fri, Jun 13, 2014 at 4:41 PM, Werner Fink wer...@suse.de wrote: From: Frederic Crozat fcro...@suse.com Hm, this would not help at all for modules loaded on-demand (which are most of

Re: [systemd-devel] [PATCH 10/11] Avoid doubling the efforts for /var/log/journal

2014-06-16 Thread Cristian Rodríguez
El 13/06/14 10:41, Werner Fink escribió: That is: set NOATIME, NOCOW, and NOCOMP for the journal directory --- src/journal/journald-server.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git src/journal/journald-server.c

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Cristian Rodríguez
El 13/06/14 05:19, Jay D Bhatt escribió: Thanks. I surely forgot to attach log. Now you can find it attached. Nope, there is no attached log in your message. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] systemd not initializing

2014-06-12 Thread Cristian Rodríguez
El 12/06/14 04:51, Mantas Mikulėnas escribió: name_to_handle_at(0xff9c, 0x96444, 0x7eefb7b8, 0x7eefb844, 0x400) = -1 ENOSYS (Function not implemented) systemd is checking if it should load SMACK or IMA policy; this can be safely ignored if you don't use these security modules. Or could

Re: [systemd-devel] [PATCH] dbus1-generator: fix resource leak on file pointer f

2014-06-12 Thread Cristian Rodríguez
El 12/06/14 12:44, Colin King escribió: From: Colin Ian King colin.k...@canonical.com File pointer f is not closed on the multiple error exit paths or on the end of create_dbus_files() causing multiple points of a resource leak. Close f on the appropriate paths. There is no resource leak..

[systemd-devel] [PATCH] Remove libattr mentions from README

2014-06-12 Thread Cristian Rodríguez
It is no longer required. --- README | 1 - 1 file changed, 1 deletion(-) diff --git a/README b/README index de159fe..2fd95e9 100644 --- a/README +++ b/README @@ -115,7 +115,6 @@ REQUIREMENTS: libcryptsetup (optional) libaudit (optional) libacl (optional) -

Re: [systemd-devel] [PATCH] build-sys: do proper LTO with GCC without needing fat objects

2014-06-05 Thread Cristian Rodríguez
El 05/06/14 17:49, Jan Alexander Steffens (heftig) escribió: commit 235c6e6 added `-ffat-lto-objects` in order to work around GCC 4.9's new default of disabling such objects. However, this also means LTO doesn't optimize across static libraries — and never did so in the past, either. Use

Re: [systemd-devel] [PATCH] build-sys: do proper LTO with GCC without needing fat objects

2014-06-05 Thread Cristian Rodríguez
El 05/06/14 17:49, Jan Alexander Steffens (heftig) escribió: commit 235c6e6 added `-ffat-lto-objects` in order to work around GCC 4.9's new default of disabling such objects. The other possibility and that we face that this LTO thing does not seem ready for prime time yet and either disable it

[systemd-devel] commit 235c6e628199221b7885f159367614b7105547cf is incorrect

2014-06-04 Thread Cristian Rodríguez
Commit 235c6e628199221b7885f159367614b7105547cf build-sys: accommodate gcc-4.9.0 link-time optimization (LTO) changes systemd fails to build (symbols not found/resolved during cgls link step) under gcc-4.9.0 due to link-time optimization (lto) changes, in particular from

Re: [systemd-devel] systemd-213 fails to compile without kmod, no way to fix it using ./configure options

2014-05-31 Thread Cristian Rodríguez
El 31/05/14 13:00, Samuli Suominen escribió: A proper git formatted patch for inclusion. IN my opinion, we should just make KMOD a mandatory dependency, drop all ifdefs, error out if not found. -- Cristian I don't know the key to success, but the key to failure is trying to please everybody.

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Cristian Rodríguez
El vie 30 may 2014 01:41:37 CLT, Samuli Suominen escribió: On 30/05/14 04:55, Greg KH wrote: On Fri, May 30, 2014 at 03:40:52AM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote: As discussed ad-nauseum previously, it is the kernel's

[systemd-devel] [PATCH] udev-builtin-keyboard: do tell on which device EVIOCSKEYCODE failed.

2014-05-30 Thread Cristian Rodríguez
I am getting Error calling EVIOCSKEYCODE (scan code 0xc022d, key code 418): Invalid argument, the error message does not tell on which specific device the problem is, add that info. --- src/udev/udev-builtin-keyboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-30 Thread Cristian Rodríguez
El 30/05/14 13:08, Greg KH escribió: On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote: As discussed ad-nauseum previously, it is the kernel's task to load firmware, not udev's. Ok, it turns out there is still one kernel driver that requires this to work properly, so we

[systemd-devel] [PATCH] tty-ask-password-agent: Do tell what directory we failed to open

2014-05-29 Thread Cristian Rodríguez
--- src/tty-ask-password-agent/tty-ask-password-agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tty-ask-password-agent/tty-ask-password-agent.c b/src/tty-ask-password-agent/tty-ask-password-agent.c index 3203474..55a2215 100644 ---

[systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-29 Thread Cristian Rodríguez
As discussed ad-nauseum previously, it is the kernel's task to load firmware, not udev's. --- Makefile.am | 8 configure.ac| 20 src/udev/udev-builtin.c | 3 --- src/udev/udev.h | 6 -- src/udev/udevd.c| 13 -

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-29 Thread Cristian Rodríguez
El 29/05/14 21:54, Greg KH escribió: On Thu, May 29, 2014 at 08:54:22PM -0400, Cristian Rodríguez wrote: As discussed ad-nauseum previously, it is the kernel's task to load firmware, not udev's. --- Makefile.am | 8 configure.ac| 20

Re: [systemd-devel] [PATCH] Drop the udev firmware loader

2014-05-29 Thread Cristian Rodríguez
El 30/05/14 00:17, Michael Biebl escribió: As a responsible and serious upstream project I expect us to not gratiously break our downstream users, especially if it can be easily avoided. And as already said, the maintenance cost is basically zero. So your argument is that we should keep code

Re: [systemd-devel] [PATCH 17/17] networkd: add dhcp server support

2014-05-27 Thread Cristian Rodríguez
El 27/05/14 10:04, Eelco Dolstra escribió: ¿ That sounds reasonable. However, to be honest, I've never really understood why networkd needs to be part of systemd in the first place. For the start, to share a large amount code.. It seems to me that it would work just as well as a separate

Re: [systemd-devel] [PATCH 17/17] networkd: add dhcp server support

2014-05-27 Thread Cristian Rodríguez
El 27/05/14 07:39, David Herrmann escribió: I strongly disagree. One major example is Wifi-P2P which requires a DHCP-Server for ad-hoc P2P connections. OOk. that convinced me, thanks.. -- Cristian I don't know the key to success, but the key to failure is trying to please everybody.

Re: [systemd-devel] [PATCH] [RFC] Move handling of sysv initscripts to a generator

2014-05-27 Thread Cristian Rodríguez
El 27/05/14 20:14, Peeters Simon escribió: this feels wrong, the native unit should override the sysv one. Is there any reason why you want to change this? Couldn't you just use arg_dest = argv[3]; instead? This behaviour is probably my only objection to the idea in question, the generated

Re: [systemd-devel] [PATCH 17/17] networkd: add dhcp server support

2014-05-26 Thread Cristian Rodríguez
El 26/05/14 22:38, Zbigniew Jędrzejewski-Szmek escribió: On Mon, May 26, 2014 at 09:39:46PM +0200, Tom Gundersen wrote: When enabled in [Network] it will set up a dhcp server on the interface, listening on one of its statically configured IPv4 addresses and with a fixed size pool of leases

[systemd-devel] [PATCH] test-unit-file: skip if unit_file_get_list returns permission denied

2014-05-24 Thread Cristian Rodríguez
--- src/test/test-unit-file.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/test/test-unit-file.c b/src/test/test-unit-file.c index 63a8a7d..4813342 100644 --- a/src/test/test-unit-file.c +++ b/src/test/test-unit-file.c @@ -48,6 +48,12 @@ static int test_unit_file_get_set(void) {

[systemd-devel] [PATCH] Use %m instead of strerror(errno) where appropiate

2014-05-23 Thread Cristian Rodríguez
--- src/journal/sd-journal.c| 6 ++ src/libsystemd-network/sd-dhcp-client.c | 4 ++-- src/nspawn/nspawn.c | 2 +- src/shared/label.c | 2 +- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/journal/sd-journal.c

Re: [systemd-devel] [PATCH] gudev: avoid using export-symbols-regex

2014-05-20 Thread Cristian Rodríguez
El mar 20 may 2014 13:25:52 CLT, Kay Sievers escribió: On Wed, Apr 23, 2014 at 11:43 AM, Cristian Rodríguez crrodrig...@opensuse.org wrote: There is no need for this hackery, just hide the internal functions using glib 's G_GNUC_INTERNAL macro. Hmm, why is that a hack? Explicitly

Re: [systemd-devel] cryptsetup vs. swapon/fsck (some kind of race condition)

2014-05-20 Thread Cristian Rodríguez
El 20/05/14 12:16, Lennart Poettering escribió: Please, remove the old cruft! Or at least disable it by default int the code! mdadm also has the same ugly assumptions.. even worst, it does not use libudev but determines if udev is running by : ( (stat(/dev/.udev, stb) == 0 || stat(/run/udev,

Re: [systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-19 Thread Cristian Rodríguez
El 19/05/14 13:52, Tom Gundersen escribió: I can't reproduce this warning, but more importantly, why is this necessary in this function and not the subsequent noes (which all seem to be more or less equivalent)? What compiler did you tried ? happens with GCC 4.9.0 r209782. -- Cristian I

[systemd-devel] [PATCH] build: Fix compile failure, KMOD_CFLAGS missing..again..

2014-05-19 Thread Cristian Rodríguez
--- Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/Makefile.am b/Makefile.am index f2a3bbd..bea3876 100644 --- a/Makefile.am +++ b/Makefile.am @@ -4195,6 +4195,8 @@ endif # -- if ENABLE_RESOLVED

Re: [systemd-devel] [PATCH] build: Honour SUID_CFLAGS and SUID_LDFLAGS

2014-05-18 Thread Cristian Rodríguez
El 18/05/14 06:47, Lennart Poettering escribió: On Sat, 17.05.14 12:39, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: This is the standard* way used to pass special linker/compiler flags such as -fPIE and -pie * Standard in the sense it is understood by many other packages

[systemd-devel] [PATCH] Fix a few compiler warnings

2014-05-18 Thread Cristian Rodríguez
--- src/journal/test-journal-stream.c | 2 +- src/libsystemd/sd-login/sd-login.c | 2 +- src/shared/util.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/journal/test-journal-stream.c b/src/journal/test-journal-stream.c index 8e1d08d..4f56edb

[systemd-devel] [PATCH] build: Honour SUID_CFLAGS and SUID_LDFLAGS

2014-05-17 Thread Cristian Rodríguez
This is the standard* way used to pass special linker/compiler flags such as -fPIE and -pie * Standard in the sense it is understood by many other packages and commonly used by distributions. --- configure.ac | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [systemd-devel] [PATCH] build: Honour SUID_CFLAGS and SUID_LDFLAGS

2014-05-17 Thread Cristian Rodríguez
El 17/05/14 14:56, Dave Reisner escribió: On Sat, May 17, 2014 at 12:39:47PM -0400, Cristian Rodríguez wrote: This is the standard* way used to pass special linker/compiler flags such as -fPIE and -pie * Standard in the sense it is understood by many other packages and commonly used

Re: [systemd-devel] logind.conf.d?

2014-05-16 Thread Cristian Rodríguez
El vie 16 may 2014 15:58:27 CLT, Josh Triplett escribió: Does that sound like a reasonable addition? Yeah, that may be useful for distributions too. +1 -- Cristian I don't know the key to success, but the key to failure is trying to please everybody.

[systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error

2014-05-15 Thread Cristian Rodríguez
timesyncd requires networkd running. --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index 16b689e..a19ca24 100644 --- a/configure.ac +++ b/configure.ac @@ -830,6 +830,8 @@ AC_ARG_ENABLE(timesyncd, AS_HELP_STRING([--disable-timesyncd], [disable

Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error

2014-05-15 Thread Cristian Rodríguez
El 15/05/14 18:23, Cristian Rodríguez escribió: timesyncd requires networkd running. --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index 16b689e..a19ca24 100644 --- a/configure.ac +++ b/configure.ac @@ -830,6 +830,8 @@ AC_ARG_ENABLE

Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error

2014-05-15 Thread Cristian Rodríguez
El 15/05/14 18:34, Lennart Poettering escribió: On Thu, 15.05.14 18:23, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: timesyncd requires networkd running. It doesn't really Should work either way... I tried that a few hours ago.. r = manager_network_monitor_listen(m

Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error

2014-05-15 Thread Cristian Rodríguez
El 15/05/14 19:20, Lennart Poettering escribió: ilure. What's the precise error? Failed to listen to networkd events: No such file or directory) -- Cristian I don't know the key to success, but the key to failure is trying to please everybody.

[systemd-devel] [PATCH] network: fix build failure, missing KMOD_XXX flags

2014-05-13 Thread Cristian Rodríguez
- Add KMOD_CFLAGS and KMOD_LIBS where appropiate - networkd now requires kmod. make --disable-kmod --enable-networkd to raise an error. --- Makefile.am | 7 ++- configure.ac | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index b8ff732..0d08975

Re: [systemd-devel] Delaying (SSH) key generation until the urandom pool is initialized

2014-04-29 Thread Cristian Rodríguez
El 29/04/14 14:43, Florian Weimer escribió: The message at https://mail.gnome.org/archives/ostree-list/2014-February/msg00010.html contains two boot traces from virtual machines which show that the SSH key is generated before the kernel pool is sufficiently seeded. Would it be possible using

Re: [systemd-devel] Compilation with gcc-4.9 fails

2014-04-22 Thread Cristian Rodríguez
El 22/04/14 20:05, Jan Engelhardt escribió: On Monday 2014-03-03 07:51, Jan Engelhardt wrote: When building with GCC 4.9.0 [svn r208221], then the following happens: [...] $ nm src/libsystemd/sd-bus/.libs/libsystemd_la-sd-bus.o 0001 C __gnu_lto_slim 0001 C __gnu_lto_v1

Re: [systemd-devel] Compilation with gcc-4.9 fails

2014-04-22 Thread Cristian Rodríguez
El 22/04/14 20:05, Jan Engelhardt escribió: On Monday 2014-03-03 07:51, Jan Engelhardt wrote: When building with GCC 4.9.0 [svn r208221], then the following happens: [...] $ nm src/libsystemd/sd-bus/.libs/libsystemd_la-sd-bus.o 0001 C __gnu_lto_slim 0001 C __gnu_lto_v1

[systemd-devel] [PATCH] gudev: avoid using export-symbols-regex

2014-04-22 Thread Cristian Rodríguez
There is no need for this hackery, just hide the internal functions using glib 's G_GNUC_INTERNAL macro. --- Makefile.am | 3 +-- src/gudev/gudevprivate.h | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index 6967b6f..903d888 100644

Re: [systemd-devel] [PATCH] libudev: replace name_to_handle_at with normal sscanf

2014-04-20 Thread Cristian Rodríguez
El 20/04/14 10:53, Kay Sievers escribió: On Sun, Apr 20, 2014 at 5:36 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: Hi Kay, it seems that handles are not crucial, and the simplified version below works too. Is there something I'm missing? The real problem here is that kernel

[systemd-devel] [PATCH] build: if -fstack-protector-strong is available, use it.

2014-04-11 Thread Cristian Rodríguez
--- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 5074114..d40fb38 100644 --- a/configure.ac +++ b/configure.ac @@ -156,6 +156,7 @@ CC_CHECK_FLAGS_APPEND([with_cflags], [CFLAGS], [\ -ffunction-sections \ -fdata-sections \

Re: [systemd-devel] [PATCH] [RFC] Ignore OOMScoreAdjust in Linux containers

2014-04-09 Thread Cristian Rodríguez
El 09/04/14 16:41, Richard Weinberger escribió: e other things like this too I suppose). Okay, I'll send patches for OOMScoreAdjust and other settings to ignore failures. This way systemd can also support containers without user namespaces. No matter how useful these are. (hello docker.io

Re: [systemd-devel] Move use of locale_t to different shared file, so that udev can still be built without it (MinimalBuild)

2014-04-08 Thread Cristian Rodríguez
El 08/04/14 03:04, Samuli Suominen escribió: This is the *only* patch we are carrying for udev currently, otherwise uClibc builds work fine, so please at least consider what I just said. All this locale_t thing is standarized in POSIX 2008, . it is up to the particular libc to keep up with

Re: [systemd-devel] Four special object test files

2014-04-07 Thread Cristian Rodríguez
El 07/04/14 15:15, Kevin Wilson escribió: What it the reason for this concatenation? automake subdir-objects does this.. -- Cristian Team PITA ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] Netconsole NG

2014-04-06 Thread Cristian Rodríguez
El 06/04/14 12:59, poma escribió: /usr/lib/systemd/system/netconsole.service: [Unit] Description=Adds the netconsole module with the configured parameters After=network.target [Service] EnvironmentFile=/etc/sysconfig/netconsole Type=simple RemainAfterExit=yes ExecStart=/usr/sbin/modprobe

Re: [systemd-devel] Netconsole NG

2014-04-06 Thread Cristian Rodríguez
El 06/04/14 13:42, Cristian Rodríguez escribió: Hrmm.. a systemd-netconsole.service that could setup this is a clean race-free fashion will be a cool addition to the stack ;) The question is.. as a separate tool or an extension to networkd, which seems to be a more suitable place

[systemd-devel] [PATCH] run systemd-tmpfiles-clean only when we have AC power

2014-04-03 Thread Cristian Rodríguez
While it is cool to be neat and clean all the time, this task can wait if we are on battery. --- units/systemd-tmpfiles-clean.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/units/systemd-tmpfiles-clean.service.in b/units/systemd-tmpfiles-clean.service.in index a5b5acb..06bb21f

[systemd-devel] [PATCH] tests: fix test-rtnl-manual.c compile failure

2014-03-31 Thread Cristian Rodríguez
Needs KMOD_CFLAGS --- Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/Makefile.am b/Makefile.am index 6c7d6e5..77495a4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1399,6 +1399,10 @@ test_ipcrm_LDADD = \ libsystemd-shared.la \ -lrt +test_rtnl_manual_CFLAGS

<    1   2   3   >