Re: [systemd-devel] [PATCH 0/6] RFC: Initial implementation of mount table handling using libmount kernelwatch

2020-08-03 Thread Ian Kent
On Mon, 2020-08-03 at 09:30 +0100, Colin Guthrie wrote: > Ian Kent wrote on 29/07/2020 01:57: > > On Tue, 2020-07-28 at 16:13 +0200, Lennart Poettering wrote: > > > On Mo, 27.07.20 12:57, Ian Kent (ik...@redhat.com) wrote: > > > > > > > Further to

Re: [systemd-devel] [PATCH 0/6] RFC: Initial implementation of mount table handling using libmount kernelwatch

2020-08-03 Thread Ian Kent
On Mon, 2020-08-03 at 11:34 +0200, Lennart Poettering wrote: > On Mi, 29.07.20 08:57, Ian Kent (ik...@redhat.com) wrote: > > > On Tue, 2020-07-28 at 16:13 +0200, Lennart Poettering wrote: > > > On Mo, 27.07.20 12:57, Ian Kent (ik...@redhat.com) wrote: > > > > >

Re: [systemd-devel] [PATCH 0/6] RFC: Initial implementation of mount table handling using libmount kernelwatch

2020-07-28 Thread Ian Kent
On Tue, 2020-07-28 at 16:13 +0200, Lennart Poettering wrote: > On Mo, 27.07.20 12:57, Ian Kent (ik...@redhat.com) wrote: > > > Further to my post about using the new mount table notifications in > > systemd I'd like to start by posting a few patches for discussion >

[systemd-devel] [PATCH 5/6] systemd: add Hashmap mount_unit_by_mnt_id

2020-07-26 Thread Ian Kent
From: Ian Kent When kernelwatch notification handling is added it will be necessary to find the Mount unit from the mount id to update individual Mount state. Add a Hashmap to lookup the Unit to get the Mount given a MountParameters mount id. Signed-off-by: Ian Kent --- src/core/mount.c

[systemd-devel] [PATCH 4/6] systemd: add mount id to MountParameters

2020-07-26 Thread Ian Kent
From: Ian Kent When kernelwatch notification handling is added it will be necessary to find the Mount unit from the mount id to update individual Mount state, so add the mount id to MountParameters. Signed-off-by: Ian Kent --- src/core/mount.c | 29 + src/core

[systemd-devel] [PATCH 3/6] systemd: try to use fsinfo for sigchld handling

2020-07-26 Thread Ian Kent
From: Ian Kent Try and use the new fsinfo() system call when handing SIGCHLD from systemd mount unit mounting. Signed-off-by: Ian Kent --- src/core/mount.c | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/src/core

[systemd-devel] [PATCH 6/6] systemd: use libmount kernelwatch if available

2020-07-26 Thread Ian Kent
From: Ian Kent Introduce an initial implementation that uses the new libmount kernelwatch notification method together with the fsinfo() system call. What I'm trying to do here is use kernelwatch notifications to create a set of mount units that have actually changed for the traversal

[systemd-devel] [PATCH 2/6] systemd: refactor mount_process_proc_self_mountinfo()

2020-07-26 Thread Ian Kent
From: Ian Kent When libmount kernelwatch notifications are introduced it will be necessary to update mount unit state for individual units when so seperate out the state update. Signed-off-by: Ian Kent --- src/core/mount.c | 154 -- 1 file

[systemd-devel] [PATCH 1/6] systemd: try to use libmount fsinfo if available

2020-07-26 Thread Ian Kent
From: Ian Kent Try and use the new fsinfo() system call when loading the mount table if possible. Signed-off-by: Ian Kent --- src/core/mount.c |6 -- src/mount/mount-tool.c |4 +++- src/shared/libmount-util.h | 28 src/shared/mount

[systemd-devel] [PATCH 0/6] RFC: Initial implementation of mount table handling using libmount kernelwatch

2020-07-26 Thread Ian Kent
. Comments on what I have so far are welcome. And also any discussion about how the mount unit state update works would be much appreciated, as well as approaches to debugging sysyemd problems in general. --- Ian Kent (6): systemd: try to use libmount fsinfo if available systemd: ref

Re: [systemd-devel] Using a new mount table notification type in systemd

2020-07-07 Thread Ian Kent
On Tue, 2020-07-07 at 08:47 +, Luca Boccassi wrote: > On Tue, 2020-07-07 at 10:44 +0800, Ian Kent wrote: > > Hi all, > > > > Some of you may be aware of the David Howells recent efforts to > > have > > a new notifications sub-system merged into the upstr

[systemd-devel] Using a new mount table notification type in systemd

2020-07-06 Thread Ian Kent
Hi all, Some of you may be aware of the David Howells recent efforts to have a new notifications sub-system merged into the upstream kernel. Part of that includes a way to get information about specific mounts without loading and scanning the mount table (the new fsinfo() system call). Paired wi

Re: [systemd-devel] [Libtirpc-devel] [PATCH] rpcbind: add support for systemd socket activation

2012-02-03 Thread Ian Kent
On Wed, 2012-02-01 at 17:37 +0100, Tom Gundersen wrote: > Hi Chuck, > > Thanks for the feedback. > > On Wed, Feb 1, 2012 at 4:32 PM, Chuck Lever wrote: > > Typically this is done by breaking the proposed change into smaller atomic > > patches. Is that not possible in this case? > > Not entire

Re: [systemd-devel] [PATCH] Circumvent autofs_v5_packet_union size bug

2011-11-13 Thread Ian Kent
On Mon, 2011-11-14 at 03:08 +0100, Kay Sievers wrote: > On Mon, Nov 14, 2011 at 02:38, Ian Kent wrote: > > On Fri, 2011-11-11 at 14:33 +0100, Kay Sievers wrote: > >> On Tue, Sep 20, 2011 at 14:26, Kay Sievers wrote: > >> > On Tue, Sep 20, 2011 at 12:58, Le

Re: [systemd-devel] [PATCH] Circumvent autofs_v5_packet_union size bug

2011-11-13 Thread Ian Kent
On Sun, 2011-11-13 at 13:23 +0100, Thomas Meyer wrote: > Am Freitag, den 11.11.2011, 14:33 +0100 schrieb Kay Sievers: > > On Tue, Sep 20, 2011 at 14:26, Kay Sievers wrote: > > > On Tue, Sep 20, 2011 at 12:58, Lennart Poettering > > > wrote: > > >&g

Re: [systemd-devel] [PATCH] Circumvent autofs_v5_packet_union size bug

2011-11-13 Thread Ian Kent
On Fri, 2011-11-11 at 14:33 +0100, Kay Sievers wrote: > On Tue, Sep 20, 2011 at 14:26, Kay Sievers wrote: > > On Tue, Sep 20, 2011 at 12:58, Lennart Poettering > > wrote: > >> On Tue, 20.09.11 11:36, Ian Kent (ra...@themaw.net) wrote: > >> > >>> &g

Re: [systemd-devel] [PATCH] Circumvent autofs_v5_packet_union size bug

2011-09-19 Thread Ian Kent
On Mon, 2011-09-19 at 22:47 +0200, Lennart Poettering wrote: > On Fri, 16.09.11 14:09, Thomas Meyer (tho...@m3y3r.de) wrote: > > > the size of autofs_v5_packet_union is 300 bytes on x86 and 304 bytes on > > x86_64 kernels. > > when running systemd (x86) on an x86_64 kernel this leads to a hang in