Re: [systemd-devel] [PATCH 2/3] sd-daemon: Use LISTEN_NAMES env when available

2015-05-19 Thread Krzysztof Opasiak
On 05/18/2015 11:05 PM, Filipe Brandenburger wrote: Hi, On Mon, May 18, 2015 at 7:26 AM, Krzysztof Opasiak k.opas...@samsung.com wrote: Matching between fds and list of expected paths is done in n^2 I don't think that's the case, because you can just stat() all the names and fstat() all

Re: [systemd-devel] [PATCH 1/3] core: Add LISTEN_NAMES environment variable

2015-05-19 Thread Krzysztof Opasiak
. I will update my patches according to your remarks and idea described here. Thank you for the review and clarification, -- Krzysztof Opasiak Samsung RD Institute Poland Samsung Electronics ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH 1/3] core: Add LISTEN_NAMES environment variable

2015-05-18 Thread Krzysztof Opasiak
On 05/16/2015 11:28 PM, Zbigniew Jędrzejewski-Szmek wrote: On Fri, May 15, 2015 at 05:35:48PM +0200, Lennart Poettering wrote: On Fri, 15.05.15 17:09, Krzysztof Opasiak (k.opas...@samsung.com) wrote: When passing file descriptors to service systemd pass also two environment variable

Re: [systemd-devel] [PATCH 2/3] sd-daemon: Use LISTEN_NAMES env when available

2015-05-18 Thread Krzysztof Opasiak
On 05/15/2015 05:40 PM, Lennart Poettering wrote: On Fri, 15.05.15 17:09, Krzysztof Opasiak (k.opas...@samsung.com) wrote: LISTEN_NAMES environment variable contains details about received file descriptors. Let's try to use it instead of doing always two stats. I am really not convinced

Re: [systemd-devel] [PATCH 1/3] core: Add LISTEN_NAMES environment variable

2015-05-18 Thread Krzysztof Opasiak
Hi, On 05/15/2015 05:35 PM, Lennart Poettering wrote: On Fri, 15.05.15 17:09, Krzysztof Opasiak (k.opas...@samsung.com) wrote: When passing file descriptors to service systemd pass also two environment variable: - LISTEN_PID - PID of service - LISTEN_FDS - Number of file descriptors passed

[systemd-devel] [PATCH 1/3] core: Add LISTEN_NAMES environment variable

2015-05-15 Thread Krzysztof Opasiak
When passing file descriptors to service systemd pass also two environment variable: - LISTEN_PID - PID of service - LISTEN_FDS - Number of file descriptors passed to service Passed fds may have different types: socket, fifo etc. To distinguish them sd-daemon library provides a set of sd_is_*()

[systemd-devel] [PATCH 2/3] sd-daemon: Use LISTEN_NAMES env when available

2015-05-15 Thread Krzysztof Opasiak
LISTEN_NAMES environment variable contains details about received file descriptors. Let's try to use it instead of doing always two stats. This commit reworks all sd_is_*() functions to try parse LISTEN_NAMES variable in first step and do stats only as fallback procedure or if field for given fd