Re: [systemd-devel] [PATCH] firmware: wake all waiters

2017-06-28 Thread Luis R. Rodriguez
On Wed, Jun 28, 2017 at 06:21:09PM +0200, Lennart Poettering wrote: > On Wed, 28.06.17 09:06, Luis R. Rodriguez (mcg...@kernel.org) wrote: > > > On Wed, Jun 28, 2017 at 12:06 AM, Lennart Poettering > > <mzxre...@0pointer.de> wrote: > > > On Wed, 28.06

Re: [systemd-devel] [PATCH] firmware: wake all waiters

2017-06-28 Thread Luis R. Rodriguez
On Wed, Jun 28, 2017 at 12:06 AM, Lennart Poettering <mzxre...@0pointer.de> wrote: > On Wed, 28.06.17 00:24, Luis R. Rodriguez (mcg...@kernel.org) wrote: > >> > Do you know how systemd developers feel about the issue (CCed)? Given >> > that it seems to domina

Re: [systemd-devel] [PATCH] firmware: wake all waiters

2017-06-27 Thread Luis R. Rodriguez
On Tue, Jun 27, 2017 at 02:25:53PM -0700, Jakub Kicinski wrote: > On Tue, 27 Jun 2017 18:39:42 +0200, Luis R. Rodriguez wrote: > > > > > The problem is that advanced NICs are quite programmable [1] and > > > depending on use case one may want to load different firmware

Re: [systemd-devel] [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-10-03 Thread Luis R. Rodriguez
On Fri, Oct 3, 2014 at 1:23 AM, Tom Gundersen t...@jklm.no wrote: On Thu, Oct 2, 2014 at 10:06 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Thu, Oct 02, 2014 at 08:12:37AM +0200, Tom Gundersen wrote: Making kmod a special case is of course possible. However, as long

Re: [systemd-devel] [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-10-02 Thread Luis R. Rodriguez
now. On Thu, Oct 02, 2014 at 08:12:37AM +0200, Tom Gundersen wrote: On Tue, Sep 30, 2014 at 5:24 PM, Luis R. Rodriguez mcg...@suse.com wrote: commit e64fae5573e566ce4fd9b23c68ac8f3096603314 Author: Kay Sievers kay.siev...@vrfy.org Date: Wed Jan 18 05:06:18 2012 +0100 udevd: kill

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-12 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 10:48 PM, Tom Gundersen t...@jklm.no wrote: On Fri, Sep 12, 2014 at 12:26 AM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: On Thu, Sep 11, 2014 at 2:43 PM, Tom Gundersen t...@jklm.no wrote: How about simply introducing a new flag to finit_module() to indicate

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-09-11 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 1:07 PM, Tom Gundersen t...@jklm.no wrote: On Mon, Aug 11, 2014 at 7:19 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Mon, Aug 11, 2014 at 12:57 PM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 11.08.14 18:39, Luis R. Rodriguez (mcg...@suse.com) wrote

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 2:43 PM, Tom Gundersen t...@jklm.no wrote: On Wed, Sep 10, 2014 at 11:10 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: More than two years have gone by on growing design and assumptions on top of that original commit. I'm not sure if *systemd folks* yet believe

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-09-11 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 11:50:19PM +0200, Tom Gundersen wrote: On Thu, Sep 11, 2014 at 11:02 PM, Luis R. Rodriguez mcg...@suse.com wrote: and added a warning which is triggered after a third of the timeout. This is great! What commit merged this?I just looked at the latest commits

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-10 Thread Luis R. Rodriguez
Tom, thanks for reviewing this! My reply below! On Tue, Sep 9, 2014 at 11:46 PM, Tom Gundersen t...@jklm.no wrote: On Tue, Sep 9, 2014 at 10:45 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: On Tue, Sep 9, 2014 at 12:35 PM, James Bottomley james.bottom...@hansenpartnership.com wrote

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-09 Thread Luis R. Rodriguez
On Tue, Sep 9, 2014 at 12:35 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Tue, 2014-09-09 at 12:16 -0700, Luis R. Rodriguez wrote: On Mon, Sep 8, 2014 at 10:38 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: If we want to sort out some sync/async

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-31 Thread Luis R. Rodriguez
On Wed, Aug 27, 2014 at 5:16 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Aug 27, 2014 at 05:07:10PM -0700, Luis R. Rodriguez wrote: Hey, if you have patches already, I'll be glad to look at them :) OK well I'll spin what I have then, but I'm reviewing Wu's solution from

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-27 Thread Luis R. Rodriguez
On Mon, Aug 11, 2014 at 10:19 AM, Luis R. Rodriguez mcg...@suse.com wrote: On Mon, Aug 11, 2014 at 12:57 PM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 11.08.14 18:39, Luis R. Rodriguez (mcg...@suse.com) wrote: This looks really wrong. We shouldn't permit worker processes

Re: [systemd-devel] dell rbu driver and FW_LOADER_USER_HELPER

2014-08-26 Thread Luis R. Rodriguez
On Tue, Aug 26, 2014 at 07:09:46PM +0200, Luis R. Rodriguez wrote: When Christian tried removing the udev firmware loader it was detected that the Dell rbu driver still required use of FW_LOADER_USER_HELPER [0]. This driver needed reworking to not be tied to the firmware loader, curious

Re: [systemd-devel] [PATCH v3 2/3] cxgb4: use module_long_probe_init()

2014-08-14 Thread Luis R. Rodriguez
On Thu, Aug 14, 2014 at 09:42:49AM -0700, Casey Leedom wrote: On 08/13/2014 04:33 PM, Anish Bhatt wrote: Adding Casey who's actually incharge of this code and missing from the CC list Thanks Anish! As I mentioned to Anish, there are fundamentally two problems here in the time being

Re: [systemd-devel] [PATCH v3 2/3] cxgb4: use module_long_probe_init()

2014-08-14 Thread Luis R. Rodriguez
On Thu, Aug 14, 2014 at 09:53:21PM +0200, Luis R. Rodriguez wrote: On Thu, Aug 14, 2014 at 09:42:49AM -0700, Casey Leedom wrote: Part of the problem is that the current architecture has Device Probe happening out of the Module Initialization when we call pci_register_driver() with our

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-11 Thread Luis R. Rodriguez
On Mon, Aug 11, 2014 at 03:50:47PM +0200, Lennart Poettering wrote: On Fri, 08.08.14 19:16, Luis R. Rodriguez (mcg...@do-not-panic.com) wrote: This looks really wrong. We shouldn't permit worker processes to be blocked indefinitely without any timeout applied. Designing a worker process

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-11 Thread Luis R. Rodriguez
On Mon, Aug 11, 2014 at 12:57 PM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 11.08.14 18:39, Luis R. Rodriguez (mcg...@suse.com) wrote: This looks really wrong. We shouldn't permit worker processes to be blocked indefinitely without any timeout applied. Designing a worker

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-09 Thread Luis R. Rodriguez
On Sat, Aug 09, 2014 at 09:42:36AM +0200, Kay Sievers wrote: On Sat, Aug 9, 2014 at 4:16 AM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: The purpose of commit e64fae55 (January 2012) on systemd was to introduce a timeout send to hell drivers that are not using asynch firmware loading

[systemd-devel] [PATCH v2] udev: warn instead of killing kmod loading

2014-08-09 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com The purpose of commit e64fae55 (January 2012) on systemd was to introduce a timeout for drivers that are not using asynch firmware loading. That commit actually would not have triggered in full effect on udev's usage of kmod for module loading until commit

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-09 Thread Luis R. Rodriguez
On Sat, Aug 9, 2014 at 10:06 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Aug 09, 2014 at 10:33:47AM +0200, Luis R. Rodriguez wrote: On Sat, Aug 09, 2014 at 09:42:36AM +0200, Kay Sievers wrote: On Sat, Aug 9, 2014 at 4:16 AM, Luis R. Rodriguez mcg...@do-not-panic.com

[systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-08-08 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com The purpose of commit e64fae55 (January 2012) on systemd was to introduce a timeout send to hell drivers that are not using asynch firmware loading. That commit actually would not have triggered in full effect on udev's usage of kmod for module loading

Re: [systemd-devel] [Cocci] systemd m4 library complex systemd example, and coccinelle conversion

2014-06-25 Thread Luis R. Rodriguez
On Mon, Jun 23, 2014 at 03:19:30PM +0200, Lennart Poettering wrote: On Thu, 12.06.14 18:04, Luis R. Rodriguez (mcg...@do-not-panic.com) wrote: Hey folks, so I've been working on getting systemd support on xen for a bit now and thanks to the last suggestion about the launcher here

Re: [systemd-devel] [Cocci] systemd m4 library complex systemd example, and coccinelle conversion

2014-06-25 Thread Luis R. Rodriguez
On Wed, Jun 25, 2014 at 02:24:44PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Jun 25, 2014 at 10:20:11AM +0200, Luis R. Rodriguez wrote: On Mon, Jun 23, 2014 at 03:19:30PM +0200, Lennart Poettering wrote: On Thu, 12.06.14 18:04, Luis R. Rodriguez (mcg...@do-not-panic.com) wrote

Re: [systemd-devel] systemd m4 library complex systemd example, and coccinelle conversion

2014-06-25 Thread Luis R. Rodriguez
On Wed, Jun 25, 2014 at 9:45 AM, Cristian Rodríguez crrodrig...@opensuse.org wrote: El 12/06/14 21:04, Luis R. Rodriguez escribió: - If you want to use the dynamic link loader you should use AX_AVAILABLE_SYSTEMD() but must then ensure to use -rdynamic -ldl when linking

Re: [systemd-devel] systemd m4 library complex systemd example, and coccinelle conversion

2014-06-25 Thread Luis R. Rodriguez
On Wed, Jun 25, 2014 at 11:32 AM, Cristian Rodríguez crrodrig...@opensuse.org wrote: El 25/06/14 13:00, Luis R. Rodriguez escribió: On Wed, Jun 25, 2014 at 9:45 AM, Cristian Rodríguez crrodrig...@opensuse.org wrote: El 12/06/14 21:04, Luis R. Rodriguez escribió: - If you want to use

[systemd-devel] systemd m4 library complex systemd example, and coccinelle conversion

2014-06-12 Thread Luis R. Rodriguez
Hey folks, so I've been working on getting systemd support on xen for a bit now and thanks to the last suggestion about the launcher here on systemd-devel I think we're on the final stretch now. I'll be submitting a v6 PATCH series shortly which I think should be the last if not close to the last

Re: [systemd-devel] [PATCH v5 12/14] autoconf: xen: enable explicit preference option for xenstored preference

2014-06-09 Thread Luis R. Rodriguez
On Wed, Jun 04, 2014 at 07:52:56PM -0700, Cameron Norman wrote: On Wed, Jun 4, 2014 at 5:31 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Sun, Jun 01, 2014 at 08:15:47AM +0200, Lennart Poettering wrote: On Fri, 30.05.14 01:29, Luis R. Rodriguez (mcg...@suse.com) wrote: I'm cc'ing a few

Re: [systemd-devel] [PATCH v5 12/14] autoconf: xen: enable explicit preference option for xenstored preference

2014-06-04 Thread Luis R. Rodriguez
On Sun, Jun 01, 2014 at 08:15:47AM +0200, Lennart Poettering wrote: On Fri, 30.05.14 01:29, Luis R. Rodriguez (mcg...@suse.com) wrote: I'm cc'ing a few security folks as I'd appreciate review on the ideas here, in particular that of a launcher idea on system to replace alternatives

Re: [systemd-devel] [PATCH v5 12/14] autoconf: xen: enable explicit preference option for xenstored preference

2014-05-29 Thread Luis R. Rodriguez
Campbell wrote: On Sat, 2014-05-24 at 01:20 +0200, Luis R. Rodriguez wrote: On Thu, May 22, 2014 at 11:05:47AM +0100, Ian Campbell wrote: On Thu, 2014-05-22 at 01:02 +0200, Luis R. Rodriguez wrote: It might be reasonable for hotplugpath.sh to define XENSTORE_xenstored=/path/to/xenstored

[systemd-devel] The best way to deal with a deamon with two binary options

2014-05-22 Thread Luis R. Rodriguez
Hey folks, Xen systemd support with active sockets and sd_notify() is under way, we're in what seems to be the final rounds of patch review. One of the last items we are reviewing is how to best deal with a deamon that has two binary options for the daemon. They share the same arguments and in