Re: [systemd-devel] [PATCH 2/2] sysv-generator: remove NULL pointer dereference

2015-04-26 Thread Shawn Landden
Actually you missed that free_sysvstub_hashmap does not tolerate NULL pointers. On Sun, Apr 26, 2015 at 11:21 AM, Shawn Landden sh...@churchofgit.com wrote: On Sun, Apr 26, 2015 at 11:15 AM, Thomas H.P. Andersen pho...@gmail.com wrote: Hi Shawn, I fixed this a few hours ago. I also updated

Re: [systemd-devel] [PATCH 2/2] sysv-generator: remove NULL pointer dereference

2015-04-26 Thread Shawn Landden
, Apr 26, 2015 at 12:04 PM, Thomas H.P. Andersen pho...@gmail.com wrote: On Sun, Apr 26, 2015 at 8:31 PM, Thomas H.P. Andersen pho...@gmail.com wrote: On Sun, Apr 26, 2015 at 8:23 PM, Shawn Landden sh...@churchofgit.com wrote: Actually you missed that free_sysvstub_hashmap does not tolerate NULL

[systemd-devel] [PATCH 1/2] path-util: fix fd_is_mount_point

2015-04-26 Thread Shawn Landden
(coverity) --- src/shared/path-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/path-util.c b/src/shared/path-util.c index 925bb28..95bfafc 100644 --- a/src/shared/path-util.c +++ b/src/shared/path-util.c @@ -627,7 +627,7 @@ fallback_fstat:

[systemd-devel] [PATCH 2/2] sysv-generator: remove NULL pointer dereference

2015-04-26 Thread Shawn Landden
(coverity) --- src/sysv-generator/sysv-generator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index 5ecd750..714ce8f 100644 --- a/src/sysv-generator/sysv-generator.c +++

Re: [systemd-devel] [PATCH 2/2] sysv-generator: remove NULL pointer dereference

2015-04-26 Thread Shawn Landden
in on my end. On Sun, Apr 26, 2015 at 7:58 PM, Shawn Landden sh...@churchofgit.com wrote: (coverity) --- src/sysv-generator/sysv-generator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index

[systemd-devel] [PATCH] sysv-generator: do not dereference uninitilized data or NULL pointer

2015-04-26 Thread Shawn Landden
(coverity) v2 --- src/sysv-generator/sysv-generator.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index 5ecd750..f56d727 100644 --- a/src/sysv-generator/sysv-generator.c +++

Re: [systemd-devel] [PATCH 5/6] network: fix strict aliasing issue

2015-04-12 Thread Shawn Landden
On Sun, Apr 12, 2015 at 12:43 PM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 11.03.15 08:13, Shawn Landden (sh...@churchofgit.com) wrote: We shouldn't assume 64-bit arch with the way we do math either. (although I will submit a patch to glibc to add a uint64_t union alias) Hmm

Re: [systemd-devel] [PATCH] network: allow domain names up to 255 characters

2015-04-12 Thread Shawn Landden
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] [PATCH] network: allow domain names up to 255 characters

2015-04-12 Thread Shawn Landden
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] [systemd-commits] 2 commits - src/libsystemd-network src/udev

2015-04-11 Thread Shawn Landden
: Shawn Landden sh...@churchofgit.com Date: Tue Mar 10 20:45:15 2015 -0700 sd-dhcp-client: fix strict aliasing issue diff --git a/src/libsystemd-network/sd-dhcp-client.c b/src/libsystemd-network/sd-dhcp-client.c index 4224e01..a477ccc 100644 --- a/src/libsystemd-network/sd-dhcp

Re: [systemd-devel] sd_event_run

2015-04-11 Thread Shawn Landden
as _new(). Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com

Re: [systemd-devel] sd_event_run

2015-04-11 Thread Shawn Landden
On Sat, Apr 11, 2015 at 6:01 PM, Shawn Landden shawnland...@gmail.com wrote: On Sat, Apr 11, 2015 at 4:52 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Fri, Apr 10, 2015 at 06:14:40PM +0200, Lennart Poettering wrote: On Sat, 14.03.15 12:19, Tom Gundersen (t...@jklm.no) wrote

[systemd-devel] [PATCH] sd-dhcp-client: shutup gcc aliasing warning

2015-04-11 Thread Shawn Landden
we only access this as void* so there is no violation --- src/libsystemd-network/sd-dhcp-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-network/sd-dhcp-client.c b/src/libsystemd-network/sd-dhcp-client.c index c44392e..bf57d4b 100644 ---

[systemd-devel] [PATCH] bootchart: fix check for no fd

2015-04-05 Thread Shawn Landden
found with coverty report --- src/bootchart/store.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index f19427e..f159cba 100644 --- a/src/bootchart/store.c +++ b/src/bootchart/store.c @@ -476,7 +476,7 @@ catch_rename:

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 8:38 AM, Djalal Harouni tix...@opendz.org wrote: On Mon, Mar 30, 2015 at 07:32:35PM -0700, Shawn Landden wrote: On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harouni tix...@opendz.org wrote: On Fri, Mar 27, 2015 at 09:51:26AM -0700, Shawn Landden wrote: On Fri, Mar 27, 2015

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 7:19 AM, Dimitri John Ledkov dimitri.j.led...@intel.com wrote: On 31 March 2015 at 15:08, Shawn Landden shawnland...@gmail.com wrote: On Tue, Mar 31, 2015 at 12:31 AM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 03/31/2015 02:30 AM, Shawn Landden wrote

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 10:35 AM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 30.03.15 19:30, Shawn Landden (shawnland...@gmail.com) wrote: What do you feel is missing from systemctl show? It is only suppose to show fields that have been changed by humans (even the developer

Re: [systemd-devel] Drop systemd-ui

2015-03-31 Thread Shawn Landden
On Tue, Mar 31, 2015 at 12:31 AM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 03/31/2015 02:30 AM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 4:02 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 03/30/2015 10:32 PM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 1:35

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Shawn Landden
or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 5:04 PM, Djalal Harouni tix...@opendz.org wrote: On Fri, Mar 27, 2015 at 09:51:26AM -0700, Shawn Landden wrote: On Fri, Mar 27, 2015 at 8:16 AM, Tom Gundersen t...@jklm.no wrote: [...] * Current expression may modify/interact with a global state which may cause

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 4:02 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 03/30/2015 10:32 PM, Shawn Landden wrote: On Mon, Mar 30, 2015 at 1:35 PM, Jóhann B. Guðmundsson johan...@gmail.com wrote: Heyja Should this not be dropped and *DE write,integrate/implement an graphical

[systemd-devel] [PATCH] macro: allow assert_se() assertions to also be optimized when NDEBUG is set

2015-03-30 Thread Shawn Landden
replaces log with assert() to remove strings. saves 3kB from text section of systemd. --- src/shared/macro.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/shared/macro.h b/src/shared/macro.h index 7f89951..8cbff01 100644 --- a/src/shared/macro.h +++

Re: [systemd-devel] Drop systemd-ui

2015-03-30 Thread Shawn Landden
On Mon, Mar 30, 2015 at 8:34 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Mon, 30 Mar 2015 19:30:02 -0700 Shawn Landden shawnland...@gmail.com пишет: What do you feel is missing from systemctl show? It is only suppose to show fields that have been changed by humans (even

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-27 Thread Shawn Landden
On Thu, Mar 26, 2015 at 5:47 PM, Djalal Harouni tix...@opendz.org wrote: On Fri, Mar 27, 2015 at 12:30:53AM +0100, Tom Gundersen wrote: On Thu, Mar 26, 2015 at 9:19 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 24.03.15 11:11, Shawn Landden (sh...@churchofgit.com) wrote

Re: [systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-27 Thread Shawn Landden
On Thu, Mar 26, 2015 at 1:19 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 24.03.15 11:11, Shawn Landden (sh...@churchofgit.com) wrote: Will result in slightly smaller binaries, and cuts out the branch, even if the expression is still executed. I am sorry, but the whole point

Re: [systemd-devel] [PATCH] CODING_STYLE: this also help with unaligned memory accesses

2015-03-27 Thread Shawn Landden
On Thu, Mar 26, 2015 at 1:31 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 24.03.15 11:16, Shawn Landden (sh...@churchofgit.com) wrote: And those arches don't get much testing too. --- CODING_STYLE | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[systemd-devel] [PATCH] timedatectl: check for getenv(TZDIR)

2015-03-27 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. If TZDIR is set, glibc will look there rather than /usr/share/zoneinfo. See tzset(3). --- src/timedate/timedatectl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] systemd not honoring LD_LIBRARY_PATH?

2015-03-27 Thread Shawn Landden
-- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] CODING_STYLE: this also help with unaligned memory accesses

2015-03-24 Thread Shawn Landden
And those arches don't get much testing too. --- CODING_STYLE | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CODING_STYLE b/CODING_STYLE index b687e72..8934954 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -14,7 +14,8 @@ - The destructors always unregister the object

Re: [systemd-devel] [PATCH 1/2] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
On Tue, Mar 24, 2015 at 11:32 AM, Kay Sievers k...@vrfy.org wrote: On Tue, Mar 24, 2015 at 7:11 PM, Shawn Landden sh...@churchofgit.com wrote: /* Enforce the values of /etc/localtime */ if (getenv(TZ)) { -fprintf(stderr, Warning: Ignoring the TZ variable.\n\n

[systemd-devel] [PATCH] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. avoid calling gmtime_r() and localtime_r() twice deduplicate some strings v2 --- src/timedate/timedatectl.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git

[systemd-devel] [PATCH] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. v3 --- src/timedate/timedatectl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index ab5c8a1..d529a0a 100644 ---

[systemd-devel] [PATCH 1/2] timedatectl: check for getenv(TZDIR)

2015-03-24 Thread Shawn Landden
I liked having the DST information. It is a pity glibc doesn't export this information. --- src/timedate/timedatectl.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index ab5c8a1..8daae54

[systemd-devel] [PATCH 2/2] macro: allow assert_se() assertions to also be optimized out when NDEBUG is set

2015-03-24 Thread Shawn Landden
Will result in slightly smaller binaries, and cuts out the branch, even if the expression is still executed. --- src/shared/macro.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/shared/macro.h b/src/shared/macro.h index 7f89951..02219ea 100644 ---

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-23 Thread Shawn Landden
On Mon, Mar 23, 2015 at 4:42 AM, Stef Walter st...@redhat.com wrote: On 23.03.2015 12:11, Shawn Landden wrote: On Sun, Mar 22, 2015 at 10:32 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 19.03.15 14:39, David Herrmann (dh.herrm...@gmail.com) wrote: Hmm, so

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-23 Thread Shawn Landden
___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel

[systemd-devel] [PATCH] bootchart: remove duplicated code, prevent creating empty files

2015-03-23 Thread Shawn Landden
on IRC Signed-off-by: Shawn Landden sh...@churchofgit.com --- src/bootchart/bootchart.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/bootchart/bootchart.c b/src/bootchart/bootchart.c index 99ffb86..71dffc9 100644 --- a/src/bootchart/bootchart.c +++ b/src/bootchart/bootchart.c

[systemd-devel] [PATCH] timedatectl: fix when queried system has differn't timezone

2015-03-23 Thread Shawn Landden
Also allow getting time from time(2) when BUS_TRANSPORT_MACHINE. --- src/timedate/timedatectl.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index 9e04f8f..7c9bd11 100644 --- a/src/timedate/timedatectl.c +++

[systemd-devel] [PATCH] timedatectl: fix when queried system has differn't timezone

2015-03-23 Thread Shawn Landden
Also allow getting time from time(2) when BUS_TRANSPORT_MACHINE. v2: check for error --- src/timedate/timedatectl.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index 9e04f8f..44d329e 100644 ---

[systemd-devel] [PATCH] bootchart: more useful error message for common error

2015-03-23 Thread Shawn Landden
Reported-by: tfirg_ on IRC Signed-off-by: Shawn Landden sh...@churchofgit.com --- src/bootchart/store.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index 607cc5e..dfa681f 100644 --- a/src/bootchart/store.c +++ b/src/bootchart

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-23 Thread Shawn Landden
On Mon, Mar 23, 2015 at 12:13 PM, Stef Walter st...@redhat.com wrote: Sorry about the encrypted email ... I hit the wrong button. On 23.03.2015 19:07, Shawn Landden wrote: On Mon, Mar 23, 2015 at 8:56 AM, Kay Sievers k...@vrfy.org wrote: On Mon, Mar 23, 2015 at 3:49 PM, Stef Walter st

Re: [systemd-devel] [PATCH] timedated: Add a LocalOffset property for timezone offset

2015-03-23 Thread Shawn Landden
://lists.freedesktop.org/mailman/listinfo/systemd-devel -- Liberty equality fraternity or death, Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] timedated: add LocalTimeUSec via dbus

2015-03-23 Thread Shawn Landden
On Mon, Mar 23, 2015 at 6:52 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Mon, Mar 23, 2015 at 04:24:38AM -0700, Shawn Landden wrote: --- src/timedate/timedated.c | 24 1 file changed, 24 insertions(+) diff --git a/src/timedate/timedated.c b/src

Re: [systemd-devel] [PATCH] fix compiler warning

2015-03-15 Thread Shawn Landden
On Sun, Mar 15, 2015 at 4:53 AM, Ronny Chevalier chevalier.ro...@gmail.com wrote: 2015-03-14 17:54 GMT+01:00 Shawn Landden sh...@churchofgit.com: On Sat, Mar 14, 2015 at 6:31 AM, Ronny Chevalier chevalier.ro...@gmail.com wrote: 2015-03-11 4:42 GMT+01:00 Shawn Landden sh

Re: [systemd-devel] [PATCH 4/6] make in_addr_from_string() accept ipv4 addresses even when using AF_INET6

2015-03-15 Thread Shawn Landden
On Sun, Mar 15, 2015 at 1:07 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, Mar 11, 2015 at 08:13:47AM -0700, Shawn Landden wrote: if we are going to have a function to fix up the deficiencies of inet_pton(), better go all the way. --- src/shared/in-addr-util.c | 17

Re: [systemd-devel] [PATCH 4/6] make in_addr_from_string() accept ipv4 addresses even when using AF_INET6

2015-03-15 Thread Shawn Landden
On Sun, Mar 15, 2015 at 1:36 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Sun, Mar 15, 2015 at 01:28:05PM -0700, Shawn Landden wrote: On Sun, Mar 15, 2015 at 1:07 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Wed, Mar 11, 2015 at 08:13:47AM -0700, Shawn

[systemd-devel] [PATCH] path-lookup: use secure_getenv()

2015-03-14 Thread Shawn Landden
All these except user_data_home_dir() are certainly vectors for arbitrary code execution. These should use secure_getenv() --- src/shared/path-lookup.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/shared/path-lookup.c b/src/shared/path-lookup.c

Re: [systemd-devel] [PATCH] fix compiler warning

2015-03-14 Thread Shawn Landden
On Sat, Mar 14, 2015 at 6:31 AM, Ronny Chevalier chevalier.ro...@gmail.com wrote: 2015-03-11 4:42 GMT+01:00 Shawn Landden sh...@churchofgit.com: warning: pointer/integer type mismatch in conditional expression --- src/shared/socket-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[systemd-devel] [PATCH 2/6] fix strict aliasing violations in src/udev/udev-builtin-usb_id.c

2015-03-12 Thread Shawn Landden
--- src/udev/udev-builtin-usb_id.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/udev/udev-builtin-usb_id.c b/src/udev/udev-builtin-usb_id.c index 6516d93..3c15b2f 100644 --- a/src/udev/udev-builtin-usb_id.c +++ b/src/udev/udev-builtin-usb_id.c @@ -28,6

[systemd-devel] [PATCH 6/6] refactor in_addr_to_string()

2015-03-12 Thread Shawn Landden
--- src/resolve/resolved-dns-rr.c | 6 ++ src/shared/in-addr-util.c | 32 +++- 2 files changed, 13 insertions(+), 25 deletions(-) diff --git a/src/resolve/resolved-dns-rr.c b/src/resolve/resolved-dns-rr.c index 78d9e4a..a73ccd7 100644 ---

[systemd-devel] [PATCH 4/6] make in_addr_from_string() accept ipv4 addresses even when using AF_INET6

2015-03-12 Thread Shawn Landden
if we are going to have a function to fix up the deficiencies of inet_pton(), better go all the way. --- src/shared/in-addr-util.c | 17 + src/shared/in-addr-util.h | 1 + 2 files changed, 18 insertions(+) diff --git a/src/shared/in-addr-util.c b/src/shared/in-addr-util.c index

[systemd-devel] [PATCH 1/6] fix strict aliasing issues in src/udev/udev-ctrl.c

2015-03-11 Thread Shawn Landden
it is ironic that The only purpose of this structure is to cast the structure pointer passed in addr in order to avoid compiler warnings. See EXAMPLE below. from bind(2) --- src/udev/udev-ctrl.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git

[systemd-devel] [PATCH 5/6] network: fix strict aliasing issue

2015-03-11 Thread Shawn Landden
We shouldn't assume 64-bit arch with the way we do math either. (although I will submit a patch to glibc to add a uint64_t union alias) --- src/network/networkd-address.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/network/networkd-address.c

[systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
is part of systemd. + + Copyright 2015 Shawn Landden + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software Foundation; either version 2.1 of the License, or + (at your option) any later

[systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
new file mode 100644 index 000..cabd46c --- /dev/null +++ b/src/systemctl/bootspec.c @@ -0,0 +1,231 @@ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** + This file is part of systemd. + + Copyright 2015 Shawn Landden + + systemd is free software; you can redistribute

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers k...@vrfy.org wrote: On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden sh...@churchofgit.com wrote: Still use helper when Xen Dom0, to avoid duplicating some hairy code. I think the rbtree version was far more understandable as greedy_realloc0

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers k...@vrfy.org wrote: On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden sh...@churchofgit.com wrote: Still use helper when Xen Dom0, to avoid duplicating some hairy code. I think the rbtree version was far more understandable as greedy_realloc0

[systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
/null +++ b/src/systemctl/bootspec.c @@ -0,0 +1,247 @@ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** + This file is part of systemd. + + Copyright 2015 Shawn Landden + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser

Re: [systemd-devel] [PATCH] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-03-11 Thread Shawn Landden
On Wed, Mar 11, 2015 at 6:24 PM, Kay Sievers k...@vrfy.org wrote: On Thu, Mar 12, 2015 at 2:07 AM, Shawn Landden sh...@churchofgit.com wrote: On Wed, Mar 11, 2015 at 5:51 PM, Kay Sievers k...@vrfy.org wrote: On Thu, Mar 12, 2015 at 1:22 AM, Shawn Landden sh...@churchofgit.com wrote

[systemd-devel] [PATCH] add REMOTE_ADDR and REMOTE_PORT for Accept=yes

2015-03-10 Thread Shawn Landden
--- TODO | 2 - man/systemd.socket.xml | 7 ++- src/core/service.c | 41 - src/libsystemd/sd-resolve/test-resolve.c | 2 +- src/shared/socket-util.c | 76 +++-

[systemd-devel] [PATCH] fix strict aliasing issue in src/libsystemd-network/sd-dhcp-client.c

2015-03-10 Thread Shawn Landden
--- src/libsystemd-network/sd-dhcp-client.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/libsystemd-network/sd-dhcp-client.c b/src/libsystemd-network/sd-dhcp-client.c index 4224e01..a477ccc 100644 --- a/src/libsystemd-network/sd-dhcp-client.c +++

[systemd-devel] [PATCH] fix strict aliasing violations in src/udev/udev-builtin-usb_id.c

2015-03-10 Thread Shawn Landden
also switch to inttypes.h --- src/udev/udev-builtin-usb_id.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/udev/udev-builtin-usb_id.c b/src/udev/udev-builtin-usb_id.c index ab0d96e..b42b32e 100644 --- a/src/udev/udev-builtin-usb_id.c

[systemd-devel] [PATCH] fix compiler warning

2015-03-10 Thread Shawn Landden
warning: pointer/integer type mismatch in conditional expression --- src/shared/socket-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/socket-util.c b/src/shared/socket-util.c index 5820279..73e1177 100644 --- a/src/shared/socket-util.c +++

[systemd-devel] [PATCH] fix strict aliasing issues in src/udev/udev-ctrl.c

2015-03-10 Thread Shawn Landden
it is ironic that The only purpose of this structure is to cast the structure pointer passed in addr in order to avoid compiler warnings. See EXAMPLE below. from bind(2) --- src/udev/udev-ctrl.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git

Re: [systemd-devel] [PATCH] add REMOTE_ADDR and REMOTE_PORT for Accept=yes

2015-03-09 Thread Shawn Landden
On Mon, Mar 9, 2015 at 1:18 PM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 09.03.15 13:09, Shawn Landden (sh...@churchofgit.com) wrote: +if (UNIT_DEREF(s-accept_socket)) { +union sockaddr_union sa; +socklen_t salen = sizeof(sa

[systemd-devel] [PATCH] add REMOTE_ADDR and REMOTE_PORT for Accept=yes

2015-03-09 Thread Shawn Landden
--- TODO | 2 - man/systemd.socket.xml | 6 ++- src/core/service.c | 39 +++- src/libsystemd/sd-resolve/test-resolve.c | 2 +- src/shared/socket-util.c | 76 +++-

Re: [systemd-devel] [PATCH] add REMOTE_ADDR and REMOTE_PORT for Accept=yes

2015-03-09 Thread Shawn Landden
On Mon, Mar 9, 2015 at 1:18 PM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 09.03.15 13:09, Shawn Landden (sh...@churchofgit.com) wrote: +if (UNIT_DEREF(s-accept_socket)) { +union sockaddr_union sa; +socklen_t salen = sizeof(sa

[systemd-devel] [PATCH] add REMOTE_ADDR and REMOTE_PORT for Accept=yes

2015-03-09 Thread Shawn Landden
--- TODO | 2 - man/systemd.socket.xml | 6 ++- src/core/service.c | 35 +- src/libsystemd/sd-resolve/test-resolve.c | 2 +- src/shared/socket-util.c | 80 ++--

Re: [systemd-devel] [PATCH] add REMOTE_ADDR and REMOTE_PORT for Accept=yes

2015-03-09 Thread Shawn Landden
On Mon, Mar 9, 2015 at 9:22 AM, Lennart Poettering lenn...@poettering.net wrote: On Sun, 08.03.15 16:24, Shawn Landden (sh...@churchofgit.com) wrote: varlistentry diff --git a/src/core/service.c b/src/core/service.c index cc4ea19..6a690ac 100644 --- a/src/core/service.c +++ b

[systemd-devel] [PATCH] add REMOTE_ADDR and REMOTE_PORT for Accept=yes

2015-03-08 Thread Shawn Landden
--- TODO | 2 -- man/systemd.socket.xml | 6 +- src/core/service.c | 47 +++ 3 files changed, 52 insertions(+), 3 deletions(-) diff --git a/TODO b/TODO index ae32388..780084a 100644 --- a/TODO +++ b/TODO @@ -164,8 +164,6 @@

[systemd-devel] [PATCH] adjust for time spent in timedated even without dbus timestamp

2015-03-07 Thread Shawn Landden
it is trivial to fall back to our own timestamp v2: use now() v3: remove useless if () --- src/timedate/timedated.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/timedate/timedated.c b/src/timedate/timedated.c index 88d57e9..b8c586c 100644 ---

[systemd-devel] [PATCH] adjust for time spent in timedated even without dbus timestamp

2015-03-07 Thread Shawn Landden
it is trivial to fall back to our own timestamp v2: use now() v3: remove useless if () v4: add comment --- src/timedate/timedated.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/timedate/timedated.c b/src/timedate/timedated.c index 88d57e9..97b535f 100644 ---

[systemd-devel] [PATCH] adjust for time spent in timedated even without dbus timestamp

2015-03-06 Thread Shawn Landden
it is trivial to fall back to our own timestamp v2: use now() --- src/timedate/timedated.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/timedate/timedated.c b/src/timedate/timedated.c index 88d57e9..75b1f1b 100644 --- a/src/timedate/timedated.c +++

[systemd-devel] [PATCH] adjust for time spent in timedated even without dbus timestamp

2015-03-06 Thread Shawn Landden
it is trivial to fall back to our own timestamp --- src/timedate/timedated.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/timedate/timedated.c b/src/timedate/timedated.c index 88d57e9..7e47348 100644 --- a/src/timedate/timedated.c +++ b/src/timedate/timedated.c

Re: [systemd-devel] [PATCH] core/socket: Add REMOTE_IP environment variable for Accept=true

2015-03-06 Thread Shawn Landden
On Thu, Mar 5, 2015 at 3:18 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 04.03.15 15:18, Shawn Landden (sh...@churchofgit.com) wrote: Can't this just use getpeername_pretty()? Then I can't force it to only ipv4 and ipv6. Lennart -- Lennart Poettering, Red Hat

[systemd-devel] [PATCH] core/socket: Add REMOTE_IP environment variable for Accept=true

2015-03-04 Thread Shawn Landden
Fix handling of abstract unix domain sockets too. v2 --- TODO | 2 -- man/systemd.socket.xml | 5 - src/core/service.c | 24 src/shared/socket-util.c | 25 +++-- 4 files changed, 47 insertions(+), 9 deletions(-) diff

Re: [systemd-devel] [PATCH] fix strict aliasing violations in src/udev/udev-builtin-usb_id.c

2015-03-04 Thread Shawn Landden
On Wed, Mar 4, 2015 at 7:58 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 03, 2015 at 04:21:30PM -0800, Shawn Landden wrote: also switch to inttypes.h --- src/udev/udev-builtin-usb_id.c | 35 ++- 1 file changed, 18 insertions

[systemd-devel] [PATCH] core/socket: Add REMOTE_IP environment variable for Accept=true

2015-03-04 Thread Shawn Landden
Fix handling of abstract unix domain sockets too. --- TODO | 2 -- man/systemd.socket.xml | 5 - src/core/service.c | 24 src/shared/socket-util.c | 25 +++-- 4 files changed, 47 insertions(+), 9 deletions(-) diff

Re: [systemd-devel] [PATCH] fix strict aliasing violations in src/udev/udev-builtin-usb_id.c

2015-03-04 Thread Shawn Landden
Oh wait, I c, yes I had same question. On Wed, Mar 4, 2015 at 8:07 PM, Shawn Landden sh...@churchofgit.com wrote: On Wed, Mar 4, 2015 at 7:58 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Mar 03, 2015 at 04:21:30PM -0800, Shawn Landden wrote: also switch to inttypes.h

[systemd-devel] [PATCH] fix strict aliasing violations in src/udev/udev-builtin-usb_id.c

2015-03-03 Thread Shawn Landden
also switch to inttypes.h --- src/udev/udev-builtin-usb_id.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/src/udev/udev-builtin-usb_id.c b/src/udev/udev-builtin-usb_id.c index ab0d96e..0223421 100644 --- a/src/udev/udev-builtin-usb_id.c

Re: [systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-27 Thread Shawn Landden
. This also eliminates one directory. All of these are handled by units: sleep.target shutdown.target etc... On Fri, Feb 20, 2015 at 02:31:00PM -0800, Shawn Landden wrote: --- Makefile.am | 6 +- src/core/shutdown.c | 420 - src

Re: [systemd-devel] [v1] shutdown: add kexec loading, ?avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
On Thu, Feb 26, 2015 at 6:22 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Feb 26, 2015 at 08:04:08AM +, Jan Janssen wrote: Shawn Landden shawn at churchofgit.com writes: void strv_free(char **l) { -strv_clear(l); +char **k

Re: [systemd-devel] [v1] shutdown: add kexec loading, ?avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
On Fri, Feb 27, 2015 at 9:03 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: We need two operations: sorting kernels to list them, and picking (I On Fri, Feb 27, 2015 at 08:58:04AM -0800, Shawn Landden wrote: On Thu, Feb 26, 2015 at 6:22 PM, Zbigniew Jędrzejewski-Szmek zbys

[systemd-devel] sd_id128_equal borked

2015-02-27 Thread Shawn Landden
_sd_pure_ static inline int sd_id128_equal(sd_id128_t a, sd_id128_t b) { return memcmp(a, b, 16) == 0; } this should either be return memcmp(a, b, 16); or return bool -- --- Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd

Re: [systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-27 Thread Shawn Landden
On Thu, Feb 26, 2015 at 12:04 AM, Jan Janssen medhe...@web.de wrote: Shawn Landden shawn at churchofgit.com writes: void strv_free(char **l) { -strv_clear(l); +char **k; + +if (!l) +return; + +for (k = l; *k; k

[systemd-devel] [v3 1/4] man: these binaries are internal APIs

2015-02-27 Thread Shawn Landden
--- man/systemd-halt.service.xml | 1 - man/systemd-shutdownd.service.xml | 1 - man/systemd-suspend.service.xml | 1 - 3 files changed, 3 deletions(-) diff --git a/man/systemd-halt.service.xml b/man/systemd-halt.service.xml index c94e2a1..7e7f8f2 100644 --- a/man/systemd-halt.service.xml

Re: [systemd-devel] feature request: dlopen

2015-02-22 Thread Shawn Landden
mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- --- Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [systemd-devel] A use case for staged startup

2015-02-21 Thread Shawn Landden
-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel -- --- Shawn Landden ChurchOfGit.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org

[systemd-devel] [PATCH 3/8] power: refactor the three power management binaries to src/power

2015-02-20 Thread Shawn Landden
--- Makefile.am | 6 +- src/core/shutdown.c | 420 - src/power/Makefile| 28 +++ src/power/shutdown.c | 420 + src/power/shutdownd.c | 461

[systemd-devel] [PATCH 6/8] add rbtree implamentation

2015-02-20 Thread Shawn Landden
from https://github.com/fbuihuu/libtree (LGPLv2.1+) --- Makefile.am | 2 + src/shared/rbtree.c | 482 src/shared/rbtree.h | 79 + 3 files changed, 563 insertions(+) create mode 100644 src/shared/rbtree.c create mode 100644

[systemd-devel] [PATCH 8/8] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-20 Thread Shawn Landden
: nil -*-*/ + +/*** + This file is part of systemd. + + Copyright 2015 Shawn Landden + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software Foundation; either version 2.1 of the License

[systemd-devel] [PATCH 4/8] update TODO

2015-02-20 Thread Shawn Landden
--- TODO | 2 ++ 1 file changed, 2 insertions(+) diff --git a/TODO b/TODO index 52a32d3..bf66ba1 100644 --- a/TODO +++ b/TODO @@ -32,6 +32,8 @@ External: * When lz4 gets an API for lz4 command output, make use of it to compress coredumps in a way compatible with /usr/bin/lz4. +* Fix emacs

[systemd-devel] [PATCH 7/8] add rpmvercmp()

2015-02-20 Thread Shawn Landden
--- Makefile.am| 2 + src/shared/rpmvercmp.c | 122 + src/shared/rpmvercmp.h | 14 ++ 3 files changed, 138 insertions(+) create mode 100644 src/shared/rpmvercmp.c create mode 100644 src/shared/rpmvercmp.h diff --git

[systemd-devel] [PATCH 1/8] man: these binaries are internal APIs

2015-02-20 Thread Shawn Landden
--- man/systemd-halt.service.xml | 1 - man/systemd-shutdownd.service.xml | 1 - man/systemd-suspend.service.xml | 1 - 3 files changed, 3 deletions(-) diff --git a/man/systemd-halt.service.xml b/man/systemd-halt.service.xml index c94e2a1..7e7f8f2 100644 --- a/man/systemd-halt.service.xml

[systemd-devel] [PATCH 2/8] man/systemd.timer.xml: improve documentation of WakeSystem=

2015-02-20 Thread Shawn Landden
--- man/systemd.timer.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/man/systemd.timer.xml b/man/systemd.timer.xml index 20890f2..4207be0 100644 --- a/man/systemd.timer.xml +++ b/man/systemd.timer.xml @@ -230,8 +230,9 @@ be suspended and if the system

[systemd-devel] [PATCH 5/8] power: these binaries are internal APIs

2015-02-20 Thread Shawn Landden
They are not executed by a user (they all check how they were executed) so we can use assert() in main() just like we would anywhere else. --- src/power/shutdown.c | 20 ++-- src/power/shutdownd.c | 22 -- src/power/sleep.c | 14 +++--- 3 files

[systemd-devel] [v1] shutdown: add kexec loading, avoid calling `kexec` binary unnessecarily

2015-02-20 Thread Shawn Landden
: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ + +/*** + This file is part of systemd. + + Copyright 2015 Shawn Landden + + systemd is free software; you can redistribute it and/or modify it + under the terms of the GNU Lesser General Public License as published by + the Free Software

[systemd-devel] [PATCH] fix build against v3.20-rc1

2015-02-18 Thread Shawn Landden
--- fs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs.c b/fs.c index 22ca62b..f751392 100644 --- a/fs.c +++ b/fs.c @@ -208,7 +208,6 @@ static struct inode *fs_inode_get(struct super_block *sb, inode-i_private = kdbus_node_ref(node); inode-i_mapping-a_ops = empty_aops; -

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-17 Thread Shawn Landden
, Feb 16, 2015 at 07:53:47PM -0800, Shawn Landden wrote: On Mon, Feb 16, 2015 at 5:08 AM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 13.02.15 14:18, Shawn Landden (sh...@churchofgit.com) wrote: Still use helper when Xen Dom0, to avoid duplicating some hairy code

Re: [systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-17 Thread Shawn Landden
On Tue, Feb 17, 2015 at 7:00 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Mon, Feb 16, 2015 at 07:53:47PM -0800, Shawn Landden wrote: On Mon, Feb 16, 2015 at 5:08 AM, Lennart Poettering lenn...@poettering.net wrote: On Fri, 13.02.15 14:18, Shawn Landden (sh

  1   2   3   >