[systemd-devel] [PATCH] STACK (http://css.csail.mit.edu/stack/) found issues for unstable optimized code again.

2014-02-07 Thread Stefan Beller
The first problem arises in src/gudev/gudevdevice.c In lines 688 and 882 we call the function split_at_whitespace, which is just a wrapper around g_strsplit_set, but removes also the empty strings. Now in this wrapper function we have a 'gchar **result;' on which we'll operate. In line 638 we

Re: [systemd-devel] [PATCH] Fix a typo

2014-02-03 Thread Stefan Beller
On 03.02.2014 05:55, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Feb 02, 2014 at 11:03:06PM +0100, Stefan Beller wrote: --- src/libsystemd/sd-bus/PORTING-DBUS1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd/sd-bus/PORTING-DBUS1 b/src/libsystemd/sd-bus

[systemd-devel] [PATCH] Fix a typo

2014-02-02 Thread Stefan Beller
--- src/libsystemd/sd-bus/PORTING-DBUS1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd/sd-bus/PORTING-DBUS1 b/src/libsystemd/sd-bus/PORTING-DBUS1 index 90d184b7..750033f 100644 --- a/src/libsystemd/sd-bus/PORTING-DBUS1 +++ b/src/libsystemd/sd-bus/PORTING-DBUS1

[systemd-devel] [PATCH 2/2] Update .mailmap file

2014-01-03 Thread Stefan Beller
This commit updates email addresses of people, who are already in the .mailmap file, so I'd assume they have sorted out their viewpoint on privacy within the .mailmap file. The entries for this commit have been produced using: # Finding out duplicates by comparing email addresses:

[systemd-devel] [PATCH 1/2] swap: remove if/else with the same data path

2014-01-03 Thread Stefan Beller
This was introduced in e1770af812 (2012-02-03, swap: replace failure boolean by result enum). This just removes unneeded lines of code, no functional change. --- src/core/swap.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/core/swap.c b/src/core/swap.c index

[systemd-devel] [PATCH] boot-efi: Remove superfluous assignment

2013-12-30 Thread Stefan Beller
2 lines after the changed line we assign err to efi_get_variable(...) unconditionally, so it makes no sense to initialize it to some value. --- src/boot/boot-efi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/boot/boot-efi.c b/src/boot/boot-efi.c index 33840b6..1c80126

[systemd-devel] [PATCH] swap: remove if/else with the same data path

2013-12-30 Thread Stefan Beller
This was introduced in e1770af812 (2012-02-03, swap: replace failure boolean by result enum). It doesn't do any harm as it most likely will get optimized away anyway, but maybe for readability? --- src/core/swap.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git