Re: [systemd-devel] Udev rules hardware database

2014-11-05 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Nov 05, 2014 at 04:55:52PM +0100, Patrick Häcker wrote: > - If not, is udev the correct piece in the Linux stack to put this? Most likely the kernel should do this by itself. What where the devices that you had to disable power saving on? > - What is the general way to contribute udev rul

Re: [systemd-devel] systemd-machined sigterm, cgroups trimmed

2014-11-05 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Nov 04, 2014 at 08:38:51AM -0600, Major Hayden wrote: > Hello there, > > I'm currently running systemd 216 on Fedora 21 and I've found an issue where > systemd-machined stops running and cgroups are trimmed from the scope of > running qemu virtual machines. The series of events looks li

Re: [systemd-devel] statelessy system

2014-11-03 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 03, 2014 at 12:24:42PM +0100, Lennart Poettering wrote: > Would be happy to take a patch that makes those cases check for a > config file in /usr/lib as fallback though, to cover all bases. Didn't we have a patch to support .d directories floated on the ml? Can't seem to find it at the

Re: [systemd-devel] [PATCH 2/5] libsystemd:terminal :fix uninitialized warning

2014-11-03 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 03, 2014 at 01:41:20PM +0100, Lennart Poettering wrote: > On Mon, 03.11.14 13:12, David Herrmann (dh.herrm...@gmail.com) wrote: > > > Hi > > > > On Thu, Oct 16, 2014 at 11:43 PM, wrote: > > > From: Philippe De Swert > > > > > > Remove the following warning during the compilation: >

Re: [systemd-devel] [PATCH] manager: Ensure user's systemd runtime directory exists.

2014-11-02 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Nov 02, 2014 at 02:04:20PM +, Colin Guthrie wrote: > This mirrors code in dbus.c when creating the private socket and > avoids error messages like: > > systemd[1353]: bind(/run/user/603/systemd/notify) failed: No such file or > directory > systemd[1353]: Failed to fully start up daemo

Re: [systemd-devel] [PATCH 1/5] calendar: semesterly alias for semi-annually

2014-11-02 Thread Zbigniew Jędrzejewski-Szmek
Are easy/needed changes. > > 2014-11-01 20:27 GMT+01:00 Zbigniew Jędrzejewski-Szmek : > > > On Thu, Oct 30, 2014 at 12:19:11PM +0100, Daniele Medri wrote: > > > --- > > > man/systemd.time.xml | 4 ++-- > > > src/shared/calendarspec.c| 3

[systemd-devel] [PATCH] unit: do not order timers.target before basic.target

2014-11-02 Thread Zbigniew Jędrzejewski-Szmek
Since commit 19f8d037833f2 'timer: order OnCalendar units after timer-sync.target if DefaultDependencies=no' timers might get a dependency on time-sync.target, which does not really belong in early boot. If ntp is enabled, time-sync.target might be delayed until a network connection is established.

Re: [systemd-devel] [PATCH] scsi_id: fix usage spelling

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Nov 01, 2014 at 12:18:08PM -0400, Joe Lawrence wrote: > s/threat/treat/g Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] kernel-install/90-loaderentry.install: fix cmdline parsing

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 11:54:07AM +1100, Michael Chapman wrote: > A recent commit (2f3a215) changed the parsing of /proc/cmdline to use a > shell array. Unfortunately, this introduced a bug: "read -ar line" > populates the shell variable $r, not $line. This breaks installation of > new loader entr

Re: [systemd-devel] [PATCH] bus: use STR_IN_SET

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 30, 2014 at 03:45:15PM +0900, WaLyong Cho wrote: > --- > src/core/dbus-unit.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.

Re: [systemd-devel] [PATCH] man: explain journalctl --flush correctly

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 11:20:02AM +0100, Umut Tezduyar Lindskog wrote: > --- > NEWS | 4 > man/journalctl.xml | 4 ++-- > 2 files changed, 6 insertions(+), 2 deletions(-) Applied. Zbyszek ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH v3] core: improve error message when machine id is missing

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 31, 2014 at 10:16:45AM +0100, Jan Synacek wrote: > --- > Changes in v3: > - check correct errno > Changes in v2: > - show long explanation only when errno == EROFS > > src/core/machine-id-setup.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/

Re: [systemd-devel] [PATCH] sd-dhcp6-client: fix off-by-two error in DUID length

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 31, 2014 at 12:20:21PM -0500, Dan Williams wrote: > The duid data passed by the caller does not include the DUID type, > but sd_dhcp6_client_set_duid() was treating it like it did. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] [PATCH 4/5] constant for weekdays_bits

2014-11-01 Thread Zbigniew Jędrzejewski-Szmek
Applied this one. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] statelessy system

2014-10-31 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 31, 2014 at 02:06:37PM +0100, Łukasz Stelmach wrote: > My question: is v217 ready to run without /etc/systemd/*.conf and read > them from /usr/lib/systemd wher I (vendor) can put properly tailored files? Hi Łukasz, if you look into those files, you'll see that they contain only comment

Re: [systemd-devel] [PATCH] shared/install: avoid prematurely rejecting "missing" units

2014-10-30 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 30, 2014 at 08:28:14PM -0400, Dave Reisner wrote: > f7101b7368df copied some logic to prevent enabling masked units, but > also added a check which causes attempts to enable templated units to > fail. Since we know the logic beyond this check will properly handle > units which truly do

Re: [systemd-devel] remote-fs ordering, iSCSI and _netdev

2014-10-30 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 30, 2014 at 03:09:25PM -0700, Chris Leech wrote: > On Tue, Oct 28, 2014 at 01:57:06AM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > On Mon, Oct 27, 2014 at 02:10:47PM -0700, Chris Leech wrote: > > > ... > > > If there's no matching mount unit from f

Re: [systemd-devel] [PATCH v3] Bootchart: use /proc/pid/mountinfo for root bdev

2014-10-30 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 30, 2014 at 05:45:53PM +0300, Timofey Titovets wrote: > Good time of day, list. > I have try to fix "Fixme" in svg.c: > /* FIXME: this works only in the simple case */ > > By default function try to get only root=/dev/* > I also attach patch. Thanks. > > v2: > Rewrited with use

Re: [systemd-devel] [PATCH] sysusers: Preserve ownership and mode on /etc/passwd and friends

2014-10-30 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 05:27:28PM +, Colin Guthrie wrote: > FWIW, I tested this now and it seems to have worked fine and properly > preserved both mode and ownership of the files in question. > > OK to push this one? Yeah, looks reasonable. Zbyszek > Colin Guthrie wrote on 29/10/14 14:34: >

Re: [systemd-devel] [PATCH v2] Bootchart: allow parse LABEL, UUID, PARTUUID for svg info

2014-10-29 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 09:09:03PM +0300, Timofey Titovets wrote: > 2014-10-29 16:20 GMT+03:00 Zbigniew Jędrzejewski-Szmek : > > On Wed, Oct 29, 2014 at 04:16:22PM +0300, Timofey Titovets wrote: > >> Why then developers use cmdline before? > >> Maybe cmdline allow de

Re: [systemd-devel] systemd and power management

2014-10-29 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 01:00:42PM -0400, Daniel Hollocher wrote: > Hey folks, > I'm a not expert here, so please forgive the low quality/interest of my > question. > > I'm curious what the ideal systemd way is to set various power management > settings in the /sys tree. For me personally, I'm lo

Re: [systemd-devel] [PATCH v2] Bootchart: allow parse LABEL, UUID, PARTUUID for svg info

2014-10-29 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 04:16:22PM +0300, Timofey Titovets wrote: > Why then developers use cmdline before? > Maybe cmdline allow determine disk when bootchart working from or in initrd? bootchart was merged into systemd after being developed in separate and often does not follow the same conventio

Re: [systemd-devel] systemctl show environment quoting

2014-10-29 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 09:40:19AM +0100, Alexandre Detiste wrote: > Hi, > > I stumbled on this: > > $ systemctl cat cron-crontab-pi-0 | grep Environment > Environment="A=a a" "MAILTO=system-c...@mailinator.com" "B=b b" "C=c c" > $ systemctl show cron-crontab-pi-0 -p Environment > Environment=A=a

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-28 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 28, 2014 at 05:16:38PM +0100, Jan Alexander Steffens wrote: > On Oct 28, 2014 5:05 PM, "Lennart Poettering" > wrote: > > On Tue, 28.10.14 11:28, Dale R. Worley (wor...@alum.mit.edu) wrote: > > > That is not entirely true. I'm a user (because systemd is in Fedora > > > 19), and I've co

Re: [systemd-devel] [PATCH] manager: do not print anything while passwords are being queried

2014-10-28 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 27, 2014 at 06:37:21PM +0100, Lennart Poettering wrote: > On Sun, 26.10.14 05:37, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > https://bugs.freedesktop.org/show_bug.cgi?id=73942 > > So in really old systemd versions I had a concept in place of never

Re: [systemd-devel] [PATCH 3/4] manager: stop start timeout when sysinit.target is reached

2014-10-28 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 28, 2014 at 10:50:05AM +0100, Lennart Poettering wrote: > On Tue, 28.10.14 03:52, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > On Tue, Oct 28, 2014 at 02:32:37AM +0100, Lennart Poettering wrote: > > > On Mon, 27.10.14 23:07, Lennart Poettering (l

Re: [systemd-devel] [PATCH v2] Bootchart: allow parse LABEL, UUID, PARTUUID for svg info

2014-10-28 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 28, 2014 at 07:56:32AM +0300, Timofey Titovets wrote: > Good time of day, list. > I try to fix "Fixme" in svg.c: > /* FIXME: this works only in the simple case */ > > By default function try to get only root=/dev/* > > I also attach patch. Thanks. > > v2: > Rewrited with use fs

Re: [systemd-devel] [PATCH 3/4] manager: stop start timeout when sysinit.target is reached

2014-10-27 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 28, 2014 at 02:32:37AM +0100, Lennart Poettering wrote: > On Mon, 27.10.14 23:07, Lennart Poettering (lenn...@poettering.net) wrote: > > > On Mon, 27.10.14 20:03, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > > On Mon, Oct 27,

Re: [systemd-devel] remote-fs ordering, iSCSI and _netdev

2014-10-27 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 27, 2014 at 02:10:47PM -0700, Chris Leech wrote: > Hi, I was hoping someone could help me make sure I'm not overlooking > something with trying to manage mounts on iSCSI disks. > > I have an iscsi.service which starts and stops sessions to iSCSI > targets. It's set with Before=remote-

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-27 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 27, 2014 at 06:25:56PM -0400, Dale R. Worley wrote: > > From: "Lennart Poettering" > > > > Please, let's discuss this elsewhere. Let's keep a strict technical > > focus on this ML! > > I believe that you mean that outsiders are welcome here to provide > assistance to systemd as it ha

Re: [systemd-devel] [PATCH 1/4] manager: print a warning after 2/3 of the start timeout

2014-10-27 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 27, 2014 at 06:49:22PM +0100, Lennart Poettering wrote: > > +log_info("Active jobs (%u running):\n\t%s.", > > m->n_running_jobs, all); > > +} else > > +log_info("No jobs seem to be running."); > > + > > +return 0; > > +} > > A long-stand

Re: [systemd-devel] [PATCH 3/4] manager: stop start timeout when sysinit.target is reached

2014-10-27 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 27, 2014 at 06:51:08PM +0100, Lennart Poettering wrote: > On Sat, 25.10.14 21:43, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > > +if (result == JOB_DONE && unit_has_name(u, SPECIAL_SYSINIT_TARGET)) > > +

Re: [systemd-devel] systemctl preset for user units (and how presets are applied after factory reset)

2014-10-27 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 27, 2014 at 02:16:38PM +, Colin Guthrie wrote: > > Zbigniew Jędrzejewski-Szmek wrote on 27/10/14 13:52: > >> [As a side note, if this is the recommended approach, then we should > >> probably add appropriate RPM macros to macros.systemd for user unit &

Re: [systemd-devel] systemctl preset for user units (and how presets are applied after factory reset)

2014-10-27 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 27, 2014 at 10:42:56AM +, Colin Guthrie wrote: > So that led me to ask myself: does systemctl preset support user units? > The man page doesn't make it clear that e.g. the --global switch applies > to preset as well as enable, but in testing it (happily) appears to > work! So I'm go

Re: [systemd-devel] string constants vs. #defines [was: Re: [PATCH v4] udev hwdb: Support shipping pre-compiled database in system images]

2014-10-26 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Oct 26, 2014 at 07:51:13AM -0400, Martin Pitt wrote: > Hello all, > > Zbigniew Jędrzejewski-Szmek [2014-10-25 21:51 +0200]: > > Looks fine and push-worthy. Two minor nitpicks below, feel free > > to fix up before pushing or ignore as you see fit. > > Michael ra

[systemd-devel] [PATCH] manager: do not print anything while passwords are being queried

2014-10-25 Thread Zbigniew Jędrzejewski-Szmek
https://bugs.freedesktop.org/show_bug.cgi?id=73942 --- src/core/manager.c | 105 - src/core/manager.h | 5 +++ 2 files changed, 109 insertions(+), 1 deletion(-) diff --git a/src/core/manager.c b/src/core/manager.c index b0d73c1068..1069a527c6

Re: [systemd-devel] [PATCH v4] udev hwdb: Support shipping pre-compiled database in system images

2014-10-25 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 24, 2014 at 04:24:46PM -0400, Martin Pitt wrote: > The updated patch fixes both now. Looks fine and push-worthy. Two minor nitpicks below, feel free to fix up before pushing or ignore as you see fit. > From 1624d949c60a911f7bf578d0141c8cd0d98c54e9 Mon Sep 17 00:00:00 2001 > From: Marti

[systemd-devel] [PATCH 4/4] Update TODO

2014-10-25 Thread Zbigniew Jędrzejewski-Szmek
--- TODO | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index ed0066122e..74aad34828 100644 --- a/TODO +++ b/TODO @@ -2,8 +2,6 @@ Fixes needed before 217: * sd_session_get_desktop() yells at me? -* change startup timeout to not cover the full bootup, but o

[systemd-devel] [PATCH 2/4] manager: also show the warning on the console

2014-10-25 Thread Zbigniew Jędrzejewski-Szmek
--- src/core/manager.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index 7917afdbb1..770a6b55e2 100644 --- a/src/core/manager.c +++ b/src/core/manager.c @@ -111,11 +111,17 @@ static int manager_log_running_jo

[systemd-devel] [PATCH 3/4] manager: stop start timeout when sysinit.target is reached

2014-10-25 Thread Zbigniew Jędrzejewski-Szmek
--- This is pretty basic, sysinit.target is hardcoded, but it should fix the issue at hand, i.e. the system powering off when some long running job is started during boot. src/core/job.c | 3 +++ src/core/manager.c | 14 ++ src/core/manager.h | 1 + 3 files changed, 14 insertion

[systemd-devel] [PATCH 1/4] manager: print a warning after 2/3 of the start timeout

2014-10-25 Thread Zbigniew Jędrzejewski-Szmek
--- This could use some more polishing, but is useful as is I think... src/core/manager.c | 67 -- src/core/manager.h | 1 + 2 files changed, 66 insertions(+), 2 deletions(-) diff --git a/src/core/manager.c b/src/core/manager.c index b790d18bb

Re: [systemd-devel] Waiting for nspawn services

2014-10-25 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Oct 25, 2014 at 05:39:51AM -0400, Rich Freeman wrote: > One of the useful options in nspawn is the ability to boot the init > within the container using -b, especially if that init happens to be > systemd. > > However, I could not find any easy way to set a dependency on a > service within

Re: [systemd-devel] Problem with modprobe in lm_sensors.service

2014-10-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 06, 2014 at 02:41:29PM -0400, Dale R. Worley wrote: > I am running Fedora 16 with kernel 3.14.19-100.fc19.x86_64 and > systemd-204-21.fc19.x86_64. That's ... old. > [Unit] > Description=Initialize hardware monitoring sensors > After=syslog.target > > [Service] > En

Re: [systemd-devel] [PATCH 1/2] selinux: fix potential double free crash in child process

2014-10-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 13, 2014 at 04:57:12PM +0200, Michal Sekletar wrote: > Before returning from function we should reset ret to NULL, thus cleanup > function is nop. > > Also context_str() returns pointer to a string containing context but not a > copy, hence we must make copy it explicitly. > --- > src

Re: [systemd-devel] [PATCH, REVIEW] Added unit enabled-context cache to improve performance w/ many units.

2014-10-24 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 11:08:13PM -0700, Ken Sedgwick wrote: > Resubmitting using git format-patch, git imap-send ... no code changes. Hi, thank you for working on systemd, it is appreciated. Nevertheless, this patch is hard to apply for a couple of reasons. First, it does not apply: it is line

Re: [systemd-devel] booting A/B rootfs

2014-10-24 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 09, 2014 at 06:13:01AM +0200, Darko Luketic wrote: > Hi, > > I have limited knowledge of the boot process. > I'm wondering if the following is possible with systemd. > > Imagine you have 2 rootfs partitions. > You build a new rootfs on a security update or when a new version of a > li

Re: [systemd-devel] [PATCH v3] udev hwdb: Support shipping pre-compiled database in system images

2014-10-24 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 24, 2014 at 11:52:39AM -0400, Martin Pitt wrote: > Hello all, > > thanks Lennart for the detailled review! Took me a while to respond as > I'm on a company sprint this week. I think I addressed all your > points, plus fixing the unit condition. open_hwdb_bin() isn't the > prettiest thi

Re: [systemd-devel] [PATCH v2] journalctl: Unify boot id lookup into common function get_boots

2014-10-24 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 07:37:29PM +0200, Jan Janssen wrote: > --- > Changes in v2: > - Properly initialize count to zero Thanks, applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/l

Re: [systemd-devel] [systemd-commits] 2 commits - man/pam_systemd.xml src/shared

2014-10-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 04:15:59PM -0700, Lennart Poettering wrote: > man: in pam_systemd, it must be "his" (or "her"), not their Why? "Their" is gramatically correct, and sidesteps specyfing the gender. http://english.stackexchange.com/questions/192/is-it-correct-to-use-their-instead-of-his-

Re: [systemd-devel] [PATCH] Add timesync-wait tool

2014-10-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 09:24:06PM +0200, Łukasz Stelmach wrote: > --- > src/timesync/timesync-wait.c | 43 +++ > 1 file changed, 43 insertions(+) > create mode 100644 src/timesync/timesync-wait.c > > I am afraid TFD_TIMER_CANCEL_ON_SET doesn't help much h

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 04:59:45PM +0200, Lennart Poettering wrote: > On Thu, 23.10.14 17:52, Mantas Mikulėnas (graw...@gmail.com) wrote: > > > On Oct 23, 2014 5:48 PM, "Lennart Poettering" > > wrote: > > > > > > On Thu, 23.10.14 16:06, Damien Robert (damien.olivier.rob...@gmail.com) > > wrote: >

Re: [systemd-devel] Fwd: [PATCH v3] tests: added tests for unit_file_get_{state, list}

2014-10-23 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 02:22:01PM +0200, Lennart Poettering wrote: > On Fri, 17.10.14 14:02, Martin Pitt (martin.p...@ubuntu.com) wrote: > > > > diff --git a/Makefile.am b/Makefile.am > > > index e52db17..7d4f2f5 100644 > > > --- a/Makefile.am > > > +++ b/Makefile.am > > > @@ -1358,7 +1358,8 @@ t

Re: [systemd-devel] [PATCH] journalctl: Unify boot id lookup into common function get_boots

2014-10-22 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 10, 2014 at 01:21:10PM +0200, Jan Janssen wrote: > --- > src/journal/journalctl.c | 133 > +-- > 1 file changed, 58 insertions(+), 75 deletions(-) > > diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c > index 328e40b..550b610

Re: [systemd-devel] [Feature request] Retentiontime per unit configuration

2014-10-22 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 23, 2014 at 01:09:25AM +0200, Lennart Poettering wrote: > On Wed, 27.08.14 08:39, Kris Erik Schwerdt (schwe...@itsc.uni-luebeck.de) > wrote: > > > Hallo > > > > During a task of migration of multiple servers to a systemd-based > > distribution I was wondering if there would be a way

Re: [systemd-devel] Timers without matching units?

2014-10-22 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 22, 2014 at 02:50:13PM +0400, Ivan Shapovalov wrote: > Hi, > > The systemd.timer(5) manpage states: > > "For each timer file, a matching unit file must exist, describing the unit to > activate when the timer elapses." > > However, if I need the timer unit just to wake up the machine

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 22, 2014 at 02:42:13AM +0200, Ronny Chevalier wrote: > 2014-10-22 2:13 GMT+02:00 Ronny Chevalier : > > 2014-10-22 1:48 GMT+02:00 Zbigniew Jędrzejewski-Szmek : > >> On Sat, Oct 18, 2014 at 06:30:02PM +0200, Ronny Chevalier wrote: > >>> It helps editing unit

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-21 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Oct 18, 2014 at 06:30:02PM +0200, Ronny Chevalier wrote: > It helps editing units by either creating a drop-in file, like > /etc/systemd/system/my.service.d/amendments.conf, or by copying the > original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full > option is specified. Then i

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-10-21 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 22, 2014 at 12:29:15AM +0200, Ronny Chevalier wrote: > 2014-10-21 0:51 GMT+02:00 Lennart Poettering : > > On Sat, 18.10.14 18:30, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: > > > > Looks pretty good. A few comments. > > > >> + > >> +static int unit_file_copy_if_needed(const char

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-20 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 20, 2014 at 07:07:05PM +0200, Lennart Poettering wrote: > On Mon, 20.10.14 11:02, David Herrmann (dh.herrm...@gmail.com) wrote: > > > >> >> I want to rely on systemd --user to handle PulseAudio's activation > > >> >> (ditching the built in stuff) and but I'm worried that e.g. GNOME or

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-20 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 20, 2014 at 05:01:14PM +0400, Andrei Borzenkov wrote: > On Mon, Oct 20, 2014 at 4:47 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Mon, Oct 20, 2014 at 02:16:30PM +0400, Andrei Borzenkov wrote: > >> On Mon, Oct 20, 2014 at 1:02 PM, David Herrmann &

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-20 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 20, 2014 at 02:16:30PM +0400, Andrei Borzenkov wrote: > On Mon, Oct 20, 2014 at 1:02 PM, David Herrmann wrote: > > Btw., manager_check_finished() doesn't explicitly wait for > > default.target, but instead waits for all jobs to be done. Not sure > > why.. > > Because default.target ca

Re: [systemd-devel] Reusing systemd utils in a non-systemd application?

2014-10-20 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 20, 2014 at 07:19:42AM +, Chaiken, Alison wrote: > There are some very useful functions in systemd/src/shared that are tempting > to reuse in other, unrelated applications.My first attempt is like this: > > /usr/bin/gcc -g -Wall -Wextra -std=gnu99 -I../systemd/src/systemd > -

Re: [systemd-devel] How soon after login can I rely on systemd --user having reached sockets.target?

2014-10-19 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Oct 19, 2014 at 12:43:59PM +0200, Colin Guthrie wrote: > David Herrmann wrote on 19/10/14 12:05: > > Hi > > > > On Fri, Oct 17, 2014 at 6:14 PM, Colin Guthrie wrote: > >> Hi, > >> > >> How soon after login can I rely on systemd --user having reached > >> sockets.target? > >> > >> This fee

Re: [systemd-devel] [PATCH] shell-completion/bash: add add-wants and add-requires

2014-10-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 16, 2014 at 09:41:02AM +0200, Lukas Nykryn wrote: > --- > shell-completion/bash/systemctl.in | 12 > 1 file changed, 12 insertions(+) > > diff --git a/shell-completion/bash/systemctl.in > b/shell-completion/bash/systemctl.in > index afa80da..30ba668 100644 > --- a/shell-

Re: [systemd-devel] [PATCH v2] environment: append unit_id to error messages regarding EnvironmentFile

2014-10-17 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 17, 2014 at 11:46:01AM +0200, Lukas Nykryn wrote: > --- > > I have swapped parameters in test-fileio in previous version > src/core/execute.c | 6 +++--- > src/core/execute.h | 2 +- > src/shared/env-util.c | 7 --- > src/shared/env-util.h | 2 +- > src/test/test-fileio.

Re: [systemd-devel] [PATCH 4/5] shared:util : Remove shadow compile warning

2014-10-16 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 17, 2014 at 02:16:14AM +0300, Philippe De Swert wrote: > Hi, > > On 17/10/14 02:09, Zbigniew Jędrzejewski-Szmek wrote: > > On Fri, Oct 17, 2014 at 12:43:52AM +0300, philippedesw...@gmail.com wrote: > >> From: Philippe De Swert > >> > >>

Re: [systemd-devel] [PATCH 4/5] shared:util : Remove shadow compile warning

2014-10-16 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Oct 17, 2014 at 12:43:52AM +0300, philippedesw...@gmail.com wrote: > From: Philippe De Swert > > Removes the following compilation warning: > src/shared/util.c: In function 'rm_rf_children_dangerous': > src/shared/util.c:2800:22: warning: declaration of 'is_dir' shadows a global > declar

Re: [systemd-devel] [PATCH] sysctl.d: default to fq_codel, fight bufferbloat

2014-10-16 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 16, 2014 at 02:05:47PM +0200, Michal Schmidt wrote: > Quoting from Jon Corbet's report of Stephen Hemminger's talk at Linux > Plumbers Conference 2014 (https://lwn.net/Articles/616241/): > > [...] So Stephen encouraged everybody to run a command like: > > sysctl -w net.core.de

Re: [systemd-devel] [PATCH] logind: Support /etc/systemd/logind.conf.d/*.conf

2014-10-16 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 16, 2014 at 12:27:21PM +0200, Josh Triplett wrote: > This makes it possible to drop in configuration file snippets from a > package or other configuration management mechanism. What kind of settings would you install in this way? Zbyszek ___

Re: [systemd-devel] [PATCH 2/2] selinux: set selinux context applied on exec() before closing all fds

2014-10-13 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 13, 2014 at 04:57:13PM +0200, Michal Sekletar wrote: > We need original socket_fd around otherwise label_get_child_mls_label fails > with > -EINVAL return code. > --- > src/core/execute.c | 58 > -- > 1 file changed, 30 insertions(+

Re: [systemd-devel] Unicode support in console after boot

2014-10-13 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 13, 2014 at 03:13:50PM +0200, Jan Synacek wrote: > Andrei Borzenkov writes: > > On Mon, Oct 13, 2014 at 4:33 PM, Jan Synacek wrote: > >> Andrei Borzenkov writes: > >>> On Mon, Oct 13, 2014 at 12:48 PM, Jan Synacek wrote: > Mantas Mikulėnas writes: > > On Mon, Oct 13, 2014

Re: [systemd-devel] [systemd-commits] src/tmpfiles

2014-10-12 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Oct 12, 2014 at 06:42:36PM -0700, Dave Reisner wrote: > src/tmpfiles/tmpfiles.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > New commits: > commit e7aab5412829ed6b50d109f670bd0b1b365838a7 > Author: Dave Reisner > Date: Sat Oct 11 20:35:06 2014 -0400 > > tmpfiles:

Re: [systemd-devel] [PATCH] Set $NOTIFY_SOCKET for control procs if NotifyAccess=all

2014-10-12 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Oct 11, 2014 at 11:36:06PM +, Brandon L Black wrote: > --- > TODO | 2 -- > src/core/service.c | 11 +-- > 2 files changed, 1 insertion(+), 12 deletions(-) Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@

Re: [systemd-devel] [question] networkd: Any support for hooks?

2014-10-10 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 09, 2014 at 07:24:07AM +0200, Marcel Holtmann wrote: > For the wpa_supplicant, we are going to fix that one with a proper daemon > soon. Interesting. Can you shed some light on this? Zbyszek ___ systemd-devel mailing list systemd-devel@lists

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-10-09 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 09, 2014 at 07:01:11PM +0530, Susant Sahani wrote: > CID 1237543 (#1 of 1): Unchecked return value from library > (CHECKED_RETURN) > --- > src/socket-proxy/socket-proxyd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/socket-proxy/socket-proxyd.c > b/sr

Re: [systemd-devel] [PATCH] units: remove unnecessary ordering dependencies in systemd-hibernate-resume@.service

2014-10-09 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Aug 27, 2014 at 08:32:56PM +0400, Ivan Shapovalov wrote: > -Before=local-fs-pre.target systemd-remount-fs.service > systemd-fsck-root.service > +Before=local-fs-pre.target Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.free

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-09 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 08:58:53PM +0200, Jan Janssen wrote: > On 2014-10-08 14:59, Zbigniew Jędrzejewski-Szmek wrote: > >On Wed, Oct 08, 2014 at 08:24:49AM +0200, Jan Janssen wrote: > >> > >> > >>>Gesendet: Mittwoch, 08. Oktober 2014 um 01:40 Uhr > >

Re: [systemd-devel] [PATCH] clarify what microsoft and oracle stands for

2014-10-09 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 09, 2014 at 10:14:36PM -0400, Rahul Sundaram wrote: > --- > man/systemd-detect-virt.xml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/man/systemd-detect-virt.xml b/man/systemd-detect-virt.xml > index 1e8230c..4f9980a 100644 > --- a/man/systemd-detect-vir

Re: [systemd-devel] Cannot get Shutdown Script to Run (Libvirt Virtual Machine Shutdown)

2014-10-09 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 09, 2014 at 01:41:24AM +0200, Lennart Poettering wrote: > The ExecStart=/bin/true we just add because current systemd versions > refuse to run service units that have no ExecStart= set. It is on the > TODO list to allow services also when they have no ExecStart= but with > an ExecStop=,

Re: [systemd-devel] How to exclusively toggle between two systemd instances of a single daemon?

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Oct 09, 2014 at 07:51:32AM +0300, Mantas Mikulėnas wrote: > On Wed, Oct 8, 2014 at 4:39 PM, Zbigniew Jędrzejewski-Szmek < > zbys...@in.waw.pl> wrote: > > > On Wed, Oct 08, 2014 at 06:30:51AM -0700, terrygalant.li...@fastest.cc > > wrote: > > > Hi >

Re: [systemd-devel] [PATCH 1/2] sd-event: be more careful when enabling/disabling signals

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 09:44:33PM +0200, Lennart Poettering wrote: > On Sun, 05.10.14 20:42, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > > @@ -626,11 +634,13 @@ static void source_disconnect(sd_event_source *s) { > > > > case SOURCE_S

Re: [systemd-devel] [PATCH] core: don't allow enabling if unit is masked

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 11:23:51PM +0200, Lennart Poettering wrote: > On Wed, 08.10.14 23:07, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > > > > A related thing: there's a mapping bus-error <-> errno implemented, > > > > >

Re: [systemd-devel] [PATCH] core: don't allow enabling if unit is masked

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 09:28:39PM +0200, Lennart Poettering wrote: > On Wed, 08.10.14 17:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > > I think that the best way to handle this would be to > > > > use a temporary structure like >

Re: [systemd-devel] [PATCH] core: don't allow enabling if unit is masked

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 05:02:31PM +0200, Lennart Poettering wrote: > On Wed, 08.10.14 15:29, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > On Wed, Oct 08, 2014 at 11:54:19AM +0200, Lennart Poettering wrote: > > > On Tue, 07.10.14 13:35, Jan Synacek (jsyna

Re: [systemd-devel] systemd-detect-virt and vendors

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 10:42:21AM -0400, Rahul Sundaram wrote: > Hi > > On Wed, Oct 8, 2014 at 10:37 AM, Zbigniew Jędrzejewski-Szmek wrote: > > > This would break compatibility, because systemd-detect-virt would > > have to start returning different strings. > &

Re: [systemd-devel] systemd-detect-virt and vendors

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 10:35:25AM -0400, Rahul Sundaram wrote: > Hi > > On Wed, Oct 8, 2014 at 9:46 AM, Lennart Poettering > wrote: > > > > > I think what would make a lot of sense though is to add a section to > > the man page somewhere, that explains which ID refers to which > > software from

Re: [systemd-devel] How to exclusively toggle between two systemd instances of a single daemon?

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 06:45:48AM -0700, terrygalant.li...@fastest.cc wrote: > Hi Zbigniew > > On Wed, Oct 8, 2014, at 06:39 AM, Zbigniew Jędrzejewski-Szmek wrote: > > You can also make a symlink from /etc/systemd/system/xxx.service to > > either of the two files and manag

Re: [systemd-devel] How to exclusively toggle between two systemd instances of a single daemon?

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 06:30:51AM -0700, terrygalant.li...@fastest.cc wrote: > Hi > > I have 2 installed instances of a single daemon. > > 1 is from distro-installed packages, installed into standard default OS > locations with unit files in /usr/lib/systemd/system/. > > The other is installed

Re: [systemd-devel] [PATCH] core: don't allow enabling if unit is masked

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 11:54:19AM +0200, Lennart Poettering wrote: > On Tue, 07.10.14 13:35, Jan Synacek (jsyna...@redhat.com) wrote: > > > --- > > src/shared/install.c | 13 + > > 1 file changed, 13 insertions(+) > > > > diff --git a/src/shared/install.c b/src/shared/install.c > >

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 08:24:49AM +0200, Jan Janssen wrote: > > > > Gesendet: Mittwoch, 08. Oktober 2014 um 01:40 Uhr > > Von: "Zbigniew Jędrzejewski-Szmek" > > An: "Jan Janssen" > > Cc: systemd-devel@lists.freedesktop.org >

Re: [systemd-devel] [PATCH] man/systemctl: document enable on masked units

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 08:04:52AM +0200, Jan Synacek wrote: > --- > man/systemctl.xml | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/man/systemctl.xml b/man/systemctl.xml > index b28a3b7..d2fa3b3 100644 > --- a/man/systemctl.xml > +++ b/man/systemctl.xml > @@ -92

Re: [systemd-devel] [PATCH] note on relative symlink in os-release

2014-10-08 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 08, 2014 at 01:42:59AM -0400, Rahul Sundaram wrote: > --- > man/os-release.xml | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/man/os-release.xml b/man/os-release.xml > index 4e02f80..b298304 100644 > --- a/man/os-release.xml > +++ b/man/os-releas

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 06, 2014 at 06:57:38PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Oct 06, 2014 at 06:36:34PM +0200, Jan Janssen wrote: > > *bump* > Sorry, I'll look into this. Doesn't work. Both without or with your other patch sd_journal_enumerate_unique I get bogus r

Re: [systemd-devel] [PATCH v4] systemctl: add add-wants and add-requires verbs

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 05:46:48PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Oct 07, 2014 at 02:09:37PM +0200, Lukas Nykryn wrote: > > --- > > Changes in v4 > > - renamed install_dependency -> dependency > > - removed the enum with dependencies and used

Re: [systemd-devel] [PATCH] core: don't allow enabling if unit is masked

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 01:35:41PM +0200, Jan Synacek wrote: > --- > src/shared/install.c | 13 + > 1 file changed, 13 insertions(+) Applied. Making the error messages better is another step that needs to be done. Zbyszek ___ systemd-devel

Re: [systemd-devel] [PATCH] dbus-manager: don't allow enabling if unit is masked

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 08:23:32AM +0200, Jan Synacek wrote: > While I'm at it, what about disable? Should it behave in the same way, > i.e. return error when the unit is masked? My guess is that yes, but I'm > not sure. I don't see a reason why disabling should be disallowed. I think we even allow

Re: [systemd-devel] [PATCH v4] systemctl: add add-wants and add-requires verbs

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 07, 2014 at 02:09:37PM +0200, Lukas Nykryn wrote: > --- > Changes in v4 > - renamed install_dependency -> dependency > - removed the enum with dependencies and used the general one instead This part should really be a separate commit. It moves a lot of code around and makes it harder to

Re: [systemd-devel] variable expansion in ExecStart

2014-10-07 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 06, 2014 at 05:52:40PM +0200, Lennart Poettering wrote: > On Sat, 04.10.14 21:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > Hi, > > > > Environment="X='Y' Z" > > ExecStart=/bin/echo $X ${X} > > > >

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-06 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 06, 2014 at 02:56:22PM -0400, Rob Owens wrote: > - Original Message - > > From: "Martin Steigerwald" > > > Heck, I started a thread here and then didn´t manage to take time to > > carefully > > read it and reply here and there as I see fit. But I challenged people on > > debia

Re: [systemd-devel] [PATCH] journal: Fix sd_journal_enumerate_unique skipping values

2014-10-06 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Oct 06, 2014 at 06:36:34PM +0200, Jan Janssen wrote: > *bump* Sorry, I'll look into this. Zbyszek > On 2014-09-06 10:36, Jan Janssen wrote: > >sd_journal_enumerate_unique will lock its mmap window to prevent it > >from being released by calling mmap_cache_get with keep_always=true. > >Thi

<    5   6   7   8   9   10   11   12   13   14   >