From: Elia Pinto <devzero2...@rpm5.org>

The cppcheck target was introduced by commit 
16f4efb4150c65e3c61adaa8ea512489de49f532
"build-sys: add cppcheck target". But it is preferable to use a make phony 
target
for it, as this patch does.

There are two general reasons to use a phony target: to avoid a conflict with a 
file of the same name,
and to improve performance. In this case the first reason is obvious, and the 
second is that
make skips the implicit rule search for phony targets, since it knows that 
phony targets
do not name actual files that could be remade from other files (as described in 
the
"Gnu Make" Manual).

Signed-off-by: Elia Pinto <devzero2...@rpm5.org>
---
 Makefile.am |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile.am b/Makefile.am
index 935a195..9b982f5 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -5070,6 +5070,7 @@ tests += \
        test-libsystemd-login-sym \
        test-libudev-sym
 
+.PHONY: cppcheck
 cppcheck:
        cppcheck --enable=all -q $(top_srcdir)
 
-- 
1.7.10.4

_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to