Re: [systemd-devel] [PATCH][RFC] bus-proxy: add support for "GetConnectionCredentials" method

2015-02-20 Thread David Herrmann
Hi On Fri, Feb 20, 2015 at 1:54 PM, Simon McVittie wrote: > On 20/02/15 12:43, David Herrmann wrote: >> >> -1 is not a valid value. It should be silently dropped, so we're fine >> here. > > > Perhaps I'm misunderstanding what you're saying here and we're actually > agreeing, but for clarity: Yea

Re: [systemd-devel] [PATCH][RFC] bus-proxy: add support for "GetConnectionCredentials" method

2015-02-20 Thread Simon McVittie
On 20/02/15 12:43, David Herrmann wrote: -1 is not a valid value. It should be silently dropped, so we're fine here. Perhaps I'm misunderstanding what you're saying here and we're actually agreeing, but for clarity: The specification for GetConnectionCredentials deliberately does not docume

Re: [systemd-devel] [PATCH][RFC] bus-proxy: add support for "GetConnectionCredentials" method

2015-02-20 Thread David Herrmann
Hi On Fri, Feb 20, 2015 at 1:20 PM, Simon McVittie wrote: > On 19/02/15 21:26, Djalal Harouni wrote: >> >> On Thu, Feb 19, 2015 at 05:44:34PM +0100, Djalal Harouni wrote: >>> >>> On Thu, Feb 19, 2015 at 01:05:22PM +, Simon McVittie wrote: On 19/02/15 12:43, Lukasz Skalski wrote: >>>

Re: [systemd-devel] [PATCH][RFC] bus-proxy: add support for "GetConnectionCredentials" method

2015-02-20 Thread Simon McVittie
On 19/02/15 21:26, Djalal Harouni wrote: On Thu, Feb 19, 2015 at 05:44:34PM +0100, Djalal Harouni wrote: On Thu, Feb 19, 2015 at 01:05:22PM +, Simon McVittie wrote: On 19/02/15 12:43, Lukasz Skalski wrote: r = get_creds_by_message(a, m, SD_BUS_CREDS_PID|SD_BUS_CREDS_EUID, &creds, &error);

Re: [systemd-devel] [PATCH][RFC] bus-proxy: add support for "GetConnectionCredentials" method

2015-02-19 Thread Djalal Harouni
On Thu, Feb 19, 2015 at 05:44:34PM +0100, Djalal Harouni wrote: > On Thu, Feb 19, 2015 at 01:05:22PM +, Simon McVittie wrote: > > On 19/02/15 12:43, Lukasz Skalski wrote: > > >GetConnectionCredentials method was added to dbus-1 specification > > >more than one year ago. This method should retur

Re: [systemd-devel] [PATCH][RFC] bus-proxy: add support for "GetConnectionCredentials" method

2015-02-19 Thread Djalal Harouni
On Thu, Feb 19, 2015 at 01:05:22PM +, Simon McVittie wrote: > On 19/02/15 12:43, Lukasz Skalski wrote: > >GetConnectionCredentials method was added to dbus-1 specification > >more than one year ago. This method should return "[...] as many > >credentials as possible for the process connected to

Re: [systemd-devel] [PATCH][RFC] bus-proxy: add support for "GetConnectionCredentials" method

2015-02-19 Thread Lukasz Skalski
On 02/19/2015 02:05 PM, Simon McVittie wrote: > On 19/02/15 12:43, Lukasz Skalski wrote: >> GetConnectionCredentials method was added to dbus-1 specification >> more than one year ago. This method should return "[...] as many >> credentials as possible for the process connected to the server", >> b

Re: [systemd-devel] [PATCH][RFC] bus-proxy: add support for "GetConnectionCredentials" method

2015-02-19 Thread Simon McVittie
On 19/02/15 12:43, Lukasz Skalski wrote: GetConnectionCredentials method was added to dbus-1 specification more than one year ago. This method should return "[...] as many credentials as possible for the process connected to the server", but at this moment only "UnixUserID" and "ProcessID" are de

[systemd-devel] [PATCH][RFC] bus-proxy: add support for "GetConnectionCredentials" method

2015-02-19 Thread Lukasz Skalski
GetConnectionCredentials method was added to dbus-1 specification more than one year ago. This method should return "[...] as many credentials as possible for the process connected to the server", but at this moment only "UnixUserID" and "ProcessID" are defined by the specification. We should add s